[ros-diffs] [reactos] 02/02: [WINLOGON] Let Winlogon assign security to desktop when a user logs in now

[George Bișoc]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=07227562c0731d847fe73…

commit 07227562c0731d847fe73569fdcab180e567e7e1
Author:     George Bișoc <george.bisoc(a)reactos.org>
AuthorDate: Sun May 8 00:51:54 2022 +0200
Commit:     George Bișoc <george.bisoc(a)reactos.org>
CommitDate: Sun May 8 20:16:18 2022 +0200

    [WINLOGON] Let Winlogon assign security to desktop when a user logs in now
---
 base/system/winlogon/security.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/base/system/winlogon/security.c b/base/system/winlogon/security.c
index 4045496abb2..d2a845ffbd6 100644
--- a/base/system/winlogon/security.c
+++ b/base/system/winlogon/security.c
@@ -1446,21 +1446,12 @@ AllowAccessOnSession(
         goto Quit;
     }
 
-/*
- * FIXME: Desktop security management is broken. The application desktop gets created
- * with CreateDesktopW() API call with an initial and defined security  descriptor for it
yet
- * when we are giving access to the logged in user, SetUserObjectSecurity() API call
fails to set
- * new security because the desktop in question has no prior security  descriptor (when
it's
- * been assigned even before!!!). This chunk of code must be enabled when this gets
fixed.
- */
-#if 0
     /* Allow application desktop access to this user within this session */
     if (!AllowDesktopAccessToUser(Session->ApplicationDesktop, LogonSid))
     {
         ERR("AllowAccessOnSession(): Failed to allow application desktop access to
the logon user!\n");
         goto Quit;
     }
-#endif
 
     /* Get the length of this logon SID */
     SidLength = GetLengthSid(LogonSid);