[ros-diffs] [tfaber] 72681: [FASTFAT] - Acquire DirResource before MainResource in DoQuery to keep locking order consistent and avoid deadlocks. Patch by Volodymyr Shcherbyna with small modification by me. COR...

Author: tfaber
Date: Thu Sep 15 13:12:02 2016
New Revision: 72681

URL: http://svn.reactos.org/svn/reactos?rev=72681&view=rev
Log:
[FASTFAT]
- Acquire DirResource before MainResource in DoQuery to keep locking order consistent and
avoid deadlocks. Patch by Volodymyr Shcherbyna with small modification by me.
CORE-11959 CORE-11652

Modified:
    trunk/reactos/drivers/filesystems/fastfat/dir.c

Modified: trunk/reactos/drivers/filesystems/fastfat/dir.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa…
==============================================================================
--- trunk/reactos/drivers/filesystems/fastfat/dir.c	[iso-8859-1] (original)
+++ trunk/reactos/drivers/filesystems/fastfat/dir.c	[iso-8859-1] Thu Sep 15 13:12:02 2016
@@ -158,7 +158,7 @@
             pInfo->AllocationSize.u.LowPart =
ROUND_UP(DirContext->DirEntry.FatX.FileSize,
                                                       
DeviceExt->FatInfo.BytesPerCluster);
         }
-    
+
         pInfo->FileAttributes = DirContext->DirEntry.FatX.Attrib & 0x3f;
     }
     else
@@ -421,9 +421,20 @@
 #endif
     Buffer = VfatGetUserBuffer(IrpContext->Irp, FALSE);
 
+    if (!ExAcquireResourceExclusiveLite(&IrpContext->DeviceExt->DirResource,
+                                        BooleanFlagOn(IrpContext->Flags,
IRPCONTEXT_CANWAIT)))
+    {
+        Status = VfatLockUserBuffer(IrpContext->Irp, BufferLength, IoWriteAccess);
+        if (NT_SUCCESS(Status))
+            Status = STATUS_PENDING;
+
+        return Status;
+    }
+
     if (!ExAcquireResourceSharedLite(&pFcb->MainResource,
                                      BooleanFlagOn(IrpContext->Flags,
IRPCONTEXT_CANWAIT)))
     {
+        ExReleaseResourceLite(&IrpContext->DeviceExt->DirResource);
         Status = VfatLockUserBuffer(IrpContext->Irp, BufferLength, IoWriteAccess);
         if (NT_SUCCESS(Status))
             Status = STATUS_PENDING;
@@ -447,7 +458,7 @@
      * -> The pattern length is not null
      * -> The pattern buffer is not null
      * Otherwise, we'll fall later and allocate a match all (*) pattern
-     */ 
+     */
     if (pSearchPattern &&
         pSearchPattern->Length != 0 && pSearchPattern->Buffer != NULL)
     {
@@ -461,6 +472,7 @@
             if (!pCcb->SearchPattern.Buffer)
             {
                 ExReleaseResourceLite(&pFcb->MainResource);
+                ExReleaseResourceLite(&IrpContext->DeviceExt->DirResource);
                 return STATUS_INSUFFICIENT_RESOURCES;
             }
             RtlCopyUnicodeString(&pCcb->SearchPattern, pSearchPattern);
@@ -477,6 +489,7 @@
         if (!pCcb->SearchPattern.Buffer)
         {
             ExReleaseResourceLite(&pFcb->MainResource);
+            ExReleaseResourceLite(&IrpContext->DeviceExt->DirResource);
             return STATUS_INSUFFICIENT_RESOURCES;
         }
         pCcb->SearchPattern.Buffer[0] = L'*';
@@ -503,13 +516,6 @@
     DirContext.LongNameU.MaximumLength = sizeof(LongNameBuffer);
     DirContext.ShortNameU.Buffer = ShortNameBuffer;
     DirContext.ShortNameU.MaximumLength = sizeof(ShortNameBuffer);
-
-    if (!ExAcquireResourceExclusiveLite(&IrpContext->DeviceExt->DirResource,
-                                        BooleanFlagOn(IrpContext->Flags,
IRPCONTEXT_CANWAIT)))
-    {
-        ExReleaseResourceLite(&pFcb->MainResource);
-        return STATUS_PENDING;
-    }
 
     while ((Status == STATUS_SUCCESS) && (BufferLength > 0))
     {
@@ -586,8 +592,8 @@
         IrpContext->Irp->IoStatus.Information =
Stack->Parameters.QueryDirectory.Length - BufferLength;
     }
 
+    ExReleaseResourceLite(&pFcb->MainResource);
     ExReleaseResourceLite(&IrpContext->DeviceExt->DirResource);
-    ExReleaseResourceLite(&pFcb->MainResource);
 
     return Status;
 }
@@ -600,7 +606,7 @@
     Stack = IrpContext->Stack;
     pVcb = IrpContext->DeviceExt;
     pFcb = (PVFATFCB) IrpContext->FileObject->FsContext;
- 
+
     FsRtlNotifyFullChangeDirectory(pVcb->NotifySync,
                                    &(pVcb->NotifyList),
                                    IrpContext->FileObject->FsContext2,