[ros-diffs] [hpoussin] 22273: Allocate buffer for system directory on heap instead of stack

Author: hpoussin
Date: Wed Jun  7 21:30:06 2006
New Revision: 22273

URL: http://svn.reactos.ru/svn/reactos?rev=22273&view=rev
Log:
Allocate buffer for system directory on heap instead of stack

Modified:
    trunk/reactos/dll/win32/setupapi/devinst.c

Modified: trunk/reactos/dll/win32/setupapi/devinst.c
URL:
http://svn.reactos.ru/svn/reactos/trunk/reactos/dll/win32/setupapi/devinst.…
==============================================================================
--- trunk/reactos/dll/win32/setupapi/devinst.c (original)
+++ trunk/reactos/dll/win32/setupapi/devinst.c Wed Jun  7 21:30:06 2006
@@ -409,9 +409,6 @@
     DWORD i;
     BOOL ret = FALSE;
 
-    TRACE("%s %p 0x%x 0x%x\n",
-        debugstr_w(SectionName), PlatformInfo, ProductType, SuiteMask);
-
     static const WCHAR ExtensionPlatformNone[]  = {'.',0};
     static const WCHAR ExtensionPlatformNT[]  = {'.','N','T',0};
     static const WCHAR ExtensionPlatformWindows[]  =
{'.','W','i','n',0};
@@ -423,6 +420,9 @@
     static const WCHAR ExtensionArchitecturemips[]  =
{'m','i','p','s',0};
     static const WCHAR ExtensionArchitectureppc[]  =
{'p','p','c',0};
     static const WCHAR ExtensionArchitecturex86[]  =
{'x','8','6',0};
+
+    TRACE("%s %p 0x%x 0x%x\n",
+        debugstr_w(SectionName), PlatformInfo, ProductType, SuiteMask);
 
     *ScorePlatform = *ScoreMajorVersion = *ScoreMinorVersion = *ScoreProductType =
*ScoreSuiteMask = 0;
 
@@ -3198,12 +3198,20 @@
     }
     else
     {
-        WCHAR Windir[MAX_PATH + 1 + strlenW(InfDirectory)];
+        LPWSTR Windir;
         UINT ret;
+
+        Windir = MyMalloc((MAX_PATH + 1 + strlenW(InfDirectory)) * sizeof(WCHAR));
+        if (!Windir)
+        {
+            SetLastError(ERROR_NOT_ENOUGH_MEMORY);
+            return FALSE;
+        }
 
         ret = GetSystemWindowsDirectoryW(Windir, MAX_PATH);
         if (ret == 0 || ret > MAX_PATH)
         {
+            MyFree(Windir);
             SetLastError(ERROR_GEN_FAILURE);
             return FALSE;
         }
@@ -3221,6 +3229,7 @@
             /* The file is in another place */
             *IsOEMLocation = TRUE;
         }
+        MyFree(Windir);
     }
     return TRUE;
 }