[ros-diffs] [fireball] 41279: Mikhail Denisenko <[e-mail]> - Split the PIDL into current and parent folder, and call GetFolderAttributes only for current folder PIDL. This fixes tons of "ERR: HCR_GetFolderAttributes should be called for simple PIDL's only!" debug log spam messages. See issue #4494 for more details.

Author: fireball
Date: Thu Jun  4 13:01:10 2009
New Revision: 41279

URL: http://svn.reactos.org/svn/reactos?rev=41279&view=rev
Log:
Mikhail Denisenko <denisenkom(a)gmail.com>
- Split the PIDL into current and parent folder, and call GetFolderAttributes only for
current folder PIDL. This fixes tons of "ERR: HCR_GetFolderAttributes should be
called for simple PIDL's only!" debug log spam messages.

See issue #4494 for more details.

Modified:
    trunk/reactos/base/shell/explorer/shell/shellfs.cpp

Modified: trunk/reactos/base/shell/explorer/shell/shellfs.cpp
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/shell/…
==============================================================================
--- trunk/reactos/base/shell/explorer/shell/shellfs.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/shell/explorer/shell/shellfs.cpp [iso-8859-1] Thu Jun  4 13:01:10
2009
@@ -172,7 +172,11 @@
 
 	SFGAOF attribs = SFGAO_FILESYSTEM;
 
-	if (FAILED(const_cast<ShellFolder&>(_folder)->GetAttributesOf(1,
(LPCITEMIDLIST*)&_pidl, &attribs)))
+	// Split pidl into current and parent folder PIDLs
+	ShellPath pidlParent, pidlFolder;
+	_pidl.split(pidlParent, pidlFolder);
+
+	if (FAILED(const_cast<ShellFolder&>(_folder)->GetAttributesOf(1,
(LPCITEMIDLIST*)&pidlFolder, &attribs)))
 		return false;
 
 	if (!(attribs & SFGAO_FILESYSTEM))