[ros-diffs] [reactos] 01/01: [ADVAPI32_APITEST] Unknown field isn't that unknown and should contain "1"

[Pierre Schweitzer]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=830f2998abf17123f3b01…

commit 830f2998abf17123f3b0126733cb4f49282ca1fe
Author:     Pierre Schweitzer <pierre(a)reactos.org>
AuthorDate: Sat Dec 29 22:09:52 2018 +0100
Commit:     Pierre Schweitzer <pierre(a)reactos.org>
CommitDate: Sat Dec 29 22:09:52 2018 +0100

    [ADVAPI32_APITEST] Unknown field isn't that unknown and should contain
"1"
    
    See processhacker source code (as reference)
---
 modules/rostests/apitests/advapi32/ServiceEnv.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/modules/rostests/apitests/advapi32/ServiceEnv.c
b/modules/rostests/apitests/advapi32/ServiceEnv.c
index f71d25541d..cfb7318b4f 100644
--- a/modules/rostests/apitests/advapi32/ServiceEnv.c
+++ b/modules/rostests/apitests/advapi32/ServiceEnv.c
@@ -113,19 +113,20 @@ service_main(DWORD dwArgc, LPWSTR* lpszArgv)
         {
             /* IN/OUT parameter structure for I_QueryTagInformation() function
              * See: https://wj32.org/wp/2010/03/30/howto-use-i_querytaginformation/
+             * See:
https://github.com/processhacker/processhacker/blob/master/phnt/include/sub…
              */
             struct
             {
                 ULONG ProcessId;
                 PVOID ServiceTag;
-                ULONG Unknown;
+                ULONG TagType;
                 PWSTR Buffer;
             } ServiceQuery;
 
             /* Set our input parameters */
             ServiceQuery.ProcessId = GetCurrentProcessId();
             ServiceQuery.ServiceTag = Teb->SubProcessTag;
-            ServiceQuery.Unknown = 0;
+            ServiceQuery.TagType = 0;
             ServiceQuery.Buffer = NULL;
             /* Call ADVAPI32 to query the correctness of our tag */
             _I_QueryTagInformation(NULL, 1, &ServiceQuery);
@@ -135,6 +136,7 @@ service_main(DWORD dwArgc, LPWSTR* lpszArgv)
             {
                 /* It should match our service name */
                 service_ok(wcscmp(lpszArgv[0], ServiceQuery.Buffer) == 0,
"Mismatching info: %S - %S\n", lpszArgv[0], ServiceQuery.Buffer);
+                service_ok(ServiceQuery.TagType == 1, "Invalid tag type: %x\n",
ServiceQuery.TagType);
                 LocalFree(ServiceQuery.Buffer);
             }
         }