[ros-diffs] [tkreuzer] 64831: [NTDLL_APITEST] Disable NtContinue test when runtime checks are enabled [USER32_APITEST] Disable WndProc test when runtime checks are enabled [KERNEL32_WINETEST] Zero initialize a...

Author: tkreuzer
Date: Sun Oct 19 19:37:55 2014
New Revision: 64831

URL: http://svn.reactos.org/svn/reactos?rev=64831&view=rev
Log:
[NTDLL_APITEST] Disable NtContinue test when runtime checks are enabled
[USER32_APITEST] Disable WndProc test when runtime checks are enabled
[KERNEL32_WINETEST] Zero initialize a buffer. This is necessary, since we fail all calls
to GetVolumePathNamesForVolumeNameW and thus never get any data into the buffer, which can
later result in a buffer-overrun, when doing a lstrlenW on it.

Modified:
    trunk/rostests/apitests/ntdll/NtContinue.c
    trunk/rostests/apitests/user32/WndProc.c
    trunk/rostests/winetests/kernel32/volume.c

Modified: trunk/rostests/apitests/ntdll/NtContinue.c
URL:
http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/NtContinue…
==============================================================================
--- trunk/rostests/apitests/ntdll/NtContinue.c	[iso-8859-1] (original)
+++ trunk/rostests/apitests/ntdll/NtContinue.c	[iso-8859-1] Sun Oct 19 19:37:55 2014
@@ -123,6 +123,10 @@
 
 START_TEST(NtContinue)
 {
+#ifdef __RUNTIME_CHECKS__
+    skip("This test breaks MSVC runtime checks!");
+    return;
+#endif /* __RUNTIME_CHECKS__ */
     initrand();
 
     /* First time */

Modified: trunk/rostests/apitests/user32/WndProc.c
URL:
http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/user32/WndProc.c…
==============================================================================
--- trunk/rostests/apitests/user32/WndProc.c	[iso-8859-1] (original)
+++ trunk/rostests/apitests/user32/WndProc.c	[iso-8859-1] Sun Oct 19 19:37:55 2014
@@ -99,5 +99,9 @@
 
 START_TEST(WndProc)
 {
+#ifdef __RUNTIME_CHECKS__
+    skip("This test breaks MSVC runtime checks!");
+    return;
+#endif /* __RUNTIME_CHECKS__ */
    test_wndproc();
 }

Modified: trunk/rostests/winetests/kernel32/volume.c
URL:
http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/kernel32/volume…
==============================================================================
--- trunk/rostests/winetests/kernel32/volume.c	[iso-8859-1] (original)
+++ trunk/rostests/winetests/kernel32/volume.c	[iso-8859-1] Sun Oct 19 19:37:55 2014
@@ -765,6 +765,12 @@
     WCHAR volume[MAX_PATH], buffer[MAX_PATH];
     DWORD len, error;
 
+#ifdef __REACTOS__
+    /* due to failing all calls to GetVolumeNameForVolumeMountPointW, this
+     * buffer never gets initialized and could cause a buffer overflow later */
+    volume[0] = 0;
+#endif /* __REACTOS__ */
+
     if (!pGetVolumePathNamesForVolumeNameW || !pGetVolumeNameForVolumeMountPointW)
     {
         win_skip("required functions not found\n");