[hbelusca] 58110: while (TRUE); (when something is unimplemented) ---> ASSERT(FALSE); // while (TRUE); (unless we deal with a 'noreturn' function), and in some cases, return an adequate value. Part...
4 Jan
2013
4 Jan
'13
11:47 a.m.
Author: hbelusca
Date: Fri Jan 4 11:47:19 2013
New Revision: 58110
URL: http://svn.reactos.org/svn/reactos?rev=58110&view=rev
Log:
while (TRUE); (when something is unimplemented) ---> ASSERT(FALSE); // while (TRUE);
(unless we deal with a 'noreturn' function),
and in some cases, return an adequate value.
Part 1/2
Modified:
trunk/reactos/dll/win32/kernel32/client/path.c
trunk/reactos/dll/win32/kernel32/client/thread.c
trunk/reactos/drivers/bus/pcix/device.c
trunk/reactos/drivers/bus/pcix/enum.c
trunk/reactos/drivers/bus/pcix/fdo.c
trunk/reactos/drivers/bus/pcix/init.c
trunk/reactos/drivers/bus/pcix/intrface/agpintrf.c
trunk/reactos/drivers/bus/pcix/intrface/busintrf.c
trunk/reactos/drivers/bus/pcix/intrface/cardbus.c
trunk/reactos/drivers/bus/pcix/intrface/devhere.c
trunk/reactos/drivers/bus/pcix/intrface/lddintrf.c
trunk/reactos/drivers/bus/pcix/intrface/locintrf.c
trunk/reactos/drivers/bus/pcix/intrface/pmeintf.c
trunk/reactos/drivers/bus/pcix/intrface/routintf.c
trunk/reactos/drivers/bus/pcix/pci/config.c
trunk/reactos/drivers/bus/pcix/pci/ppbridge.c
trunk/reactos/drivers/bus/pcix/pcivrify.c
trunk/reactos/drivers/bus/pcix/pdo.c
trunk/reactos/drivers/bus/pcix/power.c
trunk/reactos/drivers/bus/pcix/utils.c
trunk/reactos/drivers/storage/class/ramdisk/ramdisk.c
trunk/reactos/drivers/usb/usbhub/fdo.c
trunk/reactos/hal/halx86/acpi/halpnpdd.c
trunk/reactos/hal/halx86/generic/bios.c
trunk/reactos/hal/halx86/generic/misc.c
trunk/reactos/hal/halx86/generic/spinlock.c
trunk/reactos/hal/halx86/legacy/bus/cmosbus.c
trunk/reactos/hal/halx86/legacy/bus/pcibus.c
trunk/reactos/hal/halx86/legacy/halpnpdd.c
trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c
Modified: trunk/reactos/dll/win32/kernel32/client/path.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/…
==============================================================================
--- trunk/reactos/dll/win32/kernel32/client/path.c [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/kernel32/client/path.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -237,7 +237,8 @@
{
/* This means someone added RTL_PERTHREAD_CURDIR */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE);
+ // while (TRUE);
}
/* We do not. Do we have the LDR_ENTRY for the executable? */
Modified: trunk/reactos/dll/win32/kernel32/client/thread.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/…
==============================================================================
--- trunk/reactos/dll/win32/kernel32/client/thread.c [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/kernel32/client/thread.c [iso-8859-1] Fri Jan 4 11:47:19
2013
@@ -241,7 +241,8 @@
DbgPrint("SXS: %s - Failing thread create because "
"NtQueryInformationThread() failed with status %08lx\n",
__FUNCTION__, Status);
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
+ return NULL;
}
/* Allocate the Activation Context Stack */
@@ -252,7 +253,8 @@
DbgPrint("SXS: %s - Failing thread create because "
"RtlAllocateActivationContextStack() failed with status
%08lx\n",
__FUNCTION__, Status);
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
+ return NULL;
}
/* Save it */
@@ -274,7 +276,8 @@
DbgPrint("SXS: %s - Failing thread create because "
"RtlQueryInformationActivationContext() failed with status
%08lx\n",
__FUNCTION__, Status);
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
+ return NULL;
}
/* Does it need to be activated? */
@@ -291,7 +294,8 @@
DbgPrint("SXS: %s - Failing thread create because "
"RtlActivateActivationContextEx() failed with status
%08lx\n",
__FUNCTION__, Status);
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
+ return NULL;
}
}
}
@@ -367,7 +371,8 @@
/* We should never reach this place */
DPRINT1("It should not happen\n");
- while (TRUE);
+ ASSERT(FALSE);
+ while (TRUE); // 'noreturn' function.
}
/*
Modified: trunk/reactos/drivers/bus/pcix/device.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/device.c?…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/device.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/device.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -262,7 +262,7 @@
{
/* Not yet implemented */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
VOID
@@ -272,7 +272,7 @@
{
/* Not yet implemented */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
VOID
@@ -282,7 +282,7 @@
{
/* Not yet implemented */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
/* EOF */
Modified: trunk/reactos/drivers/bus/pcix/enum.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/enum.c?re…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/enum.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/enum.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -148,13 +148,13 @@
/* Not used in the driver yet */
case 1:
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
/* Not used in the driver yet */
case 2:
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
/* A drain request */
@@ -541,7 +541,8 @@
{
/* Not yet implemented */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
+ return STATUS_NOT_IMPLEMENTED;
}
NTSTATUS
@@ -599,7 +600,7 @@
{
/* Have not tested this on eVb's machine yet */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
/* Check if the requirements are actually the zero list */
@@ -1522,7 +1523,7 @@
{
/* Not really handling this year */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
/* Check for PCI bridges with the ISA bit set, or required */
if ((PdoExtension) &&
@@ -1532,7 +1533,7 @@
{
/* We'll need to do some legacy support */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
}
else
@@ -1547,7 +1548,7 @@
{
/* Again, some more legacy support we'll have to do */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
}
}
@@ -1557,7 +1558,7 @@
{
/* Not yet supported */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
}
@@ -1606,7 +1607,7 @@
{
DPRINT1("PCI: Bus numbers have been changed! Restoring
originals.\n");
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
}
@@ -1668,7 +1669,7 @@
{
/* Check if this PCI device is the ACPI Watchdog Device... */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
/* Check for non-simple devices */
@@ -1734,7 +1735,7 @@
{
/* Rescan scenarios are not yet implemented */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
/* Bus processing will need to happen */
@@ -2197,7 +2198,7 @@
{
/* Don't have hotplug devices to test with yet, QEMU 0.14 should */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
/* Locate the correct resource configurator for this type of device */
Modified: trunk/reactos/drivers/bus/pcix/fdo.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/fdo.c?rev…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/fdo.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/fdo.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -94,7 +94,7 @@
/* These resources would only be for non-root FDOs, unhandled for now */
ASSERT(Resources->Count == 1);
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
/* Initialize the arbiter for this FDO */
@@ -112,7 +112,7 @@
/* Unhandled for now */
ASSERT(Resources->Count == 1);
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
/* Commit the transition to the started state */
@@ -137,7 +137,7 @@
IN PPCI_FDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -148,7 +148,7 @@
IN PPCI_FDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -159,7 +159,7 @@
IN PPCI_FDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -170,7 +170,7 @@
IN PPCI_FDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -181,7 +181,7 @@
IN PPCI_FDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -319,7 +319,7 @@
IN PPCI_FDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -330,7 +330,7 @@
IN PPCI_FDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -341,7 +341,7 @@
IN PPCI_FDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -393,7 +393,7 @@
/* HotPlug PCI Support not yet implemented */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
} while (FALSE);
/* Free the buffer and return */
@@ -545,7 +545,7 @@
{
/* Root PDO in ReactOS does not assign boot resources */
UNIMPLEMENTED;
-// while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
DPRINT1("Encountered during setup\n");
Descriptor = NULL;
}
@@ -554,7 +554,7 @@
{
/* Root PDO in ReactOS does not assign boot resources */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
else
{
Modified: trunk/reactos/drivers/bus/pcix/init.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/init.c?re…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/init.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/init.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -679,7 +679,7 @@
{
/* This function is not yet implemented */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_SUCCESS;
}
@@ -690,7 +690,7 @@
/* This function is not yet implemented */
DPRINT1("PCI: Unload\n");
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
NTSTATUS
Modified: trunk/reactos/drivers/bus/pcix/intrface/agpintrf.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/intrface/…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/intrface/agpintrf.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/intrface/agpintrf.c [iso-8859-1] Fri Jan 4 11:47:19
2013
@@ -59,7 +59,8 @@
/* Not yet implemented */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
+ return STATUS_NOT_IMPLEMENTED;
}
/* EOF */
Modified: trunk/reactos/drivers/bus/pcix/intrface/busintrf.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/intrface/…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/intrface/busintrf.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/intrface/busintrf.c [iso-8859-1] Fri Jan 4 11:47:19
2013
@@ -49,7 +49,8 @@
{
/* Not yet implemented */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
+ return STATUS_NOT_IMPLEMENTED;
}
/* EOF */
Modified: trunk/reactos/drivers/bus/pcix/intrface/cardbus.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/intrface/…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/intrface/cardbus.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/intrface/cardbus.c [iso-8859-1] Fri Jan 4 11:47:19
2013
@@ -34,7 +34,7 @@
Cardbus_SaveCurrentSettings(IN PPCI_CONFIGURATOR_CONTEXT Context)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
VOID
@@ -42,7 +42,7 @@
Cardbus_SaveLimits(IN PPCI_CONFIGURATOR_CONTEXT Context)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
VOID
@@ -50,7 +50,7 @@
Cardbus_MassageHeaderForLimitsDetermination(IN PPCI_CONFIGURATOR_CONTEXT Context)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
VOID
@@ -58,7 +58,7 @@
Cardbus_RestoreCurrent(IN PPCI_CONFIGURATOR_CONTEXT Context)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
VOID
@@ -68,7 +68,7 @@
IN PIO_RESOURCE_DESCRIPTOR IoDescriptor)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
VOID
@@ -77,7 +77,7 @@
IN PPCI_COMMON_HEADER PciData)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
VOID
@@ -86,7 +86,7 @@
IN PPCI_COMMON_HEADER PciData)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
NTSTATUS
@@ -109,7 +109,8 @@
{
/* Not yet implemented */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
+ return STATUS_NOT_IMPLEMENTED;
}
/* EOF */
Modified: trunk/reactos/drivers/bus/pcix/intrface/devhere.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/intrface/…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/intrface/devhere.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/intrface/devhere.c [iso-8859-1] Fri Jan 4 11:47:19
2013
@@ -51,7 +51,8 @@
/* Not yet implemented */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
+ return STATUS_NOT_IMPLEMENTED;
}
/* EOF */
Modified: trunk/reactos/drivers/bus/pcix/intrface/lddintrf.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/intrface/…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/intrface/lddintrf.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/intrface/lddintrf.c [iso-8859-1] Fri Jan 4 11:47:19
2013
@@ -49,7 +49,8 @@
{
/* Not yet implemented */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
+ return STATUS_NOT_IMPLEMENTED;
}
/* EOF */
Modified: trunk/reactos/drivers/bus/pcix/intrface/locintrf.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/intrface/…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/intrface/locintrf.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/intrface/locintrf.c [iso-8859-1] Fri Jan 4 11:47:19
2013
@@ -49,7 +49,8 @@
{
/* Not yet implemented */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
+ return STATUS_NOT_IMPLEMENTED;
}
/* EOF */
Modified: trunk/reactos/drivers/bus/pcix/intrface/pmeintf.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/intrface/…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/intrface/pmeintf.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/intrface/pmeintf.c [iso-8859-1] Fri Jan 4 11:47:19
2013
@@ -52,7 +52,8 @@
/* Not yet implemented */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
+ return STATUS_NOT_IMPLEMENTED;
}
/* EOF */
Modified: trunk/reactos/drivers/bus/pcix/intrface/routintf.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/intrface/…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/intrface/routintf.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/intrface/routintf.c [iso-8859-1] Fri Jan 4 11:47:19
2013
@@ -54,7 +54,8 @@
/* Not yet implemented */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
+ return STATUS_NOT_IMPLEMENTED;
}
NTSTATUS
Modified: trunk/reactos/drivers/bus/pcix/pci/config.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/pci/confi…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/pci/config.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/pci/config.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -66,7 +66,7 @@
{
/* Currently this driver only supports the legacy HAL interface */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
else
{
Modified: trunk/reactos/drivers/bus/pcix/pci/ppbridge.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/pci/ppbri…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/pci/ppbridge.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/pci/ppbridge.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -672,7 +672,7 @@
IN PPCI_COMMON_HEADER PciData)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
VOID
Modified: trunk/reactos/drivers/bus/pcix/pcivrify.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/pcivrify.…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/pcivrify.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/pcivrify.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -80,7 +80,7 @@
{
/* This function is not yet implemented */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_SUCCESS;
}
Modified: trunk/reactos/drivers/bus/pcix/pdo.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/pdo.c?rev…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/pdo.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/pdo.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -80,7 +80,7 @@
IN PPCI_PDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -101,7 +101,7 @@
IN PPCI_PDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -219,7 +219,7 @@
IN PPCI_PDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -230,7 +230,7 @@
IN PPCI_PDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -241,7 +241,7 @@
IN PPCI_PDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -252,7 +252,7 @@
IN PPCI_PDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -263,7 +263,7 @@
IN PPCI_PDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -274,7 +274,7 @@
IN PPCI_PDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -405,7 +405,7 @@
IN PPCI_PDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -416,7 +416,7 @@
IN PPCI_PDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -437,7 +437,7 @@
IN PPCI_PDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -448,7 +448,7 @@
IN PPCI_PDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
@@ -459,7 +459,7 @@
IN PPCI_PDO_EXTENSION DeviceExtension)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_NOT_SUPPORTED;
}
Modified: trunk/reactos/drivers/bus/pcix/power.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/power.c?r…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/power.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/power.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -192,7 +192,8 @@
{
/* We would normally re-assign resources after powerup */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
+ Status = STATUS_NOT_IMPLEMENTED;
}
}
Modified: trunk/reactos/drivers/bus/pcix/utils.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/utils.c?r…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/utils.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/utils.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -153,7 +153,7 @@
{
/* This scenario shouldn't happen yet, since SetupDD isn't used */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
/* Return if this is Datacenter or not */
@@ -758,7 +758,8 @@
/* eVb has not been able to test such devices yet */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
+ return FALSE;
}
NTSTATUS
Modified: trunk/reactos/drivers/storage/class/ramdisk/ramdisk.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/ramd…
==============================================================================
--- trunk/reactos/drivers/storage/class/ramdisk/ramdisk.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/storage/class/ramdisk/ramdisk.c [iso-8859-1] Fri Jan 4 11:47:19
2013
@@ -773,7 +773,7 @@
FailCreate:
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_SUCCESS;
}
@@ -1068,7 +1068,7 @@
DPRINT1("Get drive layout request\n");
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IOCTL_DISK_GET_PARTITION_INFO:
@@ -1080,7 +1080,7 @@
DPRINT1("Invalid request\n");
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
}
@@ -1097,7 +1097,7 @@
DPRINT1("Read/Write request\n");
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
//
@@ -1107,7 +1107,7 @@
DPRINT1("SCSI request\n");
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
//
@@ -1117,7 +1117,7 @@
DPRINT1("Flush request\n");
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
//
@@ -1127,7 +1127,7 @@
DPRINT1("Invalid request: %lx\n",
IoStackLocation->MajorFunction);
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
}
@@ -1481,8 +1481,7 @@
//
// We don't handle anything else yet
//
- ASSERT(FALSE);
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
}
else
@@ -1498,7 +1497,7 @@
case IOCTL_CDROM_CHECK_VERIFY:
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IOCTL_STORAGE_GET_MEDIA_TYPES:
@@ -1664,67 +1663,67 @@
case IOCTL_DISK_GET_DRIVE_LAYOUT:
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IOCTL_DISK_GET_LENGTH_INFO:
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IOCTL_DISK_IS_WRITABLE:
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IOCTL_SCSI_MINIPORT:
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IOCTL_STORAGE_QUERY_PROPERTY:
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IOCTL_MOUNTDEV_QUERY_UNIQUE_ID:
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IOCTL_MOUNTDEV_QUERY_STABLE_GUID:
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS:
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IOCTL_VOLUME_SET_GPT_ATTRIBUTES:
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IOCTL_VOLUME_GET_GPT_ATTRIBUTES:
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IOCTL_VOLUME_OFFLINE:
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
default:
@@ -1793,7 +1792,7 @@
// FIXME: TODO
//
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
//
@@ -1980,7 +1979,7 @@
IN PIRP Irp)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_SUCCESS;
}
@@ -2148,37 +2147,37 @@
case IRP_MN_START_DEVICE:
DPRINT1("PnP IRP: %lx\n", Minor);
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IRP_MN_QUERY_STOP_DEVICE:
DPRINT1("PnP IRP: %lx\n", Minor);
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IRP_MN_CANCEL_STOP_DEVICE:
DPRINT1("PnP IRP: %lx\n", Minor);
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IRP_MN_STOP_DEVICE:
DPRINT1("PnP IRP: %lx\n", Minor);
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IRP_MN_QUERY_REMOVE_DEVICE:
DPRINT1("PnP IRP: %lx\n", Minor);
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IRP_MN_CANCEL_REMOVE_DEVICE:
DPRINT1("PnP IRP: %lx\n", Minor);
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IRP_MN_REMOVE_DEVICE:
@@ -2213,7 +2212,7 @@
case IRP_MN_SURPRISE_REMOVAL:
DPRINT1("PnP IRP: %lx\n", Minor);
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IRP_MN_QUERY_ID:
@@ -2224,7 +2223,7 @@
if (DeviceExtension->Type == RamdiskDrive)
{
DPRINT1("PnP IRP: %lx\n", Minor);
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
break;
@@ -2236,14 +2235,14 @@
if (DeviceExtension->Type == RamdiskDrive)
{
DPRINT1("PnP IRP: %lx\n", Minor);
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
break;
case IRP_MN_EJECT:
DPRINT1("PnP IRP: %lx\n", Minor);
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
break;
case IRP_MN_QUERY_DEVICE_TEXT:
@@ -2254,7 +2253,7 @@
if (DeviceExtension->Type == RamdiskDrive)
{
DPRINT1("PnP IRP: %lx\n", Minor);
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
break;
@@ -2278,7 +2277,7 @@
if (DeviceExtension->Type == RamdiskDrive)
{
DPRINT1("PnP IRP: %lx\n", Minor);
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
break;
Modified: trunk/reactos/drivers/usb/usbhub/fdo.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbhub/fdo.c?r…
==============================================================================
--- trunk/reactos/drivers/usb/usbhub/fdo.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/usb/usbhub/fdo.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -1,4 +1,4 @@
-/*
+/*
* PROJECT: ReactOS Universal Serial Bus Hub Driver
* LICENSE: GPL - See COPYING in the top level directory
* FILE: drivers/usb/usbhub/fdo.c
Modified: trunk/reactos/hal/halx86/acpi/halpnpdd.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/acpi/halpnpdd.c…
==============================================================================
--- trunk/reactos/hal/halx86/acpi/halpnpdd.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halx86/acpi/halpnpdd.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -814,7 +814,7 @@
IN PIRP Irp)
{
DPRINT1("HAL: PnP Driver WMI!\n");
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_SUCCESS;
}
Modified: trunk/reactos/hal/halx86/generic/bios.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/bios.c?…
==============================================================================
--- trunk/reactos/hal/halx86/generic/bios.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halx86/generic/bios.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -216,6 +216,8 @@
/* Strange, it isn't! This can happen during NMI */
DPRINT1("HAL: Trap0D while not in V86 mode\n");
KiDumpTrapFrame(TrapFrame);
+
+ ASSERT(FALSE);
while (TRUE);
}
Modified: trunk/reactos/hal/halx86/generic/misc.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/misc.c?…
==============================================================================
--- trunk/reactos/hal/halx86/generic/misc.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halx86/generic/misc.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -229,7 +229,7 @@
//
// Don't recurse
//
- if (HalpNMIInProgress++) while (TRUE);
+ if (HalpNMIInProgress++) ASSERT(FALSE); // while (TRUE);
//
// Read the system control register B
Modified: trunk/reactos/hal/halx86/generic/spinlock.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/spinloc…
==============================================================================
--- trunk/reactos/hal/halx86/generic/spinlock.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halx86/generic/spinlock.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -182,7 +182,8 @@
{
#ifdef CONFIG_SMP
ASSERT(FALSE); // FIXME: Unused
- while (TRUE);
+ // while (TRUE);
+ return FALSE;
#endif
/* Simply raise to synch */
@@ -206,7 +207,8 @@
{
#ifdef CONFIG_SMP
ASSERT(FALSE); // FIXME: Unused
- while (TRUE);
+ // while (TRUE);
+ return FALSE;
#endif
/* Simply raise to dispatch */
Modified: trunk/reactos/hal/halx86/legacy/bus/cmosbus.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/legacy/bus/cmos…
==============================================================================
--- trunk/reactos/hal/halx86/legacy/bus/cmosbus.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halx86/legacy/bus/cmosbus.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -26,7 +26,7 @@
IN ULONG Length)
{
DPRINT1("CMOS GetData\n");
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return 0;
}
@@ -40,7 +40,7 @@
IN ULONG Length)
{
DPRINT1("CMOS SetData\n");
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return 0;
}
Modified: trunk/reactos/hal/halx86/legacy/bus/pcibus.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/legacy/bus/pcib…
==============================================================================
--- trunk/reactos/hal/halx86/legacy/bus/pcibus.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halx86/legacy/bus/pcibus.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -537,7 +537,7 @@
IN PPCI_COMMON_CONFIG PciData)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
VOID
@@ -549,7 +549,7 @@
IN PPCI_COMMON_CONFIG PciOldData)
{
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
NTSTATUS
@@ -643,7 +643,8 @@
/* FIXME: TODO */
DPRINT1("You have implemented the KD routines for searching PCI debugger"
"devices, but you have forgotten to implement this routine\n");
- while (TRUE);
+ UNIMPLEMENTED;
+ ASSERT(FALSE); // while (TRUE);
}
static ULONG NTAPI
@@ -678,7 +679,7 @@
{
/* /PCILOCK is not yet supported */
UNIMPLEMENTED;
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
}
#endif
/* Now create the correct resource list based on the supported bus ranges */
Modified: trunk/reactos/hal/halx86/legacy/halpnpdd.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/legacy/halpnpdd…
==============================================================================
--- trunk/reactos/hal/halx86/legacy/halpnpdd.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halx86/legacy/halpnpdd.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -812,7 +812,7 @@
IN PIRP Irp)
{
DPRINT1("HAL: PnP Driver WMI!\n");
- while (TRUE);
+ ASSERT(FALSE); // while (TRUE);
return STATUS_SUCCESS;
}
Modified: trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.…
==============================================================================
--- trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c [iso-8859-1] Fri Jan 4 11:47:19 2013
@@ -3784,7 +3784,7 @@
#define PIP_RETURN_DATA(x, y) {ReturnLength = x; Data = y; Status = STATUS_SUCCESS;
break;}
#define PIP_REGISTRY_DATA(x, y) {ValueName = x; ValueType = y; break;}
-#define PIP_UNIMPLEMENTED() {UNIMPLEMENTED; while(TRUE); break;}
+#define PIP_UNIMPLEMENTED() {UNIMPLEMENTED; ASSERT(FALSE); break;} // while(TRUE);
/*
* @implemented
4374
days inactive
4374
days old
0 comments
1 participants
participants (1)
-
hbelusca＠svn.reactos.org