[tfaber] 65859: [MSI] - Apply Wine commit f41ac94e (msi: Include the terminating null in the buffer size for decoded stream names.) by Hans Leidekker. Fixes a stack buffer overflow when installing ...

Author: tfaber
Date: Sun Dec 28 13:05:48 2014
New Revision: 65859

URL: http://svn.reactos.org/svn/reactos?rev=65859&view=rev
Log:
[MSI]
- Apply Wine commit f41ac94e (msi: Include the terminating null in the buffer size for
decoded stream names.) by Hans Leidekker. Fixes a stack buffer overflow when installing
VMware Tools.

Modified:
    trunk/reactos/dll/win32/msi/database.c
    trunk/reactos/dll/win32/msi/streams.c

Modified: trunk/reactos/dll/win32/msi/database.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msi/database.c?r…
==============================================================================
--- trunk/reactos/dll/win32/msi/database.c	[iso-8859-1] (original)
+++ trunk/reactos/dll/win32/msi/database.c	[iso-8859-1] Sun Dec 28 13:05:48 2014
@@ -113,7 +113,7 @@
 {
     HRESULT r;
     IStorage *stg;
-    WCHAR decoded[MAX_STREAM_NAME_LEN];
+    WCHAR decoded[MAX_STREAM_NAME_LEN + 1];
 
     decode_streamname( stname, decoded );
     TRACE("%s -> %s\n", debugstr_w(stname), debugstr_w(decoded));

Modified: trunk/reactos/dll/win32/msi/streams.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msi/streams.c?re…
==============================================================================
--- trunk/reactos/dll/win32/msi/streams.c	[iso-8859-1] (original)
+++ trunk/reactos/dll/win32/msi/streams.c	[iso-8859-1] Sun Dec 28 13:05:48 2014
@@ -56,7 +56,7 @@
 static STREAM *create_stream(MSISTREAMSVIEW *sv, LPCWSTR name, BOOL encoded, IStream
*stm)
 {
     STREAM *stream;
-    WCHAR decoded[MAX_STREAM_NAME_LEN];
+    WCHAR decoded[MAX_STREAM_NAME_LEN + 1];
 
     stream = msi_alloc(sizeof(STREAM));
     if (!stream)