Author: sginsberg Date: Wed Sep 24 12:11:35 2008 New Revision: 36489
URL: http://svn.reactos.org/svn/reactos?rev=36489&view=rev Log: - IoFlushAdapterBuffers: "AdapterObject" is not an optional parameter, it is vital to identify the DMA adapter. Remove the check which confused Coverity and ASSERTify this instead. - Fix for Coverity error CID: 155
Modified: trunk/reactos/hal/halx86/generic/dma.c
Modified: trunk/reactos/hal/halx86/generic/dma.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/dma.c?re... ============================================================================== --- trunk/reactos/hal/halx86/generic/dma.c [iso-8859-1] (original) +++ trunk/reactos/hal/halx86/generic/dma.c [iso-8859-1] Wed Sep 24 12:11:35 2008 @@ -1569,9 +1569,11 @@ PHYSICAL_ADDRESS PhysicalAddress; PPFN_NUMBER MdlPagesPtr;
+ /* Sanity checks */ ASSERT_IRQL_LESS_OR_EQUAL(DISPATCH_LEVEL); - - if (AdapterObject != NULL && !AdapterObject->MasterDevice) + ASSERT(AdapterObject); + + if (!AdapterObject->MasterDevice) { /* Mask out (disable) the DMA channel. */ if (AdapterObject->AdapterNumber == 1)