[tfaber] 53688: [NTOSKRNL][RTL][DOC] - Fix incorrect loop boundaries in the ARM version of MmCreateProcessAddressSpace. Spotted by Vincenzo Cotugno and cppcheck - Correct outdated wineimport.cmd UR...
11 Sep
2011
11 Sep
'11
11:47 a.m.
Author: tfaber
Date: Sun Sep 11 11:47:28 2011
New Revision: 53688
URL: http://svn.reactos.org/svn/reactos?rev=53688&view=rev
Log:
[NTOSKRNL][RTL][DOC]
- Fix incorrect loop boundaries in the ARM version of MmCreateProcessAddressSpace. Spotted
by Vincenzo Cotugno and cppcheck
- Correct outdated wineimport.cmd URL in README.WINE
- Assorted spelling and readability fixes
Modified:
trunk/reactos/lib/rtl/i386/rtlmem.s
trunk/reactos/lib/rtl/path.c
trunk/reactos/media/doc/README.WINE
trunk/reactos/ntoskrnl/ex/i386/fastinterlck_asm.S
trunk/reactos/ntoskrnl/ke/spinlock.c
trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c
trunk/reactos/ntoskrnl/mm/arm/stubs.c
trunk/reactos/ntoskrnl/ob/oblife.c
Modified: trunk/reactos/lib/rtl/i386/rtlmem.s
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/i386/rtlmem.s?rev=…
==============================================================================
--- trunk/reactos/lib/rtl/i386/rtlmem.s [iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/i386/rtlmem.s [iso-8859-1] Sun Sep 11 11:47:28 2011
@@ -65,7 +65,7 @@
NotEqual2:
- /* Remember how many mathced */
+ /* Remember how many matched */
dec esi
sub esi, [esp+12]
Modified: trunk/reactos/lib/rtl/path.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/path.c?rev=53688&a…
==============================================================================
--- trunk/reactos/lib/rtl/path.c [iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/path.c [iso-8859-1] Sun Sep 11 11:47:28 2011
@@ -489,7 +489,7 @@
else
{
/* Use the optimized path after acquiring the lock */
- QuickPath = 1;
+ QuickPath = TRUE;
NewBuffer = NULL;
}
Modified: trunk/reactos/media/doc/README.WINE
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/media/doc/README.WINE?rev=…
==============================================================================
--- trunk/reactos/media/doc/README.WINE [iso-8859-1] (original)
+++ trunk/reactos/media/doc/README.WINE [iso-8859-1] Sun Sep 11 11:47:28 2011
@@ -270,7 +270,7 @@
Update process for autosync DLLs
*** This process can only be done on Microsoft Windows ***
-- Download wineimport.cmd at svn://svn.reactos.org/reactos/trunk/tools/
+- Download wineimport.cmd at svn://svn.reactos.org/project-tools/trunk/
- Download cvs command line program and be sure to put it in your path
(available at http://ftp.gnu.org/non-gnu/cvs/binary/stable/x86-woe/ )
- Download svn command line program and be sure to put it in your path
Modified: trunk/reactos/ntoskrnl/ex/i386/fastinterlck_asm.S
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/i386/fastinter…
==============================================================================
--- trunk/reactos/ntoskrnl/ex/i386/fastinterlck_asm.S [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ex/i386/fastinterlck_asm.S [iso-8859-1] Sun Sep 11 11:47:28
2011
@@ -37,7 +37,7 @@
lock add [ecx], edx
/* Check for carry bit and return */
- jb .l1
+ jc .l1
ret
.l1:
@@ -82,7 +82,7 @@
or eax, eax
jz .l7
- /* Copy sequence number and adjust it */
+ /* Copy depth and adjust it */
lea ecx, [edx-1]
/* Get next pointer and do the exchange */
@@ -167,7 +167,7 @@
or eax, eax
jz .l10
- /* Clear sequence and pointer */
+ /* Clear depth and pointer */
mov ecx, edx
mov cx, bx
Modified: trunk/reactos/ntoskrnl/ke/spinlock.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/spinlock.c?rev…
==============================================================================
--- trunk/reactos/ntoskrnl/ke/spinlock.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ke/spinlock.c [iso-8859-1] Sun Sep 11 11:47:28 2011
@@ -291,7 +291,7 @@
FASTCALL
KiReleaseSpinLock(IN PKSPIN_LOCK SpinLock)
{
- /* Do the lined function */
+ /* Do the inlined function */
KxReleaseSpinLock(SpinLock);
}
Modified: trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c?…
==============================================================================
--- trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c [iso-8859-1] Sun Sep 11 11:47:28 2011
@@ -553,7 +553,7 @@
// Get the new base address
//
BaseAddress = (PVOID)((ULONG_PTR)BaseAddress -
- ((*MdlPages) << PAGE_SHIFT));
+ (*MdlPages << PAGE_SHIFT));
}
//
@@ -614,7 +614,7 @@
// Get page and base information
//
MdlPages = (PPFN_NUMBER)(Mdl + 1);
- Base = (PVOID)Mdl->StartVa;
+ Base = Mdl->StartVa;
//
// Get the addresses and how many pages we span (and need to lock)
@@ -840,7 +840,7 @@
(PointerPte->u.Hard.Valid == 0))
{
//
- // What kind of lock where we using?
+ // What kind of lock were we using?
//
if (UsePfnLock)
{
@@ -870,7 +870,7 @@
}
//
- // Waht lock should we use?
+ // What lock should we use?
//
if (UsePfnLock)
{
@@ -908,7 +908,7 @@
if (Address <= MM_HIGHEST_USER_ADDRESS)
{
//
- // What kind of lock where we using?
+ // What kind of lock were we using?
//
if (UsePfnLock)
{
@@ -1040,7 +1040,7 @@
} while (PointerPte <= LastPte);
//
- // What kind of lock where we using?
+ // What kind of lock were we using?
//
if (UsePfnLock)
{
@@ -1068,7 +1068,7 @@
ASSERT(!NT_SUCCESS(Status));
//
- // What kind of lock where we using?
+ // What kind of lock were we using?
//
if (UsePfnLock)
{
@@ -1189,8 +1189,8 @@
ASSERT(Pfn1->u2.ShareCount == 0);
/* Not supported yet */
- ASSERT(((Pfn1->u3.e1.PrototypePte == 0) &&
- (Pfn1->OriginalPte.u.Soft.Prototype == 0)));
+ ASSERT((Pfn1->u3.e1.PrototypePte == 0) &&
+ (Pfn1->OriginalPte.u.Soft.Prototype == 0));
/* One less page */
InterlockedExchangeAddSizeT(&MmSystemLockPagesCount, -1);
@@ -1225,8 +1225,8 @@
ASSERT(Pfn1->u3.e1.PageLocation == ActiveAndValid);
/* Not supported yet */
- ASSERT(((Pfn1->u3.e1.PrototypePte == 0) &&
- (Pfn1->OriginalPte.u.Soft.Prototype == 0)));
+ ASSERT((Pfn1->u3.e1.PrototypePte == 0) &&
+ (Pfn1->OriginalPte.u.Soft.Prototype == 0));
/* But there is one less "locked" page though */
InterlockedExchangeAddSizeT(&MmSystemLockPagesCount,
-1);
@@ -1307,7 +1307,7 @@
/* Save the PFN entry instead for the secondary loop */
*MdlPages = (PFN_NUMBER)MiGetPfnEntry(*MdlPages);
- ASSERT((*MdlPages) != 0);
+ ASSERT(*MdlPages != 0);
} while (++MdlPages < LastPage);
//
@@ -1322,7 +1322,7 @@
do
{
/* Get the current entry and reference count */
- Pfn1 = (PMMPFN)(*MdlPages);
+ Pfn1 = (PMMPFN)*MdlPages;
OldRefCount = Pfn1->u3.e2.ReferenceCount;
ASSERT(OldRefCount != 0);
@@ -1400,8 +1400,8 @@
MmAdvanceMdl(IN PMDL Mdl,
IN ULONG NumberOfBytes)
{
- UNIMPLEMENTED;
- return STATUS_NOT_IMPLEMENTED;
+ UNIMPLEMENTED;
+ return STATUS_NOT_IMPLEMENTED;
}
/*
@@ -1414,8 +1414,8 @@
IN PMDL MemoryDescriptorList,
IN MEMORY_CACHING_TYPE CacheType)
{
- UNIMPLEMENTED;
- return 0;
+ UNIMPLEMENTED;
+ return 0;
}
/*
@@ -1427,7 +1427,7 @@
IN ULONG PoolTag,
IN PMDL MemoryDescriptorList)
{
- UNIMPLEMENTED;
+ UNIMPLEMENTED;
}
/*
@@ -1438,8 +1438,8 @@
MmPrefetchPages(IN ULONG NumberOfLists,
IN PREAD_LIST *ReadLists)
{
- UNIMPLEMENTED;
- return STATUS_NOT_IMPLEMENTED;
+ UNIMPLEMENTED;
+ return STATUS_NOT_IMPLEMENTED;
}
/*
@@ -1450,8 +1450,8 @@
MmProtectMdlSystemAddress(IN PMDL MemoryDescriptorList,
IN ULONG NewProtect)
{
- UNIMPLEMENTED;
- return STATUS_NOT_IMPLEMENTED;
+ UNIMPLEMENTED;
+ return STATUS_NOT_IMPLEMENTED;
}
/*
@@ -1464,7 +1464,7 @@
IN KPROCESSOR_MODE AccessMode,
IN LOCK_OPERATION Operation)
{
- UNIMPLEMENTED;
+ UNIMPLEMENTED;
}
@@ -1478,7 +1478,7 @@
IN KPROCESSOR_MODE AccessMode,
IN LOCK_OPERATION Operation)
{
- UNIMPLEMENTED;
+ UNIMPLEMENTED;
}
/*
Modified: trunk/reactos/ntoskrnl/mm/arm/stubs.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/arm/stubs.c?re…
==============================================================================
--- trunk/reactos/ntoskrnl/mm/arm/stubs.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/mm/arm/stubs.c [iso-8859-1] Sun Sep 11 11:47:28 2011
@@ -306,7 +306,7 @@
// Loop two tables (Hyperspace and TTB). Each one is 16KB
//
//
- for (i = 0; i < 8; i++)
+ for (i = 0; i < sizeof(Pfn) / sizeof(Pfn[0]); i++)
{
//
// Allocate a page
Modified: trunk/reactos/ntoskrnl/ob/oblife.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/oblife.c?rev=5…
==============================================================================
--- trunk/reactos/ntoskrnl/ob/oblife.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ob/oblife.c [iso-8859-1] Sun Sep 11 11:47:28 2011
@@ -1100,7 +1100,7 @@
ObpTypeObjectType,
sizeof(OBJECT_TYPE),
KernelMode,
- (POBJECT_HEADER*)&Header);
+ &Header);
if (!NT_SUCCESS(Status))
{
/* Free the name and fail */
4815
days inactive
4815
days old
0 comments
1 participants
participants (1)
-
tfaber＠svn.reactos.org