fixed a buffer overflow when the referenced domain length is 0
Modified: trunk/reactos/subsys/system/cacls/cacls.c
_____
Modified: trunk/reactos/subsys/system/cacls/cacls.c
--- trunk/reactos/subsys/system/cacls/cacls.c 2006-01-14 23:35:20 UTC
(rev 20871)
+++ trunk/reactos/subsys/system/cacls/cacls.c 2006-01-14 23:37:56 UTC
(rev 20872)
@@ -248,7 +248,7 @@
&DomainSize,
&Use))
{
- if (GetLastError() == ERROR_NONE_MAPPED)
+ if (GetLastError() == ERROR_NONE_MAPPED ||
NameSize == 0)
{
goto BuildSidString;
}
@@ -271,7 +271,9 @@
}
Domain = Name + NameSize;
- Name[0] = Domain[0] = _T('\0');
+ Name[0] = _T('\0');
+ if (DomainSize != 0)
+ Domain[0] = _T('\0');
if (!LookupAccountSid(NULL,
Sid,
Name,
Show replies by date