Author: tfaber Date: Mon May 8 10:59:27 2017 New Revision: 74498
URL: http://svn.reactos.org/svn/reactos?rev=74498&view=rev Log: [SHELL32] - Avoid leaking the list items on destruction of CEnumIDListBase CORE-13194
Modified: trunk/reactos/dll/win32/shell32/CEnumIDListBase.cpp trunk/reactos/dll/win32/shell32/CEnumIDListBase.h
Modified: trunk/reactos/dll/win32/shell32/CEnumIDListBase.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/CEnumIDLi... ============================================================================== --- trunk/reactos/dll/win32/shell32/CEnumIDListBase.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/CEnumIDListBase.cpp [iso-8859-1] Mon May 8 10:59:27 2017 @@ -22,15 +22,16 @@
WINE_DEFAULT_DEBUG_CHANNEL(shell);
-CEnumIDListBase::CEnumIDListBase() -{ - mpFirst = NULL; - mpLast = NULL; - mpCurrent = NULL; +CEnumIDListBase::CEnumIDListBase() : + mpFirst(NULL), + mpLast(NULL), + mpCurrent(NULL) +{ }
CEnumIDListBase::~CEnumIDListBase() { + DeleteList(); }
/**************************************************************************
Modified: trunk/reactos/dll/win32/shell32/CEnumIDListBase.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/CEnumIDLi... ============================================================================== --- trunk/reactos/dll/win32/shell32/CEnumIDListBase.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/CEnumIDListBase.h [iso-8859-1] Mon May 8 10:59:27 2017 @@ -33,7 +33,7 @@ ENUMLIST *mpCurrent; public: CEnumIDListBase(); - ~CEnumIDListBase(); + virtual ~CEnumIDListBase(); BOOL AddToEnumList(LPITEMIDLIST pidl); BOOL DeleteList(); BOOL HasItemWithCLSID(LPITEMIDLIST pidl);