[hbelusca] 63848: [NTVDM]: Studying ntvdm, we can find the significance of some of the parameters. Others seem unused.

Author: hbelusca
Date: Sat Aug  9 18:48:31 2014
New Revision: 63848

URL: http://svn.reactos.org/svn/reactos?rev=63848&view=rev
Log:
[NTVDM]: Studying ntvdm, we can find the significance of some of the parameters. Others seem unused.

Modified:
    trunk/reactos/subsystems/ntvdm/hardware/vga.c

Modified: trunk/reactos/subsystems/ntvdm/hardware/vga.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/ntvdm/hardware/v...
==============================================================================
--- trunk/reactos/subsystems/ntvdm/hardware/vga.c	[iso-8859-1] (original)
+++ trunk/reactos/subsystems/ntvdm/hardware/vga.c	[iso-8859-1] Sat Aug  9 18:48:31 2014
@@ -23,7 +23,7 @@

/*
  * Activate this line if you want to use the real
- * RegisterConsoleVDM API of Windows/ReactOS.
+ * RegisterConsoleVDM API of ReactOS/Windows.
  */
 // #define USE_REAL_REGISTERCONSOLEVDM

@@ -314,33 +314,33 @@

BOOL
 WINAPI
-__RegisterConsoleVDM(IN DWORD dwDosVDMFlag,
-                     IN HANDLE hEventHandle1,
-                     IN HANDLE hEventHandle2,
-                     IN HANDLE hEventHandle3,
-                     IN DWORD Unused1,
-                     OUT PULONG returned_val_1,
-                     OUT PVOID* returned_val_2,
-                     IN PVOID lpUnknownBuffer,
-                     IN DWORD dwUnknownBufferLength,
+__RegisterConsoleVDM(IN DWORD dwRegisterFlags,
+                     IN HANDLE hStartHardwareEvent,
+                     IN HANDLE hEndHardwareEvent,
+                     IN HANDLE hErrorHardwareEvent,
+                     IN DWORD dwUnusedVar,
+                     OUT LPDWORD lpVideoStateLength,
+                     OUT PVOID* lpVideoState, // PVIDEO_HARDWARE_STATE_HEADER*
+                     IN PVOID lpUnusedBuffer,
+                     IN DWORD dwUnusedBufferLength,
                      IN COORD dwVDMBufferSize,
                      OUT PVOID* lpVDMBuffer)
 {
-    UNREFERENCED_PARAMETER(hEventHandle3);
-    UNREFERENCED_PARAMETER(Unused1);
-    UNREFERENCED_PARAMETER(returned_val_1);
-    UNREFERENCED_PARAMETER(returned_val_2);
-    UNREFERENCED_PARAMETER(lpUnknownBuffer);
-    UNREFERENCED_PARAMETER(dwUnknownBufferLength);
+    UNREFERENCED_PARAMETER(hErrorHardwareEvent);
+    UNREFERENCED_PARAMETER(dwUnusedVar);
+    UNREFERENCED_PARAMETER(lpVideoStateLength);
+    UNREFERENCED_PARAMETER(lpVideoState);
+    UNREFERENCED_PARAMETER(lpUnusedBuffer);
+    UNREFERENCED_PARAMETER(dwUnusedBufferLength);

SetLastError(0);
-    DPRINT1("__RegisterConsoleVDM(%d)\n", dwDosVDMFlag);
+    DPRINT1("__RegisterConsoleVDM(%d)\n", dwRegisterFlags);

if (lpVDMBuffer == NULL) return FALSE;

-    if (dwDosVDMFlag != 0)
-    {
-        // if (EventHandle_1 == NULL || EventHandle_2 == NULL) return FALSE;
+    if (dwRegisterFlags != 0)
+    {
+        // if (hStartHardwareEvent == NULL || hEndHardwareEvent == NULL) return FALSE;
         if (VDMBuffer != NULL) return FALSE;

VDMBufferSize = dwVDMBufferSize;
@@ -451,7 +451,7 @@
     /*
      * Windows 2k3 winsrv.dll calls NtVdmControl(VdmQueryVdmProcess == 14, &ConsoleHandle);
      * in the two following APIs:
-     * SrvRegisterConsoleVDM  (corresponding win32 API: RegisterConsoleVDM)
+     * SrvRegisterConsoleVDM  (corresponding Win32 API: RegisterConsoleVDM)
      * SrvVDMConsoleOperation (corresponding Win32 API: )
      * to check whether the current process is a VDM process, and fails otherwise with the
      * error 0xC0000022 ().