[akhaldi] 61939: [SACDRV] * Improve the way we include the ntoskrnl internal hdl.h. * Remove one time inclusions from the main header and put them back where they belong. * Improve the GUIDs situat...

Author: akhaldi
Date: Mon Feb  3 00:11:14 2014
New Revision: 61939

URL: http://svn.reactos.org/svn/reactos?rev=61939&view=rev
Log:
[SACDRV]
* Improve the way we include the ntoskrnl internal hdl.h.
* Remove one time inclusions from the main header and put them back where they belong.
* Improve the GUIDs situation.
* Improve header inclusions.
CORE-7716

Modified:
    trunk/reactos/drivers/sac/driver/CMakeLists.txt
    trunk/reactos/drivers/sac/driver/channel.c
    trunk/reactos/drivers/sac/driver/cmdchan.c
    trunk/reactos/drivers/sac/driver/concmd.c
    trunk/reactos/drivers/sac/driver/conmgr.c
    trunk/reactos/drivers/sac/driver/data.c
    trunk/reactos/drivers/sac/driver/init.c
    trunk/reactos/drivers/sac/driver/rawchan.c
    trunk/reactos/drivers/sac/driver/sacdrv.h
    trunk/reactos/drivers/sac/driver/util.c

Modified: trunk/reactos/drivers/sac/driver/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/CMakeLi…
==============================================================================
--- trunk/reactos/drivers/sac/driver/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/drivers/sac/driver/CMakeLists.txt	[iso-8859-1] Mon Feb  3 00:11:14 2014
@@ -1,3 +1,5 @@
+
+include_directories(${REACTOS_SOURCE_DIR})
 
 list(APPEND SOURCE
      chanmgr.c

Modified: trunk/reactos/drivers/sac/driver/channel.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/channel…
==============================================================================
--- trunk/reactos/drivers/sac/driver/channel.c	[iso-8859-1] (original)
+++ trunk/reactos/drivers/sac/driver/channel.c	[iso-8859-1] Mon Feb  3 00:11:14 2014
@@ -9,8 +9,6 @@
 /* INCLUDES *******************************************************************/
 
 #include "sacdrv.h"
-
-/* GLOBALS ********************************************************************/
 
 /* FUNCTIONS ******************************************************************/
 
@@ -575,4 +573,3 @@
     Status = ChannelDereferenceHandles(Channel);
     return Status;
 }
-

Modified: trunk/reactos/drivers/sac/driver/cmdchan.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/cmdchan…
==============================================================================
--- trunk/reactos/drivers/sac/driver/cmdchan.c	[iso-8859-1] (original)
+++ trunk/reactos/drivers/sac/driver/cmdchan.c	[iso-8859-1] Mon Feb  3 00:11:14 2014
@@ -9,8 +9,6 @@
 /* INCLUDES *******************************************************************/
 
 #include "sacdrv.h"
-
-/* GLOBALS ********************************************************************/
 
 /* FUNCTIONS ******************************************************************/
 

Modified: trunk/reactos/drivers/sac/driver/concmd.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/concmd.…
==============================================================================
--- trunk/reactos/drivers/sac/driver/concmd.c	[iso-8859-1] (original)
+++ trunk/reactos/drivers/sac/driver/concmd.c	[iso-8859-1] Mon Feb  3 00:11:14 2014
@@ -9,6 +9,8 @@
 /* INCLUDES *******************************************************************/
 
 #include "sacdrv.h"
+
+#include <ndk/exfuncs.h>
 
 /* GLOBALS ********************************************************************/
 

Modified: trunk/reactos/drivers/sac/driver/conmgr.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/conmgr.…
==============================================================================
--- trunk/reactos/drivers/sac/driver/conmgr.c	[iso-8859-1] (original)
+++ trunk/reactos/drivers/sac/driver/conmgr.c	[iso-8859-1] Mon Feb  3 00:11:14 2014
@@ -9,6 +9,8 @@
 /* INCLUDES *******************************************************************/
 
 #include "sacdrv.h"
+
+#include <initguid.h>
 
 /* GLOBALS ********************************************************************/
 
@@ -890,4 +892,3 @@
     ASSERT(FALSE);
     return STATUS_NOT_IMPLEMENTED;
 }
-

Modified: trunk/reactos/drivers/sac/driver/data.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/data.c?…
==============================================================================
--- trunk/reactos/drivers/sac/driver/data.c	[iso-8859-1] (original)
+++ trunk/reactos/drivers/sac/driver/data.c	[iso-8859-1] Mon Feb  3 00:11:14 2014
@@ -501,4 +501,3 @@
     SAC_DBG(SAC_DBG_ENTRY_EXIT, "Exiting with status TRUE\n");
     return TRUE;
 }
-

Modified: trunk/reactos/drivers/sac/driver/init.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/init.c?…
==============================================================================
--- trunk/reactos/drivers/sac/driver/init.c	[iso-8859-1] (original)
+++ trunk/reactos/drivers/sac/driver/init.c	[iso-8859-1] Mon Feb  3 00:11:14 2014
@@ -9,8 +9,6 @@
 /* INCLUDES *******************************************************************/
 
 #include "sacdrv.h"
-
-/* GLOBALS ********************************************************************/
 
 /* FUNCTIONS ******************************************************************/
 

Modified: trunk/reactos/drivers/sac/driver/rawchan.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/rawchan…
==============================================================================
--- trunk/reactos/drivers/sac/driver/rawchan.c	[iso-8859-1] (original)
+++ trunk/reactos/drivers/sac/driver/rawchan.c	[iso-8859-1] Mon Feb  3 00:11:14 2014
@@ -9,8 +9,6 @@
 /* INCLUDES *******************************************************************/
 
 #include "sacdrv.h"
-
-/* GLOBALS ********************************************************************/
 
 /* FUNCTIONS ******************************************************************/
 

Modified: trunk/reactos/drivers/sac/driver/sacdrv.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/sacdrv.…
==============================================================================
--- trunk/reactos/drivers/sac/driver/sacdrv.h	[iso-8859-1] (original)
+++ trunk/reactos/drivers/sac/driver/sacdrv.h	[iso-8859-1] Mon Feb  3 00:11:14 2014
@@ -9,14 +9,8 @@
 /* INCLUDES *******************************************************************/
 
 #include <ntifs.h>
-#include <intrin.h>
-#include <wchar.h>
 #include <stdio.h>
-#include <ndk/obtypes.h>
-#include <ndk/exfuncs.h>
-#include <ndk/rtlfuncs.h>
-#include <../../../ntoskrnl/include/internal/hdl.h>
-#include <initguid.h>
+#include <ntoskrnl/include/internal/hdl.h>
 #include <sacmsg.h>
 
 /* DEFINES ********************************************************************/

Modified: trunk/reactos/drivers/sac/driver/util.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/util.c?…
==============================================================================
--- trunk/reactos/drivers/sac/driver/util.c	[iso-8859-1] (original)
+++ trunk/reactos/drivers/sac/driver/util.c	[iso-8859-1] Mon Feb  3 00:11:14 2014
@@ -9,6 +9,8 @@
 /* INCLUDES *******************************************************************/
 
 #include "sacdrv.h"
+
+#include <ndk/rtlfuncs.h>
 
 /* GLOBALS ********************************************************************/