Author: arty Date: Tue Sep 23 03:43:49 2008 New Revision: 36419
URL: http://svn.reactos.org/svn/reactos?rev=36419&view=rev Log: Fix possible overrun of the last byte of dbuf (coverity 552).
Modified: trunk/reactos/base/services/dhcp/dhclient.c
Modified: trunk/reactos/base/services/dhcp/dhclient.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/dhclient... ============================================================================== --- trunk/reactos/base/services/dhcp/dhclient.c [iso-8859-1] (original) +++ trunk/reactos/base/services/dhcp/dhclient.c [iso-8859-1] Tue Sep 23 03:43:49 2008 @@ -480,9 +480,9 @@
RegSetValueEx( RegKey, "DhcpNameServer", 0, REG_SZ, (LPBYTE)nsbuf, strlen(nsbuf) + 1); - - free( nsbuf ); } + // free(NULL) is defined to be OK too + free( nsbuf ); } }
@@ -1706,7 +1706,7 @@ len = ip->client-> config->defaults[i].len + lease->options[i].len; - if (len > sizeof(dbuf)) { + if (len >= sizeof(dbuf)) { warning("no space to %s %s", "prepend option", dhcp_options[i].name);