[hbelusca] 71303: [CONSOLE.CPL]: Fix a test condition. Reviewed by Thomas Faber; initially patched by Victor Martinez Calvo Should fix CID 1322302 "Fix an use after free". Please reanalyze with Cov...

Author: hbelusca
Date: Mon May  9 22:06:27 2016
New Revision: 71303

URL: http://svn.reactos.org/svn/reactos?rev=71303&view=rev
Log:
[CONSOLE.CPL]: Fix a test condition. Reviewed by Thomas Faber; initially patched by Victor Martinez Calvo Should fix CID 1322302 "Fix an use after free".
Please reanalyze with Coverity :)
CORE-11179

Modified:
    trunk/reactos/dll/cpl/console/console.c

Modified: trunk/reactos/dll/cpl/console/console.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/console/console.c?r...
==============================================================================
--- trunk/reactos/dll/cpl/console/console.c	[iso-8859-1] (original)
+++ trunk/reactos/dll/cpl/console/console.c	[iso-8859-1] Mon May  9 22:06:27 2016
@@ -227,9 +227,9 @@
     }
     psh.pszCaption = szTitle;

-    if (/* pSharedInfo != NULL && */ ConInfo->hWnd != NULL)
-    {
-        /* We were started from a console window: this is our parent. */
+    if (pSharedInfo != NULL)
+    {
+        /* We were started from a console window: this is our parent (or ConInfo->hWnd is NULL) */
         psh.hwndParent = ConInfo->hWnd;
     }
     else