https://git.reactos.org/?p=reactos.git;a=commitdiff;h=01a3611583da1fba4a2b88...
commit 01a3611583da1fba4a2b88683bf09fe7523fa762 Author: winesync ros-dev@reactos.org AuthorDate: Sun Mar 13 00:16:35 2022 +0100 Commit: Mark Jansen mark.jansen@reactos.org CommitDate: Sun Mar 20 19:28:10 2022 +0100
[WINESYNC] msi: Remove an unnecessary call to SELECT_get_dimensions().
Signed-off-by: Zebediah Figura z.figura12@gmail.com Signed-off-by: Hans Leidekker hans@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
wine commit id 7728acd1b6994c553a046e3ff9ee1aebc20c38b6 by Zebediah Figura z.figura12@gmail.com --- dll/win32/msi/select.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/dll/win32/msi/select.c b/dll/win32/msi/select.c index 99339c24b89..c6e7b209033 100644 --- a/dll/win32/msi/select.c +++ b/dll/win32/msi/select.c @@ -233,14 +233,10 @@ static UINT SELECT_get_column_info( struct tagMSIVIEW *view, UINT n, LPCWSTR *na static UINT msi_select_update(struct tagMSIVIEW *view, MSIRECORD *rec, UINT row) { MSISELECTVIEW *sv = (MSISELECTVIEW*)view; - UINT r, i, num_columns, col, type, val; + UINT r, i, col, type, val; LPCWSTR str;
- r = SELECT_get_dimensions(view, NULL, &num_columns); - if (r != ERROR_SUCCESS) - return r; - - for (i = 0; i < num_columns; i++) + for (i = 0; i < sv->num_cols; i++) { col = sv->cols[i];