[reactos] 01/01: [RPCRT4] Stub RpcGetAuthorizationContextForClient (#2042)

[Oleg Dubinskiy]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=be460fe03f67e86e9abdd…

commit be460fe03f67e86e9abddc22b7a3faeb21539243
Author:     Oleg Dubinskiy <oleg.dubinskij2013(a)yandex.ua>
AuthorDate: Fri Nov 29 15:19:56 2019 +0200
Commit:     Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito(a)reactos.org>
CommitDate: Fri Nov 29 14:19:56 2019 +0100

    [RPCRT4] Stub RpcGetAuthorizationContextForClient (#2042)
    
    ## Purpose
    
    Add a stub for RpcGetAuthorizationContextForClient function into rpcrt4, according to
https://docs.microsoft.com/en-us/windows/win32/api/rpcasync/nf-rpcasync-rpc…
(but with Wine-specific diffs in the syntax, according to the code guidelines:
https://wiki.winehq.org/Submitting_Patches#Code_guidelines, since we're syncing rpcrt4
with Wine). Required by MS Winlogon with also Win32 subsystem and some other dlls replaced
(aka ROS-Frankenstein), so after my ch [...]
    I think I also need to submit a patch in Wine, but it is a bit problematically to
reproduce this error there, since Wine has no even winlogon.exe, and launching MS Winlogon
in pair with profmap.dll, causes the crash due to unimplemented RtlSetProcessIsCritical
function in ntdll (which is completely different than our). Ftr, our ntdll already has it
implemented:
https://git.reactos.org/?p=reactos.git;a=blob;f=sdk/lib/rtl/process.c;hb=67…
But wi [...]
    
    JIRA issue: CORE-16458
    
    Although this PR doesn't fix that shutdown issue, it at least improves the
situation with replaced system files and allows to investigate it more.
    
    ## Proposed changes
    
    - Add a stub for the function in `dll/win32/rpcrt4/rpc_async.c`;
    - Properly call it in `dll/win32/rpcrt4/rpcrt4.spec`.
---
 dll/win32/rpcrt4/rpc_async.c | 47 ++++++++++++++++++++++++++++++++++++++++++++
 dll/win32/rpcrt4/rpcrt4.spec |  2 +-
 2 files changed, 48 insertions(+), 1 deletion(-)

diff --git a/dll/win32/rpcrt4/rpc_async.c b/dll/win32/rpcrt4/rpc_async.c
index 00c2d6bede8..40628b4b4ef 100644
--- a/dll/win32/rpcrt4/rpc_async.c
+++ b/dll/win32/rpcrt4/rpc_async.c
@@ -166,3 +166,50 @@ RPC_STATUS WINAPI RpcAsyncCancelCall(PRPC_ASYNC_STATE pAsync, BOOL
fAbortCall)
     FIXME("(%p, %s): stub\n", pAsync, fAbortCall ? "TRUE" :
"FALSE");
     return RPC_S_INVALID_ASYNC_HANDLE;
 }
+
+#ifdef __REACTOS__
+/***********************************************************************
+ *           RpcGetAuthorizationContextForClient [RPCRT4.@]
+ * 
+ * Called by RpcFreeAuthorizationContext to return the Authz context.
+ * 
+ * PARAMS
+ *  ClientBinding        [I] Binding handle, represents a binding to a client on the
server.
+ *  ImpersonateOnReturn  [I] Directs this function to be represented the client on
return.
+ *  Reserved1            [I] Reserved, equal to null.
+ *  expiration_time      [I] Points to the exact date and time when the token expires.
+ *  Reserved2            [I] Reserved, equal to a LUID structure which has a members,
+ *                           each of them is set to zero.
+ *  Reserved3            [I] Reserved, equal to zero.
+ *  Reserved4            [I] Reserved, equal to null.
+ *  authz_client_context [I] Points to an AUTHZ_CLIENT_CONTEXT_HANDLE structure
+ *                           that has direct pass to Authz functions.
+ * 
+ * RETURNS
+ *  Success: RPC_S_OK.
+ *  Failure: Any error code.
+ */
+RPC_STATUS
+WINAPI
+RpcGetAuthorizationContextForClient(RPC_BINDING_HANDLE ClientBinding,
+                                    BOOL ImpersonateOnReturn,
+                                    void * Reserved1,
+                                    PLARGE_INTEGER expiration_time,
+                                    LUID Reserved2,
+                                    DWORD Reserved3,
+                                    PVOID Reserved4,
+                                    PVOID *authz_client_context)
+{
+    FIXME("(%p, %d, %p, %p, (%d, %u), %u, %p, %p): stub\n",
+          ClientBinding,
+          ImpersonateOnReturn,
+          Reserved1,
+          expiration_time,
+          Reserved2.HighPart,
+          Reserved2.LowPart,
+          Reserved3,
+          Reserved4,
+          authz_client_context);
+    return RPC_S_NO_CONTEXT_AVAILABLE;
+}
+#endif
diff --git a/dll/win32/rpcrt4/rpcrt4.spec b/dll/win32/rpcrt4/rpcrt4.spec
index 7bc8f6f85f1..38bdfd310ee 100644
--- a/dll/win32/rpcrt4/rpcrt4.spec
+++ b/dll/win32/rpcrt4/rpcrt4.spec
@@ -378,7 +378,7 @@
 378 stdcall RpcErrorStartEnumeration(ptr)
 379 stub RpcFreeAuthorizationContext
 380 stdcall RpcGetAsyncCallStatus(ptr) RpcAsyncGetCallStatus
-# RpcGetAuthorizationContextForClient
+381 stdcall RpcGetAuthorizationContextForClient(ptr long ptr ptr int64 long ptr ptr)
 382 stub RpcIfIdVectorFree
 383 stub RpcIfInqId
 384 stdcall RpcImpersonateClient(ptr)