[hbelusca] 68971: [NTDLL][HAL][INFLIB][RTL][NTOS] VOIDify function paramater lists when they indeed don't take any arguments.
Author: hbelusca Date: Thu Sep 3 23:57:39 2015 New Revision: 68971
URL: http://svn.reactos.org/svn/reactos?rev=68971&view=rev Log: [NTDLL][HAL][INFLIB][RTL][NTOS] VOIDify function paramater lists when they indeed don't take any arguments.
Modified: trunk/reactos/dll/ntdll/dispatch/amd64/stubs.c trunk/reactos/dll/ntdll/ldr/ldrinit.c trunk/reactos/dll/ntdll/rtl/libsupp.c trunk/reactos/hal/halx86/apic/tsc.c trunk/reactos/hal/halx86/generic/bios.c trunk/reactos/include/asm/asm.inc trunk/reactos/lib/inflib/infrosgen.c trunk/reactos/lib/rtl/heappage.c trunk/reactos/ntoskrnl/ex/lookas.c trunk/reactos/ntoskrnl/fsrtl/tunnel.c trunk/reactos/ntoskrnl/include/internal/amd64/ke.h trunk/reactos/ntoskrnl/include/internal/i386/intrin_i.h trunk/reactos/ntoskrnl/io/iomgr/iomgr.c trunk/reactos/ntoskrnl/kd/wrappers/gdbstub.c trunk/reactos/ntoskrnl/kd/wrappers/gdbstub_powerpc.c trunk/reactos/ntoskrnl/kdbg/kdb.c trunk/reactos/ntoskrnl/kdbg/kdb_cli.c trunk/reactos/ntoskrnl/ke/powerpc/kiinit.c trunk/reactos/ntoskrnl/ke/powerpc/stubs.c trunk/reactos/ntoskrnl/mm/ARM3/i386/init.c trunk/reactos/ntoskrnl/mm/ARM3/session.c trunk/reactos/ntoskrnl/mm/ARM3/special.c trunk/reactos/ntoskrnl/mm/mminit.c trunk/reactos/ntoskrnl/ps/kill.c trunk/reactos/ntoskrnl/ps/psmgr.c trunk/reactos/ntoskrnl/rtl/libsupp.c
Modified: trunk/reactos/dll/ntdll/dispatch/amd64/stubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/dispatch/amd64/st... ============================================================================== --- trunk/reactos/dll/ntdll/dispatch/amd64/stubs.c [iso-8859-1] (original) +++ trunk/reactos/dll/ntdll/dispatch/amd64/stubs.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -44,7 +44,7 @@
VOID NTAPI -KiRaiseUserExceptionDispatcher() +KiRaiseUserExceptionDispatcher(VOID) { UNIMPLEMENTED; return; @@ -52,7 +52,7 @@
VOID NTAPI -KiUserCallbackDispatcher() +KiUserCallbackDispatcher(VOID) { UNIMPLEMENTED; return; @@ -60,7 +60,7 @@
VOID NTAPI -KiUserExceptionDispatcher() +KiUserExceptionDispatcher(VOID) { UNIMPLEMENTED; return;
Modified: trunk/reactos/dll/ntdll/ldr/ldrinit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ldr/ldrinit.c?rev... ============================================================================== --- trunk/reactos/dll/ntdll/ldr/ldrinit.c [iso-8859-1] (original) +++ trunk/reactos/dll/ntdll/ldr/ldrinit.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -395,7 +395,7 @@
VOID NTAPI -LdrpEnsureLoaderLockIsHeld() +LdrpEnsureLoaderLockIsHeld(VOID) { // Ignored atm }
Modified: trunk/reactos/dll/ntdll/rtl/libsupp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/rtl/libsupp.c?rev... ============================================================================== --- trunk/reactos/dll/ntdll/rtl/libsupp.c [iso-8859-1] (original) +++ trunk/reactos/dll/ntdll/rtl/libsupp.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -66,7 +66,7 @@
KPROCESSOR_MODE NTAPI -RtlpGetMode() +RtlpGetMode(VOID) { return UserMode; } @@ -298,8 +298,8 @@ RtlpCreateAtomHandleTable(PRTL_ATOM_TABLE AtomTable) { RtlInitializeHandleTable(0xCFFF, - sizeof(RTL_ATOM_HANDLE), - &AtomTable->RtlHandleTable); + sizeof(RTL_ATOM_HANDLE), + &AtomTable->RtlHandleTable);
return TRUE; }
Modified: trunk/reactos/hal/halx86/apic/tsc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/apic/tsc.c?rev=6... ============================================================================== --- trunk/reactos/hal/halx86/apic/tsc.c [iso-8859-1] (original) +++ trunk/reactos/hal/halx86/apic/tsc.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -53,7 +53,7 @@
VOID NTAPI -HalpInitializeTsc() +HalpInitializeTsc(VOID) { ULONG_PTR Flags; KIDTENTRY OldIdtEntry, *IdtPointer;
Modified: trunk/reactos/hal/halx86/generic/bios.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/bios.c?r... ============================================================================== --- trunk/reactos/hal/halx86/generic/bios.c [iso-8859-1] (original) +++ trunk/reactos/hal/halx86/generic/bios.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -228,7 +228,7 @@
VOID DECLSPEC_NORETURN -HalpTrap06() +HalpTrap06(VOID) { /* Restore ES/DS to known good values first */ Ke386SetEs(KGDT_R3_DATA | RPL_MASK); @@ -247,7 +247,7 @@
VOID NTAPI -HalpBiosCall() +HalpBiosCall(VOID) { /* Must be volatile so it doesn't get optimized away! */ volatile KTRAP_FRAME V86TrapFrame;
Modified: trunk/reactos/include/asm/asm.inc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/asm/asm.inc?rev=689... ============================================================================== --- trunk/reactos/include/asm/asm.inc [iso-8859-1] (original) +++ trunk/reactos/include/asm/asm.inc [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -2,7 +2,7 @@ * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS Kernel * FILE: ntoskrnl/include/amd64/asmmacro.S - * PURPOSE: ASM macros for for GAS and MASM/ML64 + * PURPOSE: ASM macros for GAS and MASM/ML64 * PROGRAMMERS: Timo Kreuzer (timo.kreuzer@reactos.org) */
Modified: trunk/reactos/lib/inflib/infrosgen.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/inflib/infrosgen.c?rev=... ============================================================================== --- trunk/reactos/lib/inflib/infrosgen.c [iso-8859-1] (original) +++ trunk/reactos/lib/inflib/infrosgen.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -19,7 +19,7 @@ static int InfpHeapRefCount;
static VOID -CheckHeap() +CheckHeap(VOID) { if (NULL == InfpHeap) {
Modified: trunk/reactos/lib/rtl/heappage.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/heappage.c?rev=6897... ============================================================================== --- trunk/reactos/lib/rtl/heappage.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/heappage.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -1201,7 +1201,7 @@ }
NTSTATUS NTAPI -RtlpDphInitializeDelayedFreeQueue() +RtlpDphInitializeDelayedFreeQueue(VOID) { NTSTATUS Status;
@@ -1278,7 +1278,7 @@ }
NTSTATUS NTAPI -RtlpDphTargetDllsLogicInitialize() +RtlpDphTargetDllsLogicInitialize(VOID) { UNIMPLEMENTED; return STATUS_SUCCESS; @@ -1428,7 +1428,7 @@ }
NTSTATUS NTAPI -RtlpDphProcessStartupInitialization() +RtlpDphProcessStartupInitialization(VOID) { NTSTATUS Status; PTEB Teb = NtCurrentTeb();
Modified: trunk/reactos/ntoskrnl/ex/lookas.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/lookas.c?rev=68... ============================================================================== --- trunk/reactos/ntoskrnl/ex/lookas.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/lookas.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -90,7 +90,7 @@ VOID NTAPI INIT_FUNCTION -ExpInitLookasideLists() +ExpInitLookasideLists(VOID) { ULONG i;
Modified: trunk/reactos/ntoskrnl/fsrtl/tunnel.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fsrtl/tunnel.c?rev... ============================================================================== --- trunk/reactos/ntoskrnl/fsrtl/tunnel.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/fsrtl/tunnel.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -196,7 +196,7 @@ INIT_FUNCTION VOID NTAPI -FsRtlInitializeTunnels() +FsRtlInitializeTunnels(VOID) { ULONG TunnelEntries; UNICODE_STRING MaximumTunnelEntryAgeInSeconds = RTL_CONSTANT_STRING(L"MaximumTunnelEntryAgeInSeconds");
Modified: trunk/reactos/ntoskrnl/include/internal/amd64/ke.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/a... ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/amd64/ke.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/amd64/ke.h [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -260,7 +260,7 @@
VOID FORCEINLINE -KiSendEOI() +KiSendEOI(VOID) { /* Write 0 to the apic EOI register */ *((volatile ULONG*)APIC_EOI_REGISTER) = 0;
Modified: trunk/reactos/ntoskrnl/include/internal/i386/intrin_i.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/i... ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/i386/intrin_i.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/i386/intrin_i.h [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -52,7 +52,7 @@
FORCEINLINE USHORT -Ke386GetLocalDescriptorTable() +Ke386GetLocalDescriptorTable(VOID) { USHORT Ldt; __asm__("sldt %0\n\t"
Modified: trunk/reactos/ntoskrnl/io/iomgr/iomgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iomgr.c?r... ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/iomgr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/iomgr.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -332,7 +332,7 @@ BOOLEAN INIT_FUNCTION NTAPI -IopCreateRootDirectories() +IopCreateRootDirectories(VOID) { OBJECT_ATTRIBUTES ObjectAttributes; UNICODE_STRING DirName;
Modified: trunk/reactos/ntoskrnl/kd/wrappers/gdbstub.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kd/wrappers/gdbstu... ============================================================================== --- trunk/reactos/ntoskrnl/kd/wrappers/gdbstub.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kd/wrappers/gdbstub.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -133,7 +133,7 @@
/* scan for the sequence $<data>#<Checksum> */ PCHAR -GspGetPacket() +GspGetPacket(VOID) { PCHAR Buffer = &GspInBuffer[0]; CHAR Checksum;
Modified: trunk/reactos/ntoskrnl/kd/wrappers/gdbstub_powerpc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kd/wrappers/gdbstu... ============================================================================== --- trunk/reactos/ntoskrnl/kd/wrappers/gdbstub_powerpc.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kd/wrappers/gdbstub_powerpc.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -181,7 +181,7 @@ /* scan for the sequence $<data>#<Checksum> */
PCHAR -GspGetPacket() +GspGetPacket(VOID) { PCHAR Buffer = &GspInBuffer[0]; CHAR Checksum;
Modified: trunk/reactos/ntoskrnl/kdbg/kdb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kdbg/kdb.c?rev=689... ============================================================================== --- trunk/reactos/ntoskrnl/kdbg/kdb.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kdbg/kdb.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -1236,7 +1236,7 @@ * Disables interrupts, releases display ownership, ... */ static VOID -KdbpInternalEnter() +KdbpInternalEnter(VOID) { PETHREAD Thread; PVOID SavedInitialStack, SavedStackBase, SavedKernelStack;
Modified: trunk/reactos/ntoskrnl/kdbg/kdb_cli.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kdbg/kdb_cli.c?rev... ============================================================================== --- trunk/reactos/ntoskrnl/kdbg/kdb_cli.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kdbg/kdb_cli.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -3512,7 +3512,7 @@ * call this function if KdbInitFileBuffer is not NULL. */ VOID -KdbpCliInterpretInitFile() +KdbpCliInterpretInitFile(VOID) { PCHAR p1, p2; INT i; @@ -3561,7 +3561,7 @@ * Reads the KDBinit file from the SystemRoot\System32\drivers\etc directory and executes it. */ VOID -KdbpCliInit() +KdbpCliInit(VOID) { NTSTATUS Status; OBJECT_ATTRIBUTES ObjectAttributes;
Modified: trunk/reactos/ntoskrnl/ke/powerpc/kiinit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/powerpc/kiinit.... ============================================================================== --- trunk/reactos/ntoskrnl/ke/powerpc/kiinit.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ke/powerpc/kiinit.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -41,19 +41,21 @@
VOID NTAPI -KiSetupSyscallHandler() +KiSetupSyscallHandler(VOID) { paddr_t handler_target; int *source; for(source = syscall_start, handler_target = 0xc00; - source < &syscall_end; - source++, handler_target += sizeof(int)) - SetPhys(handler_target, *source); -} - -VOID -NTAPI -KiSetupDecrementerTrap() + source < &syscall_end; + source++, handler_target += sizeof(int)) + { + SetPhys(handler_target, *source); + } +} + +VOID +NTAPI +KiSetupDecrementerTrap(VOID) { paddr_t handler_target; int *source; @@ -165,7 +167,7 @@ 0, 0xFFFFFFFF, &PageDirectory, - TRUE); + TRUE); InitProcess->QuantumReset = MAXCHAR; } else @@ -270,26 +272,26 @@ Cpu = KeNumberProcessors; if (!Cpu) { - /* We'll allocate a page from the end of the kernel area for KPCR. This code will probably - * change when we get SMP support. - */ - info[0].phys = 0; - info[0].proc = 2; - info[0].addr = (vaddr_t)Pcr; - info[0].flags = MMU_KRW_UR; - info[1].phys = 0; - info[1].proc = 2; - info[1].addr = ((vaddr_t)Pcr) + (1 << PAGE_SHIFT); - info[1].flags = MMU_KRW_UR; - info[2].phys = 0; - info[2].proc = 2; - info[2].addr = (vaddr_t)KI_USER_SHARED_DATA; - info[2].flags = MMU_KRW_UR; + /* We'll allocate a page from the end of the kernel area for KPCR. This code will probably + * change when we get SMP support. + */ + info[0].phys = 0; + info[0].proc = 2; + info[0].addr = (vaddr_t)Pcr; + info[0].flags = MMU_KRW_UR; + info[1].phys = 0; + info[1].proc = 2; + info[1].addr = ((vaddr_t)Pcr) + (1 << PAGE_SHIFT); + info[1].flags = MMU_KRW_UR; + info[2].phys = 0; + info[2].proc = 2; + info[2].addr = (vaddr_t)KI_USER_SHARED_DATA; + info[2].flags = MMU_KRW_UR; info[3].phys = 0; info[3].proc = 2; info[3].addr = (vaddr_t)KIP0PCRADDRESS; info[3].flags = MMU_KRW_UR; - MmuMapPage(info, 4); + MmuMapPage(info, 4); }
/* Skip initial setup if this isn't the Boot CPU */ @@ -326,7 +328,7 @@ /* Check for break-in */ if (KdPollBreakIn()) { - DbgBreakPointWithStatus(DBG_STATUS_CONTROL_C); + DbgBreakPointWithStatus(DBG_STATUS_CONTROL_C); }
/* Raise to HIGH_LEVEL */ @@ -347,7 +349,7 @@ { }
-void abort() +void abort(VOID) { KeBugCheck(KMODE_EXCEPTION_NOT_HANDLED); while(1);
Modified: trunk/reactos/ntoskrnl/ke/powerpc/stubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/powerpc/stubs.c... ============================================================================== --- trunk/reactos/ntoskrnl/ke/powerpc/stubs.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ke/powerpc/stubs.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -31,7 +31,7 @@
VOID NTAPI -KiUnexpectedInterrupt() +KiUnexpectedInterrupt(VOID) { }
Modified: trunk/reactos/ntoskrnl/mm/ARM3/i386/init.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/i386/init.... ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/i386/init.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/i386/init.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -42,7 +42,7 @@ VOID NTAPI INIT_FUNCTION -MiInitializeSessionSpaceLayout() +MiInitializeSessionSpaceLayout(VOID) { // // Set the size of session view, pool, and image
Modified: trunk/reactos/ntoskrnl/mm/ARM3/session.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/session.c?... ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/session.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/session.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -37,7 +37,7 @@
FORCEINLINE KIRQL -MiAcquireExpansionLock() +MiAcquireExpansionLock(VOID) { KIRQL OldIrql;
Modified: trunk/reactos/ntoskrnl/mm/ARM3/special.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/special.c?... ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/special.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/special.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -588,7 +588,7 @@
VOID NTAPI -MiTestSpecialPool() +MiTestSpecialPool(VOID) { ULONG i; PVOID p1, p2[100];
Modified: trunk/reactos/ntoskrnl/mm/mminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/mminit.c?rev=68... ============================================================================== --- trunk/reactos/ntoskrnl/mm/mminit.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/mminit.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -67,7 +67,7 @@ VOID INIT_FUNCTION NTAPI -MiInitSystemMemoryAreas() +MiInitSystemMemoryAreas(VOID) { // // Create all the static memory areas.
Modified: trunk/reactos/ntoskrnl/ps/kill.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/kill.c?rev=6897... ============================================================================== --- trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -208,7 +208,7 @@ #if DBG VOID NTAPI -PspCheckProcessList() +PspCheckProcessList(VOID) { PLIST_ENTRY Entry;
@@ -1066,7 +1066,7 @@ NTAPI PspIsProcessExiting(IN PEPROCESS Process) { - return Process->Flags & PSF_PROCESS_EXITING_BIT; + return Process->Flags & PSF_PROCESS_EXITING_BIT; }
VOID
Modified: trunk/reactos/ntoskrnl/ps/psmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/psmgr.c?rev=689... ============================================================================== --- trunk/reactos/ntoskrnl/ps/psmgr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ps/psmgr.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -395,7 +395,7 @@ BOOLEAN NTAPI INIT_FUNCTION -PspInitPhase1() +PspInitPhase1(VOID) { /* Initialize the System DLL and return status of operation */ if (!NT_SUCCESS(PspInitializeSystemDll())) return FALSE;
Modified: trunk/reactos/ntoskrnl/rtl/libsupp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/rtl/libsupp.c?rev=... ============================================================================== --- trunk/reactos/ntoskrnl/rtl/libsupp.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/rtl/libsupp.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -92,7 +92,7 @@
KPROCESSOR_MODE NTAPI -RtlpGetMode() +RtlpGetMode(VOID) { return KernelMode; }
-
hbelusca＠svn.reactos.org