[jimtabor] 37099: Implement GetFontUnicodeRanges, port from wine. Tested with wine gdi32 font crosstests.

Author: jimtabor
Date: Thu Oct 30 08:33:08 2008
New Revision: 37099

URL: http://svn.reactos.org/svn/reactos?rev=37099&view=rev
Log:
Implement GetFontUnicodeRanges, port from wine. Tested with wine gdi32 font crosstests.

Modified:
    trunk/reactos/subsystems/win32/win32k/include/text.h
    trunk/reactos/subsystems/win32/win32k/objects/font.c
    trunk/reactos/subsystems/win32/win32k/objects/freetype.c
    trunk/reactos/subsystems/win32/win32k/stubs/stubs.c

Modified: trunk/reactos/subsystems/win32/win32k/include/text.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/inc...
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/include/text.h [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/include/text.h [iso-8859-1] Thu Oct 30 08:33:08 2008
@@ -92,6 +92,7 @@
 BOOL FASTCALL ftGdiGetTextMetricsW(HDC,PTMW_INTERNAL);
 DWORD FASTCALL ftGetFontLanguageInfo(PDC);
 INT FASTCALL ftGdiGetTextCharsetInfo(PDC,PFONTSIGNATURE,DWORD);
+DWORD FASTCALL ftGetFontUnicodeRanges(PFONTGDI, PGLYPHSET);

#define IntLockProcessPrivateFonts(W32Process) \
   ExEnterCriticalRegionAndAcquireFastMutexUnsafe(&W32Process->PrivateFontListLock)

Modified: trunk/reactos/subsystems/win32/win32k/objects/font.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/obj...
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/font.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/font.c [iso-8859-1] Thu Oct 30 08:33:08 2008
@@ -60,6 +60,81 @@

ExFreePool(SafeFileName.Buffer);
   return Ret;
+}
+
+ /*
+ * @implemented
+ */
+DWORD
+APIENTRY
+NtGdiGetFontUnicodeRanges(
+    IN HDC hdc,
+    OUT OPTIONAL LPGLYPHSET pgs)
+{
+  PDC pDc;
+  PDC_ATTR Dc_Attr;
+  HFONT hFont;
+  PTEXTOBJ TextObj;
+  PFONTGDI FontGdi;
+  DWORD Size = 0;
+  PGLYPHSET pgsSafe;
+  NTSTATUS Status = STATUS_SUCCESS;
+
+  pDc = DC_LockDc(hdc);
+  if (!pDc)
+  {
+     SetLastWin32Error(ERROR_INVALID_HANDLE);
+     return 0;
+  }
+
+  Dc_Attr = pDc->pDc_Attr;
+  if(!Dc_Attr) Dc_Attr = &pDc->Dc_Attr;
+
+  hFont = Dc_Attr->hlfntNew;
+  TextObj = TEXTOBJ_LockText(hFont);
+        
+  if ( TextObj == NULL)
+  {
+     SetLastWin32Error(ERROR_INVALID_HANDLE);
+     goto Exit;
+  }
+  FontGdi = ObjToGDI(TextObj->Font, FONT);
+
+
+  Size = ftGetFontUnicodeRanges( FontGdi, NULL);
+  if (Size && pgs)
+  {
+     pgsSafe = ExAllocatePoolWithTag(PagedPool, Size, TAG_GDITEXT);
+     if (!pgsSafe)
+     {
+        SetLastWin32Error(ERROR_NOT_ENOUGH_MEMORY);
+        Size = 0;
+        goto Exit;
+     }
+
+     Size = ftGetFontUnicodeRanges( FontGdi, pgsSafe);
+
+     if (Size)
+     {     
+        _SEH_TRY
+        {
+            ProbeForWrite(pgsSafe, Size, 1);
+            RtlCopyMemory(pgs, pgsSafe, Size);
+        }
+        _SEH_HANDLE
+        {
+           Status = _SEH_GetExceptionCode();
+        }
+        _SEH_END
+
+        if (!NT_SUCCESS(Status)) Size = 0;
+     }
+     ExFreePoolWithTag(pgsSafe, TAG_GDITEXT);
+  }
+Exit:
+  TEXTOBJ_UnlockText(TextObj);
+  DC_UnlockDc(pDc);
+  return Size;
 }

ULONG

Modified: trunk/reactos/subsystems/win32/win32k/objects/freetype.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/obj...
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/freetype.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/freetype.c [iso-8859-1] Thu Oct 30 08:33:08 2008
@@ -3371,6 +3371,74 @@
   return Ret;
 }

+
+DWORD
+FASTCALL
+ftGetFontUnicodeRanges(PFONTGDI Font, PGLYPHSET glyphset)
+{
+    DWORD size = 0;
+    DWORD num_ranges = 0;
+    FT_Face face = Font->face;
+
+    if (face->charmap->encoding == FT_ENCODING_UNICODE)
+    {
+        FT_UInt glyph_code = 0;
+        FT_ULong char_code, char_code_prev;
+
+        char_code_prev = char_code = FT_Get_First_Char(face, &glyph_code);
+
+        DPRINT("face encoding FT_ENCODING_UNICODE, number of glyphs %ld, first glyph %u, first char %04lx\n",
+               face->num_glyphs, glyph_code, char_code);
+
+        if (!glyph_code) return 0;
+
+        if (glyphset)
+        {
+            glyphset->ranges[0].wcLow = (USHORT)char_code;
+            glyphset->ranges[0].cGlyphs = 0;
+            glyphset->cGlyphsSupported = 0;
+        }
+
+        num_ranges = 1;
+        while (glyph_code)
+        {
+            if (char_code < char_code_prev)
+            {
+                DPRINT1("expected increasing char code from FT_Get_Next_Char\n");
+                return 0;
+            }
+            if (char_code - char_code_prev > 1)
+            {
+                num_ranges++;
+                if (glyphset)
+                {
+                    glyphset->ranges[num_ranges - 1].wcLow = (USHORT)char_code;
+                    glyphset->ranges[num_ranges - 1].cGlyphs = 1;
+                    glyphset->cGlyphsSupported++;
+                }
+            }
+            else if (glyphset)
+            {
+                glyphset->ranges[num_ranges - 1].cGlyphs++;
+                glyphset->cGlyphsSupported++;
+            }
+            char_code_prev = char_code;
+            char_code = FT_Get_Next_Char(face, char_code, &glyph_code);
+        }
+    }
+    else
+        DPRINT1("encoding %u not supported\n", face->charmap->encoding);
+
+    size = sizeof(GLYPHSET) + sizeof(WCRANGE) * (num_ranges - 1);
+    if (glyphset)
+    {
+        glyphset->cbThis = size;
+        glyphset->cRanges = num_ranges;
+    }
+    return size;
+}
+
+
 DWORD
 FASTCALL
 ftGetFontLanguageInfo(PDC Dc)

Modified: trunk/reactos/subsystems/win32/win32k/stubs/stubs.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/stu...
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/stubs/stubs.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/stubs/stubs.c [iso-8859-1] Thu Oct 30 08:33:08 2008
@@ -2230,19 +2230,6 @@
  /*
  * @unimplemented
  */
-DWORD
-APIENTRY
-NtGdiGetFontUnicodeRanges(
-    IN HDC hdc,
-    OUT OPTIONAL LPGLYPHSET pgs)
-{
-    UNIMPLEMENTED;
-    return 0;
-}
-
- /*
- * @unimplemented
- */
 UINT
 APIENTRY
 NtGdiGetStringBitmapW(

[Steven Edwards]

Hello,

On Thu, Oct 30, 2008 at 9:33 AM,  [e-mail] wrote:
> URL: http://svn.reactos.org/svn/reactos?rev=37099&view=rev
> Log:
> Implement GetFontUnicodeRanges, port from wine. Tested with wine gdi32 font crosstests.

If your using enough of the original implementation to credit Wine
then to me that means someone else at least partly own copyright to
these functions. Could you please use git blame or git web and see who
the author was of the original implementation from Wine and credit
them appropriately in the header? From time to time when someone says
'foo from wine' I get pinged from wine developers who's code is
appropriated and they ask for proper attribution. If we don't do it
right the first time, then at some point another audit of each commit
from SVN will have to happen and we will have to go back and add those
copyright holders to the files license header.
-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo