[hbelusca] 60767: [FAST486] - Remove an unneeded inclusion to the CRT header: limits.h (and use instead NDK definitions for max/min long values). - Remove unneeded comments... [NTVDM] Remove an unn...
27 Oct
2013
27 Oct
'13
11:42 a.m.
Author: hbelusca
Date: Sun Oct 27 11:42:44 2013
New Revision: 60767
URL: http://svn.reactos.org/svn/reactos?rev=60767&view=rev
Log:
[FAST486]
- Remove an unneeded inclusion to the CRT header: limits.h (and use instead NDK
definitions for max/min long values).
- Remove unneeded comments...
[NTVDM]
Remove an unneeded add_dependencies(...) command.
Modified:
branches/ntvdm/include/reactos/libs/fast486/fast486.h
branches/ntvdm/lib/fast486/common.c
branches/ntvdm/lib/fast486/common.h
branches/ntvdm/lib/fast486/extraops.c
branches/ntvdm/lib/fast486/extraops.h
branches/ntvdm/lib/fast486/fast486.c
branches/ntvdm/lib/fast486/opcodes.c
branches/ntvdm/lib/fast486/opcodes.h
branches/ntvdm/lib/fast486/opgroups.c
branches/ntvdm/lib/fast486/opgroups.h
branches/ntvdm/subsystems/ntvdm/CMakeLists.txt
Modified: branches/ntvdm/include/reactos/libs/fast486/fast486.h
URL:
http://svn.reactos.org/svn/reactos/branches/ntvdm/include/reactos/libs/fast…
==============================================================================
--- branches/ntvdm/include/reactos/libs/fast486/fast486.h [iso-8859-1] (original)
+++ branches/ntvdm/include/reactos/libs/fast486/fast486.h [iso-8859-1] Sun Oct 27 11:42:44
2013
@@ -22,7 +22,13 @@
#ifndef _FAST486_H_
#define _FAST486_H_
+#pragma once
+
/* DEFINES ********************************************************************/
+
+#ifndef FASTCALL
+#define FASTCALL __fastcall
+#endif
#define FAST486_NUM_GEN_REGS 8
#define FAST486_NUM_SEG_REGS 6
Modified: branches/ntvdm/lib/fast486/common.c
URL:
http://svn.reactos.org/svn/reactos/branches/ntvdm/lib/fast486/common.c?rev=…
==============================================================================
--- branches/ntvdm/lib/fast486/common.c [iso-8859-1] (original)
+++ branches/ntvdm/lib/fast486/common.c [iso-8859-1] Sun Oct 27 11:42:44 2013
@@ -21,8 +21,6 @@
/* INCLUDES *******************************************************************/
-// #define WIN32_NO_STATUS
-// #define _INC_WINDOWS
#include <windef.h>
// #define NDEBUG
Modified: branches/ntvdm/lib/fast486/common.h
URL:
http://svn.reactos.org/svn/reactos/branches/ntvdm/lib/fast486/common.h?rev=…
==============================================================================
--- branches/ntvdm/lib/fast486/common.h [iso-8859-1] (original)
+++ branches/ntvdm/lib/fast486/common.h [iso-8859-1] Sun Oct 27 11:42:44 2013
@@ -22,11 +22,9 @@
#ifndef _COMMON_H_
#define _COMMON_H_
+#pragma once
+
/* DEFINES ********************************************************************/
-
-#ifndef FASTCALL
-#define FASTCALL __fastcall
-#endif
#define SIGN_FLAG_BYTE 0x80
#define SIGN_FLAG_WORD 0x8000
Modified: branches/ntvdm/lib/fast486/extraops.c
URL:
http://svn.reactos.org/svn/reactos/branches/ntvdm/lib/fast486/extraops.c?re…
==============================================================================
--- branches/ntvdm/lib/fast486/extraops.c [iso-8859-1] (original)
+++ branches/ntvdm/lib/fast486/extraops.c [iso-8859-1] Sun Oct 27 11:42:44 2013
@@ -21,8 +21,6 @@
/* INCLUDES *******************************************************************/
-// #define WIN32_NO_STATUS
-// #define _INC_WINDOWS
#include <windef.h>
// #define NDEBUG
Modified: branches/ntvdm/lib/fast486/extraops.h
URL:
http://svn.reactos.org/svn/reactos/branches/ntvdm/lib/fast486/extraops.h?re…
==============================================================================
--- branches/ntvdm/lib/fast486/extraops.h [iso-8859-1] (original)
+++ branches/ntvdm/lib/fast486/extraops.h [iso-8859-1] Sun Oct 27 11:42:44 2013
@@ -22,7 +22,10 @@
#ifndef _EXTRAOPS_H_
#define _EXTRAOPS_H_
+#pragma once
+
/* DEFINES ********************************************************************/
+
FAST486_OPCODE_HANDLER(Fast486ExtOpcodeClts);
FAST486_OPCODE_HANDLER(Fast486ExtOpcodeStoreControlReg);
FAST486_OPCODE_HANDLER(Fast486ExtOpcodeStoreDebugReg);
Modified: branches/ntvdm/lib/fast486/fast486.c
URL:
http://svn.reactos.org/svn/reactos/branches/ntvdm/lib/fast486/fast486.c?rev…
==============================================================================
--- branches/ntvdm/lib/fast486/fast486.c [iso-8859-1] (original)
+++ branches/ntvdm/lib/fast486/fast486.c [iso-8859-1] Sun Oct 27 11:42:44 2013
@@ -21,8 +21,6 @@
/* INCLUDES *******************************************************************/
-// #define WIN32_NO_STATUS
-// #define _INC_WINDOWS
#include <windef.h>
// #define NDEBUG
Modified: branches/ntvdm/lib/fast486/opcodes.c
URL:
http://svn.reactos.org/svn/reactos/branches/ntvdm/lib/fast486/opcodes.c?rev…
==============================================================================
--- branches/ntvdm/lib/fast486/opcodes.c [iso-8859-1] (original)
+++ branches/ntvdm/lib/fast486/opcodes.c [iso-8859-1] Sun Oct 27 11:42:44 2013
@@ -21,10 +21,7 @@
/* INCLUDES *******************************************************************/
-// #define WIN32_NO_STATUS
-// #define _INC_WINDOWS
#include <windef.h>
-#include <limits.h>
// #define NDEBUG
#include <debug.h>
@@ -3694,11 +3691,7 @@
}
/* Check for carry/overflow */
- if ((Product < LONG_MIN) || (Product > LONG_MAX))
- {
- State->Flags.Cf = State->Flags.Of = TRUE;
- }
- else State->Flags.Cf = State->Flags.Of = FALSE;
+ State->Flags.Cf = State->Flags.Of = ((Product < MINLONG) || (Product >
MAXLONG));
/* Write-back the result */
return Fast486WriteModrmDwordOperands(State,
Modified: branches/ntvdm/lib/fast486/opcodes.h
URL:
http://svn.reactos.org/svn/reactos/branches/ntvdm/lib/fast486/opcodes.h?rev…
==============================================================================
--- branches/ntvdm/lib/fast486/opcodes.h [iso-8859-1] (original)
+++ branches/ntvdm/lib/fast486/opcodes.h [iso-8859-1] Sun Oct 27 11:42:44 2013
@@ -22,11 +22,9 @@
#ifndef _OPCODES_H_
#define _OPCODES_H_
+#pragma once
+
/* DEFINES ********************************************************************/
-
-#ifndef FASTCALL
-#define FASTCALL __fastcall
-#endif
#define FAST486_NUM_OPCODE_HANDLERS 256
#define FAST486_OPCODE_WRITE_REG (1 << 1)
Modified: branches/ntvdm/lib/fast486/opgroups.c
URL:
http://svn.reactos.org/svn/reactos/branches/ntvdm/lib/fast486/opgroups.c?re…
==============================================================================
--- branches/ntvdm/lib/fast486/opgroups.c [iso-8859-1] (original)
+++ branches/ntvdm/lib/fast486/opgroups.c [iso-8859-1] Sun Oct 27 11:42:44 2013
@@ -21,8 +21,6 @@
/* INCLUDES *******************************************************************/
-// #define WIN32_NO_STATUS
-// #define _INC_WINDOWS
#include <windef.h>
// #define NDEBUG
Modified: branches/ntvdm/lib/fast486/opgroups.h
URL:
http://svn.reactos.org/svn/reactos/branches/ntvdm/lib/fast486/opgroups.h?re…
==============================================================================
--- branches/ntvdm/lib/fast486/opgroups.h [iso-8859-1] (original)
+++ branches/ntvdm/lib/fast486/opgroups.h [iso-8859-1] Sun Oct 27 11:42:44 2013
@@ -21,6 +21,8 @@
#ifndef _OPGROUPS_H_
#define _OPGROUPS_H_
+
+#pragma once
/* DEFINES ********************************************************************/
Modified: branches/ntvdm/subsystems/ntvdm/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/branches/ntvdm/subsystems/ntvdm/CMakeLis…
==============================================================================
--- branches/ntvdm/subsystems/ntvdm/CMakeLists.txt [iso-8859-1] (original)
+++ branches/ntvdm/subsystems/ntvdm/CMakeLists.txt [iso-8859-1] Sun Oct 27 11:42:44 2013
@@ -20,5 +20,4 @@
set_module_type(ntvdm win32cui UNICODE)
target_link_libraries(ntvdm fast486)
add_importlibs(ntvdm msvcrt user32 gdi32 kernel32 ntdll)
-add_dependencies(ntvdm fast486)
add_cd_file(TARGET ntvdm DESTINATION reactos/system32 FOR all)
4077
days inactive
4077
days old
0 comments
1 participants
participants (1)
-
hbelusca＠svn.reactos.org