[janderwald] 23082: * check return value of RtlDeleteAtomFromAtomTable * simply, optimize, bugfix UserRegisterClass * allow de-registration for system classes * set ERROR_CLASS_DOES_NOT_EXIST in case of errors * reduces user32_winetest.exe class errors to 31 failures

Author: janderwald
Date: Sun Jul 16 19:16:55 2006
New Revision: 23082

URL: http://svn.reactos.org/svn/reactos?rev=23082&view=rev
Log:
* check return value of RtlDeleteAtomFromAtomTable
* simply, optimize, bugfix UserRegisterClass 
* allow de-registration for system classes
* set ERROR_CLASS_DOES_NOT_EXIST in case of errors
* reduces user32_winetest.exe class errors to 31 failures

Modified:
    trunk/reactos/subsystems/win32/win32k/ntuser/class.c

Modified: trunk/reactos/subsystems/win32/win32k/ntuser/class.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ntu...
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/ntuser/class.c (original)
+++ trunk/reactos/subsystems/win32/win32k/ntuser/class.c Sun Jul 16 19:16:55 2006
@@ -171,11 +171,11 @@
     return TRUE;
 }

-static VOID
+static NTSTATUS
 IntDeregisterClassAtom(IN RTL_ATOM Atom)
 {
-    RtlDeleteAtomFromAtomTable(gAtomTable,
-                               Atom);
+    return RtlDeleteAtomFromAtomTable(gAtomTable,
+                                      Atom);
 }

static BOOL
@@ -1147,38 +1147,28 @@

/* try to find a previously registered class */
     ClassAtom = IntGetClassAtom(ClassName,
-                                NULL,
-                                NULL,
-                                NULL,
+                                lpwcx->hInstance,
+                                pi,
+                                &Class,
                                 NULL);
     if (ClassAtom != (RTL_ATOM)0)
     {
-        Class = IntFindClass(ClassAtom,
-                             lpwcx->hInstance,
-                             &pi->LocalClassList,
-                             NULL);
-        if (Class != NULL)
-        {
-            goto ClassAlreadyExists;
-        }
-
-        /* if CS_GLOBALCLASS is set, try to find a previously registered global class.
-           Re-registering system classes as global classes seems to be allowed,
-           so we don't fail */
         if (lpwcx->style & CS_GLOBALCLASS)
         {
-            Class = IntFindClass(ClassAtom,
-                                 NULL,
-                                 ((dwFlags & REGISTERCLASS_SYSTEM) ?
-                                     &pi->SystemClassList : &pi->GlobalClassList),
-                                 NULL);
-            if (Class != NULL)
-            {
-ClassAlreadyExists:
+            // global classes shall not have same names as system classes
+            if (Class->Global || Class->System)
+            {
                 DPRINT("Class 0x%p does already exist!\n", ClassAtom);
                 SetLastWin32Error(ERROR_CLASS_ALREADY_EXISTS);
                 return (RTL_ATOM)0;
             }
+        }
+        else if ( !Class->Global && !Class->System)
+        {
+            // local class already exists
+            DPRINT("Class 0x%p does already exist!\n", ClassAtom);
+            SetLastWin32Error(ERROR_CLASS_ALREADY_EXISTS);
+            return (RTL_ATOM)0;
         }
     }

@@ -1244,13 +1234,6 @@

ASSERT(Class != NULL);

-    if (Class->System)
-    {
-        DPRINT1("Attempted to unregister system class 0x%p!\n", ClassAtom);
-        SetLastWin32Error(ERROR_ACCESS_DENIED);
-        return FALSE;
-    }
-
     if (Class->Windows != 0 ||
         Class->Clone != NULL)
     {
@@ -1264,11 +1247,13 @@
     /* unlink the class */
     *Link = Class->Next;

-    IntDeregisterClassAtom(Class->Atom);
-
-    /* finally free the resources */
-    IntDestroyClass(Class);
-    return TRUE;
+    if (NT_SUCCESS(IntDeregisterClassAtom(Class->Atom)))
+    {
+        /* finally free the resources */
+        IntDestroyClass(Class);
+        return TRUE;
+    }
+	return FALSE;
 }

INT
@@ -2117,7 +2102,6 @@
     {
         goto Cleanup;
     }
-
     _SEH_TRY
     {
         /* probe the paramters */
@@ -2184,20 +2168,24 @@

if (!(Class->Global || Class->System) && hInstance == NULL)
                 {
+                    SetLastWin32Error(ERROR_CLASS_DOES_NOT_EXIST);
                     Ret = FALSE;
                 }
             }
-        }
+         }
+         else
+         {
+            SetLastWin32Error(ERROR_CLASS_DOES_NOT_EXIST);
+         }
     }
     _SEH_HANDLE
     {
-        SetLastNtError(_SEH_GetExceptionCode());
+         SetLastWin32Error(ERROR_CLASS_DOES_NOT_EXIST);
     }
     _SEH_END;

Cleanup:
     UserLeave();
-
     return Ret;
 }