1. implemented the ProcessDebugPort class for
NtQueryInformationProcess()
2. Probe user mode pointers in NtQueryInformationProcess() and
NtSetInformationProcess()
Modified: trunk/reactos/ntoskrnl/ps/process.c
_____
Modified: trunk/reactos/ntoskrnl/ps/process.c
--- trunk/reactos/ntoskrnl/ps/process.c 2005-01-19 22:47:26 UTC (rev
13143)
+++ trunk/reactos/ntoskrnl/ps/process.c 2005-01-19 23:38:06 UTC (rev
13144)
@@ -1135,7 +1135,37 @@
KPROCESSOR_MODE PreviousMode;
PreviousMode = ExGetPreviousMode();
+
+ /* check for valid buffers */
+ if(PreviousMode == UserMode)
+ {
+ _SEH_TRY
+ {
+ /* probe with 32bit alignment */
+ ProbeForWrite(ProcessInformation,
+ ProcessInformationLength,
+ sizeof(ULONG));
+ if(ReturnLength)
+ {
+ ProbeForWrite(ReturnLength,
+ sizeof(ULONG),
+ 1);
+ }
+ Status = STATUS_SUCCESS;
+ }
+ _SEH_HANDLE
+ {
+ Status = _SEH_GetExceptionCode();
+ }
+ _SEH_END;
+
+ if(!NT_SUCCESS(Status))
+ {
+ return Status;
+ }
+ }
+
/*
* TODO: Here we should probably check that ProcessInformationLength
* bytes indeed are writable at address ProcessInformation.
@@ -1223,6 +1253,31 @@
break;
case ProcessDebugPort:
+ {
+ if (ProcessInformationLength != sizeof(ULONG))
+ {
+ Status = STATUS_INFO_LENGTH_MISMATCH;
+ }
+ else
+ {
+ _SEH_TRY
+ {
+
+ *(PHANDLE)ProcessInformation = (Process->DebugPort != NULL
? (HANDLE)-1 : NULL);
+ if (ReturnLength)
+ {
+ *ReturnLength = sizeof(HANDLE);
+ }
+ }
+ _SEH_HANDLE
+ {
+ Status = _SEH_GetExceptionCode();
+ }
+ _SEH_END;
+ }
+ break;
+ }
+
case ProcessLdtInformation:
case ProcessWorkingSetWatch:
case ProcessWx86Information:
@@ -1458,7 +1513,7 @@
_SEH_TRY
{
DstPath->Length = ProcParams->ImagePathName.Length;
- DstPath->MaximumLength = DstPath->Length + sizeof(WCHAR);
+ DstPath->MaximumLength = ProcParams->ImagePathName.Length
+ sizeof(WCHAR);
DstPath->Buffer = (PWSTR)(DstPath + 1);
RtlCopyMemory(DstPath->Buffer,
ProcParams->ImagePathName.Buffer, ProcParams->ImagePathName.Length);
@@ -1551,6 +1606,29 @@
PreviousMode = ExGetPreviousMode();
+ /* check for valid buffers */
+ if(PreviousMode == UserMode)
+ {
+ _SEH_TRY
+ {
+ /* probe with 32bit alignment */
+ ProbeForRead(ProcessInformation,
+ ProcessInformationLength,
+ sizeof(ULONG));
+ Status = STATUS_SUCCESS;
+ }
+ _SEH_HANDLE
+ {
+ Status = _SEH_GetExceptionCode();
+ }
+ _SEH_END;
+
+ if(!NT_SUCCESS(Status))
+ {
+ return Status;
+ }
+ }
+
Status = ObReferenceObjectByHandle(ProcessHandle,
PROCESS_SET_INFORMATION,
PsProcessType,
Show replies by date