- Revert so call "Fixes" introduced in 18941 because they are bugs which
I had to fix in 18002 and adding back bugs isn't really a good idea.
Modified: trunk/reactos/lib/rtl/unicode.c
_____
Modified: trunk/reactos/lib/rtl/unicode.c
--- trunk/reactos/lib/rtl/unicode.c 2005-11-01 22:45:35 UTC (rev
18941)
+++ trunk/reactos/lib/rtl/unicode.c 2005-11-01 23:37:26 UTC (rev
18942)
@@ -357,6 +357,7 @@
if (AnsiString->Buffer)
{
RtlpFreeStringMemory(AnsiString->Buffer, TAG_ASTR);
+ RtlZeroMemory(AnsiString, sizeof(ANSI_STRING));
}
}
@@ -369,10 +370,7 @@
{
PAGED_CODE_RTL();
- if (OemString->Buffer)
- {
- RtlpFreeStringMemory(OemString->Buffer, TAG_OSTR);
- }
+ if (OemString->Buffer) RtlpFreeStringMemory(OemString->Buffer,
TAG_OSTR);
}
/*
@@ -387,6 +385,7 @@
if (UnicodeString->Buffer)
{
RtlpFreeStringMemory(UnicodeString->Buffer, TAG_ASTR);
+ RtlZeroMemory(UnicodeString, sizeof(UNICODE_STRING));
}
}
@@ -485,7 +484,7 @@
if(SourceString)
{
DestSize = wcslen(SourceString) * sizeof(WCHAR);
- if (DestSize > 0xFFFE) return STATUS_NAME_TOO_LONG;
+ if (DestSize >= 0xFFFC) return STATUS_NAME_TOO_LONG;
DestinationString->Length = (USHORT)DestSize;
DestinationString->MaximumLength = (USHORT)DestSize +
sizeof(WCHAR);
}
@@ -1944,8 +1943,6 @@
PAGED_CODE_RTL();
Length = (wcslen(Source) + 1) * sizeof(WCHAR);
- if (Length > 0xFFFE) return FALSE;
-
UniDest->Buffer = RtlpAllocateStringMemory(Length, TAG_USTR);
if (UniDest->Buffer == NULL) return FALSE;
Show replies by date