[reactos] 01/01: [MSV1_0] Protect the logon list from concurrent access

[Eric Kohl]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=4cdcbbd1a908716e505f8b...

commit 4cdcbbd1a908716e505f8b8fb4bdbb05153b7c65
Author:     Eric Kohl [e-mail]
AuthorDate: Sun Jan 5 16:30:40 2025 +0100
Commit:     Eric Kohl [e-mail]
CommitDate: Sun Jan 5 16:30:40 2025 +0100

[MSV1_0] Protect the logon list from concurrent access
---
 dll/win32/msv1_0/msv1_0.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/dll/win32/msv1_0/msv1_0.c b/dll/win32/msv1_0/msv1_0.c
index 46d6bff6f55..1d4d6efc448 100644
--- a/dll/win32/msv1_0/msv1_0.c
+++ b/dll/win32/msv1_0/msv1_0.c
@@ -27,6 +27,7 @@ typedef struct _LOGON_LIST_ENTRY

BOOL PackageInitialized = FALSE;
 LIST_ENTRY LogonListHead;
+RTL_RESOURCE LogonListResource;
 ULONG EnumCounter;

/* FUNCTIONS ***************************************************************/
@@ -891,6 +892,8 @@ MsvpEnumerateUsers(
         return STATUS_INVALID_PARAMETER;
     }

+    RtlAcquireResourceShared(&LogonListResource, TRUE);
+
     /* Count the currently logged-on users */
     CurrentEntry = LogonListHead.Flink;
     while (CurrentEntry != &LogonListHead)
@@ -973,6 +976,8 @@ MsvpEnumerateUsers(
     *ProtocolStatus = STATUS_SUCCESS;

done:
+    RtlReleaseResource(&LogonListResource);
+
     if (LocalBuffer != NULL)
         DispatchTable.FreeLsaHeap(LocalBuffer);

@@ -1018,6 +1023,8 @@ MsvpGetUserInfo(

TRACE("LogonId: 0x%lx\n", RequestBuffer->LogonId.LowPart);

+    RtlAcquireResourceShared(&LogonListResource, TRUE);
+
     LogonEntry = GetLogonByLogonId(&RequestBuffer->LogonId);
     if (LogonEntry == NULL)
     {
@@ -1100,6 +1107,8 @@ MsvpGetUserInfo(
     *ProtocolStatus = STATUS_SUCCESS;

done:
+    RtlReleaseResource(&LogonListResource);
+
     if (LocalBuffer != NULL)
         DispatchTable.FreeLsaHeap(LocalBuffer);

@@ -1278,6 +1287,7 @@ LsaApInitializePackage(IN ULONG AuthenticationPackageId,
     if (!PackageInitialized)
     {
         InitializeListHead(&LogonListHead);
+        RtlInitializeResource(&LogonListResource);
         EnumCounter = 0;
         PackageInitialized = TRUE;
     }
@@ -1333,7 +1343,9 @@ LsaApLogonTerminated(
     LogonEntry = GetLogonByLogonId(LogonId);
     if (LogonEntry != NULL)
     {
+        RtlAcquireResourceExclusive(&LogonListResource, TRUE);
         RemoveEntryList(&LogonEntry->ListEntry);
+        RtlReleaseResource(&LogonListResource);

if (LogonEntry->UserName.Buffer)
             RtlFreeHeap(RtlGetProcessHeap(), 0, LogonEntry->UserName.Buffer);
@@ -1702,7 +1714,9 @@ LsaApLogonUserEx2(IN PLSA_CLIENT_REQUEST ClientRequest,

LogonEntry->LogonType = LogonType;

+        RtlAcquireResourceExclusive(&LogonListResource, TRUE);
         InsertTailList(&LogonListHead, &LogonEntry->ListEntry);
+        RtlReleaseResource(&LogonListResource);
     }

if (LogonType == Interactive || LogonType == Batch || LogonType == Service)