Author: cwittich Date: Fri Apr 24 14:35:58 2015 New Revision: 67381
URL: http://svn.reactos.org/svn/reactos?rev=67381&view=rev Log: [WIN32K] fix a memory leak add a missing pool tag some spelling fixes
Modified: trunk/reactos/win32ss/user/ntuser/desktop.c trunk/reactos/win32ss/user/ntuser/window.c trunk/reactos/win32ss/user/ntuser/winsta.c
Modified: trunk/reactos/win32ss/user/ntuser/desktop.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/desktop... ============================================================================== --- trunk/reactos/win32ss/user/ntuser/desktop.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/desktop.c [iso-8859-1] Fri Apr 24 14:35:58 2015 @@ -823,7 +823,7 @@ PSHELL_HOOK_WINDOW Current; HWND* list;
- /* FIXME: If we save nb elements in desktop, we dont have to loop to find nb entries */ + /* FIXME: If we save nb elements in desktop, we don't have to loop to find nb entries */ ListEntry = Desktop->ShellHookWindows.Flink; while (ListEntry != &Desktop->ShellHookWindows) {
Modified: trunk/reactos/win32ss/user/ntuser/window.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/window.... ============================================================================== --- trunk/reactos/win32ss/user/ntuser/window.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/window.c [iso-8859-1] Fri Apr 24 14:35:58 2015 @@ -1451,6 +1451,7 @@ dwCount++; } } + ExFreePoolWithTag(List, USERTAG_WINDOWLIST); }
ObDereferenceObject(Thread); @@ -2795,10 +2796,10 @@ (Child->strName.Length < 0xFFFF && !RtlCompareUnicodeString(WindowName, &CurrentWindowName, TRUE))) { - Ret = Child->head.h; - break; - } - } + Ret = Child->head.h; + break; + } + } } ExFreePoolWithTag(List, USERTAG_WINDOWLIST); }
Modified: trunk/reactos/win32ss/user/ntuser/winsta.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/winsta.... ============================================================================== --- trunk/reactos/win32ss/user/ntuser/winsta.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/winsta.c [iso-8859-1] Fri Apr 24 14:35:58 2015 @@ -487,7 +487,7 @@
if (InputWindowStation == NULL) { - ERR("Initializeing input window station\n"); + ERR("Initializing input window station\n"); InputWindowStation = WindowStationObject;
WindowStationObject->Flags &= ~WSS_NOIO; @@ -1369,12 +1369,12 @@ * Size of buffer passed by caller. * * lpBuffer - * Buffer passed by caller. If the function succedes, the buffer is + * Buffer passed by caller. If the function succeeds, the buffer is * filled with window station/desktop count (in first DWORD) and * NULL-terminated window station/desktop names. * * pRequiredSize - * If the function suceedes, this is the number of bytes copied. + * If the function succeeds, this is the number of bytes copied. * Otherwise it's size of buffer needed for function to succeed. * * Status @@ -1495,7 +1495,7 @@
if (!NT_SUCCESS(Status)) { - ExFreePoolWithTag(WindowStation->psidUser, 0); + ExFreePoolWithTag(WindowStation->psidUser, USERTAG_SECURITY); WindowStation->psidUser = 0; goto Leave; }