[akhaldi] 61722: [DXDIAGN] * Move some inclusions to the main header. * Set the default debugging channel globally through the main header. * Remove inclusions and definitions that already exist in...

Author: akhaldi
Date: Mon Jan 20 11:32:43 2014
New Revision: 61722

URL: http://svn.reactos.org/svn/reactos?rev=61722&view=rev
Log:
[DXDIAGN]
* Move some inclusions to the main header.
* Set the default debugging channel globally through the main header.
* Remove inclusions and definitions that already exist in the main header.
* Improve header inclusions.
* Improve the GUIDs situation.
CORE-7716

Added:
    trunk/reactos/dll/directx/wine/dxdiagn/guid.c   (with props)
Modified:
    trunk/reactos/dll/directx/wine/dxdiagn/CMakeLists.txt
    trunk/reactos/dll/directx/wine/dxdiagn/container.c
    trunk/reactos/dll/directx/wine/dxdiagn/dxdiag_main.c
    trunk/reactos/dll/directx/wine/dxdiagn/dxdiag_private.h
    trunk/reactos/dll/directx/wine/dxdiagn/dxdiagn.rc
    trunk/reactos/dll/directx/wine/dxdiagn/provider.c
    trunk/reactos/dll/directx/wine/dxdiagn/resource.h

Modified: trunk/reactos/dll/directx/wine/dxdiagn/CMakeLists.txt
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/dxdiagn/CM...
==============================================================================
--- trunk/reactos/dll/directx/wine/dxdiagn/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/dll/directx/wine/dxdiagn/CMakeLists.txt	[iso-8859-1] Mon Jan 20 11:32:43 2014
@@ -7,6 +7,7 @@
     container.c
     dxdiag_main.c
     provider.c
+    guid.c
     ${CMAKE_CURRENT_BINARY_DIR}/dxdiagn.def)

add_idl_headers(dxdiagn_idlheader fil_data.idl)

Modified: trunk/reactos/dll/directx/wine/dxdiagn/container.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/dxdiagn/co...
==============================================================================
--- trunk/reactos/dll/directx/wine/dxdiagn/container.c	[iso-8859-1] (original)
+++ trunk/reactos/dll/directx/wine/dxdiagn/container.c	[iso-8859-1] Mon Jan 20 11:32:43 2014
@@ -19,14 +19,7 @@
  *
  */

-#include <config.h>
-
-#define COBJMACROS
 #include "dxdiag_private.h"
-#include <wine/debug.h>
-#include <wine/unicode.h>
-
-WINE_DEFAULT_DEBUG_CHANNEL(dxdiag);

static inline IDxDiagContainerImpl *impl_from_IDxDiagContainer(IDxDiagContainer *iface)
 {

Modified: trunk/reactos/dll/directx/wine/dxdiagn/dxdiag_main.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/dxdiagn/dx...
==============================================================================
--- trunk/reactos/dll/directx/wine/dxdiagn/dxdiag_main.c	[iso-8859-1] (original)
+++ trunk/reactos/dll/directx/wine/dxdiagn/dxdiag_main.c	[iso-8859-1] Mon Jan 20 11:32:43 2014
@@ -19,22 +19,9 @@
  *
  */

-#define COBJMACROS
+#include "dxdiag_private.h"

-#include <config.h>
-#include <stdarg.h>
-
-#include <windef.h>
-#include <winbase.h>
-#include <objbase.h>
-#include <oleauto.h>
-#include <oleidl.h>
 #include <rpcproxy.h>
-#include <initguid.h>
-#include "dxdiag_private.h"
-#include <wine/debug.h>
-
-WINE_DEFAULT_DEBUG_CHANNEL(dxdiag);

HINSTANCE dxdiagn_instance = 0;

Modified: trunk/reactos/dll/directx/wine/dxdiagn/dxdiag_private.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/dxdiagn/dx...
==============================================================================
--- trunk/reactos/dll/directx/wine/dxdiagn/dxdiag_private.h	[iso-8859-1] (original)
+++ trunk/reactos/dll/directx/wine/dxdiagn/dxdiag_private.h	[iso-8859-1] Mon Jan 20 11:32:43 2014
@@ -21,20 +21,30 @@
 #ifndef __WINE_DXDIAG_PRIVATE_H
 #define __WINE_DXDIAG_PRIVATE_H

+#include <wine/config.h>
+
+#include <stdarg.h>
+
 #define WIN32_NO_STATUS
 #define _INC_WINDOWS
 #define COM_NO_WINDOWS_H

-#include <stdarg.h>
+#define COBJMACROS
+#define NONAMELESSUNION
+#define NONAMELESSSTRUCT

#include <windef.h>
 #include <winbase.h>
 #include <wingdi.h>

+#include <wine/debug.h>
+#include <wine/dxdiag.h>
 #include <wine/list.h>
-#include <wine/dxdiag.h>
+#include <wine/unicode.h>

#include "resource.h"
+
+WINE_DEFAULT_DEBUG_CHANNEL(dxdiag);

/* DXDiag Interfaces: */
 typedef struct IDxDiagProviderImpl  IDxDiagProviderImpl;

Modified: trunk/reactos/dll/directx/wine/dxdiagn/dxdiagn.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/dxdiagn/dx...
==============================================================================
--- trunk/reactos/dll/directx/wine/dxdiagn/dxdiagn.rc	[iso-8859-1] (original)
+++ trunk/reactos/dll/directx/wine/dxdiagn/dxdiagn.rc	[iso-8859-1] Mon Jan 20 11:32:43 2014
@@ -15,6 +15,8 @@
  * License along with this library; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
  */
+
+#include <windef.h>

#include "resource.h"

Added: trunk/reactos/dll/directx/wine/dxdiagn/guid.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/dxdiagn/gu...
==============================================================================
--- trunk/reactos/dll/directx/wine/dxdiagn/guid.c	(added)
+++ trunk/reactos/dll/directx/wine/dxdiagn/guid.c	[iso-8859-1] Mon Jan 20 11:32:43 2014
@@ -0,0 +1,18 @@
+/* DO NOT USE THE PRECOMPILED HEADER FOR THIS FILE! */
+
+#include <stdarg.h>
+
+#define WIN32_NO_STATUS
+#define _INC_WINDOWS
+#define COM_NO_WINDOWS_H
+
+#include <windef.h>
+#include <winbase.h>
+#include <wingdi.h>
+#include <objbase.h>
+#include <initguid.h>
+#include <fil_data.h>
+#include <wbemcli.h>
+#include <wine/dxdiag.h>
+
+/* NO CODE HERE, THIS IS JUST REQUIRED FOR THE GUID DEFINITIONS */

Propchange: trunk/reactos/dll/directx/wine/dxdiagn/guid.c
------------------------------------------------------------------------------
    svn:eol-style = native

Modified: trunk/reactos/dll/directx/wine/dxdiagn/provider.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/dxdiagn/pr...
==============================================================================
--- trunk/reactos/dll/directx/wine/dxdiagn/provider.c	[iso-8859-1] (original)
+++ trunk/reactos/dll/directx/wine/dxdiagn/provider.c	[iso-8859-1] Mon Jan 20 11:32:43 2014
@@ -20,29 +20,14 @@
  *
  */

-#include <config.h>
-
-#define COBJMACROS
-#define NONAMELESSUNION
-#define NONAMELESSSTRUCT
 #include "dxdiag_private.h"
-#include <wine/unicode.h>
+
 #include <winver.h>
-#include <wingdi.h>
-#include <objidl.h>
 #include <uuids.h>
-#include <vfw.h>
-#include <mmddk.h>
 #include <d3d9.h>
-#include <strmif.h>
-#include <initguid.h>
 #include <fil_data.h>
 #include <psapi.h>
 #include <wbemcli.h>
-
-#include <wine/debug.h>
-
-WINE_DEFAULT_DEBUG_CHANNEL(dxdiag);

static const WCHAR szEmpty[] = {0};

Modified: trunk/reactos/dll/directx/wine/dxdiagn/resource.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/dxdiagn/re...
==============================================================================
--- trunk/reactos/dll/directx/wine/dxdiagn/resource.h	[iso-8859-1] (original)
+++ trunk/reactos/dll/directx/wine/dxdiagn/resource.h	[iso-8859-1] Mon Jan 20 11:32:43 2014
@@ -18,7 +18,7 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
  */

-#include <windef.h>
+#pragma once

#define IDS_REGIONAL_SETTING 1
 #define IDS_PAGE_FILE_FORMAT 2