[jmorlan] 35187: - Fix cmd's SearchForExecutable: it was inside out, giving extension priority over directory. - Remove code that checked if the file's extension was in PATHEXT. Windows does not check, and it's very handy to be able to "run" non-executable files. - Allow explicit paths with no backslash (like "A:file") - Batch: use GetFullPathName to get the batch file's absolute path; this way %~dp0 will always give the right directory even in the weird case of running the .bat via a relative p

Author: jmorlan
Date: Fri Aug  8 11:48:21 2008
New Revision: 35187

URL: http://svn.reactos.org/svn/reactos?rev=35187&view=rev
Log:
- Fix cmd's SearchForExecutable: it was inside out, giving extension priority over
directory.
- Remove code that checked if the file's extension was in PATHEXT. Windows does not
check, and it's very handy to be able to "run" non-executable files.
- Allow explicit paths with no backslash (like "A:file")
- Batch: use GetFullPathName to get the batch file's absolute path; this way %~dp0
will always give the right directory even in the weird case of running the .bat via a
relative path in PATH. Remove code in SearchForExecutable which tried to make sure it
returned an absolute path (but it didn't in that case).

Modified:
    trunk/reactos/base/shell/cmd/batch.c
    trunk/reactos/base/shell/cmd/where.c

Modified: trunk/reactos/base/shell/cmd/batch.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/batch.c?rev…
==============================================================================
--- trunk/reactos/base/shell/cmd/batch.c [iso-8859-1] (original)
+++ trunk/reactos/base/shell/cmd/batch.c [iso-8859-1] Fri Aug  8 11:48:21 2008
@@ -263,10 +263,10 @@
 			cmd_free (bc->raw_params);
 	}
 
-	ZeroMemory(bc->BatchFilePath, sizeof(bc->BatchFilePath));
+	GetFullPathName(fullname, sizeof(bc->BatchFilePath), bc->BatchFilePath,
&tmp);
+	*tmp = '\0';
+
 	bc->hBatchFile = hFile;
-	tmp = _tcsrchr(fullname, '\\');
-	_tcsncpy(bc->BatchFilePath, fullname, ((_tcslen(fullname) - _tcslen(tmp)) + 1));
 	SetFilePointer (bc->hBatchFile, 0, NULL, FILE_BEGIN);
 	bc->bEcho = bEcho; /* Preserve echo across batch calls */
 	bc->shiftlevel = 0;

Modified: trunk/reactos/base/shell/cmd/where.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/where.c?rev…
==============================================================================
--- trunk/reactos/base/shell/cmd/where.c [iso-8859-1] (original)
+++ trunk/reactos/base/shell/cmd/where.c [iso-8859-1] Fri Aug  8 11:48:21 2008
@@ -83,35 +83,49 @@
 /* searches for file using path info. */
 
 BOOL
-SearchForExecutableSingle (LPCTSTR pFileName, LPTSTR pFullName, LPTSTR pExtension)
+SearchForExecutableSingle (LPCTSTR pFileName, LPTSTR pFullName, LPTSTR pPathExt, LPTSTR
pDirectory)
 {
-	TCHAR  szPathBuffer[CMDLINE_LENGTH];
-	LPTSTR pszBuffer = NULL;
-	DWORD  dwBuffer, len;
+	TCHAR  szPathBuffer[CMDLINE_LENGTH], *pszPathEnd;
 	LPTSTR s,f;
 	/* initialize full name buffer */
 	*pFullName = _T('\0');
 
-	TRACE ("SearchForExecutableSingle: \'%s\' with ext:
\'%s\'\n",
-		debugstr_aw(pFileName), debugstr_aw(pExtension));
-
-	/* Check if valid directly on specified path */
-	if (_tcschr (pFileName, _T('\\')) != NULL)
-	{
-		LPTSTR pFilePart;
-		TRACE ("Absolute or relative path is given.\n");
-
-		if (GetFullPathName (pFileName,
-			             CMDLINE_LENGTH,
-			             szPathBuffer,
-			             &pFilePart)  ==0)
-			return FALSE;
-
-		if(pFilePart == 0)
-			return FALSE;
-		/* Add extension and test file: */
-		if (pExtension)
-			_tcscat(szPathBuffer, pExtension);
+	TRACE ("SearchForExecutableSingle: \'%s\' in dir: \'%s\'\n",
+		debugstr_aw(pFileName), debugstr_aw(pDirectory));
+
+	pszPathEnd = szPathBuffer;
+	if (pDirectory != NULL)
+	{
+		_tcscpy(szPathBuffer, pDirectory);
+		pszPathEnd += _tcslen(pszPathEnd);
+		*pszPathEnd++ = _T('\\');
+	}
+	_tcscpy(pszPathEnd, pFileName);
+	pszPathEnd += _tcslen(pszPathEnd);
+
+	if (IsExistingFile (szPathBuffer))
+	{
+		TRACE ("Found: \'%s\'\n", debugstr_aw(szPathBuffer));
+		_tcscpy (pFullName, szPathBuffer);
+		return TRUE;
+	}
+
+	s = pPathExt;
+	while (s && *s)
+	{
+		f = _tcschr (s, _T(';'));
+
+		if (f)
+		{
+			_tcsncpy (pszPathEnd, s, (size_t)(f-s));
+			pszPathEnd[f-s] = _T('\0');
+			s = f + 1;
+		}
+		else
+		{
+			_tcscpy (pszPathEnd, s);
+			s = NULL;
+		}
 
 		if (IsExistingFile (szPathBuffer))
 		{
@@ -119,78 +133,7 @@
 			_tcscpy (pFullName, szPathBuffer);
 			return TRUE;
 		}
-		return FALSE;
-	}
-
-	/* search in current directory */
-	len = GetCurrentDirectory (CMDLINE_LENGTH, szPathBuffer);
-	if (szPathBuffer[len - 1] != _T('\\'))
-	{
-		szPathBuffer[len] = _T('\\');
-		szPathBuffer[len + 1] = _T('\0');
-	}
-	_tcscat (szPathBuffer, pFileName);
-
-	if (pExtension)
-		_tcscat (szPathBuffer, pExtension);
-
-	if (IsExistingFile (szPathBuffer))
-	{
-		TRACE ("Found: \'%s\'\n", debugstr_aw(szPathBuffer));
-		_tcscpy (pFullName, szPathBuffer);
-		return TRUE;
-	}
-
-
-
-	/* load environment varable PATH into buffer */
-	pszBuffer = (LPTSTR)cmd_alloc (ENV_BUFFER_SIZE * sizeof(TCHAR));
-	dwBuffer = GetEnvironmentVariable (_T("PATH"), pszBuffer, ENV_BUFFER_SIZE);
-	if (dwBuffer > ENV_BUFFER_SIZE)
-	{
-		pszBuffer = (LPTSTR)cmd_realloc (pszBuffer, dwBuffer * sizeof (TCHAR));
-		GetEnvironmentVariable (_T("PATH"), pszBuffer, dwBuffer);
-	}
-
-
-	/* search in PATH */
-	s = pszBuffer;
-	while (s && *s)
-	{
-		f = _tcschr (s, _T(';'));
-
-		if (f)
-		{
-			_tcsncpy (szPathBuffer, s, (size_t)(f-s));
-			szPathBuffer[f-s] = _T('\0');
-			s = f + 1;
-		}
-		else
-		{
-			_tcscpy (szPathBuffer, s);
-			s = NULL;
-		}
-
-		len = _tcslen(szPathBuffer);
-		if (szPathBuffer[len - 1] != _T('\\'))
-		{
-			szPathBuffer[len] = _T('\\');
-			szPathBuffer[len + 1] = _T('\0');
-		}
-		_tcscat (szPathBuffer, pFileName);
-
-		if (pExtension)
-			_tcscat (szPathBuffer, pExtension);
-
-		if (IsExistingFile (szPathBuffer))
-		{
-			TRACE ("Found: \'%s\'\n", debugstr_aw(szPathBuffer));
-			cmd_free (pszBuffer);
-			_tcscpy (pFullName, szPathBuffer);
-			return TRUE;
-		}
-	}
-	cmd_free (pszBuffer);
+	}
 	return FALSE;
 }
 
@@ -199,60 +142,64 @@
 SearchForExecutable (LPCTSTR pFileName, LPTSTR pFullName)
 {
 	static TCHAR pszDefaultPathExt[] = _T(".COM;.EXE;.BAT;.CMD");
-	LPTSTR pszBuffer = NULL;
+	LPTSTR pszPathExt, pszPath;
 	LPTSTR pCh;
-	LPTSTR pExt;
 	DWORD  dwBuffer;
 	TRACE ("SearchForExecutable: \'%s\'\n", debugstr_aw(pFileName));
+
 	/* load environment varable PATHEXT */
-	pszBuffer = (LPTSTR)cmd_alloc (ENV_BUFFER_SIZE * sizeof(TCHAR));
-	dwBuffer = GetEnvironmentVariable (_T("PATHEXT"), pszBuffer,
ENV_BUFFER_SIZE);
+	pszPathExt = (LPTSTR)cmd_alloc (ENV_BUFFER_SIZE * sizeof(TCHAR));
+	dwBuffer = GetEnvironmentVariable (_T("PATHEXT"), pszPathExt,
ENV_BUFFER_SIZE);
 	if (dwBuffer > ENV_BUFFER_SIZE)
 	{
-		pszBuffer = (LPTSTR)cmd_realloc (pszBuffer, dwBuffer * sizeof (TCHAR));
-		GetEnvironmentVariable (_T("PATHEXT"), pszBuffer, dwBuffer);
+		pszPathExt = (LPTSTR)cmd_realloc (pszPathExt, dwBuffer * sizeof (TCHAR));
+		GetEnvironmentVariable (_T("PATHEXT"), pszPathExt, dwBuffer);
 	}
 	else if (0 == dwBuffer)
 	{
-		_tcscpy(pszBuffer, pszDefaultPathExt);
-	}
-
-	TRACE ("SearchForExecutable(): Loaded PATHEXT: %s\n",
debugstr_aw(pszBuffer));
-
-	pExt = _tcsrchr(pFileName, _T('.'));
-	if (pExt != NULL)
-	{
-		LPTSTR pszBuffer2;
-		pszBuffer2 = cmd_dup(pszBuffer);
-		if (pszBuffer2)
-		{
-			pCh = _tcstok(pszBuffer2, _T(";"));
-			while (pCh)
-			{
-				if (0 == _tcsicmp(pCh, pExt))
-				{
-					cmd_free(pszBuffer);
-					cmd_free(pszBuffer2);
-					return SearchForExecutableSingle(pFileName, pFullName, NULL);
-				}
-				pCh = _tcstok(NULL, _T(";"));
-			}
-			cmd_free(pszBuffer2);
-		}
-	}
-
-	pCh = _tcstok(pszBuffer, _T(";"));
+		_tcscpy(pszPathExt, pszDefaultPathExt);
+	}
+
+	/* Check if valid directly on specified path */
+	if (SearchForExecutableSingle(pFileName, pFullName, pszPathExt, NULL))
+	{
+		cmd_free(pszPathExt);
+		return TRUE;
+	}
+
+	/* If an explicit directory was given, stop here - no need to search PATH. */
+	if (pFileName[1] == _T(':') || _tcschr(pFileName, _T('\\')))
+	{
+		cmd_free(pszPathExt);
+		return FALSE;
+	}
+
+	/* load environment varable PATH into buffer */
+	pszPath = (LPTSTR)cmd_alloc (ENV_BUFFER_SIZE * sizeof(TCHAR));
+	dwBuffer = GetEnvironmentVariable (_T("PATH"), pszPath, ENV_BUFFER_SIZE);
+	if (dwBuffer > ENV_BUFFER_SIZE)
+	{
+		pszPath = (LPTSTR)cmd_realloc (pszPath, dwBuffer * sizeof (TCHAR));
+		GetEnvironmentVariable (_T("PATH"), pszPath, dwBuffer);
+	}
+
+	TRACE ("SearchForExecutable(): Loaded PATH: %s\n", debugstr_aw(pszPath));
+
+	/* search in PATH */
+	pCh = _tcstok(pszPath, _T(";"));
 	while (pCh)
 	{
-		if (SearchForExecutableSingle(pFileName, pFullName, pCh))
-		{
-			cmd_free(pszBuffer);
+		if (SearchForExecutableSingle(pFileName, pFullName, pszPathExt, pCh))
+		{
+			cmd_free(pszPath);
+			cmd_free(pszPathExt);
 			return TRUE;
 		}
 		pCh = _tcstok(NULL, _T(";"));
 	}
 
-	cmd_free(pszBuffer);
+	cmd_free(pszPath);
+	cmd_free(pszPathExt);
 	return FALSE;
 }