https://git.reactos.org/?p=reactos.git;a=commitdiff;h=d042f51838eff1e39e92b6...
commit d042f51838eff1e39e92b61699c01ecb9a8b66d4 Author: Joachim Henze Joachim.Henze@reactos.org AuthorDate: Wed Jun 16 13:38:51 2021 +0200 Commit: Joachim Henze Joachim.Henze@reactos.org CommitDate: Wed Jun 16 13:38:51 2021 +0200
[LDR] Restore Logging when images overlap CORE-17635
This reverts 0.4.13-dev-284-g 74be88ac473425fc99e9a363ba8cd604702262bf
The logging is helpful to alert us when we should really recalculate the base addresses for performance reasons. Spams a bit sometimes, sure, but it's worth it! --- dll/ntdll/ldr/ldrutils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dll/ntdll/ldr/ldrutils.c b/dll/ntdll/ldr/ldrutils.c index 5b1ec30e525..27fa42b929f 100644 --- a/dll/ntdll/ldr/ldrutils.c +++ b/dll/ntdll/ldr/ldrutils.c @@ -1335,7 +1335,7 @@ SkipCheck: ImageBase = (ULONG_PTR)NtHeaders->OptionalHeader.ImageBase; ImageEnd = ImageBase + ViewSize;
- DPRINT("LDR: LdrpMapDll Relocating Image Name %ws (%p-%p -> %p)\n", DllName, (PVOID)ImageBase, (PVOID)ImageEnd, ViewBase); + DPRINT1("LDR: LdrpMapDll Relocating Image Name %ws (%p-%p -> %p)\n", DllName, (PVOID)ImageBase, (PVOID)ImageEnd, ViewBase);
/* Scan all the modules */ ListHead = &Peb->Ldr->InLoadOrderModuleList; @@ -1374,7 +1374,7 @@ SkipCheck: RtlInitUnicodeString(&OverlapDll, L"Dynamically Allocated Memory"); }
- DPRINT("Overlapping DLL: %wZ\n", &OverlapDll); + DPRINT1("Overlapping DLL: %wZ\n", &OverlapDll);
/* Are we dealing with a DLL? */ if (LdrEntry->Flags & LDRP_IMAGE_DLL)