Author: tfaber
Date: Sat Aug 6 17:02:54 2011
New Revision: 53102
URL:
http://svn.reactos.org/svn/reactos?rev=53102&view=rev
Log:
[WIN32K] - Fix uninitialized variable usage
[ADVAPI32] - Fix a TRACE
[PCIX] - Fix statements without effect
Spotted by MSVC.
Modified:
trunk/reactos/dll/win32/advapi32/reg/reg.c
trunk/reactos/drivers/bus/pcix/device.c
trunk/reactos/drivers/bus/pcix/pci/ppbridge.c
trunk/reactos/subsystems/win32/win32k/ntuser/hook.c
Modified: trunk/reactos/dll/win32/advapi32/reg/reg.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/reg/reg…
==============================================================================
--- trunk/reactos/dll/win32/advapi32/reg/reg.c [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/advapi32/reg/reg.c [iso-8859-1] Sat Aug 6 17:02:54 2011
@@ -4016,7 +4016,7 @@
static const int info_size = offsetof( KEY_VALUE_PARTIAL_INFORMATION, Data );
TRACE("(%p,%s,%p,%p,%p,%p=%d)\n",
- hkey, debugstr_a(name), reserved, type, data, count, count ? *count : 0 );
+ hkeyorg, debugstr_a(name), reserved, type, data, count, count ? *count : 0 );
if ((data && !count) || reserved) return ERROR_INVALID_PARAMETER;
status = MapDefaultKey(&hkey, hkeyorg);
Modified: trunk/reactos/drivers/bus/pcix/device.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/device.c?…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/device.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/device.c [iso-8859-1] Sat Aug 6 17:02:54 2011
@@ -204,7 +204,7 @@
/* This function returns TRUE if the BAR was 64-bit, handle this */
ASSERT((i + 1) < PCI_TYPE0_ADDRESSES);
i++;
- (&Limit[i])->Type == CmResourceTypeNull;
+ Limit[i].Type = CmResourceTypeNull;
}
}
Modified: trunk/reactos/drivers/bus/pcix/pci/ppbridge.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/pci/ppbri…
==============================================================================
--- trunk/reactos/drivers/bus/pcix/pci/ppbridge.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pcix/pci/ppbridge.c [iso-8859-1] Sat Aug 6 17:02:54 2011
@@ -491,7 +491,7 @@
/* Skip the next descriptor since this one is double sized */
i++;
- (&Limit[i])->Type == CmResourceTypeNull;
+ Limit[i].Type = CmResourceTypeNull;
}
}
Modified: trunk/reactos/subsystems/win32/win32k/ntuser/hook.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/ntuser/hook.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/ntuser/hook.c [iso-8859-1] Sat Aug 6 17:02:54
2011
@@ -748,7 +748,8 @@
IntGetGlobalHookHandles(PDESKTOP pdo, int HookId)
{
PLIST_ENTRY pLastHead, pElem;
- unsigned i, cHooks;
+ unsigned i = 0;
+ unsigned cHooks = 0;
HHOOK *pList;
PHOOK pHook;