[tfaber] 71672: [SHELL32_APITEST] - Add a test for CShellLink GetPath/SetPath behavior with environment variables. Patch by Andreas Maier. ROSTESTS-229 #resolve
Author: tfaber Date: Sat Jun 25 22:09:49 2016 New Revision: 71672
URL: http://svn.reactos.org/svn/reactos?rev=71672&view=rev Log: [SHELL32_APITEST] - Add a test for CShellLink GetPath/SetPath behavior with environment variables. Patch by Andreas Maier. ROSTESTS-229 #resolve
Added: trunk/rostests/apitests/shell32/CShellLink.cpp (with props) Modified: trunk/rostests/apitests/shell32/CMakeLists.txt trunk/rostests/apitests/shell32/testlist.c
Modified: trunk/rostests/apitests/shell32/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/shell32/CMakeList... ============================================================================== --- trunk/rostests/apitests/shell32/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/apitests/shell32/CMakeLists.txt [iso-8859-1] Sat Jun 25 22:09:49 2016 @@ -6,6 +6,7 @@ add_executable(shell32_apitest CMyComputer.cpp CShellDesktop.cpp + CShellLink.cpp menu.cpp shelltest.cpp SHParseDisplayName.cpp
Added: trunk/rostests/apitests/shell32/CShellLink.cpp URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/shell32/CShellLin... ============================================================================== --- trunk/rostests/apitests/shell32/CShellLink.cpp (added) +++ trunk/rostests/apitests/shell32/CShellLink.cpp [iso-8859-1] Sat Jun 25 22:09:49 2016 @@ -0,0 +1,186 @@ +/* + * PROJECT: ReactOS api tests + * LICENSE: LGPLv2.1+ - See COPYING.LIB in the top level directory + * PURPOSE: Test for CShellLink + * PROGRAMMER: Andreas Maier + */ + +#include "shelltest.h" +#include <atlbase.h> +#include <atlcom.h> +#include <strsafe.h> +#include <ndk/rtlfuncs.h> + +#define NDEBUG +#include <debug.h> +#include <shellutils.h> + +typedef +struct _TestShellLinkDef +{ + const WCHAR* pathIn; + HRESULT hrSetPath; + /* Test 1 - hrGetPathX = IShellLink::GetPath(pathOutX, ... , flagsX); */ + const WCHAR* pathOut1; + DWORD flags1; + HRESULT hrGetPath1; + bool expandPathOut1; + /* Test 2 */ + const WCHAR* pathOut2; + DWORD flags2; + HRESULT hrGetPath2; + bool expandPathOut2; +} TestShellLinkDef; + +/* Test IShellLink::SetPath with environment-variables, existing, non-existing, ...*/ +static struct _TestShellLinkDef linkTestList[] = +{ + { + L"%comspec%", S_OK, + L"%comspec%", SLGP_SHORTPATH, S_OK, TRUE, + L"%comspec%", SLGP_RAWPATH, S_OK, FALSE + }, + { + L"%anyvar%", E_INVALIDARG, + L"", SLGP_SHORTPATH, ERROR_INVALID_FUNCTION, FALSE, + L"", SLGP_RAWPATH, ERROR_INVALID_FUNCTION, FALSE + }, + { + L"%anyvar%%comspec%", S_OK, + L"c:\%anyvar%%comspec%", SLGP_SHORTPATH, S_OK, TRUE, + L"%anyvar%%comspec%", SLGP_RAWPATH, S_OK, FALSE + }, + { + L"%temp%", S_OK, + L"%temp%", SLGP_SHORTPATH, S_OK, TRUE, + L"%temp%", SLGP_RAWPATH, S_OK, FALSE + }, + { + L"%shell%", S_OK, + L"%systemroot%\system32\%shell%", SLGP_SHORTPATH, S_OK, TRUE, + L"%shell%", SLGP_RAWPATH, S_OK, FALSE + }, + { + L"u:\anypath\%anyvar%", S_OK, + L"u:\anypath\%anyvar%", SLGP_SHORTPATH, S_OK, TRUE, + L"u:\anypath\%anyvar%", SLGP_RAWPATH, S_OK, FALSE + }, + { + L"c:\temp", S_OK, + L"c:\temp", SLGP_SHORTPATH, S_OK, FALSE, + L"c:\temp", SLGP_RAWPATH, S_OK, FALSE + }, + { + L"cmd.exe", S_OK, + L"%comspec%", SLGP_SHORTPATH, S_OK, TRUE, + L"%comspec%", SLGP_RAWPATH, S_OK, TRUE + }, + { + L"c:\non-existent-path\non-existent-file", S_OK, + L"c:\non-existent-path\non-existent-file", SLGP_SHORTPATH, S_OK, FALSE, + L"c:\non-existent-path\non-existent-file", SLGP_RAWPATH, S_OK, FALSE + }, + { + L"non-existent-file", E_INVALIDARG, + L"", SLGP_SHORTPATH, ERROR_INVALID_FUNCTION, FALSE, + L"", SLGP_RAWPATH, ERROR_INVALID_FUNCTION, FALSE + }, + { NULL, 0, NULL, 0, 0, NULL, 0, 0 } +}; + +static const UINT evVarChLen = 255; +static WCHAR evVar[evVarChLen]; + +static +VOID +test_checklinkpath(TestShellLinkDef* testDef) +{ + HRESULT hr, expectedHr; + WCHAR wPathOut[255]; + bool expandPathOut; + const WCHAR* expectedPathOut; + IShellLinkW *psl; + UINT i1; + DWORD flags; + + hr = CoCreateInstance(CLSID_ShellLink, + NULL, + CLSCTX_INPROC_SERVER, + IID_PPV_ARG(IShellLinkW, &psl)); + ok(hr == S_OK, "CoCreateInstance, hr = %lx\n", hr); + if (FAILED(hr)) + { + skip("Could not instantiate CShellLink\n"); + return; + } + + hr = psl->SetPath(testDef->pathIn); + ok(hr == testDef->hrSetPath, "IShellLink::SetPath, got hr = %lx, expected %lx\n", hr, testDef->hrSetPath); + + expectedPathOut = NULL; + for (i1 = 0; i1 <= 1; i1++ ) + { + if (i1 == 1) + { + flags = testDef->flags1; + expandPathOut = testDef->expandPathOut1; + expectedPathOut = testDef->pathOut1; + expectedHr = testDef->hrGetPath1; + } + else + { + flags = testDef->flags2; + expandPathOut = testDef->expandPathOut2; + expectedPathOut = testDef->pathOut2; + expectedHr = testDef->hrGetPath2; + } + + /* Patch some variables */ + if (expandPathOut == TRUE) + { + ExpandEnvironmentStringsW(expectedPathOut,evVar,evVarChLen); + DPRINT("** %S **\n",evVar); + expectedPathOut = evVar; + } + + hr = psl->GetPath(wPathOut,sizeof(wPathOut),NULL,flags); + ok(hr == expectedHr, + "IShellLink::GetPath, flags %lx, got hr = %lx, expected %lx\n", + flags, hr, expectedHr); + ok(wcsicmp(wPathOut,expectedPathOut) == 0, + "IShellLink::GetPath, flags %lx, in %S, got %S, expected %S\n", + flags,testDef->pathIn,wPathOut,expectedPathOut); + } + + psl->Release(); +} + +static +VOID +TestShellLink(void) +{ + TestShellLinkDef *testDef; + UINT i1 = 0; + + /* needed for test */ + SetEnvironmentVariableW(L"shell",L"cmd.exe"); + + testDef = &linkTestList[i1]; + while (testDef->pathIn != NULL) + { + + DPRINT("IShellLink-Test: %S\n", testDef->pathIn); + test_checklinkpath(testDef); + i1++; + testDef = &linkTestList[i1]; + } + + SetEnvironmentVariableW(L"shell",NULL); +} + +START_TEST(CShellLink) +{ + CoInitializeEx(NULL, COINIT_APARTMENTTHREADED); + + TestShellLink(); +}
Propchange: trunk/rostests/apitests/shell32/CShellLink.cpp ------------------------------------------------------------------------------ svn:eol-style = native
Modified: trunk/rostests/apitests/shell32/testlist.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/shell32/testlist.... ============================================================================== --- trunk/rostests/apitests/shell32/testlist.c [iso-8859-1] (original) +++ trunk/rostests/apitests/shell32/testlist.c [iso-8859-1] Sat Jun 25 22:09:49 2016 @@ -5,6 +5,7 @@
extern void func_CMyComputer(void); extern void func_CShellDesktop(void); +extern void func_CShellLink(void); extern void func_menu(void); extern void func_SHParseDisplayName(void);
@@ -12,6 +13,7 @@ { { "CMyComputer", func_CMyComputer }, { "CShellDesktop", func_CShellDesktop }, + { "CShellLink", func_CShellLink }, { "menu", func_menu }, { "SHParseDisplayName", func_SHParseDisplayName }, { 0, 0 }
-
tfaber＠svn.reactos.org