Ros-diffs November 2008

ros-diffs@reactos.org

28 participants
657 discussions

[sginsberg] 37552: - Make sure allocation succeeded (CID 467)

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Sat Nov 22 05:51:01 2008 New Revision: 37552 URL: http://svn.reactos.org/svn/reactos?rev=37552&view=rev Log: - Make sure allocation succeeded (CID 467) Modified: trunk/reactos/subsystems/win32/win32k/eng/device.c Modified: trunk/reactos/subsystems/win32/win32k/eng/device.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/en… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/eng/device.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/eng/device.c [iso-8859-1] Sat Nov 22 05:51:01 2008 @@ -62,6 +62,7 @@ nInBufferSize, lpOutBuffer, nOutBufferSize, FALSE, &Event, &Iosb); + if (!Irp) return ERROR_NOT_ENOUGH_MEMORY; Status = IoCallDriver(DeviceObject, Irp);

16 years, 1 month

[dchapyshev] 37551: - Fix EnumDateFormatsA implementation. + 7 passed tests

by dchapyshev＠svn.reactos.org

Author: dchapyshev Date: Sat Nov 22 05:32:08 2008 New Revision: 37551 URL: http://svn.reactos.org/svn/reactos?rev=37551&view=rev Log: - Fix EnumDateFormatsA implementation. + 7 passed tests Modified: trunk/reactos/dll/win32/kernel32/misc/lcformat.c Modified: trunk/reactos/dll/win32/kernel32/misc/lcformat.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/misc/lc… ============================================================================== --- trunk/reactos/dll/win32/kernel32/misc/lcformat.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/misc/lcformat.c [iso-8859-1] Sat Nov 22 05:32:08 2008 @@ -1730,302 +1730,77 @@ /************************************************************************** * EnumDateFormatsA (KERNEL32.@) */ -BOOL WINAPI EnumDateFormatsA( DATEFMT_ENUMPROCA lpDateFmtEnumProc, LCID Locale, DWORD dwFlags) -{ - LCID Loc = GetUserDefaultLCID(); - if(!lpDateFmtEnumProc) - { - SetLastError(ERROR_INVALID_PARAMETER); - return FALSE; - } - - switch( Loc ) - { - - case 0x00000407: /* (Loc,"de_DE") */ - { - switch(dwFlags) - { - case DATE_SHORTDATE: - if(!(*lpDateFmtEnumProc)("dd.MM.yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d.M.yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d.MM.yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d.M.yy")) return TRUE; - return TRUE; - case DATE_LONGDATE: - if(!(*lpDateFmtEnumProc)("dddd,d. MMMM yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d. MMMM yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d. MMM yyyy")) return TRUE; - return TRUE; - default: - FIXME("Unknown date format (%ld)\n", dwFlags); - SetLastError(ERROR_INVALID_PARAMETER); - return FALSE; - } - } - - case 0x0000040c: /* (Loc,"fr_FR") */ - { - switch(dwFlags) - { - case DATE_SHORTDATE: - if(!(*lpDateFmtEnumProc)("dd/MM/yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("dd.MM.yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("dd-MM-yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("dd/MM/yyyy")) return TRUE; - return TRUE; - case DATE_LONGDATE: - if(!(*lpDateFmtEnumProc)("dddd d MMMM yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d MMM yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d MMMM yyyy")) return TRUE; - return TRUE; - default: - FIXME("Unknown date format (%ld)\n", dwFlags); - SetLastError(ERROR_INVALID_PARAMETER); - return FALSE; - } - } - - case 0x00000c0c: /* (Loc,"fr_CA") */ - { - switch(dwFlags) - { - case DATE_SHORTDATE: - if(!(*lpDateFmtEnumProc)("yy-MM-dd")) return TRUE; - if(!(*lpDateFmtEnumProc)("dd-MM-yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("yy MM dd")) return TRUE; - if(!(*lpDateFmtEnumProc)("dd/MM/yy")) return TRUE; - return TRUE; - case DATE_LONGDATE: - if(!(*lpDateFmtEnumProc)("d MMMM, yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d MMM yyyy")) return TRUE; - return TRUE; - default: - FIXME("Unknown date format (%ld)\n", dwFlags); - SetLastError(ERROR_INVALID_PARAMETER); - return FALSE; - } - } - - case 0x00000809: /* (Loc,"en_UK") */ - { - switch(dwFlags) - { - case DATE_SHORTDATE: - if(!(*lpDateFmtEnumProc)("dd/MM/yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("dd/MM/yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d/M/yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d.M.yy")) return TRUE; - return TRUE; - case DATE_LONGDATE: - if(!(*lpDateFmtEnumProc)("dd MMMM yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d MMMM yyyy")) return TRUE; - return TRUE; - default: - FIXME("Unknown date format (%ld)\n", dwFlags); - SetLastError(ERROR_INVALID_PARAMETER); - return FALSE; - } - } - - case 0x00000c09: /* (Loc,"en_AU") */ - { - switch(dwFlags) - { - case DATE_SHORTDATE: - if(!(*lpDateFmtEnumProc)("d/MM/yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d/M/yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("dd/MM/yy")) return TRUE; - return TRUE; - case DATE_LONGDATE: - if(!(*lpDateFmtEnumProc)("dddd,d MMMM yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d MMMM yyyy")) return TRUE; - return TRUE; - default: - FIXME("Unknown date format (%ld)\n", dwFlags); - SetLastError(ERROR_INVALID_PARAMETER); - return FALSE; - } - } - - case 0x00001009: /* (Loc,"en_CA") */ - { - switch(dwFlags) - { - case DATE_SHORTDATE: - if(!(*lpDateFmtEnumProc)("dd/MM/yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d/M/yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("yy-MM-dd")) return TRUE; - if(!(*lpDateFmtEnumProc)("M/dd/yy")) return TRUE; - return TRUE; - case DATE_LONGDATE: - if(!(*lpDateFmtEnumProc)("d-MMM-yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("MMMM d, yyyy")) return TRUE; - return TRUE; - default: - FIXME("Unknown date format (%ld)\n", dwFlags); - SetLastError(ERROR_INVALID_PARAMETER); - return FALSE; - } - } - - case 0x00001409: /* (Loc,"en_NZ") */ - { - switch(dwFlags) - { - case DATE_SHORTDATE: - if(!(*lpDateFmtEnumProc)("d/MM/yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("dd/MM/yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d.MM.yy")) return TRUE; - return TRUE; - case DATE_LONGDATE: - if(!(*lpDateFmtEnumProc)("d MMMM yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("dddd, d MMMM yyyy")) return TRUE; - return TRUE; - default: - FIXME("Unknown date format (%ld)\n", dwFlags); - SetLastError(ERROR_INVALID_PARAMETER); - return FALSE; - } - } - - case 0x00001809: /* (Loc,"en_IE") */ - { - switch(dwFlags) - { - case DATE_SHORTDATE: - if(!(*lpDateFmtEnumProc)("dd/MM/yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d/M/yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d.M.yy")) return TRUE; - return TRUE; - case DATE_LONGDATE: - if(!(*lpDateFmtEnumProc)("dd MMMM yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("d MMMM yyyy")) return TRUE; - return TRUE; - default: - FIXME("Unknown date format (%ld)\n", dwFlags); - SetLastError(ERROR_INVALID_PARAMETER); - return FALSE; - } - } - - case 0x00001c09: /* (Loc,"en_ZA") */ - { - switch(dwFlags) - { - case DATE_SHORTDATE: - if(!(*lpDateFmtEnumProc)("yy/MM/dd")) return TRUE; - return TRUE; - case DATE_LONGDATE: - if(!(*lpDateFmtEnumProc)("dd MMMM yyyy")) return TRUE; - return TRUE; - default: - FIXME("Unknown date format (%ld)\n", dwFlags); - SetLastError(ERROR_INVALID_PARAMETER); - return FALSE; - } - } - - case 0x00002009: /* (Loc,"en_JM") */ - { - switch(dwFlags) - { - case DATE_SHORTDATE: - if(!(*lpDateFmtEnumProc)("dd/MM/yyyy")) return TRUE; - return TRUE; - case DATE_LONGDATE: - if(!(*lpDateFmtEnumProc)("dddd,MMMM dd,yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("MMMM dd,yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("dddd,dd MMMM,yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("dd MMMM,yyyy")) return TRUE; - return TRUE; - default: - FIXME("Unknown date format (%ld)\n", dwFlags); - SetLastError(ERROR_INVALID_PARAMETER); - return FALSE; - } - } - - case 0x00002809: /* (Loc,"en_BZ") */ - case 0x00002c09: /* (Loc,"en_TT") */ - { - switch(dwFlags) - { - case DATE_SHORTDATE: - if(!(*lpDateFmtEnumProc)("dd/MM/yyyy")) return TRUE; - return TRUE; - case DATE_LONGDATE: - if(!(*lpDateFmtEnumProc)("dddd,dd MMMM yyyy")) return TRUE; - return TRUE; - default: - FIXME("Unknown date format (%ld)\n", dwFlags); - SetLastError(ERROR_INVALID_PARAMETER); - return FALSE; - } - } - - default: /* default to US English "en_US" */ - { - switch(dwFlags) - { - case DATE_SHORTDATE: - if(!(*lpDateFmtEnumProc)("M/d/yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("M/d/yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("MM/dd/yy")) return TRUE; - if(!(*lpDateFmtEnumProc)("MM/dd/yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("yy/MM/dd")) return TRUE; - if(!(*lpDateFmtEnumProc)("dd-MMM-yy")) return TRUE; - return TRUE; - case DATE_LONGDATE: - if(!(*lpDateFmtEnumProc)("dddd, MMMM dd, yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("MMMM dd, yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("dddd, dd MMMM, yyyy")) return TRUE; - if(!(*lpDateFmtEnumProc)("dd MMMM, yyyy")) return TRUE; - return TRUE; - default: - FIXME("Unknown date format (%ld)\n", dwFlags); - SetLastError(ERROR_INVALID_PARAMETER); - return FALSE; - } - } - } +BOOL WINAPI EnumDateFormatsA(DATEFMT_ENUMPROCA lpDateFmtEnumProc, LCID Locale, DWORD dwFlags) +{ + char buf[256]; + + if (!lpDateFmtEnumProc) + { + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + } + + switch (dwFlags & ~LOCALE_USE_CP_ACP) + { + case 0: + case DATE_SHORTDATE: + if (GetLocaleInfoA(Locale, LOCALE_SSHORTDATE | (dwFlags & LOCALE_USE_CP_ACP), buf, 256)) + lpDateFmtEnumProc(buf); + break; + + case DATE_LONGDATE: + if (GetLocaleInfoA(Locale, LOCALE_SLONGDATE | (dwFlags & LOCALE_USE_CP_ACP), buf, 256)) + lpDateFmtEnumProc(buf); + break; + + case DATE_YEARMONTH: + if (GetLocaleInfoA(Locale, LOCALE_SYEARMONTH | (dwFlags & LOCALE_USE_CP_ACP), buf, 256)) + lpDateFmtEnumProc(buf); + break; + + default: + FIXME("Unknown date format (%d)\n", dwFlags); + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + } + return TRUE; } /************************************************************************** * EnumDateFormatsW (KERNEL32.@) */ -BOOL WINAPI EnumDateFormatsW( DATEFMT_ENUMPROCW proc, LCID lcid, DWORD flags ) +BOOL WINAPI EnumDateFormatsW(DATEFMT_ENUMPROCW lpDateFmtEnumProc, LCID Locale, DWORD dwFlags) { WCHAR buf[256]; - if (!proc) + if (!lpDateFmtEnumProc) { SetLastError(ERROR_INVALID_PARAMETER); return FALSE; } - switch (flags & ~LOCALE_USE_CP_ACP) - { - case 0: - case DATE_SHORTDATE: - if (GetLocaleInfoW(lcid, LOCALE_SSHORTDATE | (flags & LOCALE_USE_CP_ACP), buf, 256)) - proc(buf); + switch (dwFlags & ~LOCALE_USE_CP_ACP) + { + case 0: + case DATE_SHORTDATE: + if (GetLocaleInfoW(Locale, LOCALE_SSHORTDATE | (dwFlags & LOCALE_USE_CP_ACP), buf, 256)) + lpDateFmtEnumProc(buf); break; - case DATE_LONGDATE: - if (GetLocaleInfoW(lcid, LOCALE_SLONGDATE | (flags & LOCALE_USE_CP_ACP), buf, 256)) - proc(buf); + case DATE_LONGDATE: + if (GetLocaleInfoW(Locale, LOCALE_SLONGDATE | (dwFlags & LOCALE_USE_CP_ACP), buf, 256)) + lpDateFmtEnumProc(buf); break; - case DATE_YEARMONTH: - if (GetLocaleInfoW(lcid, LOCALE_SYEARMONTH | (flags & LOCALE_USE_CP_ACP), buf, 256)) - proc(buf); + case DATE_YEARMONTH: + if (GetLocaleInfoW(Locale, LOCALE_SYEARMONTH | (dwFlags & LOCALE_USE_CP_ACP), buf, 256)) + lpDateFmtEnumProc(buf); break; - default: - FIXME("Unknown date format (%d)\n", flags); - SetLastError(ERROR_INVALID_PARAMETER); - return FALSE; + default: + FIXME("Unknown date format (%d)\n", dwFlags); + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; } return TRUE; }

16 years, 1 month

[sginsberg] 37550: - Don't. Include. ntdef.h. From. User. Mode.

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Sat Nov 22 05:17:17 2008 New Revision: 37550 URL: http://svn.reactos.org/svn/reactos?rev=37550&view=rev Log: - Don't. Include. ntdef.h. From. User. Mode. Modified: trunk/rostests/winetests/rpcrt4/rpc.c Modified: trunk/rostests/winetests/rpcrt4/rpc.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/rpcrt4/rpc.c?re… ============================================================================== --- trunk/rostests/winetests/rpcrt4/rpc.c [iso-8859-1] (original) +++ trunk/rostests/winetests/rpcrt4/rpc.c [iso-8859-1] Sat Nov 22 05:17:17 2008 @@ -28,7 +28,7 @@ #include <winbase.h> #include <winnt.h> #include <winerror.h> -#include <ntdef.h> +#include <ntsecapi.h> #include "rpc.h" #include "rpcdce.h"

16 years, 1 month

[sginsberg] 37549: - Remove system_header too

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Sat Nov 22 05:04:49 2008 New Revision: 37549 URL: http://svn.reactos.org/svn/reactos?rev=37549&view=rev Log: - Remove system_header too Modified: trunk/reactos/include/ddk/ntdef.h Modified: trunk/reactos/include/ddk/ntdef.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntdef.h?rev=37… ============================================================================== --- trunk/reactos/include/ddk/ntdef.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/ntdef.h [iso-8859-1] Sat Nov 22 05:04:49 2008 @@ -1,9 +1,5 @@ #ifndef _NTDEF_H #define _NTDEF_H - -#if __GNUC__ >= 3 -#pragma GCC system_header -#endif #include <stdarg.h> #include <windef.h>

16 years, 1 month

[sginsberg] 37548: - No, Winetests doesn't treat ntdef.h as a PSDK header, they don't include it. The include was added when the Winetest was added to ros, because of missing NTSTATUS type. Include NDK instead.

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Sat Nov 22 05:03:56 2008 New Revision: 37548 URL: http://svn.reactos.org/svn/reactos?rev=37548&view=rev Log: - No, Winetests doesn't treat ntdef.h as a PSDK header, they don't include it. The include was added when the Winetest was added to ros, because of missing NTSTATUS type. Include NDK instead. Modified: trunk/rostests/winetests/kernel32/debugger.c Modified: trunk/rostests/winetests/kernel32/debugger.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/kernel32/debugg… ============================================================================== --- trunk/rostests/winetests/kernel32/debugger.c [iso-8859-1] (original) +++ trunk/rostests/winetests/kernel32/debugger.c [iso-8859-1] Sat Nov 22 05:03:56 2008 @@ -20,9 +20,9 @@ #include <stdio.h> #include <assert.h> -#include <ntdef.h> #include <windows.h> #include <winreg.h> +#include <ntndk.h> #include "wine/test.h" #ifndef STATUS_DEBUGGER_INACTIVE

16 years, 1 month

[sginsberg] 37547: - Deprecate PSDK's usage of system_header for real now that rostests/winetests are fixed

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Sat Nov 22 04:47:17 2008 New Revision: 37547 URL: http://svn.reactos.org/svn/reactos?rev=37547&view=rev Log: - Deprecate PSDK's usage of system_header for real now that rostests/winetests are fixed Modified: trunk/reactos/include/psdk/windef.h trunk/reactos/include/psdk/windows.h Modified: trunk/reactos/include/psdk/windef.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/windef.h?rev=… ============================================================================== --- trunk/reactos/include/psdk/windef.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/windef.h [iso-8859-1] Sat Nov 22 04:47:17 2008 @@ -1,9 +1,5 @@ #ifndef _WINDEF_H #define _WINDEF_H - -#if __GNUC__ >= 3 -#pragma GCC system_header -#endif #ifdef __cplusplus extern "C" { Modified: trunk/reactos/include/psdk/windows.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/windows.h?rev… ============================================================================== --- trunk/reactos/include/psdk/windows.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/windows.h [iso-8859-1] Sat Nov 22 04:47:17 2008 @@ -12,10 +12,6 @@ */ #ifndef _WINDOWS_H #define _WINDOWS_H - -#if __GNUC__ >= 3 -#pragma GCC system_header -#endif #ifdef __GNUC__ #include <msvctarget.h>

16 years, 1 month

[sginsberg] 37546: - Silence more "has virtual functions but non-virtual destructor" warnings

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Sat Nov 22 04:38:09 2008 New Revision: 37546 URL: http://svn.reactos.org/svn/reactos?rev=37546&view=rev Log: - Silence more "has virtual functions but non-virtual destructor" warnings Modified: trunk/rostests/dibtests/patblt/patblt.rbuild trunk/rostests/dibtests/stretchblt/stretchblt.rbuild Modified: trunk/rostests/dibtests/patblt/patblt.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/rostests/dibtests/patblt/patblt.rb… ============================================================================== --- trunk/rostests/dibtests/patblt/patblt.rbuild [iso-8859-1] (original) +++ trunk/rostests/dibtests/patblt/patblt.rbuild [iso-8859-1] Sat Nov 22 04:38:09 2008 @@ -3,5 +3,6 @@ <library>kernel32</library> <library>user32</library> <library>gdi32</library> + <compilerflag compiler="cpp">-Wno-non-virtual-dtor</compilerflag> <file>patblt.cpp</file> </module> Modified: trunk/rostests/dibtests/stretchblt/stretchblt.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/rostests/dibtests/stretchblt/stret… ============================================================================== --- trunk/rostests/dibtests/stretchblt/stretchblt.rbuild [iso-8859-1] (original) +++ trunk/rostests/dibtests/stretchblt/stretchblt.rbuild [iso-8859-1] Sat Nov 22 04:38:09 2008 @@ -3,5 +3,6 @@ <library>kernel32</library> <library>user32</library> <library>gdi32</library> + <compilerflag compiler="cpp">-Wno-non-virtual-dtor</compilerflag> <file>stretchblt.cpp</file> </module>

16 years, 1 month

[sginsberg] 37545: - Silence more "has virtual functions but non-virtual destructor" warnings - Disable outdated and unused libjpeg

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Sat Nov 22 04:37:47 2008 New Revision: 37545 URL: http://svn.reactos.org/svn/reactos?rev=37545&view=rev Log: - Silence more "has virtual functions but non-virtual destructor" warnings - Disable outdated and unused libjpeg Modified: trunk/rosapps/applications/net/netreg/netreg.rbuild trunk/rosapps/applications/net/roshttpd/roshttpd.rbuild trunk/rosapps/lib/directory.rbuild Modified: trunk/rosapps/applications/net/netreg/netreg.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/net/netreg/ne… ============================================================================== --- trunk/rosapps/applications/net/netreg/netreg.rbuild [iso-8859-1] (original) +++ trunk/rosapps/applications/net/netreg/netreg.rbuild [iso-8859-1] Sat Nov 22 04:37:47 2008 @@ -4,7 +4,7 @@ <library>user32</library> <library>ws2_32</library> <library>advapi32</library> - + <compilerflag compiler="cpp">-Wno-non-virtual-dtor</compilerflag> <file>netreg.cpp</file> <file>netreg.rc</file> </module> Modified: trunk/rosapps/applications/net/roshttpd/roshttpd.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/net/roshttpd/… ============================================================================== --- trunk/rosapps/applications/net/roshttpd/roshttpd.rbuild [iso-8859-1] (original) +++ trunk/rosapps/applications/net/roshttpd/roshttpd.rbuild [iso-8859-1] Sat Nov 22 04:37:47 2008 @@ -6,6 +6,7 @@ <library>kernel32</library> <library>ws2_32</library> <library>user32</library> + <compilerflag compiler="cpp">-Wno-non-virtual-dtor</compilerflag> <file>config.cpp</file> <file>error.cpp</file> <file>http.cpp</file> Modified: trunk/rosapps/lib/directory.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/lib/directory.rbuild?rev=3… ============================================================================== --- trunk/rosapps/lib/directory.rbuild [iso-8859-1] (original) +++ trunk/rosapps/lib/directory.rbuild [iso-8859-1] Sat Nov 22 04:37:47 2008 @@ -5,11 +5,11 @@ <directory name="dflat32"> <xi:include href="dflat32/dflat32.rbuild" /> </directory> - --> + <directory name="libjpeg"> <xi:include href="libjpeg/libjpeg.rbuild" /> </directory> - + --> <directory name="libpng"> <xi:include href="libpng/libpng.rbuild" /> </directory>

16 years, 1 month

[sginsberg] 37544: - Fix indentation (spaces -> tabs)

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Sat Nov 22 03:09:50 2008 New Revision: 37544 URL: http://svn.reactos.org/svn/reactos?rev=37544&view=rev Log: - Fix indentation (spaces -> tabs) Modified: trunk/reactos/dll/win32/kernel32/kernel32.rbuild Modified: trunk/reactos/dll/win32/kernel32/kernel32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/kernel3… ============================================================================== --- trunk/reactos/dll/win32/kernel32/kernel32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/kernel32.rbuild [iso-8859-1] Sat Nov 22 03:09:50 2008 @@ -123,7 +123,7 @@ <compilerflag compiler="cpp">-fno-exceptions</compilerflag> <compilerflag compiler="cpp">-fno-rtti</compilerflag> - <compilerflag compiler="cpp">-Wno-non-virtual-dtor</compilerflag> + <compilerflag compiler="cpp">-Wno-non-virtual-dtor</compilerflag> <directory name="misc"> <file>icustubs.cpp</file>

16 years, 1 month

[fireball] 37543: Dmitry Gorbachev - Fix an issue with choosing nonexistent x86 registers %sil/%dil, see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10153 for more details. - Add "memory" to _InterlockedAddLargeStatistic(). "In Visual C++ 2005, this function behaves as a read-write barrier." -- MSDN library. - Use "+m" instead of "=m". See issue #3772 for more details.

by fireball＠svn.reactos.org

Author: fireball Date: Sat Nov 22 02:32:15 2008 New Revision: 37543 URL: http://svn.reactos.org/svn/reactos?rev=37543&view=rev Log: Dmitry Gorbachev - Fix an issue with choosing nonexistent x86 registers %sil/%dil, see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10153 for more details. - Add "memory" to _InterlockedAddLargeStatistic(). "In Visual C++ 2005, this function behaves as a read-write barrier." -- MSDN library. - Use "+m" instead of "=m". See issue #3772 for more details. Modified: trunk/reactos/include/psdk/intrin_x86.h Modified: trunk/reactos/include/psdk/intrin_x86.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/intrin_x86.h?… ============================================================================== --- trunk/reactos/include/psdk/intrin_x86.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/intrin_x86.h [iso-8859-1] Sat Nov 22 02:32:15 2008 @@ -457,8 +457,9 @@ "jae LABEL%=;" "lock; adc $0, %[Hi32];" "LABEL%=:;" : - [Lo32] "=m" (*((volatile long *)(Addend) + 0)), [Hi32] "=m" (*((volatile long *)(Addend) + 1)) : - [Value] "ir" (Value) + [Lo32] "+m" (*((volatile long *)(Addend) + 0)), [Hi32] "+m" (*((volatile long *)(Addend) + 1)) : + [Value] "ir" (Value) : + "memory" ); return Value; @@ -499,7 +500,7 @@ static __inline__ __attribute__((always_inline)) unsigned char _interlockedbittestandreset(volatile long * a, const long b) { unsigned char retval; - __asm__("lock; btrl %[b], %[a]; setb %b[retval]" : [retval] "=r" (retval), [a] "+m" (*a) : [b] "Ir" (b) : "memory"); + __asm__("lock; btrl %[b], %[a]; setb %b[retval]" : [retval] "=q" (retval), [a] "+m" (*a) : [b] "Ir" (b) : "memory"); return retval; } @@ -515,7 +516,7 @@ static __inline__ __attribute__((always_inline)) unsigned char _interlockedbittestandset(volatile long * a, const long b) { unsigned char retval; - __asm__("lock; btsl %[b], %[a]; setc %b[retval]" : [retval] "=r" (retval), [a] "+m" (*a) : [b] "Ir" (b) : "memory"); + __asm__("lock; btsl %[b], %[a]; setc %b[retval]" : [retval] "=q" (retval), [a] "+m" (*a) : [b] "Ir" (b) : "memory"); return retval; }

16 years, 1 month

← Newer
1
...
21
22
23
24
25
26
27
...
66
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs November 2008