Ros-diffs November 2008

ros-diffs@reactos.org

28 participants
657 discussions

[sginsberg] 37532: - More hack, less build breakage

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Fri Nov 21 16:03:45 2008 New Revision: 37532 URL: http://svn.reactos.org/svn/reactos?rev=37532&view=rev Log: - More hack, less build breakage Modified: trunk/reactos/include/psdk/powrprof.h Modified: trunk/reactos/include/psdk/powrprof.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/powrprof.h?re… ============================================================================== --- trunk/reactos/include/psdk/powrprof.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/powrprof.h [iso-8859-1] Fri Nov 21 16:03:45 2008 @@ -1,10 +1,12 @@ #ifndef _POWRPROF_H #define _POWRPROF_H +#ifndef __WINE_WINTERNL_H /* FIXME: Include this, so NTSTATUS gets defined. Not very clean, but I can't get the hacH^H^H^override used by official PSDK to work. */ #include <ntsecapi.h> +#endif #ifdef __cplusplus extern "C" {

16 years, 1 month

[sginsberg] 37531: - Remove system_header from the remaining PSDK headers. The era of liberally sprinkling the overkill system_header gcc hacH^H^H^extension has now come to an end and...oh, wait. What's that you say? DDK does this too? Uh, right. Will fix that too.

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Fri Nov 21 15:46:58 2008 New Revision: 37531 URL: http://svn.reactos.org/svn/reactos?rev=37531&view=rev Log: - Remove system_header from the remaining PSDK headers. The era of liberally sprinkling the overkill system_header gcc hacH^H^H^extension has now come to an end and...oh, wait. What's that you say? DDK does this too? Uh, right. Will fix that too. Modified: trunk/reactos/include/psdk/windef.h trunk/reactos/include/psdk/windows.h trunk/reactos/include/psdk/windowsx.h Modified: trunk/reactos/include/psdk/windef.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/windef.h?rev=… ============================================================================== --- trunk/reactos/include/psdk/windef.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/windef.h [iso-8859-1] Fri Nov 21 15:46:58 2008 @@ -1,8 +1,5 @@ #ifndef _WINDEF_H #define _WINDEF_H -#if __GNUC__ >=3 -#pragma GCC system_header -#endif #ifdef __cplusplus extern "C" { Modified: trunk/reactos/include/psdk/windows.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/windows.h?rev… ============================================================================== --- trunk/reactos/include/psdk/windows.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/windows.h [iso-8859-1] Fri Nov 21 15:46:58 2008 @@ -12,9 +12,6 @@ */ #ifndef _WINDOWS_H #define _WINDOWS_H -#if __GNUC__ >=3 -#pragma GCC system_header -#endif #ifdef __GNUC__ #include <msvctarget.h> Modified: trunk/reactos/include/psdk/windowsx.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/windowsx.h?re… ============================================================================== --- trunk/reactos/include/psdk/windowsx.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/windowsx.h [iso-8859-1] Fri Nov 21 15:46:58 2008 @@ -1,8 +1,5 @@ #ifndef _WINDOWSX_H #define _WINDOWSX_H -#if __GNUC__ >=3 -#pragma GCC system_header -#endif #define WM_CTLCOLOR 25 #define Button_Enable(hwndCtl,fEnable) EnableWindow((hwndCtl),(fEnable))

16 years, 1 month

[sginsberg] 37530: - Hack-include ntsecapi.h in powrprof.h, so NTSTATUS gets defined in an NDK-safe way. Not the best way, and most likely not compatible with the official header set, but I can't get the hack used by MS headers to work.

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Fri Nov 21 15:31:01 2008 New Revision: 37530 URL: http://svn.reactos.org/svn/reactos?rev=37530&view=rev Log: - Hack-include ntsecapi.h in powrprof.h, so NTSTATUS gets defined in an NDK-safe way. Not the best way, and most likely not compatible with the official header set, but I can't get the hack used by MS headers to work. Modified: trunk/reactos/include/psdk/powrprof.h Modified: trunk/reactos/include/psdk/powrprof.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/powrprof.h?re… ============================================================================== --- trunk/reactos/include/psdk/powrprof.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/powrprof.h [iso-8859-1] Fri Nov 21 15:31:01 2008 @@ -1,8 +1,10 @@ #ifndef _POWRPROF_H #define _POWRPROF_H -#if __GNUC__ >= 3 -#pragma GCC system_header -#endif + +/* FIXME: Include this, so NTSTATUS gets defined. + Not very clean, but I can't get the hacH^H^H^override used + by official PSDK to work. */ +#include <ntsecapi.h> #ifdef __cplusplus extern "C" { @@ -16,9 +18,6 @@ #define NEWSCHEME (UINT)-1 #ifndef RC_INVOKED -#ifndef NTSTATUS -typedef LONG NTSTATUS, *PNTSTATUS; -#endif typedef struct _GLOBAL_MACHINE_POWER_POLICY{ ULONG Revision;

16 years, 1 month

[sginsberg] 37529: - LANG_WELSH and LANG_BRETON are present in newer official winnt.h (and our winnt.h), so no need to put hacked-up versions of them in "Wine compatibility" winnt.h. - Don't define wchar_t in winnt.h (kudos to Colin Finck for this fix) - Remove system_header

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Fri Nov 21 15:27:30 2008 New Revision: 37529 URL: http://svn.reactos.org/svn/reactos?rev=37529&view=rev Log: - LANG_WELSH and LANG_BRETON are present in newer official winnt.h (and our winnt.h), so no need to put hacked-up versions of them in "Wine compatibility" winnt.h. - Don't define wchar_t in winnt.h (kudos to Colin Finck for this fix) - Remove system_header Modified: trunk/reactos/include/psdk/winnt.h trunk/reactos/include/reactos/wine/winnt.h Modified: trunk/reactos/include/psdk/winnt.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/winnt.h?rev=3… ============================================================================== --- trunk/reactos/include/psdk/winnt.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/winnt.h [iso-8859-1] Fri Nov 21 15:27:30 2008 @@ -1,8 +1,5 @@ #ifndef _WINNT_H #define _WINNT_H -#if __GNUC__ >= 3 -#pragma GCC system_header -#endif #ifdef __GNUC__ #include <msvctarget.h> @@ -40,10 +37,6 @@ #include <basetsd.h> #include <guiddef.h> - -#ifndef __cplusplus - typedef unsigned short wchar_t; -#endif #include <ctype.h> #undef __need_wchar_t Modified: trunk/reactos/include/reactos/wine/winnt.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/wine/winnt… ============================================================================== --- trunk/reactos/include/reactos/wine/winnt.h [iso-8859-1] (original) +++ trunk/reactos/include/reactos/wine/winnt.h [iso-8859-1] Fri Nov 21 15:27:30 2008 @@ -33,8 +33,6 @@ #define LANG_ESPERANTO 0x8f #define LANG_WALON 0x90 #define LANG_CORNISH 0x91 -#define LANG_WELSH 0x92 -#define LANG_BRETON 0x93 /* FIXME: these are not in the Windows header */ #define LANG_GAELIC 0x94

16 years, 1 month

[sginsberg] 37528: - Silence "'struct Foo' has virtual functions but non-virtual destructor" warnings for kernel32, as we don't allow warnings for this module. Needed for the coming header fixes, as system_header hides this warning.

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Fri Nov 21 15:19:13 2008 New Revision: 37528 URL: http://svn.reactos.org/svn/reactos?rev=37528&view=rev Log: - Silence "'struct Foo' has virtual functions but non-virtual destructor" warnings for kernel32, as we don't allow warnings for this module. Needed for the coming header fixes, as system_header hides this warning. Modified: trunk/reactos/dll/win32/kernel32/kernel32.rbuild Modified: trunk/reactos/dll/win32/kernel32/kernel32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/kernel3… ============================================================================== --- trunk/reactos/dll/win32/kernel32/kernel32.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/kernel32.rbuild [iso-8859-1] Fri Nov 21 15:19:13 2008 @@ -123,6 +123,7 @@ <compilerflag compiler="cpp">-fno-exceptions</compilerflag> <compilerflag compiler="cpp">-fno-rtti</compilerflag> + <compilerflag compiler="cpp">-Wno-non-virtual-dtor</compilerflag> <directory name="misc"> <file>icustubs.cpp</file>

16 years, 1 month

[sginsberg] 37527: - Protect NTSTATUS definition in NDK with a guard, as is done in the user mode headers which also define this type - Remove system_header from these user mode headers

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Fri Nov 21 15:12:53 2008 New Revision: 37527 URL: http://svn.reactos.org/svn/reactos?rev=37527&view=rev Log: - Protect NTSTATUS definition in NDK with a guard, as is done in the user mode headers which also define this type - Remove system_header from these user mode headers Modified: trunk/reactos/include/ndk/umtypes.h trunk/reactos/include/psdk/ntsecapi.h trunk/reactos/include/psdk/ntsecpkg.h trunk/reactos/include/psdk/subauth.h Modified: trunk/reactos/include/ndk/umtypes.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/umtypes.h?rev=… ============================================================================== --- trunk/reactos/include/ndk/umtypes.h [iso-8859-1] (original) +++ trunk/reactos/include/ndk/umtypes.h [iso-8859-1] Fri Nov 21 15:12:53 2008 @@ -122,12 +122,13 @@ typedef CSHORT *PCSHORT; typedef LARGE_INTEGER PHYSICAL_ADDRESS, *PPHYSICAL_ADDRESS; typedef LONG KPRIORITY; -typedef LONG NTSTATUS, *PNTSTATUS; // // Basic NT Types // #if !defined(_NTSECAPI_H) && !defined(_SUBAUTH_H) && !defined(_NTSECAPI_) + +typedef LONG NTSTATUS, *PNTSTATUS; typedef struct _UNICODE_STRING { Modified: trunk/reactos/include/psdk/ntsecapi.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/ntsecapi.h?re… ============================================================================== --- trunk/reactos/include/psdk/ntsecapi.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/ntsecapi.h [iso-8859-1] Fri Nov 21 15:12:53 2008 @@ -1,8 +1,5 @@ #ifndef _NTSECAPI_H #define _NTSECAPI_H -#if __GNUC__ >=3 -#pragma GCC system_header -#endif #ifdef __cplusplus extern "C" { Modified: trunk/reactos/include/psdk/ntsecpkg.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/ntsecpkg.h?re… ============================================================================== --- trunk/reactos/include/psdk/ntsecpkg.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/ntsecpkg.h [iso-8859-1] Fri Nov 21 15:12:53 2008 @@ -18,9 +18,6 @@ #ifndef _NTSECPKG_H #define _NTSECPKG_H -#if __GNUC__ >=3 -#pragma GCC system_header -#endif /* Flags for the MachineState field in SECPKG_PARAMETERS */ #define SECPKG_STATE_ENCRYPTION_PERMITTED 0x01 Modified: trunk/reactos/include/psdk/subauth.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/subauth.h?rev… ============================================================================== --- trunk/reactos/include/psdk/subauth.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/subauth.h [iso-8859-1] Fri Nov 21 15:12:53 2008 @@ -1,8 +1,5 @@ #ifndef _SUBAUTH_H #define _SUBAUTH_H -#if __GNUC__ >=3 -#pragma GCC system_header -#endif #ifdef __cplusplus extern "C" {

16 years, 1 month

[sginsberg] 37526: - Remove non-standard "PLANGID" type from NDK and use LANGID* instead. Also protect LANGID definition with a header guard, as winnt.h defines it too.

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Fri Nov 21 15:05:33 2008 New Revision: 37526 URL: http://svn.reactos.org/svn/reactos?rev=37526&view=rev Log: - Remove non-standard "PLANGID" type from NDK and use LANGID* instead. Also protect LANGID definition with a header guard, as winnt.h defines it too. Modified: trunk/reactos/include/ndk/exfuncs.h trunk/reactos/include/ndk/extypes.h trunk/reactos/ntoskrnl/ex/locale.c Modified: trunk/reactos/include/ndk/exfuncs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/exfuncs.h?rev=… ============================================================================== --- trunk/reactos/include/ndk/exfuncs.h [iso-8859-1] (original) +++ trunk/reactos/include/ndk/exfuncs.h [iso-8859-1] Fri Nov 21 15:05:33 2008 @@ -336,7 +336,7 @@ NTSTATUS NTAPI NtQueryDefaultUILanguage( - PLANGID LanguageId + LANGID* LanguageId ); NTSYSCALLAPI @@ -365,7 +365,7 @@ NTSTATUS NTAPI NtQueryInstallUILanguage( - PLANGID LanguageId + LANGID* LanguageId ); NTSYSCALLAPI @@ -799,7 +799,7 @@ NTSTATUS NTAPI ZwQueryDefaultUILanguage( - PLANGID LanguageId + LANGID* LanguageId ); NTSYSAPI @@ -828,7 +828,7 @@ NTSTATUS NTAPI ZwQueryInstallUILanguage( - PLANGID LanguageId + LANGID* LanguageId ); NTSYSAPI Modified: trunk/reactos/include/ndk/extypes.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/extypes.h?rev=… ============================================================================== --- trunk/reactos/include/ndk/extypes.h [iso-8859-1] (original) +++ trunk/reactos/include/ndk/extypes.h [iso-8859-1] Fri Nov 21 15:05:33 2008 @@ -49,7 +49,9 @@ // // Atom and Language IDs // -typedef USHORT LANGID, *PLANGID; +#ifndef NTOS_MODE_USER +typedef USHORT LANGID; +#endif typedef USHORT RTL_ATOM, *PRTL_ATOM; #ifndef NTOS_MODE_USER Modified: trunk/reactos/ntoskrnl/ex/locale.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/locale.c?rev=3… ============================================================================== --- trunk/reactos/ntoskrnl/ex/locale.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/locale.c [iso-8859-1] Fri Nov 21 15:05:33 2008 @@ -29,7 +29,7 @@ NTSTATUS NTAPI ExpGetCurrentUserUILanguage(IN PWSTR MuiName, - OUT PLANGID LanguageId) + OUT LANGID* LanguageId) { UCHAR ValueBuffer[256]; PKEY_VALUE_PARTIAL_INFORMATION ValueInfo; @@ -313,7 +313,7 @@ */ NTSTATUS NTAPI -NtQueryInstallUILanguage(OUT PLANGID LanguageId) +NtQueryInstallUILanguage(OUT LANGID* LanguageId) { NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE(); @@ -347,7 +347,7 @@ */ NTSTATUS NTAPI -NtQueryDefaultUILanguage(OUT PLANGID LanguageId) +NtQueryDefaultUILanguage(OUT LANGID* LanguageId) { NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE();

16 years, 1 month

[mkupfer] 37525: - Add key modifiers MK_CONTROL and MK_SHIFT to all mouse events. - See issue #3557 for more details.

by mkupfer＠svn.reactos.org

Author: mkupfer Date: Fri Nov 21 14:58:07 2008 New Revision: 37525 URL: http://svn.reactos.org/svn/reactos?rev=37525&view=rev Log: - Add key modifiers MK_CONTROL and MK_SHIFT to all mouse events. - See issue #3557 for more details. Modified: trunk/reactos/subsystems/win32/win32k/ntuser/input.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/input.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/input.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/input.c [iso-8859-1] Fri Nov 21 14:58:07 2008 @@ -1109,6 +1109,17 @@ Msg.wParam = CurInfo->ButtonsDown; Msg.lParam = MAKELPARAM(MousePos.x, MousePos.y); Msg.pt = MousePos; + + if (gQueueKeyStateTable[VK_SHIFT] & 0xc0) + { + Msg.wParam |= MK_SHIFT; + } + + if (gQueueKeyStateTable[VK_CONTROL] & 0xc0) + { + Msg.wParam |= MK_CONTROL; + } + if(DoMove) { Msg.message = WM_MOUSEMOVE;

16 years, 1 month

[spetreolle] 37524: don't redefine IDHELP.

by spetreolle＠svn.reactos.org

Author: spetreolle Date: Fri Nov 21 14:13:22 2008 New Revision: 37524 URL: http://svn.reactos.org/svn/reactos?rev=37524&view=rev Log: don't redefine IDHELP. Modified: trunk/reactos/base/applications/mscutils/eventvwr/resource.h Modified: trunk/reactos/base/applications/mscutils/eventvwr/resource.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/resource.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/resource.h [iso-8859-1] Fri Nov 21 14:13:22 2008 @@ -4,7 +4,6 @@ // #define IDC_MYICON 2 #define IDNEXT 3 -#define IDHELP 4 #define IDD_EVENTVWR_DIALOG 102 #define IDD_PROGRESSBOX 150 #define IDS_APP_TITLE 103

16 years, 1 month

[sginsberg] 37523: - winternl.h is deprecated since the NDK was invented, don't use

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Fri Nov 21 13:23:42 2008 New Revision: 37523 URL: http://svn.reactos.org/svn/reactos?rev=37523&view=rev Log: - winternl.h is deprecated since the NDK was invented, don't use Modified: trunk/reactos/dll/win32/powrprof/powrprof.c Modified: trunk/reactos/dll/win32/powrprof/powrprof.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/powrprof/powrpro… ============================================================================== --- trunk/reactos/dll/win32/powrprof/powrprof.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/powrprof/powrprof.c [iso-8859-1] Fri Nov 21 13:23:42 2008 @@ -23,7 +23,7 @@ #include <ntstatus.h> #define WIN32_NO_STATUS #include <windows.h> -#include <winternl.h> +#include <ntndk.h> #include <powrprof.h> #include <wchar.h> #include <stdio.h>

16 years, 1 month

← Newer
1
...
23
24
25
26
27
28
29
...
66
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs November 2008