Ros-diffs November 2008

ros-diffs@reactos.org

28 participants
657 discussions

[ekohl] 37260: Sync to wine-0.9.60: - Rob Shearman <rob@codeweavers.com> Fri, 11 Apr 2008 widl: Support non-default calling conventions for object methods. - Rob Shearman <rob@codeweavers.com> Fri, 11 Apr 2008 widl: Support non-default calling conventions for non-object functions. - Rob Shearman <rob@codeweavers.com> Mon, 14 Apr 2008 widl: Check that attributes applied to interfaces, functions and arguments are applicable and issue an error if not. - Rob Shearman <rob@codeweavers.com> Mon, 14 Ap
by ekohl＠svn.reactos.org 09 Nov '08

09 Nov '08

Author: ekohl Date: Sun Nov 9 08:21:53 2008 New Revision: 37260 URL: http://svn.reactos.org/svn/reactos?rev=37260&view=rev Log: Sync to wine-0.9.60: - Rob Shearman <rob(a)codeweavers.com> Fri, 11 Apr 2008 widl: Support non-default calling conventions for object methods. - Rob Shearman <rob(a)codeweavers.com> Fri, 11 Apr 2008 widl: Support non-default calling conventions for non-object functions. - Rob Shearman <rob(a)codeweavers.com> Mon, 14 Apr 2008 widl: Check that attributes applied to interfaces, functions and arguments are applicable and issue an error if not. - Rob Shearman <rob(a)codeweavers.com> Mon, 14 Apr 2008 widl: Check that attributes applied to typedefs and fields are applicable and issue an error otherwise. - Rob Shearman <rob(a)codeweavers.com> Mon, 14 Apr 2008 widl: Make the attrs parameter passed to start_typelib const. - Rob Shearman <rob(a)codeweavers.com> Mon, 14 Apr 2008 widl: The odl attribute is valid for dispinterfaces. - Rob Shearman <rob(a)codeweavers.com> Mon, 14 Apr 2008 widl: Check that attributes are applicable for libraries, modules, dispinterfaces and coclasses and otherwise issue an error. - Rob Shearman <rob(a)codeweavers.com> Mon, 14 Apr 2008 widl: Output a warning if duplicate attributes are specified. - Rob Shearman <rob(a)codeweavers.com> Mon, 14 Apr 2008 widl: Add support for the broadcast and idempotent operation attributes. - Rob Shearman <rob(a)codeweavers.com> Mon, 14 Apr 2008 widl: Write out TYPEFLAG, FUNCFLAG and VARFLAG flags for all attribute we currently parse. Add FIXMEs for the remaining ones and remove the warning for unimplemented attribute types since we now support all the attributes that we parse. - Rob Shearman <rob(a)codeweavers.com> Mon, 14 Apr 2008 widl: Add functions to print an error or warning message using location information to enable these to be printed accurately when a check is done after an element is parsed. Add location information to variable automatically, since this is will be useful for type checking of arguments. - Rob Shearman <rob(a)codeweavers.com> Mon, 14 Apr 2008 widl: Add checking to arguments of non-local functions. Check that out arguments have enough levels of indirection and that they don't derive from void * or a function pointer. - Rob Shearman <rob(a)codeweavers.com> Tue, 15 Apr 2008 widl: Change alls calls to error in the parser to error_loc so that line number information is printed. Modified: trunk/reactos/media/doc/README.WINE trunk/reactos/tools/widl/client.c trunk/reactos/tools/widl/header.c trunk/reactos/tools/widl/parser.tab.c trunk/reactos/tools/widl/parser.tab.h trunk/reactos/tools/widl/parser.y trunk/reactos/tools/widl/proxy.c trunk/reactos/tools/widl/typelib.c trunk/reactos/tools/widl/typelib.h trunk/reactos/tools/widl/utils.c trunk/reactos/tools/widl/utils.h trunk/reactos/tools/widl/widltypes.h trunk/reactos/tools/widl/write_msft.c [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/media/doc/README.WINE URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/doc/README.WINE?rev=… Modified: trunk/reactos/tools/widl/client.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/client.c?rev=37… Modified: trunk/reactos/tools/widl/header.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/header.c?rev=37… Modified: trunk/reactos/tools/widl/parser.tab.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/parser.tab.c?re… Modified: trunk/reactos/tools/widl/parser.tab.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/parser.tab.h?re… Modified: trunk/reactos/tools/widl/parser.y URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/parser.y?rev=37… Modified: trunk/reactos/tools/widl/proxy.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/proxy.c?rev=372… Modified: trunk/reactos/tools/widl/typelib.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/typelib.c?rev=3… Modified: trunk/reactos/tools/widl/typelib.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/typelib.h?rev=3… Modified: trunk/reactos/tools/widl/utils.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/utils.c?rev=372… Modified: trunk/reactos/tools/widl/utils.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/utils.h?rev=372… Modified: trunk/reactos/tools/widl/widltypes.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/widltypes.h?rev… Modified: trunk/reactos/tools/widl/write_msft.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/write_msft.c?re…

1 0

[gschneider] 37259: - Don't hard code pixel size to 16bpp. - Fixes crashes in 8bpp and halved bitmaps in 32bpp. - This SRCCOPY code is not in use atm and will probably stay this way because it's slower then the version in win32k/dib.
by gschneider＠svn.reactos.org 09 Nov '08

09 Nov '08

Author: gschneider Date: Sun Nov 9 08:00:31 2008 New Revision: 37259 URL: http://svn.reactos.org/svn/reactos?rev=37259&view=rev Log: - Don't hard code pixel size to 16bpp. - Fixes crashes in 8bpp and halved bitmaps in 32bpp. - This SRCCOPY code is not in use atm and will probably stay this way because it's slower then the version in win32k/dib. Modified: trunk/reactos/tools/gendib/gendib.c Modified: trunk/reactos/tools/gendib/gendib.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/gendib/gendib.c?rev=… ============================================================================== --- trunk/reactos/tools/gendib/gendib.c [iso-8859-1] (original) +++ trunk/reactos/tools/gendib/gendib.c [iso-8859-1] Sun Nov 9 08:00:31 2008 @@ -542,7 +542,7 @@ if (ROPCODE_SRCCOPY == RopInfo->RopCode && 0 != (Flags & FLAG_TRIVIALXLATE) && Bpp == SourceBpp) { - Output(Out, "CenterCount = 2 * (BltInfo->DestRect.right -\n"); + Output(Out, "CenterCount = %u * (BltInfo->DestRect.right -\n", Bpp >> 3); Output(Out, " BltInfo->DestRect.left);\n"); } if (RopInfo->UsesPattern && 0 != (Flags & FLAG_PATTERNSURFACE))

1 0

[spetreolle] 37258: fix UNICODE redefined warning
by spetreolle＠svn.reactos.org 09 Nov '08

09 Nov '08

Author: spetreolle Date: Sun Nov 9 07:56:31 2008 New Revision: 37258 URL: http://svn.reactos.org/svn/reactos?rev=37258&view=rev Log: fix UNICODE redefined warning Modified: trunk/rosapps/applications/sysutils/chkdsk/chkdsk.c Modified: trunk/rosapps/applications/sysutils/chkdsk/chkdsk.c URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/sysutils/chkd… ============================================================================== --- trunk/rosapps/applications/sysutils/chkdsk/chkdsk.c [iso-8859-1] (original) +++ trunk/rosapps/applications/sysutils/chkdsk/chkdsk.c [iso-8859-1] Sun Nov 9 07:56:31 2008 @@ -42,7 +42,6 @@ //====================================================================== #define WIN32_NO_STATUS #define NTOS_MODE_USER -#define UNICODE #include <windows.h> #include <stdio.h> #include <ndk/ntndk.h>

1 0

[greatlrd] 37257: Old code lying around. Adding more test to NtGdiCreateBitmap
by greatlrd＠svn.reactos.org 09 Nov '08

09 Nov '08

Author: greatlrd Date: Sun Nov 9 07:26:15 2008 New Revision: 37257 URL: http://svn.reactos.org/svn/reactos?rev=37257&view=rev Log: Old code lying around. Adding more test to NtGdiCreateBitmap Modified: branches/reactx/rostests/apitests/w32knapi/ntgdi/NtGdiCreateBitmap.c Modified: branches/reactx/rostests/apitests/w32knapi/ntgdi/NtGdiCreateBitmap.c URL: http://svn.reactos.org/svn/reactos/branches/reactx/rostests/apitests/w32kna… ============================================================================== --- branches/reactx/rostests/apitests/w32knapi/ntgdi/NtGdiCreateBitmap.c [iso-8859-1] (original) +++ branches/reactx/rostests/apitests/w32knapi/ntgdi/NtGdiCreateBitmap.c [iso-8859-1] Sun Nov 9 07:26:15 2008 @@ -5,52 +5,52 @@ BITMAP bitmap; BYTE BitmapData[10] = {0x11, 0x22, 0x33}; - /* Test simple params */ - SetLastError(ERROR_SUCCESS); - TEST((hBmp = NtGdiCreateBitmap(1, 1, 1, 1, NULL)) != NULL); - TEST(GetLastError() == ERROR_SUCCESS); - DeleteObject(hBmp); - - /* Test all zero */ - SetLastError(ERROR_SUCCESS); + SetLastError(ERROR_SUCCESS); TEST(NtGdiCreateBitmap(0, 0, 0, 0, NULL) == NULL); TEST(GetLastError() == ERROR_INVALID_PARAMETER); - /* Test cx == 0 */ - SetLastError(ERROR_SUCCESS); - TEST(NtGdiCreateBitmap(0, 1, 1, 1, NULL) == NULL); - TEST(GetLastError() == ERROR_INVALID_PARAMETER); - - /* Test negative cx */ - SetLastError(ERROR_SUCCESS); - TEST(NtGdiCreateBitmap(-10, 1, 1, 1, NULL) == NULL); - TEST(GetLastError() == ERROR_INVALID_PARAMETER); - - /* Test cy == 0 */ - SetLastError(ERROR_SUCCESS); - TEST(NtGdiCreateBitmap(1, 0, 1, 1, NULL) == NULL); - TEST(GetLastError() == ERROR_INVALID_PARAMETER); - - /* Test negative cy */ - SetLastError(ERROR_SUCCESS); - TEST(NtGdiCreateBitmap(1, -2, 1, 1, NULL) == NULL); - TEST(GetLastError() == ERROR_INVALID_PARAMETER); - - /* Test negative cy */ - SetLastError(ERROR_SUCCESS); - TEST(NtGdiCreateBitmap(1, -2, 1, 1, BitmapData) == NULL); - TEST(GetLastError() == ERROR_SUCCESS); - - /* Test huge size */ - SetLastError(ERROR_SUCCESS); - TEST(NtGdiCreateBitmap(100000, 100000, 1, 1, NULL) == NULL); - TEST(GetLastError() == ERROR_NOT_ENOUGH_MEMORY); - - /* Test cPlanes == 0 */ - SetLastError(ERROR_SUCCESS); - TEST((hBmp = NtGdiCreateBitmap(1, 1, 0, 1, NULL)) != NULL); - TEST(GetLastError() == ERROR_SUCCESS); - ASSERT(GetObject(hBmp, sizeof(BITMAP), &bitmap) == sizeof(BITMAP)); + SetLastError(ERROR_SUCCESS); + TEST(NtGdiCreateBitmap(0, 0, 0, 1, NULL) == NULL); + TEST(GetLastError() == ERROR_INVALID_PARAMETER); + + SetLastError(ERROR_SUCCESS); + TEST(NtGdiCreateBitmap(0, 0, 1, 0, NULL) == NULL); + TEST(GetLastError() == ERROR_INVALID_PARAMETER); + + SetLastError(ERROR_SUCCESS); + TEST(NtGdiCreateBitmap(0, 1, 0, 0, NULL) == NULL); + TEST(GetLastError() == ERROR_INVALID_PARAMETER); + + SetLastError(ERROR_SUCCESS); + TEST(NtGdiCreateBitmap(1, 0, 0, 0, NULL) == NULL); + TEST(GetLastError() == ERROR_INVALID_PARAMETER); + + SetLastError(ERROR_SUCCESS); + TEST(NtGdiCreateBitmap(1, 0, 0, 1, NULL) == NULL); + TEST(GetLastError() == ERROR_INVALID_PARAMETER); + + SetLastError(ERROR_SUCCESS); + TEST(NtGdiCreateBitmap(1, 0, 1, 0, NULL) == NULL); + TEST(GetLastError() == ERROR_INVALID_PARAMETER); + + SetLastError(ERROR_SUCCESS); + TEST(NtGdiCreateBitmap(1, 1, 0, 0, NULL) == NULL); + TEST(GetLastError() == ERROR_INVALID_PARAMETER); + + SetLastError(ERROR_SUCCESS); + TEST(NtGdiCreateBitmap(1, 1, 0, 1, NULL) == NULL); + TEST(GetLastError() == ERROR_INVALID_PARAMETER); + + SetLastError(ERROR_SUCCESS); + TEST(NtGdiCreateBitmap(1, 1, 1, 0, NULL) == NULL); + TEST(GetLastError() == ERROR_INVALID_PARAMETER); + + SetLastError(ERROR_SUCCESS); + TEST( (hBmp =NtGdiCreateBitmap(1, 1, 1, 1, NULL)) != NULL); + TEST(GetLastError() == ERROR_INVALID_PARAMETER); + + RtlZeroMemory(&bitmap,sizeof(BITMAP)); + TEST(GetObject(hBmp, sizeof(BITMAP), &bitmap) == sizeof(BITMAP)); TEST(bitmap.bmType == 0); TEST(bitmap.bmWidth == 1); TEST(bitmap.bmHeight == 1); @@ -59,18 +59,39 @@ TEST(bitmap.bmBitsPixel == 1); DeleteObject(hBmp); - /* Test big cPlanes */ - SetLastError(ERROR_SUCCESS); - TEST((hBmp = NtGdiCreateBitmap(1, 1, 32, 1, NULL)) != NULL); - TEST(GetLastError() == ERROR_SUCCESS); - DeleteObject(hBmp); - - TEST(NtGdiCreateBitmap(1, 1, 33, 1, NULL) == NULL); - TEST(GetLastError() == ERROR_INVALID_PARAMETER); - - /* Test cBPP == 0 */ - SetLastError(ERROR_SUCCESS); - TEST((hBmp = NtGdiCreateBitmap(1, 1, 1, 0, NULL)) != NULL); + SetLastError(ERROR_SUCCESS); + TEST( (hBmp =NtGdiCreateBitmap(1, 1, 1, -1, NULL)) != NULL); + TEST(GetLastError() == ERROR_INVALID_PARAMETER); + DeleteObject(hBmp); + + SetLastError(ERROR_SUCCESS); + TEST( (hBmp =NtGdiCreateBitmap(1, 1, -1, 1, NULL)) != NULL); + TEST(GetLastError() == ERROR_INVALID_PARAMETER); + DeleteObject(hBmp); + + SetLastError(ERROR_SUCCESS); + TEST( (hBmp =NtGdiCreateBitmap(1, -1, 1, 1, NULL)) != NULL); + TEST(GetLastError() == ERROR_INVALID_PARAMETER); + DeleteObject(hBmp); + + SetLastError(ERROR_SUCCESS); + TEST( (hBmp =NtGdiCreateBitmap(-1, 1, 1, 1, NULL)) != NULL); + TEST(GetLastError() == ERROR_INVALID_PARAMETER); + DeleteObject(hBmp); + + + + + + + /* Test huge size */ + SetLastError(ERROR_SUCCESS); + TEST(NtGdiCreateBitmap(100000, 100000, 1, 1, NULL) == NULL); + TEST(GetLastError() == ERROR_NOT_ENOUGH_MEMORY); + + /* Test cPlanes == 0 */ + SetLastError(ERROR_SUCCESS); + TEST((hBmp = NtGdiCreateBitmap(1, 1, 0, 1, NULL)) != NULL); TEST(GetLastError() == ERROR_SUCCESS); ASSERT(GetObject(hBmp, sizeof(BITMAP), &bitmap) == sizeof(BITMAP)); TEST(bitmap.bmType == 0); @@ -81,10 +102,28 @@ TEST(bitmap.bmBitsPixel == 1); DeleteObject(hBmp); - /* Test negative cBPP */ - SetLastError(ERROR_SUCCESS); - TEST(NtGdiCreateBitmap(1, 1, 1, -1, NULL) == NULL); - TEST(GetLastError() == ERROR_INVALID_PARAMETER); + /* Test big cPlanes */ + SetLastError(ERROR_SUCCESS); + TEST((hBmp = NtGdiCreateBitmap(1, 1, 32, 1, NULL)) != NULL); + TEST(GetLastError() == ERROR_SUCCESS); + DeleteObject(hBmp); + + TEST(NtGdiCreateBitmap(1, 1, 33, 1, NULL) == NULL); + TEST(GetLastError() == ERROR_INVALID_PARAMETER); + + /* Test cBPP == 0 */ + SetLastError(ERROR_SUCCESS); + TEST((hBmp = NtGdiCreateBitmap(1, 1, 1, 0, NULL)) != NULL); + TEST(GetLastError() == ERROR_SUCCESS); + ASSERT(GetObject(hBmp, sizeof(BITMAP), &bitmap) == sizeof(BITMAP)); + TEST(bitmap.bmType == 0); + TEST(bitmap.bmWidth == 1); + TEST(bitmap.bmHeight == 1); + TEST(bitmap.bmWidthBytes == 2); + TEST(bitmap.bmPlanes == 1); + TEST(bitmap.bmBitsPixel == 1); + DeleteObject(hBmp); + /* Test bad cBPP */ SetLastError(ERROR_SUCCESS); @@ -148,31 +187,14 @@ DeleteObject(hBmp); - /* Test height 0 params */ - SetLastError(ERROR_SUCCESS); - TEST((hBmp = NtGdiCreateBitmap(1, 0, 1, 1, NULL)) == NULL); - TEST(GetLastError() == ERROR_INVALID_PARAMETER); - - /* Test height -1 params */ - SetLastError(ERROR_SUCCESS); - TEST((hBmp = NtGdiCreateBitmap(1, -1, 1, 1, NULL)) == NULL); - TEST(GetLastError() == ERROR_INVALID_PARAMETER); - - /* Test witdth 0 params */ - SetLastError(ERROR_SUCCESS); - TEST((hBmp = NtGdiCreateBitmap(0, 1, 1, 1, NULL)) == NULL); - TEST(GetLastError() == ERROR_INVALID_PARAMETER); - - /* Test witdth -1 params */ - SetLastError(ERROR_SUCCESS); - TEST((hBmp = NtGdiCreateBitmap(-1, 0, 1, 1, NULL)) == NULL); - TEST(GetLastError() == ERROR_INVALID_PARAMETER); - - - /* Test witdth -1 params */ - SetLastError(ERROR_SUCCESS); - TEST((hBmp = NtGdiCreateBitmap(0, 0, 1, 1, NULL)) == NULL); - TEST(GetLastError() == ERROR_INVALID_PARAMETER); + + + + + + + + return APISTATUS_NORMAL;

1 0

[greatlrd] 37256: branch latest trunk r37254 to reactx
by greatlrd＠svn.reactos.org 09 Nov '08

09 Nov '08

Author: greatlrd Date: Sun Nov 9 05:50:18 2008 New Revision: 37256 URL: http://svn.reactos.org/svn/reactos?rev=37256&view=rev Log: branch latest trunk r37254 to reactx Added: branches/reactx/ - copied from r37255, trunk/

1 0

[greatlrd] 37255: rename reactx to old_reactx prepare for branch lates trunk to reactx
by greatlrd＠svn.reactos.org 09 Nov '08

09 Nov '08

Author: greatlrd Date: Sun Nov 9 05:48:26 2008 New Revision: 37255 URL: http://svn.reactos.org/svn/reactos?rev=37255&view=rev Log: rename reactx to old_reactx prepare for branch lates trunk to reactx Added: branches/old_reactx/ - copied from r37254, branches/reactx/ Removed: branches/reactx/

1 0

[pschweitzer] 37253: Simplified the FsRtlIsFatDbcsLegal, FsRtlIsHpfsDbcsLegal functions using the previous macros. This removes a name parse.
by pschweitzer＠svn.reactos.org 08 Nov '08

08 Nov '08

Author: pschweitzer Date: Sat Nov 8 12:36:22 2008 New Revision: 37253 URL: http://svn.reactos.org/svn/reactos?rev=37253&view=rev Log: Simplified the FsRtlIsFatDbcsLegal, FsRtlIsHpfsDbcsLegal functions using the previous macros. This removes a name parse. Modified: branches/pierre-fsd/ntoskrnl/fsrtl/dbcsname.c Modified: branches/pierre-fsd/ntoskrnl/fsrtl/dbcsname.c URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/ntoskrnl/fsrtl/dbcsn… ============================================================================== --- branches/pierre-fsd/ntoskrnl/fsrtl/dbcsname.c [iso-8859-1] (original) +++ branches/pierre-fsd/ntoskrnl/fsrtl/dbcsname.c [iso-8859-1] Sat Nov 8 12:36:22 2008 @@ -285,12 +285,7 @@ if (FirstPart.Length < 3 || FirstPart.Length > 12) return FALSE; - if (!WildCardsPermissible && FsRtlDoesDbcsContainWildCards(&FirstPart)) - return FALSE; - - /* Now, we will parse the filename to find everything bad in - * It mustn't contain: - * 0x00-0x1F, 0x22, 0x2B, 0x2C, 0x2F, 0x3A, 0x3B, 0x3D, 0x5B, 0x5D, 0x7C */ + /* Now, we will parse the filename to find everything bad in */ for (i = 0; i < FirstPart.Length; i++) { /* First make sure the character it's not the Lead DBCS */ @@ -300,12 +295,8 @@ return FALSE; i++; } - else if ((FirstPart.Buffer[i] < 0x1F) || (FirstPart.Buffer[i] == 0x22) || - (FirstPart.Buffer[i] == 0x2B) || (FirstPart.Buffer[i] == 0x2C) || - (FirstPart.Buffer[i] == 0x2F) || (FirstPart.Buffer[i] == 0x3A) || - (FirstPart.Buffer[i] == 0x3B) || (FirstPart.Buffer[i] == 0x3D) || - (FirstPart.Buffer[i] == 0x5B) || (FirstPart.Buffer[i] == 0x5D) || - (FirstPart.Buffer[i] == 0x7C)) + /* Then check for bad characters */ + else if (!FsRtlIsAnsiCharacterLegalFat(FirstPart.Buffer[i], WildCardsPermissible)) { return FALSE; } @@ -427,12 +418,7 @@ if (FirstPart.Length > 255) return FALSE; - if (!WildCardsPermissible && FsRtlDoesDbcsContainWildCards(&FirstPart)) - return FALSE; - - /* Now, we will parse the filename to find everything bad in - * It mustn't contain: - * 0x00-0x1F, 0x22, 0x2A, 0x2F, 0x3A, 0x3C, 0x3E, 0x3F, 0x7C */ + /* Now, we will parse the filename to find everything bad in */ for (i = 0; i < FirstPart.Length; i++) { /* First make sure the character it's not the Lead DBCS */ @@ -442,11 +428,8 @@ return FALSE; i++; } - else if ((FirstPart.Buffer[i] < 0x1F) || (FirstPart.Buffer[i] == 0x22) || - (FirstPart.Buffer[i] == 0x2A) || (FirstPart.Buffer[i] == 0x2F) || - (FirstPart.Buffer[i] == 0x3A) || (FirstPart.Buffer[i] == 0x3C) || - (FirstPart.Buffer[i] == 0x3E) || (FirstPart.Buffer[i] == 0x3F) || - (FirstPart.Buffer[i] == 0x7C)) + /* Then check for bad characters */ + else if (!!FsRtlIsAnsiCharacterLegalHpfs(FirstPart.Buffer[i], WildCardsPermissible)) { return FALSE; }

1 0

[pschweitzer] 37252: Added FsRtlIsAnsiCharacterLegalFat, FsRtlIsAnsiCharacterLegalHpfs, FsRtlIsAnsiCharacterLegalNtfs macros
by pschweitzer＠svn.reactos.org 08 Nov '08

08 Nov '08

Author: pschweitzer Date: Sat Nov 8 12:34:47 2008 New Revision: 37252 URL: http://svn.reactos.org/svn/reactos?rev=37252&view=rev Log: Added FsRtlIsAnsiCharacterLegalFat, FsRtlIsAnsiCharacterLegalHpfs, FsRtlIsAnsiCharacterLegalNtfs macros Modified: branches/pierre-fsd/include/ddk/ntifs.h Modified: branches/pierre-fsd/include/ddk/ntifs.h URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/include/ddk/ntifs.h?… ============================================================================== --- branches/pierre-fsd/include/ddk/ntifs.h [iso-8859-1] (original) +++ branches/pierre-fsd/include/ddk/ntifs.h [iso-8859-1] Sat Nov 8 12:34:47 2008 @@ -2959,6 +2959,25 @@ IN PFSRTL_PER_STREAM_CONTEXT Ptr ); +#define FsRtlIsAnsiCharacterLegalFat(C, WILD) ( \ + FlagOn(FsRtlLegalAnsiCharacterArray[(UCHAR)(C)], (FSRTL_FAT_LEGAL) | \ + ((WILD) ? FSRTL_WILD_CHARACTER : 0 )) \ +) + +#define FsRtlIsAnsiCharacterLegalHpfs(C, WILD) ( \ + FlagOn(FsRtlLegalAnsiCharacterArray[(UCHAR)(C)], (FSRTL_HPFS_LEGAL) | \ + ((WILD) ? FSRTL_WILD_CHARACTER : 0 )) \ +) + +#define FsRtlIsAnsiCharacterLegalNtfs(C, WILD) ( \ + FlagOn(FsRtlLegalAnsiCharacterArray[(UCHAR)(C)], (FSRTL_NTFS_LEGAL) | \ + ((WILD) ? FSRTL_WILD_CHARACTER : 0 )) \ +) + +#define FsRtlIsAnsiCharacterWild(C) ( \ + FlagOn(FsRtlLegalAnsiCharacterArray[(UCHAR)(C)], FSRTL_WILD_CHARACTER ) \ +) + NTKERNELAPI BOOLEAN NTAPI @@ -3004,10 +3023,6 @@ (BOOLEAN)((UCHAR)(DBCS_CHAR) < 0x80 ? FALSE : \ (NLS_MB_CODE_PAGE_TAG && \ (NLS_OEM_LEAD_BYTE_INFO[(UCHAR)(DBCS_CHAR)] != 0))) \ -) - -#define FsRtlIsAnsiCharacterWild(C) ( \ - FlagOn(FsRtlLegalAnsiCharacterArray[(UCHAR)(C)], FSRTL_WILD_CHARACTER ) \ ) #define FsRtlIsUnicodeCharacterWild(C) ( \

1 0

[cgutman] 37251: - We should wait in KernelMode
by cgutman＠svn.reactos.org 08 Nov '08

08 Nov '08

Author: cgutman Date: Sat Nov 8 11:16:15 2008 New Revision: 37251 URL: http://svn.reactos.org/svn/reactos?rev=37251&view=rev Log: - We should wait in KernelMode Modified: branches/aicom-network-fixes/drivers/network/afd/afd/tdi.c Modified: branches/aicom-network-fixes/drivers/network/afd/afd/tdi.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/net… ============================================================================== --- branches/aicom-network-fixes/drivers/network/afd/afd/tdi.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/drivers/network/afd/afd/tdi.c [iso-8859-1] Sat Nov 8 11:16:15 2008 @@ -74,7 +74,7 @@ KeWaitForSingleObject( Event, Executive, - UserMode, + KernelMode, FALSE, NULL); Status = Iosb->Status;

1 0

[dchapyshev] 37250: - Sync inetcomm with Wine Head - Sync imnxport.idl and mimeole.idl
by dchapyshev＠svn.reactos.org 08 Nov '08

08 Nov '08

Author: dchapyshev Date: Sat Nov 8 01:14:34 2008 New Revision: 37250 URL: http://svn.reactos.org/svn/reactos?rev=37250&view=rev Log: - Sync inetcomm with Wine Head - Sync imnxport.idl and mimeole.idl Added: trunk/reactos/dll/win32/inetcomm/imaptransport.c (with props) trunk/reactos/dll/win32/inetcomm/mimeintl.c (with props) trunk/reactos/dll/win32/inetcomm/pop3transport.c (with props) trunk/reactos/dll/win32/inetcomm/smtptransport.c (with props) Modified: trunk/reactos/dll/win32/inetcomm/inetcomm.rbuild trunk/reactos/dll/win32/inetcomm/inetcomm.spec trunk/reactos/dll/win32/inetcomm/inetcomm_main.c trunk/reactos/dll/win32/inetcomm/inetcomm_private.h trunk/reactos/dll/win32/inetcomm/internettransport.c trunk/reactos/dll/win32/inetcomm/mimeole.c trunk/reactos/dll/win32/inetcomm/regsvr.c trunk/reactos/include/psdk/imnxport.idl trunk/reactos/include/psdk/mimeole.idl [This mail would be too long, it was shortened to contain the URLs only.] Added: trunk/reactos/dll/win32/inetcomm/imaptransport.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/inetcomm/imaptra… Modified: trunk/reactos/dll/win32/inetcomm/inetcomm.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/inetcomm/inetcom… Modified: trunk/reactos/dll/win32/inetcomm/inetcomm.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/inetcomm/inetcom… Modified: trunk/reactos/dll/win32/inetcomm/inetcomm_main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/inetcomm/inetcom… Modified: trunk/reactos/dll/win32/inetcomm/inetcomm_private.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/inetcomm/inetcom… Modified: trunk/reactos/dll/win32/inetcomm/internettransport.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/inetcomm/interne… Added: trunk/reactos/dll/win32/inetcomm/mimeintl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/inetcomm/mimeint… Modified: trunk/reactos/dll/win32/inetcomm/mimeole.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/inetcomm/mimeole… Added: trunk/reactos/dll/win32/inetcomm/pop3transport.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/inetcomm/pop3tra… Modified: trunk/reactos/dll/win32/inetcomm/regsvr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/inetcomm/regsvr.… Added: trunk/reactos/dll/win32/inetcomm/smtptransport.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/inetcomm/smtptra… Modified: trunk/reactos/include/psdk/imnxport.idl URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/imnxport.idl?… Modified: trunk/reactos/include/psdk/mimeole.idl URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/mimeole.idl?r…

1 0

← Newer
1
...
50
51
52
53
54
55
56
...
66
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs November 2008