Ros-diffs September 2008

ros-diffs@reactos.org

27 participants
747 discussions

[fireball] 36534: - Remove an excessive ASSERT (there is a real one below in the function).
by fireball＠svn.reactos.org 26 Sep '08

26 Sep '08

Author: fireball Date: Fri Sep 26 06:48:54 2008 New Revision: 36534 URL: http://svn.reactos.org/svn/reactos?rev=36534&view=rev Log: - Remove an excessive ASSERT (there is a real one below in the function). Modified: trunk/reactos/drivers/filesystems/fastfat/dirwr.c Modified: trunk/reactos/drivers/filesystems/fastfat/dirwr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/dirwr.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/dirwr.c [iso-8859-1] Fri Sep 26 06:48:54 2008 @@ -25,7 +25,6 @@ ULONG dirIndex; ASSERT(pFcb); - ASSERT(pFcb->parentFcb); if (pFcb->Flags & FCB_IS_FATX_ENTRY) {

1 0

[fireball] 36533: - Apply Art's bitmap patch from the branch, and change the other 2 functions similarly (bit set & clear).
by fireball＠svn.reactos.org 26 Sep '08

26 Sep '08

Author: fireball Date: Fri Sep 26 04:42:15 2008 New Revision: 36533 URL: http://svn.reactos.org/svn/reactos?rev=36533&view=rev Log: - Apply Art's bitmap patch from the branch, and change the other 2 functions similarly (bit set & clear). Modified: trunk/reactos/lib/rtl/bitmap.c Modified: trunk/reactos/lib/rtl/bitmap.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/bitmap.c?rev=36533… ============================================================================== --- trunk/reactos/lib/rtl/bitmap.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/bitmap.c [iso-8859-1] Fri Sep 26 04:42:15 2008 @@ -440,12 +440,12 @@ RtlClearBit(PRTL_BITMAP BitMapHeader, ULONG BitNumber) { - PULONG Ptr; + PUCHAR Ptr; if (BitNumber >= BitMapHeader->SizeOfBitMap) return; - Ptr = (PULONG)BitMapHeader->Buffer + (BitNumber / 32); - *Ptr &= ~(1 << (BitNumber % 32)); + Ptr = (PUCHAR)BitMapHeader->Buffer + (BitNumber / 8); + *Ptr &= ~(1 << (BitNumber % 8)); } /* @@ -457,7 +457,7 @@ IN ULONG StartingIndex, IN ULONG NumberToClear) { - LPBYTE lpOut; + LPBYTE lpOut; if (!BitMapHeader || !NumberToClear || StartingIndex >= BitMapHeader->SizeOfBitMap || @@ -540,12 +540,6 @@ return ~0U; } - - - - - - /* * @implemented */ @@ -557,7 +551,6 @@ { return NTDLL_FindRuns(BitMapHeader, RunArray, SizeOfRunArray, LocateLongestRuns, NTDLL_FindClearRun); } - /* * @unimplemented @@ -745,9 +738,6 @@ } - - - /* * @implemented */ @@ -797,14 +787,14 @@ RtlSetBit(PRTL_BITMAP BitMapHeader, ULONG BitNumber) { - PULONG Ptr; + PUCHAR Ptr; if (BitNumber >= BitMapHeader->SizeOfBitMap) return; - Ptr = (PULONG)BitMapHeader->Buffer + (BitNumber / 32); - - *Ptr |= (1 << (BitNumber % 32)); + Ptr = (PUCHAR)BitMapHeader->Buffer + (BitNumber / 8); + + *Ptr |= (1 << (BitNumber % 8)); } @@ -867,14 +857,14 @@ RtlTestBit(PRTL_BITMAP BitMapHeader, ULONG BitNumber) { - PULONG Ptr; + PUCHAR Ptr; if (BitNumber >= BitMapHeader->SizeOfBitMap) return FALSE; - Ptr = (PULONG)BitMapHeader->Buffer + (BitNumber / 32); - - return (BOOLEAN)(*Ptr & (1 << (BitNumber % 32))); + Ptr = (PUCHAR)BitMapHeader->Buffer + (BitNumber / 8); + + return (BOOLEAN)(*Ptr & (1 << (BitNumber % 8))); } /*

1 0

[cwittich] 36532: set eol-style:native
by cwittich＠svn.reactos.org 26 Sep '08

26 Sep '08

Author: cwittich Date: Fri Sep 26 00:05:59 2008 New Revision: 36532 URL: http://svn.reactos.org/svn/reactos?rev=36532&view=rev Log: set eol-style:native Modified: trunk/reactos/include/psdk/activaut.idl (contents, props changed) trunk/reactos/include/psdk/activdbg.idl (contents, props changed) trunk/reactos/include/psdk/imnact.idl (contents, props changed) trunk/reactos/include/psdk/imnxport.idl (contents, props changed) trunk/reactos/include/psdk/mimeole.idl (contents, props changed) [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/include/psdk/activaut.idl URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/activaut.idl?… Modified: trunk/reactos/include/psdk/activdbg.idl URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/activdbg.idl?… Modified: trunk/reactos/include/psdk/imnact.idl URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/imnact.idl?re… Modified: trunk/reactos/include/psdk/imnxport.idl URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/imnxport.idl?… Modified: trunk/reactos/include/psdk/mimeole.idl URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/mimeole.idl?r…

1 0

[cwittich] 36531: set eol-style:native
by cwittich＠svn.reactos.org 26 Sep '08

26 Sep '08

Author: cwittich Date: Fri Sep 26 00:03:14 2008 New Revision: 36531 URL: http://svn.reactos.org/svn/reactos?rev=36531&view=rev Log: set eol-style:native Modified: trunk/reactos/dll/directx/d3d8/d3d8.rbuild (contents, props changed) trunk/reactos/dll/directx/d3d9/d3d9.rbuild (contents, props changed) Modified: trunk/reactos/dll/directx/d3d8/d3d8.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/d3d8/d3d8.rbui… ============================================================================== --- trunk/reactos/dll/directx/d3d8/d3d8.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/directx/d3d8/d3d8.rbuild [iso-8859-1] Fri Sep 26 00:03:14 2008 @@ -1,7 +1,7 @@ -<?xml version="1.0"?> -<!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="d3d8" type="win32dll" entrypoint="0" installbase="system32" installname="d3d8.dll"> - <importlibrary definition="d3d8.def" /> - <file>d3d8.c</file> - <file>d3d8.rc</file> -</module> +<?xml version="1.0"?> +<!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> +<module name="d3d8" type="win32dll" entrypoint="0" installbase="system32" installname="d3d8.dll"> + <importlibrary definition="d3d8.def" /> + <file>d3d8.c</file> + <file>d3d8.rc</file> +</module> Propchange: trunk/reactos/dll/directx/d3d8/d3d8.rbuild ------------------------------------------------------------------------------ svn:eol-style = native Modified: trunk/reactos/dll/directx/d3d9/d3d9.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/d3d9/d3d9.rbui… ============================================================================== --- trunk/reactos/dll/directx/d3d9/d3d9.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/directx/d3d9/d3d9.rbuild [iso-8859-1] Fri Sep 26 00:03:14 2008 @@ -1,34 +1,34 @@ -<?xml version="1.0"?> -<!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="d3d9" type="win32dll" entrypoint="0" installbase="system32" installname="d3d9.dll" baseaddress="0x4fdd0000"> - <importlibrary definition="d3d9.spec.def" /> - - <library>advapi32</library> - <library>kernel32</library> - <library>user32</library> - <library>gdi32</library> - <library>uuid</library> - <library>dxguid</library> - <library>version</library> - <library>d3d8thk</library> - - <file>d3d9.c</file> - <file>d3d9_baseobject.c</file> - <file>d3d9_caps.c</file> - <file>d3d9_create.c</file> - <file>d3d9_cursor.c</file> - <file>d3d9_device.c</file> - <file>d3d9_haldevice.c</file> - <file>d3d9_helpers.c</file> - <file>d3d9_impl.c</file> - <file>d3d9_mipmap.c</file> - <file>d3d9_puredevice.c</file> - <file>d3d9_resource.c</file> - <file>d3d9_swapchain.c</file> - <file>d3d9_texture.c</file> - <file>adapter.c</file> - <file>device.c</file> - <file>format.c</file> - <file>d3d9.rc</file> - <file>d3d9.spec</file> -</module> +<?xml version="1.0"?> +<!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> +<module name="d3d9" type="win32dll" entrypoint="0" installbase="system32" installname="d3d9.dll" baseaddress="0x4fdd0000"> + <importlibrary definition="d3d9.spec.def" /> + + <library>advapi32</library> + <library>kernel32</library> + <library>user32</library> + <library>gdi32</library> + <library>uuid</library> + <library>dxguid</library> + <library>version</library> + <library>d3d8thk</library> + + <file>d3d9.c</file> + <file>d3d9_baseobject.c</file> + <file>d3d9_caps.c</file> + <file>d3d9_create.c</file> + <file>d3d9_cursor.c</file> + <file>d3d9_device.c</file> + <file>d3d9_haldevice.c</file> + <file>d3d9_helpers.c</file> + <file>d3d9_impl.c</file> + <file>d3d9_mipmap.c</file> + <file>d3d9_puredevice.c</file> + <file>d3d9_resource.c</file> + <file>d3d9_swapchain.c</file> + <file>d3d9_texture.c</file> + <file>adapter.c</file> + <file>device.c</file> + <file>format.c</file> + <file>d3d9.rc</file> + <file>d3d9.spec</file> +</module> Propchange: trunk/reactos/dll/directx/d3d9/d3d9.rbuild ------------------------------------------------------------------------------ svn:eol-style = native

1 0

[cwittich] 36530: set eol-style:native
by cwittich＠svn.reactos.org 26 Sep '08

26 Sep '08

Author: cwittich Date: Thu Sep 25 23:55:25 2008 New Revision: 36530 URL: http://svn.reactos.org/svn/reactos?rev=36530&view=rev Log: set eol-style:native Modified: trunk/reactos/drivers/storage/class/directory.rbuild (contents, props changed) Modified: trunk/reactos/drivers/storage/class/directory.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/dire… ============================================================================== --- trunk/reactos/drivers/storage/class/directory.rbuild [iso-8859-1] (original) +++ trunk/reactos/drivers/storage/class/directory.rbuild [iso-8859-1] Thu Sep 25 23:55:25 2008 @@ -1,16 +1,16 @@ -<?xml version="1.0"?> -<!DOCTYPE group SYSTEM "../../../tools/rbuild/project.dtd"> -<group xmlns:xi="http://www.w3.org/2001/XInclude"> - <directory name="cdrom"> - <xi:include href="cdrom/cdrom.rbuild" /> - </directory> - <directory name="class2"> - <xi:include href="class2/class2.rbuild" /> - </directory> - <directory name="disk"> - <xi:include href="disk/disk.rbuild" /> - </directory> - <directory name="ramdisk"> - <xi:include href="ramdisk/ramdisk.rbuild" /> - </directory> -</group> +<?xml version="1.0"?> +<!DOCTYPE group SYSTEM "../../../tools/rbuild/project.dtd"> +<group xmlns:xi="http://www.w3.org/2001/XInclude"> + <directory name="cdrom"> + <xi:include href="cdrom/cdrom.rbuild" /> + </directory> + <directory name="class2"> + <xi:include href="class2/class2.rbuild" /> + </directory> + <directory name="disk"> + <xi:include href="disk/disk.rbuild" /> + </directory> + <directory name="ramdisk"> + <xi:include href="ramdisk/ramdisk.rbuild" /> + </directory> +</group> Propchange: trunk/reactos/drivers/storage/class/directory.rbuild ------------------------------------------------------------------------------ svn:eol-style = native

1 0

[cwittich] 36529: set eol-style:native
by cwittich＠svn.reactos.org 26 Sep '08

26 Sep '08

Author: cwittich Date: Thu Sep 25 23:51:32 2008 New Revision: 36529 URL: http://svn.reactos.org/svn/reactos?rev=36529&view=rev Log: set eol-style:native Modified: trunk/reactos/dll/win32/stdole2.tlb/stdole2.rbuild (contents, props changed) Modified: trunk/reactos/dll/win32/stdole2.tlb/stdole2.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/stdole2.tlb/stdo… ============================================================================== --- trunk/reactos/dll/win32/stdole2.tlb/stdole2.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/stdole2.tlb/stdole2.rbuild [iso-8859-1] Thu Sep 25 23:51:32 2008 @@ -1,25 +1,25 @@ -<group> -<module name="std_ole_v2" type="embeddedtypelib"> - <include base="std_ole_v2">.</include> - <include base="ReactOS">include/reactos/wine</include> - <define name="__WINESRC__" /> - <define name="_WIN32_IE">0x600</define> - <define name="_WIN32_WINNT">0x501</define> - <define name="WINVER">0x501</define> - <file>std_ole_v2.idl</file> -</module> -<module name="stdole2.tlb" type="win32dll" extension=".tlb" installbase="system32" installname="stdole2.tlb" entrypoint="0"> - <importlibrary definition="stdole2.tlb.spec.def" /> - <include base="stdole2.tlb">.</include> - <include base="stdole2.tlb" root="intermediate">.</include> - <include base="ReactOS">include/reactos/wine</include> - <dependency>std_ole_v2</dependency> - <define name="__WINESRC__" /> - <define name="_WIN32_IE">0x600</define> - <define name="_WIN32_WINNT">0x501</define> - <define name="WINVER">0x501</define> - <library>kernel32</library> - <file>stdole2.tlb.spec</file> - <file>rsrc.rc</file> -</module> +<group> +<module name="std_ole_v2" type="embeddedtypelib"> + <include base="std_ole_v2">.</include> + <include base="ReactOS">include/reactos/wine</include> + <define name="__WINESRC__" /> + <define name="_WIN32_IE">0x600</define> + <define name="_WIN32_WINNT">0x501</define> + <define name="WINVER">0x501</define> + <file>std_ole_v2.idl</file> +</module> +<module name="stdole2.tlb" type="win32dll" extension=".tlb" installbase="system32" installname="stdole2.tlb" entrypoint="0"> + <importlibrary definition="stdole2.tlb.spec.def" /> + <include base="stdole2.tlb">.</include> + <include base="stdole2.tlb" root="intermediate">.</include> + <include base="ReactOS">include/reactos/wine</include> + <dependency>std_ole_v2</dependency> + <define name="__WINESRC__" /> + <define name="_WIN32_IE">0x600</define> + <define name="_WIN32_WINNT">0x501</define> + <define name="WINVER">0x501</define> + <library>kernel32</library> + <file>stdole2.tlb.spec</file> + <file>rsrc.rc</file> +</module> </group> Propchange: trunk/reactos/dll/win32/stdole2.tlb/stdole2.rbuild ------------------------------------------------------------------------------ svn:eol-style = native

1 0

[cgutman] 36528: - Fix a typo - Fixes coverity error 388
by cgutman＠svn.reactos.org 26 Sep '08

26 Sep '08

Author: cgutman Date: Thu Sep 25 22:43:07 2008 New Revision: 36528 URL: http://svn.reactos.org/svn/reactos?rev=36528&view=rev Log: - Fix a typo - Fixes coverity error 388 Modified: branches/aicom-network-fixes/drivers/network/ndis/ndis/miniport.c Modified: branches/aicom-network-fixes/drivers/network/ndis/ndis/miniport.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/net… ============================================================================== --- branches/aicom-network-fixes/drivers/network/ndis/ndis/miniport.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/drivers/network/ndis/ndis/miniport.c [iso-8859-1] Thu Sep 25 22:43:07 2008 @@ -1496,7 +1496,7 @@ if (Stack->Parameters.StartDevice.AllocatedResourcesTranslated != NULL) { - ResourceCount = Stack->Parameters.StartDevice.AllocatedResources->List[0]. + ResourceCount = Stack->Parameters.StartDevice.AllocatedResourcesTranslated->List[0]. PartialResourceList.Count; ResourceListSize = FIELD_OFFSET(CM_RESOURCE_LIST, List[0].PartialResourceList.

1 0

[cgutman] 36527: - Return early if there aren't any packets to be sent - Fixes coverity error 458
by cgutman＠svn.reactos.org 26 Sep '08

26 Sep '08

Author: cgutman Date: Thu Sep 25 22:35:56 2008 New Revision: 36527 URL: http://svn.reactos.org/svn/reactos?rev=36527&view=rev Log: - Return early if there aren't any packets to be sent - Fixes coverity error 458 Modified: branches/aicom-network-fixes/drivers/network/dd/ne2000/ne2000/8390.c Modified: branches/aicom-network-fixes/drivers/network/dd/ne2000/ne2000/8390.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/net… ============================================================================== --- branches/aicom-network-fixes/drivers/network/dd/ne2000/ne2000/8390.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/drivers/network/dd/ne2000/ne2000/8390.c [iso-8859-1] Thu Sep 25 22:35:56 2008 @@ -544,6 +544,8 @@ UCHAR Tmp; NDIS_DbgPrint(MAX_TRACE, ("Called.\n")); + + if (Adapter->TXCurrent < 0) return; //FrameStart = Adapter->TXStart + Adapter->TXCurrent * DRIVER_BLOCK_SIZE; //FrameStart = Adapter->TXStart;

1 0

[cgutman] 36526: - Return early if NBAddNeighbor or RouterAddRoute fails - Fixes coverity error 389
by cgutman＠svn.reactos.org 26 Sep '08

26 Sep '08

Author: cgutman Date: Thu Sep 25 22:23:56 2008 New Revision: 36526 URL: http://svn.reactos.org/svn/reactos?rev=36526&view=rev Log: - Return early if NBAddNeighbor or RouterAddRoute fails - Fixes coverity error 389 Modified: branches/aicom-network-fixes/lib/drivers/ip/network/ip.c Modified: branches/aicom-network-fixes/lib/drivers/ip/network/ip.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/lib/drivers… ============================================================================== --- branches/aicom-network-fixes/lib/drivers/ip/network/ip.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/lib/drivers/ip/network/ip.c [iso-8859-1] Thu Sep 25 22:23:56 2008 @@ -242,12 +242,14 @@ NUD_PERMANENT); if (!NCE) { TI_DbgPrint(MIN_TRACE, ("Could not create NCE.\n")); + return; } AddrWidenAddress( &NetworkAddress, &IF->Unicast, &IF->Netmask ); if (!RouterAddRoute(&NetworkAddress, &IF->Netmask, NCE, 1)) { TI_DbgPrint(MIN_TRACE, ("Could not add route due to insufficient resources.\n")); + return; } /* Allow TCP to hang some configuration on this interface */

1 0

[cgutman] 36525: - Return early if ProtocolNumber is too large - Fixes coverity error 600
by cgutman＠svn.reactos.org 26 Sep '08

26 Sep '08

Author: cgutman Date: Thu Sep 25 22:12:18 2008 New Revision: 36525 URL: http://svn.reactos.org/svn/reactos?rev=36525&view=rev Log: - Return early if ProtocolNumber is too large - Fixes coverity error 600 Modified: branches/aicom-network-fixes/lib/drivers/ip/network/ip.c Modified: branches/aicom-network-fixes/lib/drivers/ip/network/ip.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/lib/drivers… ============================================================================== --- branches/aicom-network-fixes/lib/drivers/ip/network/ip.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/lib/drivers/ip/network/ip.c [iso-8859-1] Thu Sep 25 22:12:18 2008 @@ -352,10 +352,10 @@ * To unregister a protocol handler, call this function with Handler = NULL */ { -#ifdef DBG - if (ProtocolNumber >= IP_PROTOCOL_TABLE_SIZE) + if (ProtocolNumber >= IP_PROTOCOL_TABLE_SIZE) { TI_DbgPrint(MIN_TRACE, ("Protocol number is out of range (%d).\n", ProtocolNumber)); -#endif + return; + } ProtocolTable[ProtocolNumber] = Handler; }

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
75
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs September 2008