Author: sginsberg
Date: Thu Sep 25 13:49:27 2008
New Revision: 36518
URL: http://svn.reactos.org/svn/reactos?rev=36518&view=rev
Log:
- CmpOpenHiveFiles: If "Extension" is false then we won't have allocated any buffer, so there will never be a buffer to free
- Fix for Coverity Error CID: 29
Modified:
trunk/reactos/ntoskrnl/config/cminit.c
Modified: trunk/reactos/ntoskrnl/config/cminit.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cminit.c?r…
==============================================================================
--- trunk/reactos/ntoskrnl/config/cminit.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/config/cminit.c [iso-8859-1] Thu Sep 25 13:49:27 2008
@@ -464,8 +464,7 @@
/* Check if we don't need to create a log file */
if (!Extension)
{
- /* We're done, close handles and free buffers */
- if (NameBuffer) ExFreePool(NameBuffer);
+ /* We're done, close handles */
ObDereferenceObject(Event);
ZwClose(EventHandle);
return STATUS_SUCCESS;
Author: sginsberg
Date: Thu Sep 25 13:17:08 2008
New Revision: 36516
URL: http://svn.reactos.org/svn/reactos?rev=36516&view=rev
Log:
- Delete todo.c. It was a personal scratchpad which wasn't supposed to be committed
Removed:
branches/nwin32/subsystems/win32/win32k/todo.c
Removed: branches/nwin32/subsystems/win32/win32k/todo.c
URL: http://svn.reactos.org/svn/reactos/branches/nwin32/subsystems/win32/win32k/…
==============================================================================
--- branches/nwin32/subsystems/win32/win32k/todo.c [iso-8859-1] (original)
+++ branches/nwin32/subsystems/win32/win32k/todo.c (removed)
@@ -1,28 +1,0 @@
-Initialization -- Needs a total review for NT compatibility
- -DriverEntry
- - We are loaded once per session by smss.
- - What functions does smss use to load us? When is DriverEntry actually called?
- - What should we do here?
- -NtGdiInit
- - When are we called and what should we do?
- -NtUserInitialize
- - Find out parameters and what we should do here.
-
-System calls:
- -NtGdi:
- - New layout mostly finished. Some cleanup left to do.
- - Missing parameters for NtGdiGetSpoolMessage
- - Missing APIENTRY for some functions!
-
- -NtUser: Functions need to be researched for parameters.
- We miss quite a few and most of the functions which are compatible in name/parameter numbers probably have ros-specific parameters/behaviour.
- In short, a lot of research and review is needed.
-
-gdi32 and user32
- - Need to be fixed to compile (not to use ros-specific system calls).
- - gdi32 is the easiest. Much is done but #if 0-ed due to remaining problems.
- - user32 needs a big overview (*cough*, rewrite, *cough*) and fixup.
-
-
-Interaction with display drivers
- - Videoprt needs cleanup (rewriteeeeeeeee) and review. I have begun some major cleanup, but not done yet (mostly code style and unfscking).