ReactOS.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2024
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
List overview
Download
Ros-diffs
August 2009
----- 2024 -----
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
ros-diffs@reactos.org
21 participants
654 discussions
Start a n
N
ew thread
[gschneider] 42826: Remove glyph guard (bug #933): there is no way to such an exclusion properly without working GetCharPlacement, every font engine handles glyphed output slightly different. Fixes Abiword text regression
by gschneider@svn.reactos.org
Author: gschneider Date: Fri Aug 21 16:35:48 2009 New Revision: 42826 URL:
http://svn.reactos.org/svn/reactos?rev=42826&view=rev
Log: Remove glyph guard (bug #933): there is no way to such an exclusion properly without working GetCharPlacement, every font engine handles glyphed output slightly different. Fixes Abiword text regression Modified: trunk/reactos/subsystems/win32/win32k/objects/freetype.c Modified: trunk/reactos/subsystems/win32/win32k/objects/freetype.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob…
============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/freetype.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/objects/freetype.c [iso-8859-1] Fri Aug 21 16:35:48 2009 @@ -3732,12 +3732,6 @@ } } - /* FIXME: remove this as soon as GetCharacterPlacementA/W work properly */ - if ((fuOptions & ETO_GLYPH_INDEX) && (fuOptions != (ETO_GLYPH_INDEX | ETO_PDY))) - { - fuOptions &= ~ETO_GLYPH_INDEX; - } - /* Finally call the internal routine */ Result = GreExtTextOutW(hDC, XStart,
15 years, 1 month
1
0
0
0
[janderwald] 42825: - Remove test code
by janderwald@svn.reactos.org
Author: janderwald Date: Fri Aug 21 15:15:38 2009 New Revision: 42825 URL:
http://svn.reactos.org/svn/reactos?rev=42825&view=rev
Log: - Remove test code Modified: trunk/reactos/drivers/wdm/audio/sysaudio/deviface.c Modified: trunk/reactos/drivers/wdm/audio/sysaudio/deviface.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/sysaudio…
============================================================================== --- trunk/reactos/drivers/wdm/audio/sysaudio/deviface.c [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/sysaudio/deviface.c [iso-8859-1] Fri Aug 21 15:15:38 2009 @@ -203,8 +203,6 @@ PIO_WORKITEM WorkItem = NULL; PSYSAUDIODEVEXT DeviceExtension; PKSAUDIO_DEVICE_ENTRY DeviceEntry = NULL; - PDEVICE_OBJECT AudioDeviceObject; - UNICODE_STRING ReferenceString, SymbolicLinkName; /* a new device has arrived */ DeviceEntry = ExAllocatePool(NonPagedPool, sizeof(KSAUDIO_DEVICE_ENTRY)); @@ -259,24 +257,6 @@ Ctx->DeviceEntry = DeviceEntry; Ctx->WorkItem = WorkItem; - - /* HACK - * sysaudio should register the device object for itself - */ - AudioDeviceObject = IoGetRelatedDeviceObject(DeviceEntry->FileObject); - RtlInitUnicodeString(&ReferenceString, L"sad0"); - Status = IoRegisterDeviceInterface(AudioDeviceObject, &KSCATEGORY_AUDIO_DEVICE, &ReferenceString, &SymbolicLinkName); - if (NT_SUCCESS(Status)) - { - IoSetDeviceInterfaceState(&SymbolicLinkName, TRUE); - RtlFreeUnicodeString(&SymbolicLinkName); - } - else - { - DPRINT1("Failed to open %wZ with Status %x\n", &DeviceEntry->DeviceName, Status); - DbgBreakPoint(); - - } /* fetch device extension */ DeviceExtension = (PSYSAUDIODEVEXT)DeviceObject->DeviceExtension;
15 years, 1 month
1
0
0
0
[fireball] 42824: - Convert a wrong macro to an inlined function.
by fireball@svn.reactos.org
Author: fireball Date: Fri Aug 21 15:01:27 2009 New Revision: 42824 URL:
http://svn.reactos.org/svn/reactos?rev=42824&view=rev
Log: - Convert a wrong macro to an inlined function. Modified: trunk/reactos/drivers/usb/nt4compat/usbdriver/ohci.c Modified: trunk/reactos/drivers/usb/nt4compat/usbdriver/ohci.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/nt4compat/usbd…
============================================================================== --- trunk/reactos/drivers/usb/nt4compat/usbdriver/ohci.c [iso-8859-1] (original) +++ trunk/reactos/drivers/usb/nt4compat/usbdriver/ohci.c [iso-8859-1] Fri Aug 21 15:01:27 2009 @@ -72,24 +72,28 @@ * The erratum (#4) description is incorrect. AMD's workaround waits * till some bits (mostly reserved) are clear; ok for all revs. */ -#define read_roothub(hc, register, mask) ({ \ - ULONG temp = OHCI_READ_PORT_ULONG(&((hc)->regs->roothub.register)); \ - if (temp == -1) \ - /*disable (hc)*/; \ - /*else if (hc->flags & OHCI_QUIRK_AMD756) \ - while (temp & mask) \ - temp = ohci_readl (hc, &hc->regs->roothub.register); */ \ - temp; }) +ULONG +FORCEINLINE +read_roothub(POHCI_DEV hc, PULONG reg, ULONG mask) +{ + ULONG temp = OHCI_READ_PORT_ULONG(reg); + if (temp == -1) + /*disable (hc)*/; + /*else if (hc->flags & OHCI_QUIRK_AMD756) + while (temp & mask) + temp = ohci_readl (hc, &hc->regs->roothub.register); */ + return temp; +} static ULONG roothub_a (POHCI_DEV hc) - { return read_roothub (hc, a, 0xfc0fe000); } + { return read_roothub (hc, &hc->regs->roothub.a, 0xfc0fe000); } /* static inline u32 roothub_b (struct ohci_hcd *hc) { return ohci_readl (hc, &hc->regs->roothub.b); } static inline u32 roothub_status (struct ohci_hcd *hc) { return ohci_readl (hc, &hc->regs->roothub.status); } static u32 roothub_portstatus (struct ohci_hcd *hc, int i) - { return read_roothub (hc, portstatus [i], 0xffe0fce0); } + { return read_roothub (hc, &hc->regs->roothub.portstatus [i], 0xffe0fce0); } */
15 years, 1 month
1
0
0
0
[janderwald] 42823: - Partly implement KsCreateBusEnumObject
by janderwald@svn.reactos.org
Author: janderwald Date: Fri Aug 21 14:58:20 2009 New Revision: 42823 URL:
http://svn.reactos.org/svn/reactos?rev=42823&view=rev
Log: - Partly implement KsCreateBusEnumObject Modified: trunk/reactos/drivers/ksfilter/ks/api.c trunk/reactos/drivers/ksfilter/ks/kstypes.h Modified: trunk/reactos/drivers/ksfilter/ks/api.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/ksfilter/ks/api.c?…
============================================================================== --- trunk/reactos/drivers/ksfilter/ks/api.c [iso-8859-1] (original) +++ trunk/reactos/drivers/ksfilter/ks/api.c [iso-8859-1] Fri Aug 21 14:58:20 2009 @@ -1709,7 +1709,7 @@ } /* - @unimplemented + @implemented */ KSDDKAPI NTSTATUS @@ -1722,8 +1722,118 @@ IN REFGUID InterfaceGuid OPTIONAL, IN PWCHAR ServiceRelativePath OPTIONAL) { - UNIMPLEMENTED - return STATUS_UNSUCCESSFUL; + ULONG Length; + NTSTATUS Status = STATUS_SUCCESS; + UNICODE_STRING ServiceKeyPath = RTL_CONSTANT_STRING(L"\\REGISTRY\\MACHINE\\SYSTEM\\CurrentControlSet\\Services\\"); + PBUS_ENUM_DEVICE_EXTENSION BusDeviceExtension; + PDEVICE_EXTENSION DeviceExtension; + + /* calculate sizeof bus enum device extension */ + Length = wcslen(BusIdentifier) * sizeof(WCHAR); + Length += sizeof(BUS_ENUM_DEVICE_EXTENSION); + + BusDeviceExtension = ExAllocatePool(NonPagedPool, Length); + if (!BusDeviceExtension) + { + /* not enough memory */ + return STATUS_INSUFFICIENT_RESOURCES; + } + + /* zero device extension */ + RtlZeroMemory(BusDeviceExtension, sizeof(BUS_ENUM_DEVICE_EXTENSION)); + + /* initialize bus device extension */ + wcscpy(BusDeviceExtension->BusIdentifier, BusIdentifier); + + /* allocate service path string */ + Length = ServiceKeyPath.MaximumLength; + Length += BusDeviceObject->DriverObject->DriverExtension->ServiceKeyName.MaximumLength; + + if (ServiceRelativePath) + { + /* relative path for devices */ + Length += wcslen(ServiceRelativePath) + 2 * sizeof(WCHAR); + } + + BusDeviceExtension->ServicePath.Length = 0; + BusDeviceExtension->ServicePath.MaximumLength = Length; + BusDeviceExtension->ServicePath.Buffer = ExAllocatePool(NonPagedPool, Length); + + if (!BusDeviceExtension->ServicePath.Buffer) + { + /* not enough memory */ + ExFreePool(BusDeviceExtension); + return STATUS_INSUFFICIENT_RESOURCES; + } + + RtlAppendUnicodeStringToString(&BusDeviceExtension->ServicePath, &ServiceKeyPath); + RtlAppendUnicodeStringToString(&BusDeviceExtension->ServicePath, &BusDeviceObject->DriverObject->DriverExtension->ServiceKeyName); + + if (ServiceRelativePath) + { + RtlAppendUnicodeToString(&BusDeviceExtension->ServicePath, L"\\"); + RtlAppendUnicodeToString(&BusDeviceExtension->ServicePath, ServiceRelativePath); + } + + if (InterfaceGuid) + { + /* register an device interface */ + Status = IoRegisterDeviceInterface(PhysicalDeviceObject, InterfaceGuid, NULL, &BusDeviceExtension->SymbolicLinkName); + + /* check for success */ + if (!NT_SUCCESS(Status)) + { + ExFreePool(BusDeviceExtension->ServicePath.Buffer); + ExFreePool(BusDeviceExtension); + return Status; + } + + /* now enable device interface */ + Status = IoSetDeviceInterfaceState(&BusDeviceExtension->SymbolicLinkName, TRUE); + + if (!NT_SUCCESS(Status)) + { + ExFreePool(BusDeviceExtension->ServicePath.Buffer); + ExFreePool(BusDeviceExtension); + return Status; + } + + /* set state enabled */ + BusDeviceExtension->Enabled = TRUE; + } + + /* store device objects */ + BusDeviceExtension->BusDeviceObject = BusDeviceObject; + BusDeviceExtension->PnpDeviceObject = PnpDeviceObject; + BusDeviceExtension->PhysicalDeviceObject = PhysicalDeviceObject; + + if (!PnpDeviceObject) + { + BusDeviceExtension->PnpDeviceObject = IoAttachDeviceToDeviceStack(BusDeviceObject, PhysicalDeviceObject); + + if (!BusDeviceExtension->PnpDeviceObject) + { + /* failed to attach device */ + if (BusDeviceExtension->Enabled) + { + IoSetDeviceInterfaceState(&BusDeviceExtension->SymbolicLinkName, FALSE); + RtlFreeUnicodeString(&BusDeviceExtension->SymbolicLinkName); + } + + /* free device extension */ + ExFreePool(BusDeviceExtension->ServicePath.Buffer); + ExFreePool(BusDeviceExtension); + + return STATUS_DEVICE_REMOVED; + } + } + + /* attach device extension */ + DeviceExtension = (PDEVICE_EXTENSION)BusDeviceObject->DeviceExtension; + DeviceExtension->DeviceHeader = (PKSIDEVICE_HEADER)BusDeviceExtension; + + /* FIXME scan bus and invalidate device relations */ + return Status; } NTSTATUS Modified: trunk/reactos/drivers/ksfilter/ks/kstypes.h URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/ksfilter/ks/kstype…
============================================================================== --- trunk/reactos/drivers/ksfilter/ks/kstypes.h [iso-8859-1] (original) +++ trunk/reactos/drivers/ksfilter/ks/kstypes.h [iso-8859-1] Fri Aug 21 14:58:20 2009 @@ -145,4 +145,19 @@ typedef BOOLEAN (NTAPI *PKSEVENT_SYNCHRONIZED_ROUTINE)(PKSEVENT_CTX Context); +typedef struct +{ + BOOLEAN Enabled; + + PDEVICE_OBJECT PnpDeviceObject; + PDEVICE_OBJECT PhysicalDeviceObject; + PDEVICE_OBJECT BusDeviceObject; + + UNICODE_STRING ServicePath; + UNICODE_STRING SymbolicLinkName; + + WCHAR BusIdentifier[1]; +}BUS_ENUM_DEVICE_EXTENSION, *PBUS_ENUM_DEVICE_EXTENSION; + + #endif
15 years, 1 month
1
0
0
0
[gschneider] 42822: - co_IntLoadSysMenuTemplate: only copy buffer if prior operation succeeded, bug #4803 - co_IntLoadDefaultCursors: result is not used, no need to copy it
by gschneider@svn.reactos.org
Author: gschneider Date: Fri Aug 21 13:27:24 2009 New Revision: 42822 URL:
http://svn.reactos.org/svn/reactos?rev=42822&view=rev
Log: - co_IntLoadSysMenuTemplate: only copy buffer if prior operation succeeded, bug #4803 - co_IntLoadDefaultCursors: result is not used, no need to copy it Modified: trunk/reactos/subsystems/win32/win32k/ntuser/callback.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/callback.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt…
============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/callback.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/callback.c [iso-8859-1] Fri Aug 21 13:27:24 2009 @@ -249,7 +249,7 @@ HMENU APIENTRY co_IntLoadSysMenuTemplate() { - LRESULT Result; + LRESULT Result = 0; NTSTATUS Status; PVOID ResultPointer; ULONG ResultLength; @@ -264,23 +264,20 @@ 0, &ResultPointer, &ResultLength); - - /* Simulate old behaviour: copy into our local buffer */ - Result = *(LRESULT*)ResultPointer; + if (NT_SUCCESS(Status)) + { + /* Simulate old behaviour: copy into our local buffer */ + Result = *(LRESULT*)ResultPointer; + } UserEnterCo(); - if (!NT_SUCCESS(Status)) - { - return(0); - } return (HMENU)Result; } BOOL APIENTRY co_IntLoadDefaultCursors(VOID) { - LRESULT Result; NTSTATUS Status; PVOID ResultPointer; ULONG ResultLength; @@ -296,9 +293,6 @@ sizeof(BOOL), &ResultPointer, &ResultLength); - - /* Simulate old behaviour: copy into our local buffer */ - Result = *(LRESULT*)ResultPointer; UserEnterCo();
15 years, 1 month
1
0
0
0
[janderwald] 42821: - Don't touch the freed buffer in case of an error - Found by Amine Khaldi
by janderwald@svn.reactos.org
Author: janderwald Date: Fri Aug 21 12:30:05 2009 New Revision: 42821 URL:
http://svn.reactos.org/svn/reactos?rev=42821&view=rev
Log: - Don't touch the freed buffer in case of an error - Found by Amine Khaldi Modified: trunk/reactos/ntoskrnl/io/iomgr/deviface.c Modified: trunk/reactos/ntoskrnl/io/iomgr/deviface.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/deviface…
============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/deviface.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/deviface.c [iso-8859-1] Fri Aug 21 12:30:05 2009 @@ -920,7 +920,10 @@ DPRINT("ZwSetValueKey() failed with status 0x%08lx\n", Status); ExFreePool(SymbolicLinkName->Buffer); } - SymbolicLinkName->Buffer[1] = '?'; + else + { + SymbolicLinkName->Buffer[1] = '?'; + } ZwClose(SubKey); ZwClose(InterfaceKey);
15 years, 1 month
1
0
0
0
[janderwald] 42820: - Remove hacks for bug 4566
by janderwald@svn.reactos.org
Author: janderwald Date: Fri Aug 21 12:06:29 2009 New Revision: 42820 URL:
http://svn.reactos.org/svn/reactos?rev=42820&view=rev
Log: - Remove hacks for bug 4566 Modified: trunk/reactos/drivers/ksfilter/ks/deviceinterface.c trunk/reactos/drivers/ksfilter/ks/irp.c trunk/reactos/drivers/ksfilter/ks/priv.h trunk/reactos/drivers/wdm/audio/backpln/portcls/adapter.c trunk/reactos/drivers/wdm/audio/sysaudio/deviface.c Modified: trunk/reactos/drivers/ksfilter/ks/deviceinterface.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/ksfilter/ks/device…
============================================================================== --- trunk/reactos/drivers/ksfilter/ks/deviceinterface.c [iso-8859-1] (original) +++ trunk/reactos/drivers/ksfilter/ks/deviceinterface.c [iso-8859-1] Fri Aug 21 12:06:29 2009 @@ -74,7 +74,7 @@ /* now register device interface */ Status = IoRegisterDeviceInterface(PhysicalDeviceObject, &Categories[Index], - ReferenceString, /* see damn bug 4566 */ + ReferenceString, &SymEntry->SymbolicLink); if (!NT_SUCCESS(Status)) Modified: trunk/reactos/drivers/ksfilter/ks/irp.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/ksfilter/ks/irp.c?…
============================================================================== --- trunk/reactos/drivers/ksfilter/ks/irp.c [iso-8859-1] (original) +++ trunk/reactos/drivers/ksfilter/ks/irp.c [iso-8859-1] Fri Aug 21 12:06:29 2009 @@ -635,7 +635,7 @@ } /* - @unimplemented + @implemented */ KSDDKAPI NTSTATUS @@ -1781,9 +1781,10 @@ /* get device header */ DeviceHeader = DeviceExtension->DeviceHeader; - /* hack for bug 4566 */ + if (IoStack->FileObject->FileName.Buffer == NULL) { + /* FIXME Pnp-Issue */ DPRINT("Using reference string hack\n"); Irp->IoStatus.Information = 0; /* set return status */ @@ -1834,116 +1835,6 @@ } NTSTATUS -RosDeviceInterfaceReferenceStringHack( - IN PDEVICE_OBJECT DeviceObject, - IN PIRP Irp) -{ - PIO_STACK_LOCATION IoStack; - PKSIDEVICE_HEADER DeviceHeader; - PDEVICE_EXTENSION DeviceExtension; - PCREATE_ITEM_ENTRY CreateItemEntry; - PLIST_ENTRY Entry; - LPWSTR Buffer; - ULONG Length; - - /* get current stack location */ - IoStack = IoGetCurrentIrpStackLocation(Irp); - - /* get device extension */ - DeviceExtension = (PDEVICE_EXTENSION)IoStack->DeviceObject->DeviceExtension; - /* get device header */ - DeviceHeader = DeviceExtension->DeviceHeader; - - /* retrieve all available reference strings registered */ - Length = 0; - Entry = DeviceHeader->ItemList.Flink; - while(Entry != &DeviceHeader->ItemList) - { - CreateItemEntry = (PCREATE_ITEM_ENTRY)CONTAINING_RECORD(Entry, CREATE_ITEM_ENTRY, Entry); - - ASSERT(CreateItemEntry->CreateItem); - if (CreateItemEntry->CreateItem->Create && CreateItemEntry->CreateItem->ObjectClass.Buffer) - Length += wcslen(CreateItemEntry->CreateItem->ObjectClass.Buffer) + 1; - - Entry = Entry->Flink; - } - - /* add extra zero */ - Length += 1; - - /* allocate the buffer */ - Buffer = ExAllocatePool(NonPagedPool, Length * sizeof(WCHAR)); - if (!Buffer) - { - Irp->IoStatus.Information = 0; - Irp->IoStatus.Status = STATUS_INSUFFICIENT_RESOURCES; - IoCompleteRequest(Irp, IO_NO_INCREMENT); - return STATUS_INSUFFICIENT_RESOURCES; - } - - - *((LPWSTR*)Irp->UserBuffer) = Buffer; - Irp->IoStatus.Status = STATUS_SUCCESS; - Irp->IoStatus.Information = sizeof(LPWSTR); - - Entry = DeviceHeader->ItemList.Flink; - while(Entry != &DeviceHeader->ItemList) - { - CreateItemEntry = (PCREATE_ITEM_ENTRY)CONTAINING_RECORD(Entry, CREATE_ITEM_ENTRY, Entry); - - ASSERT(CreateItemEntry->CreateItem); - if (CreateItemEntry->CreateItem->Create && CreateItemEntry->CreateItem->ObjectClass.Buffer) - { - wcscpy(Buffer, CreateItemEntry->CreateItem->ObjectClass.Buffer); - Buffer += wcslen(Buffer) + 1; - } - Entry = Entry->Flink; - } - - - - *Buffer = L'\0'; - IoCompleteRequest(Irp, IO_NO_INCREMENT); - return STATUS_SUCCESS; - -} - -NTSTATUS -NTAPI -KspDeviceControl( - IN PDEVICE_OBJECT DeviceObject, - IN PIRP Irp) -{ - PIO_STACK_LOCATION IoStack; - PKSIOBJECT_HEADER ObjectHeader; - PKSIDEVICE_HEADER DeviceHeader; - PDEVICE_EXTENSION DeviceExtension; - - - - /* get current stack location */ - IoStack = IoGetCurrentIrpStackLocation(Irp); - - /* get device extension */ - DeviceExtension = (PDEVICE_EXTENSION)IoStack->DeviceObject->DeviceExtension; - /* get device header */ - DeviceHeader = DeviceExtension->DeviceHeader; - - if (IoStack->MajorFunction == IRP_MJ_DEVICE_CONTROL && IoStack->Parameters.DeviceIoControl.IoControlCode == IOCTL_KS_OBJECT_CLASS) - { - /* hack for bug 4566 */ - return RosDeviceInterfaceReferenceStringHack(DeviceObject, Irp); - } - - ObjectHeader = (PKSIOBJECT_HEADER) IoStack->FileObject->FsContext; - - ASSERT(ObjectHeader); - //KSCREATE_ITEM_IRP_STORAGE(Irp) = ObjectHeader->CreateItem; - - return ObjectHeader->DispatchTable.DeviceIoControl(DeviceObject, Irp); -} - -NTSTATUS NTAPI KspDispatchIrp( IN PDEVICE_OBJECT DeviceObject, @@ -1969,7 +1860,7 @@ if (!ObjectHeader) { - /* hack for bug 4566 */ + /* FIXME Pnp-Issue*/ Irp->IoStatus.Status = STATUS_SUCCESS; Irp->IoStatus.Information = 0; /* complete and forget */ @@ -2045,8 +1936,6 @@ break; break; case IRP_MJ_DEVICE_CONTROL: - DriverObject->MajorFunction[MajorFunction] = KspDeviceControl; - break; case IRP_MJ_CLOSE: case IRP_MJ_READ: case IRP_MJ_WRITE: @@ -2102,12 +1991,6 @@ } } - if (IoStack->MajorFunction == IRP_MJ_DEVICE_CONTROL) - { - /* handle device requests */ - return KspDeviceControl(DeviceObject, Irp); - } - switch (IoStack->MajorFunction) { case IRP_MJ_CLOSE: @@ -2117,6 +2000,7 @@ case IRP_MJ_QUERY_SECURITY: case IRP_MJ_SET_SECURITY: case IRP_MJ_PNP: + case IRP_MJ_DEVICE_CONTROL: return KspDispatchIrp(DeviceObject, Irp); default: return KsDispatchInvalidDeviceRequest(DeviceObject, Irp); Modified: trunk/reactos/drivers/ksfilter/ks/priv.h URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/ksfilter/ks/priv.h…
============================================================================== --- trunk/reactos/drivers/ksfilter/ks/priv.h [iso-8859-1] (original) +++ trunk/reactos/drivers/ksfilter/ks/priv.h [iso-8859-1] Fri Aug 21 12:06:29 2009 @@ -20,9 +20,6 @@ #define TAG_DEVICE_HEADER TAG('H','D','S','K') -#define IOCTL_KS_OBJECT_CLASS CTL_CODE(FILE_DEVICE_KS, 0x7, METHOD_NEITHER, FILE_ANY_ACCESS) - - #define DEFINE_KSPROPERTY_PINPROPOSEDATAFORMAT(PinSet,\ PropGeneral, PropInstances, PropIntersection)\ DEFINE_KSPROPERTY_TABLE(PinSet) {\ Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/adapter.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/…
============================================================================== --- trunk/reactos/drivers/wdm/audio/backpln/portcls/adapter.c [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/backpln/portcls/adapter.c [iso-8859-1] Fri Aug 21 12:06:29 2009 @@ -312,8 +312,9 @@ */ Status = IoRegisterDeviceInterface(DeviceExt->PhysicalDeviceObject, &SubDeviceDescriptor->Interfaces[Index], - NULL, //&RefName, + &RefName, &SymbolicLinkName); + if (NT_SUCCESS(Status)) { /* activate device interface */ Modified: trunk/reactos/drivers/wdm/audio/sysaudio/deviface.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/sysaudio…
============================================================================== --- trunk/reactos/drivers/wdm/audio/sysaudio/deviface.c [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/sysaudio/deviface.c [iso-8859-1] Fri Aug 21 12:06:29 2009 @@ -13,8 +13,6 @@ const GUID KS_CATEGORY_AUDIO = {0x6994AD04L, 0x93EF, 0x11D0, {0xA3, 0xCC, 0x00, 0xA0, 0xC9, 0x22, 0x31, 0x96}}; const GUID KS_CATEGORY_TOPOLOGY = {0xDDA54A40, 0x1E4C, 0x11D1, {0xA0, 0x50, 0x40, 0x57, 0x05, 0xC1, 0x00, 0x00}}; const GUID DMOCATEGORY_ACOUSTIC_ECHO_CANCEL = {0xBF963D80L, 0xC559, 0x11D0, {0x8A, 0x2B, 0x00, 0xA0, 0xC9, 0x25, 0x5A, 0xC1}}; - -#define IOCTL_KS_OBJECT_CLASS CTL_CODE(FILE_DEVICE_KS, 0x7, METHOD_NEITHER, FILE_ANY_ACCESS) NTSTATUS BuildPinDescriptor( @@ -198,14 +196,15 @@ NTSTATUS InsertAudioDevice( IN PDEVICE_OBJECT DeviceObject, - IN PUNICODE_STRING DeviceName, - IN LPWSTR ReferenceString) + IN PUNICODE_STRING DeviceName) { NTSTATUS Status = STATUS_SUCCESS; PFILTER_WORKER_CONTEXT Ctx = NULL; PIO_WORKITEM WorkItem = NULL; PSYSAUDIODEVEXT DeviceExtension; PKSAUDIO_DEVICE_ENTRY DeviceEntry = NULL; + PDEVICE_OBJECT AudioDeviceObject; + UNICODE_STRING ReferenceString, SymbolicLinkName; /* a new device has arrived */ DeviceEntry = ExAllocatePool(NonPagedPool, sizeof(KSAUDIO_DEVICE_ENTRY)); @@ -240,12 +239,6 @@ DeviceEntry->DeviceName.Length = 0; DeviceEntry->DeviceName.MaximumLength = DeviceName->MaximumLength + 10 * sizeof(WCHAR); - /* hack for bug 4566 */ - if (ReferenceString) - { - DeviceEntry->DeviceName.MaximumLength += (wcslen(ReferenceString) + 2) * sizeof(WCHAR); - } - DeviceEntry->DeviceName.Buffer = ExAllocatePool(NonPagedPool, DeviceEntry->DeviceName.MaximumLength); if (!DeviceEntry->DeviceName.Buffer) @@ -256,12 +249,6 @@ RtlAppendUnicodeToString(&DeviceEntry->DeviceName, L"\\??\\"); RtlAppendUnicodeStringToString(&DeviceEntry->DeviceName, DeviceName); - - if (ReferenceString) - { - RtlAppendUnicodeToString(&DeviceEntry->DeviceName, L"\\"); - RtlAppendUnicodeToString(&DeviceEntry->DeviceName, ReferenceString); - } Status = OpenDevice(&DeviceEntry->DeviceName, &DeviceEntry->Handle, &DeviceEntry->FileObject); @@ -272,6 +259,24 @@ Ctx->DeviceEntry = DeviceEntry; Ctx->WorkItem = WorkItem; + + /* HACK + * sysaudio should register the device object for itself + */ + AudioDeviceObject = IoGetRelatedDeviceObject(DeviceEntry->FileObject); + RtlInitUnicodeString(&ReferenceString, L"sad0"); + Status = IoRegisterDeviceInterface(AudioDeviceObject, &KSCATEGORY_AUDIO_DEVICE, &ReferenceString, &SymbolicLinkName); + if (NT_SUCCESS(Status)) + { + IoSetDeviceInterfaceState(&SymbolicLinkName, TRUE); + RtlFreeUnicodeString(&SymbolicLinkName); + } + else + { + DPRINT1("Failed to open %wZ with Status %x\n", &DeviceEntry->DeviceName, Status); + DbgBreakPoint(); + + } /* fetch device extension */ DeviceExtension = (PSYSAUDIODEVEXT)DeviceObject->DeviceExtension; @@ -312,13 +317,6 @@ DEVICE_INTERFACE_CHANGE_NOTIFICATION * Event; NTSTATUS Status = STATUS_SUCCESS; PSYSAUDIODEVEXT DeviceExtension; - UNICODE_STRING DeviceName; - HANDLE Handle; - PFILE_OBJECT FileObject; - LPWSTR ReferenceString; - ULONG BytesReturned; - - PDEVICE_OBJECT DeviceObject = (PDEVICE_OBJECT)Context; DeviceExtension = (PSYSAUDIODEVEXT)DeviceObject->DeviceExtension; @@ -328,54 +326,7 @@ if (IsEqualGUIDAligned(&Event->Event, &GUID_DEVICE_INTERFACE_ARRIVAL)) { - /*<HACK> - * 1) Open the filter w/o reference string - * 2) Retrieve reference strings with our private IOCTL_KS_OBJECT_CLASS - * 3) Append these reference strings to symbolic link we got - * * see bug 4566 - */ - - DeviceName.Length = 0; - DeviceName.MaximumLength = Event->SymbolicLinkName->Length + 10 * sizeof(WCHAR); - - DeviceName.Buffer = ExAllocatePool(NonPagedPool, DeviceName.MaximumLength); - - if (!DeviceName.Buffer) - { - return STATUS_INSUFFICIENT_RESOURCES; - } - - RtlAppendUnicodeToString(&DeviceName, L"\\??\\"); - RtlAppendUnicodeStringToString(&DeviceName, Event->SymbolicLinkName); - - - Status = OpenDevice(&DeviceName, &Handle, &FileObject); - if (!NT_SUCCESS(Status)) - { - ExFreePool(DeviceName.Buffer); - return Status; - } - - Status = KsSynchronousIoControlDevice(FileObject, KernelMode, IOCTL_KS_OBJECT_CLASS, NULL, 0, &ReferenceString, sizeof(LPWSTR), &BytesReturned); - if (!NT_SUCCESS(Status)) - { - DPRINT1("failed Status %x\n", Status); - - ExFreePool(DeviceName.Buffer); - ObDereferenceObject(FileObject); - ZwClose(Handle); - return Status; - } - - while(*ReferenceString) - { - Status = InsertAudioDevice(DeviceObject, Event->SymbolicLinkName, ReferenceString); - ReferenceString += wcslen(ReferenceString) + 1; - } - //ExFreePool(ReferenceString); - ObDereferenceObject(FileObject); - ZwClose(Handle); - ExFreePool(DeviceName.Buffer); + Status = InsertAudioDevice(DeviceObject, Event->SymbolicLinkName); return Status; } else
15 years, 1 month
1
0
0
0
[janderwald] 42819: - Reference strings are not part of the symbolic link. Therefore don't include them when creating the symbolic link (IoCreateSymbolicLink) - Reference strings are used by the kernel streaming system to distinguish kernel streaming filters. As it is perfectly possible, to provide more than one filter with same guid but different reference string, ignore the failure for now if IoCreateSymbolicLink fails See issue #4566 for more details.
by janderwald@svn.reactos.org
Author: janderwald Date: Fri Aug 21 12:02:25 2009 New Revision: 42819 URL:
http://svn.reactos.org/svn/reactos?rev=42819&view=rev
Log: - Reference strings are not part of the symbolic link. Therefore don't include them when creating the symbolic link (IoCreateSymbolicLink) - Reference strings are used by the kernel streaming system to distinguish kernel streaming filters. As it is perfectly possible, to provide more than one filter with same guid but different reference string, ignore the failure for now if IoCreateSymbolicLink fails See issue #4566 for more details. Modified: trunk/reactos/ntoskrnl/io/iomgr/deviface.c Modified: trunk/reactos/ntoskrnl/io/iomgr/deviface.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/deviface…
============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/deviface.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/deviface.c [iso-8859-1] Fri Aug 21 12:02:25 2009 @@ -881,17 +881,12 @@ } RtlAppendUnicodeToString(SymbolicLinkName, L"#"); RtlAppendUnicodeStringToString(SymbolicLinkName, &GuidString); - if (ReferenceString && ReferenceString->Length) - { - RtlAppendUnicodeToString(SymbolicLinkName, L"\\"); - RtlAppendUnicodeStringToString(SymbolicLinkName, ReferenceString); - } SymbolicLinkName->Buffer[SymbolicLinkName->Length/sizeof(WCHAR)] = L'\0'; /* Create symbolic link */ DPRINT1("IoRegisterDeviceInterface(): creating symbolic link %wZ -> %wZ\n", SymbolicLinkName, &PdoNameInfo->Name); Status = IoCreateSymbolicLink(SymbolicLinkName, &PdoNameInfo->Name); - if (!NT_SUCCESS(Status)) + if (!NT_SUCCESS(Status) && ReferenceString == NULL) { DPRINT("IoCreateSymbolicLink() failed with status 0x%08lx\n", Status); ZwClose(SubKey); @@ -904,6 +899,13 @@ return Status; } + if (ReferenceString && ReferenceString->Length) + { + RtlAppendUnicodeToString(SymbolicLinkName, L"\\"); + RtlAppendUnicodeStringToString(SymbolicLinkName, ReferenceString); + } + SymbolicLinkName->Buffer[SymbolicLinkName->Length/sizeof(WCHAR)] = L'\0'; + /* Write symbolic link name in registry */ SymbolicLinkName->Buffer[1] = '\\'; Status = ZwSetValueKey( @@ -958,10 +960,12 @@ PDEVICE_OBJECT PhysicalDeviceObject; PFILE_OBJECT FileObject; UNICODE_STRING GuidString; + UNICODE_STRING SymLink; PWCHAR StartPosition; PWCHAR EndPosition; NTSTATUS Status; LPCGUID EventGuid; + if (SymbolicLinkName == NULL) return STATUS_INVALID_PARAMETER_1; @@ -980,9 +984,13 @@ GuidString.Buffer = StartPosition; GuidString.MaximumLength = GuidString.Length = (USHORT)((ULONG_PTR)(EndPosition + 1) - (ULONG_PTR)StartPosition); + SymLink.Buffer = SymbolicLinkName->Buffer; + SymLink.MaximumLength = SymLink.Length = (USHORT)((ULONG_PTR)(EndPosition + 1) - (ULONG_PTR)SymLink.Buffer); + + /* Get pointer to the PDO */ Status = IoGetDeviceObjectPointer( - SymbolicLinkName, + &SymLink, 0, /* DesiredAccess */ &FileObject, &PhysicalDeviceObject);
15 years, 1 month
1
0
0
0
[mkupfer] 42818: Alexander Yastrebov <menone7 AT gmail DOT com> - Russian translation and update of utorrent added. - see issue #4762 for details. - stupid BOM for compatibility added.
by mkupfer@svn.reactos.org
Author: mkupfer Date: Fri Aug 21 11:00:54 2009 New Revision: 42818 URL:
http://svn.reactos.org/svn/reactos?rev=42818&view=rev
Log: Alexander Yastrebov <menone7 AT gmail DOT com> - Russian translation and update of utorrent added. - see issue #4762 for details. - stupid BOM for compatibility added. Modified: trunk/reactos/base/applications/rapps/rapps/opera.txt trunk/reactos/base/applications/rapps/rapps/seamonkey.txt trunk/reactos/base/applications/rapps/rapps/thunderbird.txt trunk/reactos/base/applications/rapps/rapps/utorrent.txt Modified: trunk/reactos/base/applications/rapps/rapps/opera.txt URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/ra…
============================================================================== --- trunk/reactos/base/applications/rapps/rapps/opera.txt [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/rapps/opera.txt [iso-8859-1] Fri Aug 21 11:00:54 2009 @@ -1,4 +1,4 @@ -; UTF-8 +; UTF-8 [Section] Name = Opera @@ -14,6 +14,5 @@ [Section.0419] Description = ÐопÑлÑÑнÑй бÑаÑÐ·ÐµÑ Ñо многими дополниÑелÑнÑми возможноÑÑÑми, вклÑÑаÑÑий поÑÑовÑй и BitTorrent клиенÑ. - [Section.0407] Description = Der populäre Opera Browser mit vielen fortschrittlichen Eigenschaften, enthält einen Mail und BitTorrent Client. Modified: trunk/reactos/base/applications/rapps/rapps/seamonkey.txt URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/ra…
============================================================================== --- trunk/reactos/base/applications/rapps/rapps/seamonkey.txt [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/rapps/seamonkey.txt [iso-8859-1] Fri Aug 21 11:00:54 2009 @@ -1,4 +1,4 @@ -; UTF-8 +; UTF-8 [Section] Name = Mozilla SeaMonkey @@ -21,4 +21,4 @@ Description = Mozilla Suite ist lebendig. Dies ist das einzige Browser-, Mail-, Chat- and Composerwerkzeug-Bundle welches Sie benötigen. Size = 8.9M URLSite =
http://www.mozilla-europe.org/de/
-URLDownload =
http://ftp.df.lth.se/mozilla/seamonkey/releases/1.1.16/contrib-localized/se…
+URLDownload =
http://ftp.df.lth.se/mozilla/seamonkey/releases/1.1.16/contrib-localized/se…
Modified: trunk/reactos/base/applications/rapps/rapps/thunderbird.txt URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/ra…
============================================================================== --- trunk/reactos/base/applications/rapps/rapps/thunderbird.txt [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/rapps/thunderbird.txt [iso-8859-1] Fri Aug 21 11:00:54 2009 @@ -1,4 +1,4 @@ -; UTF-8 +; UTF-8 [Section] Name = Mozilla Thunderbird 2.0 @@ -21,4 +21,4 @@ Description = Der populärste und einer der besten freien Mail-Clients. Size = 6.2M URLSite =
http://www.mozilla-europe.org/de/products/thunderbird/
-URLDownload =
http://releases.mozilla.org/pub/mozilla.org/thunderbird/releases/2.0.0.19/w…
+URLDownload =
http://releases.mozilla.org/pub/mozilla.org/thunderbird/releases/2.0.0.19/w…
Modified: trunk/reactos/base/applications/rapps/rapps/utorrent.txt URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/ra…
============================================================================== --- trunk/reactos/base/applications/rapps/rapps/utorrent.txt [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/rapps/utorrent.txt [iso-8859-1] Fri Aug 21 11:00:54 2009 @@ -1,18 +1,20 @@ -; UTF-8 +; UTF-8 [Section] -Name = uTorrent -Version = 1.8 -Licence = Unknown +Name = µTorrent +Version = 1.8.3 +Licence = Freeware for non-commercial uses Description = Small and fast BitTorrent Client. -Size = Unknown +Size = 281K Category = 5 -URLSite = Unknown -URLDownload =
http://download.utorrent.com/1.8.2/utorrent-1.8.2.upx.exe
+URLSite =
http://www.utorrent.com/
+URLDownload =
http://download.utorrent.com/1.8.3/utorrent.exe
CDPath = none +[Section.0419] +Licence = ÐеÑплаÑÐ½Ð°Ñ Ð´Ð»Ñ Ð½Ðµ комеÑÑеÑкого иÑполÑÐ·Ð¾Ð²Ð°Ð½Ð¸Ñ +Description = ÐаленÑкий и бÑÑÑÑÑй BitTorrent клиенÑ. + [Section.0407] -Licence = Unbekannt +Licence = Freeware für nichtkommerzielle Nutzung Description = Kleiner und schneller BitTorrent Client. -Size = Unbekannt -URLSite = Unbekannt
15 years, 1 month
1
0
0
0
[sginsberg] 42817: - Include windef.h so CDECL gets declared for msvc's version of DEFINE_GUIDEX in ks.h
by sginsberg@svn.reactos.org
Author: sginsberg Date: Thu Aug 20 22:02:19 2009 New Revision: 42817 URL:
http://svn.reactos.org/svn/reactos?rev=42817&view=rev
Log: - Include windef.h so CDECL gets declared for msvc's version of DEFINE_GUIDEX in ks.h Modified: trunk/reactos/drivers/ksfilter/swenum/precomp.h Modified: trunk/reactos/drivers/ksfilter/swenum/precomp.h URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/ksfilter/swenum/pr…
============================================================================== --- trunk/reactos/drivers/ksfilter/swenum/precomp.h [iso-8859-1] (original) +++ trunk/reactos/drivers/ksfilter/swenum/precomp.h [iso-8859-1] Thu Aug 20 22:02:19 2009 @@ -2,6 +2,7 @@ #define PRECOMP_H__ #include <ntddk.h> +#include <windef.h> #include <ks.h> #include <swenum.h> #include <debug.h>
15 years, 1 month
1
0
0
0
← Newer
1
...
13
14
15
16
17
18
19
...
66
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
Results per page:
10
25
50
100
200