Ros-diffs September 2009

ros-diffs@reactos.org

16 participants
270 discussions

[arty] 43066: Patch by maxime vernier (bugzilla bug 4661). Fix the ghost bug and the graphical glitch with process id 0
by arty＠svn.reactos.org 17 Sep '09

17 Sep '09

Author: arty Date: Thu Sep 17 18:07:37 2009 New Revision: 43066 URL: http://svn.reactos.org/svn/reactos?rev=43066&view=rev Log: Patch by maxime vernier (bugzilla bug 4661). Fix the ghost bug and the graphical glitch with process id 0 Modified: trunk/reactos/base/applications/taskmgr/procpage.c Modified: trunk/reactos/base/applications/taskmgr/procpage.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/taskmgr/… ============================================================================== --- trunk/reactos/base/applications/taskmgr/procpage.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/taskmgr/procpage.c [iso-8859-1] Thu Sep 17 18:07:37 2009 @@ -29,6 +29,7 @@ typedef struct { ULONG Index; + ULONG ProcessId; } PROCESS_PAGE_LIST_ITEM, *LPPROCESS_PAGE_LIST_ITEM; HWND hProcessPage; /* Process List Property Page */ @@ -51,6 +52,7 @@ void ProcessPageShowContextMenu(DWORD dwProcessId); BOOL PerfDataGetText(ULONG Index, ULONG ColumnIndex, LPTSTR lpText, int nMaxCount); DWORD WINAPI ProcessPageRefreshThread(void *lpParameter); +int ProcessRunning(ULONG ProcessId); DWORD GetSelectedProcessId(void) { @@ -411,12 +413,9 @@ void UpdateProcesses() { int i; - BOOL found = FALSE; ULONG l; - ULONG pid; LV_ITEM item; LPPROCESS_PAGE_LIST_ITEM pData; - PPERFDATA pPerfData; /* Remove old processes */ for (i = 0; i < ListView_GetItemCount(hProcessPageListCtrl); i++) @@ -426,19 +425,9 @@ item.iItem = i; (void)ListView_GetItem(hProcessPageListCtrl, &item); pData = (LPPROCESS_PAGE_LIST_ITEM)item.lParam; - (void)PerfDataGet(pData->Index, &pPerfData); - pid = PerfDataGetProcessId(pData->Index); - for (l = 0; l < PerfDataGetProcessCount(); l++) + if (!ProcessRunning(pData->ProcessId)) { - if (PerfDataGetProcessId(l) == pid) - { - found = TRUE; - break; - } - } - if (!found) - { - (void)ListView_DeleteItem(hApplicationPageListCtrl, i); + (void)ListView_DeleteItem(hProcessPageListCtrl, i); HeapFree(GetProcessHeap(), 0, pData); } } @@ -450,6 +439,29 @@ { (void)ListView_SortItems(hProcessPageListCtrl, ProcessPageCompareFunc, NULL); } +} + +BOOL ProcessRunning(ULONG ProcessId) +{ + HANDLE hProcess; + DWORD exitCode; + + if (ProcessId == 0) { + return TRUE; + } + + hProcess = OpenProcess(PROCESS_ALL_ACCESS, FALSE, ProcessId); + if (hProcess == NULL) { + return FALSE; + } + + if (GetExitCodeProcess(hProcess, &exitCode)) { + CloseHandle(hProcess); + return (exitCode == STILL_ACTIVE); + } + + CloseHandle(hProcess); + return FALSE; } void AddProcess(ULONG Index) @@ -480,7 +492,8 @@ { pData = (LPPROCESS_PAGE_LIST_ITEM)HeapAlloc(GetProcessHeap(), 0, sizeof(PROCESS_PAGE_LIST_ITEM)); pData->Index = Index; - + pData->ProcessId = pid; + /* Add the item to the list */ memset(&item, 0, sizeof(LV_ITEM)); item.mask = LVIF_TEXT|LVIF_PARAM;

1 0

[sginsberg] 43065: - Use __MINGW_NOTHROW instead of __attribute__
by sginsberg＠svn.reactos.org 17 Sep '09

17 Sep '09

Author: sginsberg Date: Thu Sep 17 17:47:35 2009 New Revision: 43065 URL: http://svn.reactos.org/svn/reactos?rev=43065&view=rev Log: - Use __MINGW_NOTHROW instead of __attribute__ Modified: trunk/reactos/include/crt/float.h trunk/reactos/include/crt/setjmp.h Modified: trunk/reactos/include/crt/float.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/float.h?rev=43… ============================================================================== --- trunk/reactos/include/crt/float.h [iso-8859-1] (original) +++ trunk/reactos/include/crt/float.h [iso-8859-1] Thu Sep 17 17:47:35 2009 @@ -104,12 +104,12 @@ /* Set the FPU control word as cw = (cw & ~unMask) | (unNew & unMask), * i.e. change the bits in unMask to have the values they have in unNew, * leaving other bits unchanged. */ -_CRTIMP unsigned int __cdecl __attribute__ ((__nothrow__)) _controlfp (unsigned int unNew, unsigned int unMask); -_CRTIMP unsigned int __cdecl __attribute__ ((__nothrow__)) _control87 (unsigned int unNew, unsigned int unMask); +_CRTIMP unsigned int __cdecl __MINGW_NOTHROW _controlfp (unsigned int unNew, unsigned int unMask); +_CRTIMP unsigned int __cdecl __MINGW_NOTHROW _control87 (unsigned int unNew, unsigned int unMask); -_CRTIMP unsigned int __cdecl __attribute__ ((__nothrow__)) _clearfp (void); /* Clear the FPU status word */ -_CRTIMP unsigned int __cdecl __attribute__ ((__nothrow__)) _statusfp (void); /* Report the FPU status word */ +_CRTIMP unsigned int __cdecl __MINGW_NOTHROW _clearfp (void); /* Clear the FPU status word */ +_CRTIMP unsigned int __cdecl __MINGW_NOTHROW _statusfp (void); /* Report the FPU status word */ #define _clear87 _clearfp #define _status87 _statusfp @@ -123,11 +123,11 @@ per fninit. To use the MSVCRT.dll _fpreset, include CRT_fp8.o when building your application. */ -void __cdecl __attribute__ ((__nothrow__)) _fpreset (void); -void __cdecl __attribute__ ((__nothrow__)) fpreset (void); +void __cdecl __MINGW_NOTHROW _fpreset (void); +void __cdecl __MINGW_NOTHROW fpreset (void); /* Global 'variable' for the current floating point error code. */ -_CRTIMP int * __cdecl __attribute__ ((__nothrow__)) __fpecode(void); +_CRTIMP int * __cdecl __MINGW_NOTHROW __fpecode(void); #define _fpecode (*(__fpecode())) /* @@ -135,15 +135,15 @@ * but they really belong in math.h. */ -_CRTIMP double __cdecl __attribute__ ((__nothrow__)) _chgsign (double); -_CRTIMP double __cdecl __attribute__ ((__nothrow__)) _copysign (double, double); -_CRTIMP double __cdecl __attribute__ ((__nothrow__)) _logb (double); -_CRTIMP double __cdecl __attribute__ ((__nothrow__)) _nextafter (double, double); -_CRTIMP double __cdecl __attribute__ ((__nothrow__)) _scalb (double, long); +_CRTIMP double __cdecl __MINGW_NOTHROW _chgsign (double); +_CRTIMP double __cdecl __MINGW_NOTHROW _copysign (double, double); +_CRTIMP double __cdecl __MINGW_NOTHROW _logb (double); +_CRTIMP double __cdecl __MINGW_NOTHROW _nextafter (double, double); +_CRTIMP double __cdecl __MINGW_NOTHROW _scalb (double, long); -_CRTIMP int __cdecl __attribute__ ((__nothrow__)) _finite (double); -_CRTIMP int __cdecl __attribute__ ((__nothrow__)) _fpclass (double); -_CRTIMP int __cdecl __attribute__ ((__nothrow__)) _isnan (double); +_CRTIMP int __cdecl __MINGW_NOTHROW _finite (double); +_CRTIMP int __cdecl __MINGW_NOTHROW _fpclass (double); +_CRTIMP int __cdecl __MINGW_NOTHROW _isnan (double); #ifdef __cplusplus } Modified: trunk/reactos/include/crt/setjmp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/setjmp.h?rev=4… ============================================================================== --- trunk/reactos/include/crt/setjmp.h [iso-8859-1] (original) +++ trunk/reactos/include/crt/setjmp.h [iso-8859-1] Thu Sep 17 17:47:35 2009 @@ -130,27 +130,27 @@ #define _JMP_BUF_DEFINED #endif - void * __cdecl __attribute__ ((__nothrow__)) mingw_getsp(void); + void * __cdecl __MINGW_NOTHROW mingw_getsp(void); #ifdef USE_MINGW_SETJMP_TWO_ARGS #ifndef _INC_SETJMPEX #define setjmp(BUF) _setjmp((BUF),mingw_getsp()) - int __cdecl __attribute__ ((__nothrow__)) _setjmp(jmp_buf _Buf,void *_Ctx); + int __cdecl __MINGW_NOTHROW _setjmp(jmp_buf _Buf,void *_Ctx); #else #undef setjmp #define setjmp(BUF) _setjmpex((BUF),mingw_getsp()) #define setjmpex(BUF) _setjmpex((BUF),mingw_getsp()) - int __cdecl __attribute__ ((__nothrow__)) _setjmpex(jmp_buf _Buf,void *_Ctx); + int __cdecl __MINGW_NOTHROW _setjmpex(jmp_buf _Buf,void *_Ctx); #endif #else #ifndef _INC_SETJMPEX #define setjmp _setjmp #endif - int __cdecl __attribute__ ((__nothrow__)) setjmp(jmp_buf _Buf); + int __cdecl __MINGW_NOTHROW setjmp(jmp_buf _Buf); #endif - __declspec(noreturn) __attribute__ ((__nothrow__)) void __cdecl ms_longjmp(jmp_buf _Buf,int _Value)/* throw(...)*/; - __declspec(noreturn) __attribute__ ((__nothrow__)) void __cdecl longjmp(jmp_buf _Buf,int _Value); + __declspec(noreturn) __MINGW_NOTHROW void __cdecl ms_longjmp(jmp_buf _Buf,int _Value)/* throw(...)*/; + __declspec(noreturn) __MINGW_NOTHROW void __cdecl longjmp(jmp_buf _Buf,int _Value); #ifdef __cplusplus }

1 0

[sginsberg] 43064: - Fix uninitialized variable usage in DefWindowProcA/W - Don't inline EnableScrollBar as a forwarder for NtUserEnableScrollBar when it is implemented differently. Also define EXTINLINE compatibly for MSVC.
by sginsberg＠svn.reactos.org 17 Sep '09

17 Sep '09

Author: sginsberg Date: Thu Sep 17 17:46:24 2009 New Revision: 43064 URL: http://svn.reactos.org/svn/reactos?rev=43064&view=rev Log: - Fix uninitialized variable usage in DefWindowProcA/W - Don't inline EnableScrollBar as a forwarder for NtUserEnableScrollBar when it is implemented differently. Also define EXTINLINE compatibly for MSVC. Modified: trunk/reactos/dll/win32/user32/include/ntwrapper.h trunk/reactos/dll/win32/user32/windows/defwnd.c Modified: trunk/reactos/dll/win32/user32/include/ntwrapper.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/include/n… ============================================================================== --- trunk/reactos/dll/win32/user32/include/ntwrapper.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/user32/include/ntwrapper.h [iso-8859-1] Thu Sep 17 17:46:24 2009 @@ -1,10 +1,10 @@ +#if defined(__GNUC__) #define EXTINLINE extern inline __attribute__((always_inline)) - -EXTINLINE BOOL WINAPI -EnableScrollBar(HWND hWnd, UINT wSBflags, UINT wArrows) -{ - return NtUserEnableScrollBar(hWnd, wSBflags, wArrows); -} +#elif defined(_MSC_VER) +#define EXTINLINE extern __forceinline +#else +#error +#endif EXTINLINE BOOL WINAPI GetScrollBarInfo(HWND hWnd, LONG idObject, PSCROLLBARINFO psbi) Modified: trunk/reactos/dll/win32/user32/windows/defwnd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d… ============================================================================== --- trunk/reactos/dll/win32/user32/windows/defwnd.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/user32/windows/defwnd.c [iso-8859-1] Thu Sep 17 17:46:24 2009 @@ -2181,7 +2181,7 @@ WPARAM wParam, LPARAM lParam) { - BOOL Hook, msgOverride; + BOOL Hook, msgOverride = FALSE; LRESULT Result = 0; LOADUSERAPIHOOK @@ -2214,7 +2214,7 @@ WPARAM wParam, LPARAM lParam) { - BOOL Hook, msgOverride; + BOOL Hook, msgOverride = FALSE; LRESULT Result = 0; LOADUSERAPIHOOK

1 0

[janderwald] 43063: - Fix 2 user32 winstation test failures (patch by Giannis Adamopoulos johnyadams (_AT_)hotmail (D-O-T) com - Test results verified by Amine Khaldi
by janderwald＠svn.reactos.org 17 Sep '09

17 Sep '09

Author: janderwald Date: Thu Sep 17 17:25:36 2009 New Revision: 43063 URL: http://svn.reactos.org/svn/reactos?rev=43063&view=rev Log: - Fix 2 user32 winstation test failures (patch by Giannis Adamopoulos johnyadams (_AT_)hotmail (D-O-T) com - Test results verified by Amine Khaldi Modified: trunk/reactos/dll/win32/user32/misc/winsta.c Modified: trunk/reactos/dll/win32/user32/misc/winsta.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/wins… ============================================================================== --- trunk/reactos/dll/win32/user32/misc/winsta.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/user32/misc/winsta.c [iso-8859-1] Thu Sep 17 17:25:36 2009 @@ -88,8 +88,7 @@ */ if (NULL == WindowStation && Desktops) { - SetLastError(ERROR_INVALID_HANDLE); - return FALSE; + WindowStation = GetProcessWindowStation(); } /*

1 0

[janderwald] 43062: - Fix 2 user32 winstation test failures (patch by Giannis Adamopoulos johnyadams (_AT_)hotmail (D-O-T) com - Revert hack from 43061 and fix it properly - Test results verified by Amine Khaldi
by janderwald＠svn.reactos.org 17 Sep '09

17 Sep '09

Author: janderwald Date: Thu Sep 17 17:20:24 2009 New Revision: 43062 URL: http://svn.reactos.org/svn/reactos?rev=43062&view=rev Log: - Fix 2 user32 winstation test failures (patch by Giannis Adamopoulos johnyadams (_AT_)hotmail (D-O-T) com - Revert hack from 43061 and fix it properly - Test results verified by Amine Khaldi Modified: trunk/reactos/subsystems/win32/win32k/ntuser/clipboard.c trunk/reactos/subsystems/win32/win32k/ntuser/winsta.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/clipboard.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/clipboard.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/clipboard.c [iso-8859-1] Thu Sep 17 17:20:24 2009 @@ -1152,7 +1152,7 @@ WinSta = UserGetProcessWindowStation(); - Status = IntValidateWindowStationHandle(WinSta, UserMode, 0 /*WINSTA_ACCESSCLIPBOARD*/, &WinStaObj); + Status = IntValidateWindowStationHandle(WinSta, KernelMode, WINSTA_ACCESSCLIPBOARD, &WinStaObj); if (!NT_SUCCESS(Status)) { Modified: trunk/reactos/subsystems/win32/win32k/ntuser/winsta.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/winsta.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/winsta.c [iso-8859-1] Thu Sep 17 17:20:24 2009 @@ -630,14 +630,14 @@ InitializeObjectAttributes( &ObjectAttributes, &WindowStationName, - 0, + OBJ_CASE_INSENSITIVE, NULL, NULL); Status = ObOpenObjectByName( &ObjectAttributes, ExWindowStationObjectType, - UserMode, + KernelMode, NULL, dwDesiredAccess, NULL, @@ -686,6 +686,11 @@ NTSTATUS Status; DPRINT("About to close window station handle (0x%X)\n", hWinSta); + + if (hWinSta == UserGetProcessWindowStation()) + { + return FALSE; + } Status = IntValidateWindowStationHandle( hWinSta,

1 0

[janderwald] 43061: - Fix copying of files / directories in explorer view - Part 2/2
by janderwald＠svn.reactos.org 17 Sep '09

17 Sep '09

Author: janderwald Date: Thu Sep 17 15:45:08 2009 New Revision: 43061 URL: http://svn.reactos.org/svn/reactos?rev=43061&view=rev Log: - Fix copying of files / directories in explorer view - Part 2/2 Modified: trunk/reactos/subsystems/win32/win32k/ntuser/clipboard.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/clipboard.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/clipboard.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/clipboard.c [iso-8859-1] Thu Sep 17 15:45:08 2009 @@ -1152,7 +1152,7 @@ WinSta = UserGetProcessWindowStation(); - Status = IntValidateWindowStationHandle(WinSta, UserMode, WINSTA_ACCESSCLIPBOARD, &WinStaObj); + Status = IntValidateWindowStationHandle(WinSta, UserMode, 0 /*WINSTA_ACCESSCLIPBOARD*/, &WinStaObj); if (!NT_SUCCESS(Status)) {

1 0

[janderwald] 43060: - Fix copying of files / directories in explorer view - Part 1/2
by janderwald＠svn.reactos.org 17 Sep '09

17 Sep '09

Author: janderwald Date: Thu Sep 17 15:44:34 2009 New Revision: 43060 URL: http://svn.reactos.org/svn/reactos?rev=43060&view=rev Log: - Fix copying of files / directories in explorer view - Part 1/2 Modified: trunk/reactos/dll/win32/shell32/shv_def_cmenu.c Modified: trunk/reactos/dll/win32/shell32/shv_def_cmenu.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shv_def_… ============================================================================== --- trunk/reactos/dll/win32/shell32/shv_def_cmenu.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/shv_def_cmenu.c [iso-8859-1] Thu Sep 17 15:44:34 2009 @@ -1072,9 +1072,22 @@ } else { - /* target folder is desktop because cidl is zero */ - psfTarget = psfDesktop; - hr = S_OK; + IPersistFolder2 *ppf2 = NULL; + LPITEMIDLIST pidl; + + /* cidl is zero due to explorer view */ + hr = IShellFolder_QueryInterface (This->dcm.psf, &IID_IPersistFolder2, (LPVOID *) &ppf2); + if (SUCCEEDED(hr)) + { + hr = IPersistFolder2_GetCurFolder (ppf2, &pidl); + IPersistFolder2_Release(ppf2); + if (SUCCEEDED(hr)) + { + hr = IShellFolder_BindToObject(psfDesktop, pidl, NULL, &IID_IShellFolder, (LPVOID*)&psfTarget); + ILFree(pidl); + TRACE("psfTarget %p\n", psfTarget); + } + } } if (FAILED(hr)) @@ -1133,6 +1146,7 @@ _ILFreeaPidl(apidl, lpcida->cidl); ReleaseStgMedium(&medium); IDataObject_Release(pda); +ERR("CP result %x\n",hr); return S_OK; }

1 0

[dreimer] 43059: Gettin close to RosBE 1.5B1. Fixed installer to be in sync to colin's renaming. Updated changelog and readme updated the variables for the new GCC
by dreimer＠svn.reactos.org 16 Sep '09

16 Sep '09

Author: dreimer Date: Wed Sep 16 19:04:29 2009 New Revision: 43059 URL: http://svn.reactos.org/svn/reactos?rev=43059&view=rev Log: Gettin close to RosBE 1.5B1. Fixed installer to be in sync to colin's renaming. Updated changelog and readme updated the variables for the new GCC Modified: trunk/tools/RosBE/RosBE-Windows/Powershell/rosbe-gcc-env.ps1 trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt trunk/tools/RosBE/RosBE-Windows/Root/README.odt trunk/tools/RosBE/RosBE-Windows/Root/rosbe-gcc-env.cmd trunk/tools/RosBE/RosBE-Windows/RosBE.nsi Modified: trunk/tools/RosBE/RosBE-Windows/Powershell/rosbe-gcc-env.ps1 URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Powershe… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Powershell/rosbe-gcc-env.ps1 [iso-8859-1] (original) +++ trunk/tools/RosBE/RosBE-Windows/Powershell/rosbe-gcc-env.ps1 [iso-8859-1] Wed Sep 16 19:04:29 2009 @@ -31,7 +31,7 @@ $global:_ROSBE_HOST_GCCTARGET = (select-string -path .\gcchvers.tmp "Target: ") -replace ".*Target: (.+?)\b.*",'$1' remove-item gcchvers.tmp -$ENV:ROSBE_HOST_CFLAGS = "-I""$_ROSBE_HOST_MINGWPATH\include"" -I""$_ROSBE_HOST_MINGWPATH\lib\gcc\$_ROSBE_HOST_GCCTARGET\$_ROSBE_HOST_GCCVERSION\include""" -$ENV:ROSBE_HOST_CXXFLAGS = "-I""$_ROSBE_HOST_MINGWPATH\include"" -I""$_ROSBE_HOST_MINGWPATH\include\c++\$_ROSBE_HOST_GCCVERSION"" -I""$_ROSBE_HOST_MINGWPATH\include\c++\$_ROSBE_HOST_GCCVERSION\$_ROSBE_HOST_GCCTARGET"" -I""$_ROSBE_HOST_MINGWPATH\lib\gcc\$_ROSBE_HOST_GCCTARGET\$_ROSBE_HOST_GCCVERSION\include""" -$ENV:ROSBE_TARGET_CFLAGS = "-I""$_ROSBE_TARGET_MINGWPATH\include"" -I""$_ROSBE_TARGET_MINGWPATH\lib\gcc\$_ROSBE_TARGET_GCCTARGET\$_ROSBE_TARGET_GCCVERSION\include""" -$ENV:ROSBE_TARGET_CXXFLAGS = "-I""$_ROSBE_TARGET_MINGWPATH\include"" -I""$_ROSBE_TARGET_MINGWPATH\include\c++\$_ROSBE_TARGET_GCCVERSION"" -I""$_ROSBE_TARGET_MINGWPATH\include\c++\$_ROSBE_TARGET_GCCVERSION\$_ROSBE_TARGET_GCCTARGET"" -I""$_ROSBE_TARGET_MINGWPATH\lib\gcc\$_ROSBE_TARGET_GCCTARGET\$_ROSBE_TARGET_GCCVERSION\include""" +$ENV:ROSBE_HOST_CFLAGS = "-I""$_ROSBE_HOST_MINGWPATH\$_ROSBE_HOST_GCCTARGET\include"" -I""$_ROSBE_HOST_MINGWPATH\lib\gcc\$_ROSBE_HOST_GCCTARGET\$_ROSBE_HOST_GCCVERSION\include""" +$ENV:ROSBE_HOST_CXXFLAGS = "-I""$_ROSBE_HOST_MINGWPATH\$_ROSBE_HOST_GCCTARGET\include"" -I""$_ROSBE_HOST_MINGWPATH\lib\gcc\$_ROSBE_HOST_GCCTARGET\$_ROSBE_HOST_GCCVERSION\include\c++"" -I""$_ROSBE_HOST_MINGWPATH\lib\gcc\$_ROSBE_HOST_GCCTARGET\$_ROSBE_HOST_GCCVERSION\include""" +$ENV:ROSBE_TARGET_CFLAGS = "-I""$_ROSBE_TARGET_MINGWPATH\$_ROSBE_TARGET_GCCTARGET\include"" -I""$_ROSBE_TARGET_MINGWPATH\include"" -I""$_ROSBE_TARGET_MINGWPATH\lib\gcc\$_ROSBE_TARGET_GCCTARGET\$_ROSBE_TARGET_GCCVERSION\include""" +$ENV:ROSBE_TARGET_CXXFLAGS = "-I""$_ROSBE_TARGET_MINGWPATH\$_ROSBE_TARGET_GCCTARGET\include"" -I""$_ROSBE_TARGET_MINGWPATH\include"" -I""$_ROSBE_TARGET_MINGWPATH\include\c++\$_ROSBE_TARGET_GCCVERSION"" -I""$_ROSBE_TARGET_MINGWPATH\include\c++\$_ROSBE_TARGET_GCCVERSION\$_ROSBE_TARGET_GCCTARGET"" -I""$_ROSBE_TARGET_MINGWPATH\lib\gcc\$_ROSBE_TARGET_GCCTARGET\$_ROSBE_TARGET_GCCVERSION\include"" -I""$_ROSBE_TARGET_MINGWPATH\lib\gcc\$_ROSBE_TARGET_GCCTARGET\$_ROSBE_TARGET_GCCVERSION\include\c++""" Modified: trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/Cha… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt [iso-8859-1] (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt [iso-8859-1] Wed Sep 16 19:04:29 2009 @@ -1,4 +1,12 @@ *** Sep XXth, 2009 - RosBE 1.5 Released + +- Updated SVN to 1.6.5 (Daniel Reimer) +- Updated NASM to 2.07 (Daniel Reimer) +- Updated GCC to 4.4.2 20090915 (Dmitry Gorbachev) +- Updated BinUtils to 2.20.51 20090915 (Dmitry Gorbachev) + (with delay import feature (Timo Kreuzer)) +- Updated w32api to 3.13 (Dmitry Gorbachev) +- Updated mingwrt to 3.16 (Dmitry Gorbachev) - Installer Fixes: * Installer starts the Uninstaller of the old Version again. @@ -33,6 +41,8 @@ (Colin Finck, Gunnar) - Fix raddr2line.cmd to properly handle spaces in the path. (Colin Finck) - Added rosapps and rostests support to ssvn. (Daniel Reimer) +- clean supports now multiple clean commands like "clean aaa bbb" (Daniel Reimer, mota) +- Got rid of the TranslateOptions Hack (Daniel Reimer, Art Yerkes) *** Jun 29th, 2009 - RosBE 1.4.4 Released Modified: trunk/tools/RosBE/RosBE-Windows/Root/README.odt URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/REA… ============================================================================== Binary files - no diff available. Modified: trunk/tools/RosBE/RosBE-Windows/Root/rosbe-gcc-env.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/ros… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/rosbe-gcc-env.cmd [iso-8859-1] (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/rosbe-gcc-env.cmd [iso-8859-1] Wed Sep 16 19:04:29 2009 @@ -34,7 +34,7 @@ for /f "usebackq tokens=3" %%i in (`"gcc -v 2>&1 | find "gcc version""`) do set _ROSBE_HOST_GCCVERSION=%%i for /f "usebackq tokens=2" %%i in (`"gcc -v 2>&1 | find "Target""`) do set _ROSBE_HOST_GCCTARGET=%%i -set ROSBE_HOST_CFLAGS=-I"%_ROSBE_HOST_MINGWPATH%\include" -I"%_ROSBE_HOST_MINGWPATH%\lib\gcc\%_ROSBE_HOST_GCCTARGET%\%_ROSBE_HOST_GCCVERSION%\include" -set ROSBE_HOST_CXXFLAGS=-I"%_ROSBE_HOST_MINGWPATH%\include" -I"%_ROSBE_HOST_MINGWPATH%\include\c++\%_ROSBE_HOST_GCCVERSION%" -I"%_ROSBE_HOST_MINGWPATH%\include\c++\%_ROSBE_HOST_GCCVERSION%\%_ROSBE_HOST_GCCTARGET%" -I"%_ROSBE_HOST_MINGWPATH%\lib\gcc\%_ROSBE_HOST_GCCTARGET%\%_ROSBE_HOST_GCCVERSION%\include" -set ROSBE_TARGET_CFLAGS=-I"%_ROSBE_TARGET_MINGWPATH%\include" -I"%_ROSBE_TARGET_MINGWPATH%\lib\gcc\%_ROSBE_TARGET_GCCTARGET%\%_ROSBE_TARGET_GCCVERSION%\include" -set ROSBE_TARGET_CXXFLAGS=-I"%_ROSBE_TARGET_MINGWPATH%\include" -I"%_ROSBE_TARGET_MINGWPATH%\include\c++\%_ROSBE_TARGET_GCCVERSION%" -I"%_ROSBE_TARGET_MINGWPATH%\include\c++\%_ROSBE_TARGET_GCCVERSION%\%_ROSBE_TARGET_GCCTARGET%" -I"%_ROSBE_TARGET_MINGWPATH%\lib\gcc\%_ROSBE_TARGET_GCCTARGET%\%_ROSBE_TARGET_GCCVERSION%\include" +set ROSBE_HOST_CFLAGS=-I"%_ROSBE_HOST_MINGWPATH%\%_ROSBE_HOST_GCCTARGET%\include" -I"%_ROSBE_HOST_MINGWPATH%\lib\gcc\%_ROSBE_HOST_GCCTARGET%\%_ROSBE_HOST_GCCVERSION%\include" +set ROSBE_HOST_CXXFLAGS=-I"%_ROSBE_HOST_MINGWPATH%\%_ROSBE_HOST_GCCTARGET%\include" -I"%_ROSBE_HOST_MINGWPATH%\lib\gcc\%_ROSBE_HOST_GCCTARGET%\%_ROSBE_HOST_GCCVERSION%\include\c++" -I"%_ROSBE_HOST_MINGWPATH%\lib\gcc\%_ROSBE_HOST_GCCTARGET%\%_ROSBE_HOST_GCCVERSION%\include" +set ROSBE_TARGET_CFLAGS = -I"%_ROSBE_TARGET_MINGWPATH%\%_ROSBE_TARGET_GCCTARGET%\include" -I"%_ROSBE_TARGET_MINGWPATH%\include" -I"%_ROSBE_TARGET_MINGWPATH%\lib\gcc\%_ROSBE_TARGET_GCCTARGET%\%_ROSBE_TARGET_GCCVERSION%\include" +set ROSBE_TARGET_CXXFLAGS = -I"%_ROSBE_TARGET_MINGWPATH%\%_ROSBE_TARGET_GCCTARGET%\include" -I"%_ROSBE_TARGET_MINGWPATH%\include" -I"%_ROSBE_TARGET_MINGWPATH%\include\c++\%_ROSBE_TARGET_GCCVERSION%" -I"%_ROSBE_TARGET_MINGWPATH%\include\c++\%_ROSBE_TARGET_GCCVERSION%\%_ROSBE_TARGET_GCCTARGET%" -I"%_ROSBE_TARGET_MINGWPATH%\lib\gcc\%_ROSBE_TARGET_GCCTARGET%\%_ROSBE_TARGET_GCCVERSION%\include" -I"%_ROSBE_TARGET_MINGWPATH%\lib\gcc\%_ROSBE_TARGET_GCCTARGET%\%_ROSBE_TARGET_GCCVERSION%\include\c++" Modified: trunk/tools/RosBE/RosBE-Windows/RosBE.nsi URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/RosBE.ns… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/RosBE.nsi [iso-8859-1] (original) +++ trunk/tools/RosBE/RosBE-Windows/RosBE.nsi [iso-8859-1] Wed Sep 16 19:04:29 2009 @@ -129,15 +129,16 @@ File /r Components\Powershell\version.ps1 WriteRegStr HKLM "Software\Microsoft\PowerShell\1\ShellIds\Microsoft.PowerShell" "ExecutionPolicy" "RemoteSigned" ${else} - File /r Root\Build.cmd - File /r Root\Build-Multi.cmd + File /r Root\Basedir.cmd File /r Root\Build-Shared.cmd File /r Root\charch.cmd File /r Root\chdefgcc.cmd File /r Root\Clean.cmd File /r Root\Help.cmd + File /r Root\Make.cmd + File /r Root\Makex.cmd + File /r Root\Renv.cmd File /r Root\RosBE.cmd - File /r Root\RosBE.mac File /r Root\rosbe-gcc-env.cmd File /r Root\TimeDate.cmd File /r Root\version.cmd @@ -251,7 +252,7 @@ ${If} $R4 = '6.1' File /r Components\Powershell\reladdr2line.ps1 ${else} - File /r Root\reladdr2line.cmd + File /r Root\raddr2line.cmd ${Endif} SetOutPath "$INSTDIR\Tools" SetOverwrite try @@ -296,14 +297,15 @@ ${If} $R4 = '6.1' SetOutPath "$INSTDIR" SetOverwrite try - File /r Root\Build.cmd - File /r Root\Build-Multi.cmd + File /r Root\Basedir.cmd File /r Root\Build-Shared.cmd File /r Root\chdefgcc.cmd File /r Root\Clean.cmd File /r Root\Help.cmd + File /r Root\Make.cmd + File /r Root\Makex.cmd + File /r Root\Renv.cmd File /r Root\RosBE.cmd - File /r Root\RosBE.mac File /r Root\rosbe-gcc-env.cmd File /r Root\TimeDate.cmd File /r Root\version.cmd @@ -311,7 +313,7 @@ File /r Root\chdefdir.cmd File /r Root\Config.cmd File /r Root\options.cmd - File /r Root\reladdr2line.cmd + File /r Root\raddr2line.cmd File /r Root\scut.cmd File /r Root\sSVN.cmd File /r Root\update.cmd @@ -449,10 +451,9 @@ StrCmp $ICONS_GROUP "" NO_SHORTCUTS RMDir /r /REBOOTOK "$SMPROGRAMS\$ICONS_GROUP" NO_SHORTCUTS: - Delete /REBOOTOK "$INSTDIR\Build.cmd" - Delete /REBOOTOK "$INSTDIR\Build-Multi.cmd" + Delete /REBOOTOK "$INSTDIR\Basedir.cmd" + Delete /REBOOTOK "$INSTDIR\Build.ps1" Delete /REBOOTOK "$INSTDIR\Build-Shared.cmd" - Delete /REBOOTOK "$INSTDIR\Build.ps1" Delete /REBOOTOK "$INSTDIR\chdefdir.cmd" Delete /REBOOTOK "$INSTDIR\chdefdir.ps1" Delete /REBOOTOK "$INSTDIR\charch.cmd" @@ -465,10 +466,13 @@ Delete /REBOOTOK "$INSTDIR\Config.ps1" Delete /REBOOTOK "$INSTDIR\Help.cmd" Delete /REBOOTOK "$INSTDIR\Help.ps1" + Delete /REBOOTOK "$INSTDIR\Make.cmd" + Delete /REBOOTOK "$INSTDIR\Makex.cmd" Delete /REBOOTOK "$INSTDIR\options.cmd" Delete /REBOOTOK "$INSTDIR\options.ps1" - Delete /REBOOTOK "$INSTDIR\reladdr2line.cmd" + Delete /REBOOTOK "$INSTDIR\raddr2line.cmd" Delete /REBOOTOK "$INSTDIR\reladdr2line.ps1" + Delete /REBOOTOK "$INSTDIR\Renv.cmd" Delete /REBOOTOK "$INSTDIR\RosBE.cmd" Delete /REBOOTOK "$INSTDIR\RosBE.ps1" Delete /REBOOTOK "$INSTDIR\rosbe-gcc-env.cmd" @@ -483,7 +487,6 @@ Delete /REBOOTOK "$INSTDIR\README.pdf" Delete /REBOOTOK "$INSTDIR\rosbe.ico" Delete /REBOOTOK "$INSTDIR\uninstall.ico" - Delete /REBOOTOK "$INSTDIR\RosBE.mac" Delete /REBOOTOK "$INSTDIR\ChangeLog.txt" Delete /REBOOTOK "$INSTDIR\LICENSE.txt" Delete /REBOOTOK "$INSTDIR\srclist.txt"

1 0

[cgutman] 43058: - Call SetLastError/GetLastError to do our work for WSASetLastError/WSAGetLastError - This will help find regressions before moving to ws2_32_new (ws2_32_new uses this method)
by cgutman＠svn.reactos.org 15 Sep '09

15 Sep '09

Author: cgutman Date: Wed Sep 16 00:21:27 2009 New Revision: 43058 URL: http://svn.reactos.org/svn/reactos?rev=43058&view=rev Log: - Call SetLastError/GetLastError to do our work for WSASetLastError/WSAGetLastError - This will help find regressions before moving to ws2_32_new (ws2_32_new uses this method) Modified: trunk/reactos/dll/win32/ws2_32/misc/dllmain.c Modified: trunk/reactos/dll/win32/ws2_32/misc/dllmain.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ws2_32/misc/dllm… ============================================================================== --- trunk/reactos/dll/win32/ws2_32/misc/dllmain.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/ws2_32/misc/dllmain.c [iso-8859-1] Wed Sep 16 00:21:27 2009 @@ -39,17 +39,7 @@ EXPORT WSAGetLastError(VOID) { - PWINSOCK_THREAD_BLOCK p = NtCurrentTeb()->WinSockData; - - if (p) - { - return p->LastErrorValue; - } - else - { - /* FIXME: What error code should we use here? Can this even happen? */ - return ERROR_BAD_ENVIRONMENT; - } + return GetLastError(); } @@ -60,10 +50,7 @@ EXPORT WSASetLastError(IN INT iError) { - PWINSOCK_THREAD_BLOCK p = NtCurrentTeb()->WinSockData; - - if (p) - p->LastErrorValue = iError; + SetLastError(iError); }

1 0

[janderwald] 43057: - Set ProgramFiles, CommonProgramFiles environment variable See issue #4008 for more details.
by janderwald＠svn.reactos.org 15 Sep '09

15 Sep '09

Author: janderwald Date: Wed Sep 16 00:14:12 2009 New Revision: 43057 URL: http://svn.reactos.org/svn/reactos?rev=43057&view=rev Log: - Set ProgramFiles, CommonProgramFiles environment variable See issue #4008 for more details. Modified: trunk/reactos/dll/win32/userenv/setup.c Modified: trunk/reactos/dll/win32/userenv/setup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/setup.c?… ============================================================================== --- trunk/reactos/dll/win32/userenv/setup.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/userenv/setup.c [iso-8859-1] Wed Sep 16 00:14:12 2009 @@ -674,6 +674,10 @@ } } + SetEnvironmentVariableW(L"ProgramFiles", szProfilesPath); + SetEnvironmentVariableW(L"CommonProgramFiles", szCommonFilesDirPath); + + DPRINT("Success\n"); return TRUE;

1 0

← Newer
1
...
16
17
18
19
20
21
22
...
27
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs September 2009