Ros-diffs July 2011

ros-diffs@reactos.org

24 participants
517 discussions

[tkreuzer] 52923: [NTOSKRNL] Fix MSVC version of KiConvertToGuiThread (save and restore ebx) Noticed by Dmitry

by tkreuzer＠svn.reactos.org

Author: tkreuzer Date: Wed Jul 27 13:37:57 2011 New Revision: 52923 URL: http://svn.reactos.org/svn/reactos?rev=52923&view=rev Log: [NTOSKRNL] Fix MSVC version of KiConvertToGuiThread (save and restore ebx) Noticed by Dmitry Modified: trunk/reactos/ntoskrnl/ke/i386/trap.s Modified: trunk/reactos/ntoskrnl/ke/i386/trap.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/trap.s?re… ============================================================================== --- trunk/reactos/ntoskrnl/ke/i386/trap.s [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ke/i386/trap.s [iso-8859-1] Wed Jul 27 13:37:57 2011 @@ -167,6 +167,9 @@ PUBLIC _KiConvertToGuiThread@0 _KiConvertToGuiThread@0: + /* Safe ebx */ + push ebx + /* Calculate the stack frame offset in ebx */ mov ebx, ebp sub ebx, esp @@ -178,6 +181,9 @@ mov ebp, esp add ebp, ebx + /* Restore ebx */ + pop ebx + /* return to the caller */ ret #endif

13 years, 5 months

[akhaldi] 52922: [NTOSKRNL] * Get buildno.h out of the PCH.

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Wed Jul 27 13:07:32 2011 New Revision: 52922 URL: http://svn.reactos.org/svn/reactos?rev=52922&view=rev Log: [NTOSKRNL] * Get buildno.h out of the PCH. Modified: trunk/reactos/ntoskrnl/ex/init.c trunk/reactos/ntoskrnl/include/ntoskrnl.h trunk/reactos/ntoskrnl/kd/kdio.c Modified: trunk/reactos/ntoskrnl/ex/init.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/init.c?rev=529… ============================================================================== --- trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] Wed Jul 27 13:07:32 2011 @@ -10,6 +10,7 @@ /* INCLUDES ******************************************************************/ #include <ntoskrnl.h> +#include <reactos/buildno.h> #define NDEBUG #include <debug.h> Modified: trunk/reactos/ntoskrnl/include/ntoskrnl.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/ntoskrnl.… ============================================================================== --- trunk/reactos/ntoskrnl/include/ntoskrnl.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/ntoskrnl.h [iso-8859-1] Wed Jul 27 13:07:32 2011 @@ -51,7 +51,6 @@ #include <pseh/pseh2.h> /* ReactOS Headers */ -#include <reactos/buildno.h> #include <reactos/bugcodes.h> /* SetupLDR Support */ Modified: trunk/reactos/ntoskrnl/kd/kdio.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kd/kdio.c?rev=529… ============================================================================== --- trunk/reactos/ntoskrnl/kd/kdio.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kd/kdio.c [iso-8859-1] Wed Jul 27 13:07:32 2011 @@ -10,6 +10,7 @@ /* INCLUDES ******************************************************************/ #include <ntoskrnl.h> +#include <reactos/buildno.h> #include <debug.h> /* GLOBALS *******************************************************************/

13 years, 5 months

[akhaldi] 52921: [MUP] * Use mup.h as a PCH.

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Wed Jul 27 12:41:50 2011 New Revision: 52921 URL: http://svn.reactos.org/svn/reactos?rev=52921&view=rev Log: [MUP] * Use mup.h as a PCH. Modified: trunk/reactos/drivers/filesystems/mup/CMakeLists.txt trunk/reactos/drivers/filesystems/mup/create.c trunk/reactos/drivers/filesystems/mup/mup.c trunk/reactos/drivers/filesystems/mup/mup.h Modified: trunk/reactos/drivers/filesystems/mup/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/mup/CM… ============================================================================== --- trunk/reactos/drivers/filesystems/mup/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/mup/CMakeLists.txt [iso-8859-1] Wed Jul 27 12:41:50 2011 @@ -6,5 +6,5 @@ set_module_type(mup kernelmodedriver) add_importlibs(mup ntoskrnl hal) - +add_pch(mup mup.h) add_cd_file(TARGET mup DESTINATION reactos/system32/drivers FOR all) Modified: trunk/reactos/drivers/filesystems/mup/create.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/mup/cr… ============================================================================== --- trunk/reactos/drivers/filesystems/mup/create.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/mup/create.c [iso-8859-1] Wed Jul 27 12:41:50 2011 @@ -27,13 +27,10 @@ /* INCLUDES *****************************************************************/ -#include <ntifs.h> +#include "mup.h" //#define NDEBUG #include <debug.h> - -#include "mup.h" - /* FUNCTIONS ****************************************************************/ Modified: trunk/reactos/drivers/filesystems/mup/mup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/mup/mu… ============================================================================== --- trunk/reactos/drivers/filesystems/mup/mup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/mup/mup.c [iso-8859-1] Wed Jul 27 12:41:50 2011 @@ -27,13 +27,10 @@ /* INCLUDES *****************************************************************/ -#include <ntddk.h> +#include "mup.h" //#define NDEBUG #include <debug.h> - -#include "mup.h" - /* GLOBALS *****************************************************************/ Modified: trunk/reactos/drivers/filesystems/mup/mup.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/mup/mu… ============================================================================== --- trunk/reactos/drivers/filesystems/mup/mup.h [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/mup/mup.h [iso-8859-1] Wed Jul 27 12:41:50 2011 @@ -1,16 +1,13 @@ -#pragma once + +#include <ntddk.h> #define ROUND_UP(N, S) ((((N) + (S) - 1) / (S)) * (S)) - - typedef struct { ULONG Dummy; } DEVICE_EXTENSION, *PDEVICE_EXTENSION, VCB, *PVCB; - - /* create.c */ DRIVER_DISPATCH MupCreate; @@ -19,7 +16,6 @@ PIRP Irp); /* mup.c */ - NTSTATUS NTAPI DriverEntry(PDRIVER_OBJECT DriverObject, PUNICODE_STRING RegistryPath);

13 years, 5 months

[akhaldi] 52920: [FS_REC] * Use fs_rec.h as a PCH.

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Wed Jul 27 10:47:25 2011 New Revision: 52920 URL: http://svn.reactos.org/svn/reactos?rev=52920&view=rev Log: [FS_REC] * Use fs_rec.h as a PCH. Modified: trunk/reactos/drivers/filesystems/fs_rec/CMakeLists.txt Modified: trunk/reactos/drivers/filesystems/fs_rec/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fs_rec… ============================================================================== --- trunk/reactos/drivers/filesystems/fs_rec/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fs_rec/CMakeLists.txt [iso-8859-1] Wed Jul 27 10:47:25 2011 @@ -11,5 +11,5 @@ set_module_type(fs_rec kernelmodedriver) add_importlibs(fs_rec ntoskrnl hal) - +add_pch(fs_rec fs_rec.h) add_cd_file(TARGET fs_rec DESTINATION reactos/system32/drivers FOR all)

13 years, 5 months

[akhaldi] 52919: [EXT2FS] * Use ext2fsd.h as a PCH.

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Wed Jul 27 10:11:21 2011 New Revision: 52919 URL: http://svn.reactos.org/svn/reactos?rev=52919&view=rev Log: [EXT2FS] * Use ext2fsd.h as a PCH. Modified: trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt Modified: trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ext2/C… ============================================================================== --- trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt [iso-8859-1] Wed Jul 27 10:11:21 2011 @@ -24,7 +24,7 @@ add_library(ext2fs SHARED ${SOURCE}) target_link_libraries(ext2fs ${PSEH_LIB}) - +add_pch(ext2fs inc/ext2fsd.h) set_module_type(ext2fs kernelmodedriver) add_importlibs(ext2fs ntoskrnl hal)

13 years, 5 months

[akhaldi] 52918: [CMAKE] Thomas Faber: - Properly Initialize OUTPUT_VARIABLE.

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Wed Jul 27 09:18:46 2011 New Revision: 52918 URL: http://svn.reactos.org/svn/reactos?rev=52918&view=rev Log: [CMAKE] Thomas Faber: - Properly Initialize OUTPUT_VARIABLE. Modified: trunk/reactos/include/reactos/version.cmake Modified: trunk/reactos/include/reactos/version.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/version.cm… ============================================================================== --- trunk/reactos/include/reactos/version.cmake [iso-8859-1] (original) +++ trunk/reactos/include/reactos/version.cmake [iso-8859-1] Wed Jul 27 09:18:46 2011 @@ -17,6 +17,7 @@ endmacro() macro(converttohex INTVALUE OUTPUT_VARIABLE) + set(${OUTPUT_VARIABLE} "") set(REMAINING ${INTVALUE}) while(REMAINING) math(EXPR REMAINDER "${REMAINING}%16")

13 years, 5 months

[dgorbachev] 52917: [NTOSKRNL] Fix a bug in KiConvertToGuiThread inline asm and get rid of 1 instruction.

by dgorbachev＠svn.reactos.org

Author: dgorbachev Date: Wed Jul 27 02:37:47 2011 New Revision: 52917 URL: http://svn.reactos.org/svn/reactos?rev=52917&view=rev Log: [NTOSKRNL] Fix a bug in KiConvertToGuiThread inline asm and get rid of 1 instruction. Modified: trunk/reactos/ntoskrnl/include/internal/i386/ke.h Modified: trunk/reactos/ntoskrnl/include/internal/i386/ke.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/i386/ke.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/i386/ke.h [iso-8859-1] Wed Jul 27 02:37:47 2011 @@ -759,13 +759,12 @@ */ __asm__ __volatile__ ( - "movl %%ebp, %1\n" - "subl %%esp, %1\n" - "call _PsConvertToGuiThread@0\n" - "addl %%esp, %1\n" - "movl %1, %%ebp\n" - "movl %%eax, %0\n" - : "=r"(Result), "=r"(StackFrame) + "movl %%ebp, %1\n\t" + "subl %%esp, %1\n\t" + "call _PsConvertToGuiThread@0\n\t" + "addl %%esp, %1\n\t" + "movl %1, %%ebp" + : "=a"(Result), "=r"(StackFrame) : : "%esp", "%ecx", "%edx", "memory" );

13 years, 5 months

[dgorbachev] 52916: [CDFS] Workaround for GCC 4.6 optimizer bug (ICE when compiling with -O3).

by dgorbachev＠svn.reactos.org

Author: dgorbachev Date: Wed Jul 27 02:37:40 2011 New Revision: 52916 URL: http://svn.reactos.org/svn/reactos?rev=52916&view=rev Log: [CDFS] Workaround for GCC 4.6 optimizer bug (ICE when compiling with -O3). Modified: trunk/reactos/drivers/filesystems/cdfs/fsctl.c Modified: trunk/reactos/drivers/filesystems/cdfs/fsctl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs/f… ============================================================================== --- trunk/reactos/drivers/filesystems/cdfs/fsctl.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/cdfs/fsctl.c [iso-8859-1] Wed Jul 27 02:37:40 2011 @@ -63,10 +63,10 @@ for (i = 0; i < 2048; i += 4) { /* DON'T optimize this to ULONG!!! (breaks overflow) */ + Serial.Part[3] += Buffer[i+0]; + Serial.Part[2] += Buffer[i+1]; + Serial.Part[1] += Buffer[i+2]; Serial.Part[0] += Buffer[i+3]; - Serial.Part[1] += Buffer[i+2]; - Serial.Part[2] += Buffer[i+1]; - Serial.Part[3] += Buffer[i+0]; } CdInfo->SerialNumber = Serial.Value;

13 years, 5 months

[dgorbachev] 52915: Add "-fno-omit-frame-pointer" compiler option. GCC 4.6 omits on -O2 and -O3 level.

by dgorbachev＠svn.reactos.org

Author: dgorbachev Date: Wed Jul 27 02:37:33 2011 New Revision: 52915 URL: http://svn.reactos.org/svn/reactos?rev=52915&view=rev Log: Add "-fno-omit-frame-pointer" compiler option. GCC 4.6 omits on -O2 and -O3 level. Modified: trunk/reactos/ReactOS-i386.rbuild trunk/reactos/cmake/gcc.cmake Modified: trunk/reactos/ReactOS-i386.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ReactOS-i386.rbuild?rev=52… ============================================================================== --- trunk/reactos/ReactOS-i386.rbuild [iso-8859-1] (original) +++ trunk/reactos/ReactOS-i386.rbuild [iso-8859-1] Wed Jul 27 02:37:33 2011 @@ -30,6 +30,7 @@ <compilerflag compiler="cc,cxx">-gstabs+</compilerflag> <compilerflag compiler="cc,cxx">-fno-set-stack-executable</compilerflag> <compilerflag compiler="cc,cxx">-fno-optimize-sibling-calls</compilerflag> + <compilerflag compiler="cc,cxx">-fno-omit-frame-pointer</compilerflag> <compilerflag compiler="as">-gstabs+</compilerflag> </group> Modified: trunk/reactos/cmake/gcc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/gcc.cmake?rev=52915&… ============================================================================== --- trunk/reactos/cmake/gcc.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/gcc.cmake [iso-8859-1] Wed Jul 27 02:37:33 2011 @@ -37,7 +37,7 @@ add_compiler_flags(-fno-strict-aliasing) if(ARCH MATCHES i386) - add_compiler_flags(-mpreferred-stack-boundary=2 -fno-set-stack-executable -fno-optimize-sibling-calls) + add_compiler_flags(-mpreferred-stack-boundary=2 -fno-set-stack-executable -fno-optimize-sibling-calls -fno-omit-frame-pointer) if(OPTIMIZE STREQUAL "1") add_compiler_flags(-ftracer -momit-leaf-frame-pointer) endif()

13 years, 5 months

[dgorbachev] 52914: [FASTFAT] Do not set attribute "normal" on files. Bug #6384.

by dgorbachev＠svn.reactos.org

Author: dgorbachev Date: Wed Jul 27 02:36:56 2011 New Revision: 52914 URL: http://svn.reactos.org/svn/reactos?rev=52914&view=rev Log: [FASTFAT] Do not set attribute "normal" on files. Bug #6384. Modified: trunk/reactos/drivers/filesystems/fastfat/create.c Modified: trunk/reactos/drivers/filesystems/fastfat/create.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/create.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/create.c [iso-8859-1] Wed Jul 27 02:36:56 2011 @@ -545,7 +545,7 @@ RequestedDisposition == FILE_SUPERSEDE) { ULONG Attributes; - Attributes = Stack->Parameters.Create.FileAttributes; + Attributes = Stack->Parameters.Create.FileAttributes & ~FILE_ATTRIBUTE_NORMAL; vfatSplitPathName(&PathNameU, NULL, &FileNameU); Status = VfatAddEntry (DeviceExt, &FileNameU, &pFcb, ParentFcb, RequestedOptions,

13 years, 5 months

← Newer
1
...
7
8
9
10
11
12
13
...
52
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs July 2011