Ros-diffs July 2011

ros-diffs@reactos.org

24 participants
517 discussions

[rharabien] 52893: [DESK] - Remove forgotten debug print - Simplify a bit

by rharabien＠svn.reactos.org

Author: rharabien Date: Tue Jul 26 11:12:56 2011 New Revision: 52893 URL: http://svn.reactos.org/svn/reactos?rev=52893&view=rev Log: [DESK] - Remove forgotten debug print - Simplify a bit Modified: trunk/reactos/dll/cpl/desk/theme.c trunk/reactos/dll/cpl/desk/theme.h Modified: trunk/reactos/dll/cpl/desk/theme.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/theme.c?rev=5… ============================================================================== --- trunk/reactos/dll/cpl/desk/theme.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/desk/theme.c [iso-8859-1] Tue Jul 26 11:12:56 2011 @@ -24,7 +24,7 @@ THEME_PRESET g_ThemeTemplates[MAX_TEMPLATES]; /* This is the list of names for the colors stored in the registry */ -const TCHAR g_RegColorNames[NUM_COLORS][MAX_COLORNAMELENGTH] = +static const TCHAR *g_RegColorNames[NUM_COLORS] = {TEXT("Scrollbar"), /* 00 = COLOR_SCROLLBAR */ TEXT("Background"), /* 01 = COLOR_DESKTOP */ TEXT("ActiveTitle"), /* 02 = COLOR_ACTIVECAPTION */ @@ -59,7 +59,7 @@ }; /* This is the list of used metrics and their numbers */ -const int g_SizeMetric[NUM_SIZES] = +static const int g_SizeMetric[NUM_SIZES] = { SM_CXBORDER, /* 00: SIZE_BORDER_X */ SM_CYBORDER, /* 01: SIZE_BORDER_Y */ @@ -134,7 +134,7 @@ { INT i; TCHAR strSelectedStyle[4]; - TCHAR strSizeName[20] = {TEXT("Sizes\\0")}; + TCHAR strSizeName[20] = TEXT("Sizes\\0"); TCHAR strValueName[10]; HKEY hkNewSchemes, hkScheme, hkSize; DWORD dwType, dwLength; @@ -196,7 +196,7 @@ dwType != REG_QWORD || dwLength != sizeof(UINT64)) { /* Failed to read registry value, initialize with current setting for now */ - theme->Size[i] = GetSystemMetrics(g_SizeMetric[i]); if(i == SIZE_CAPTION_Y) OutputDebugStringA("GetSystemMetrics!\n"); + theme->Size[i] = GetSystemMetrics(g_SizeMetric[i]); } else theme->Size[i] = (INT)iSize; @@ -211,18 +211,10 @@ return Ret; } -static VOID -_UpdateUserPref(UINT SpiGet, UINT SpiSet, BOOL *pbFlag) -{ - SystemParametersInfo(SpiSet, 0, (PVOID)pbFlag, SPIF_UPDATEINIFILE|SPIF_SENDCHANGE); -} -#define UPDATE_USERPREF(NAME,pbFlag) _UpdateUserPref(SPI_GET ## NAME, SPI_SET ## NAME, pbFlag) - VOID ApplyTheme(THEME* theme, INT ThemeId) { INT i, Result; HKEY hKey; - DWORD dwDisposition; TCHAR clText[16]; NONCLIENTMETRICS NonClientMetrics; ICONMETRICS IconMetrics; @@ -231,13 +223,7 @@ SetSysColors(NUM_COLORS, g_ColorList, theme->crColor); /* Save colors to registry */ - Result = RegOpenKeyEx(HKEY_CURRENT_USER, g_CPColors, 0, KEY_ALL_ACCESS, &hKey); - if (Result != ERROR_SUCCESS) - { - /* Could not open the key, try to create it */ - Result = RegCreateKeyEx(HKEY_CURRENT_USER, g_CPColors, 0, NULL, 0, KEY_ALL_ACCESS, NULL, &hKey, &dwDisposition); - } - + Result = RegCreateKeyEx(HKEY_CURRENT_USER, g_CPColors, 0, NULL, 0, KEY_ALL_ACCESS, NULL, &hKey, NULL); if (Result == ERROR_SUCCESS) { for (i = 0; i < NUM_COLORS; i++) @@ -292,19 +278,19 @@ theme->Effects.bTooltipFade = theme->Effects.bMenuFade; SystemParametersInfo(SPI_SETDRAGFULLWINDOWS, theme->Effects.bDragFullWindows, (PVOID)&theme->Effects.bDragFullWindows, SPIF_SENDCHANGE | SPIF_UPDATEINIFILE); SystemParametersInfo(SPI_SETKEYBOARDCUES, 0, IntToPtr(theme->Effects.bKeyboardCues), SPIF_SENDCHANGE | SPIF_UPDATEINIFILE); - //UPDATE_USERPREF(ACTIVEWINDOWTRACKING, &theme->Effects.bActiveWindowTracking); - //UPDATE_USERPREF(MENUANIMATION, &theme->Effects.bMenuAnimation); - //UPDATE_USERPREF(COMBOBOXANIMATION, &theme->Effects.bComboBoxAnimation); - //UPDATE_USERPREF(LISTBOXSMOOTHSCROLLING, &theme->Effects.bListBoxSmoothScrolling); - //UPDATE_USERPREF(GRADIENTCAPTIONS, &theme->Effects.bGradientCaptions); - //UPDATE_USERPREF(ACTIVEWNDTRKZORDER, &theme->Effects.bActiveWndTrkZorder); - //UPDATE_USERPREF(HOTTRACKING, &theme->Effects.bHotTracking); - UPDATE_USERPREF(MENUFADE, &theme->Effects.bMenuFade); - //UPDATE_USERPREF(SELECTIONFADE, &theme->Effects.bSelectionFade); - UPDATE_USERPREF(TOOLTIPANIMATION, &theme->Effects.bTooltipAnimation); - UPDATE_USERPREF(TOOLTIPFADE, &theme->Effects.bTooltipFade); - //UPDATE_USERPREF(CURSORSHADOW, &theme->Effects.bCursorShadow); - //UPDATE_USERPREF(UIEFFECTS, &theme->Effects.bUiEffects); + //SystemParametersInfo(SPI_SETACTIVEWINDOWTRACKING, 0, (PVOID)&theme->Effects.bActiveWindowTracking, SPIF_UPDATEINIFILE|SPIF_SENDCHANGE); + //SystemParametersInfo(SPI_SETMENUANIMATION, 0, (PVOID)&theme->Effects.bMenuAnimation, SPIF_UPDATEINIFILE|SPIF_SENDCHANGE); + //SystemParametersInfo(SPI_SETCOMBOBOXANIMATION, 0, (PVOID)&theme->Effects.bComboBoxAnimation, SPIF_UPDATEINIFILE|SPIF_SENDCHANGE); + //SystemParametersInfo(SPI_SETLISTBOXSMOOTHSCROLLING, 0, (PVOID)&theme->Effects.bListBoxSmoothScrolling, SPIF_UPDATEINIFILE|SPIF_SENDCHANGE); + //SystemParametersInfo(SPI_SETGRADIENTCAPTIONS, 0, (PVOID)&theme->Effects.bGradientCaptions, SPIF_UPDATEINIFILE|SPIF_SENDCHANGE); + //SystemParametersInfo(SPI_SETACTIVEWNDTRKZORDER, 0, (PVOID)&theme->Effects.bActiveWndTrkZorder, SPIF_UPDATEINIFILE|SPIF_SENDCHANGE); + //SystemParametersInfo(SPI_SETHOTTRACKING, 0, (PVOID)&theme->Effects.bHotTracking, SPIF_UPDATEINIFILE|SPIF_SENDCHANGE); + SystemParametersInfo(SPI_SETMENUFADE, 0, (PVOID)&theme->Effects.bMenuFade, SPIF_UPDATEINIFILE|SPIF_SENDCHANGE); + //SystemParametersInfo(SPI_SETSELECTIONFADE, 0, (PVOID)&theme->Effects.bSelectionFade, SPIF_UPDATEINIFILE|SPIF_SENDCHANGE); + SystemParametersInfo(SPI_SETTOOLTIPANIMATION, 0, (PVOID)&theme->Effects.bTooltipAnimation, SPIF_UPDATEINIFILE|SPIF_SENDCHANGE); + SystemParametersInfo(SPI_SETTOOLTIPFADE, 0, (PVOID)&theme->Effects.bTooltipFade, SPIF_UPDATEINIFILE|SPIF_SENDCHANGE); + //SystemParametersInfo(SPI_SETCURSORSHADOW, 0, (PVOID)&theme->Effects.bCursorShadow, SPIF_UPDATEINIFILE|SPIF_SENDCHANGE); + //SystemParametersInfo(SPI_SETUIEFFECTS, 0, (PVOID)&theme->Effects.bUiEffects, SPIF_UPDATEINIFILE|SPIF_SENDCHANGE); /* Save ThemeId */ Result = RegOpenKeyEx(HKEY_CURRENT_USER, g_CPANewSchemes, 0, KEY_ALL_ACCESS, &hKey); Modified: trunk/reactos/dll/cpl/desk/theme.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/theme.h?rev=5… ============================================================================== --- trunk/reactos/dll/cpl/desk/theme.h [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/desk/theme.h [iso-8859-1] Tue Jul 26 11:12:56 2011 @@ -77,8 +77,6 @@ TCHAR strLegacyName[MAX_TEMPLATENAMELENTGH]; } THEME_PRESET; -extern const TCHAR g_RegColorNames[NUM_COLORS][MAX_COLORNAMELENGTH]; -extern const INT g_SizeMetric[NUM_SIZES]; extern THEME_PRESET g_ThemeTemplates[MAX_TEMPLATES]; /* prototypes for theme.c */

13 years, 5 months

[rharabien] 52892: [DESK] - Fix #6262: each new applied color scheme increase the window title height by one - Don't read REG_QWORD directly to DWORD variable

by rharabien＠svn.reactos.org

Author: rharabien Date: Tue Jul 26 10:51:54 2011 New Revision: 52892 URL: http://svn.reactos.org/svn/reactos?rev=52892&view=rev Log: [DESK] - Fix #6262: each new applied color scheme increase the window title height by one - Don't read REG_QWORD directly to DWORD variable Modified: trunk/reactos/dll/cpl/desk/theme.c Modified: trunk/reactos/dll/cpl/desk/theme.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/theme.c?rev=5… ============================================================================== --- trunk/reactos/dll/cpl/desk/theme.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/desk/theme.c [iso-8859-1] Tue Jul 26 10:51:54 2011 @@ -63,7 +63,7 @@ { SM_CXBORDER, /* 00: SIZE_BORDER_X */ SM_CYBORDER, /* 01: SIZE_BORDER_Y */ - SM_CYCAPTION, /* 02: SIZE_CAPTION_Y */ + SM_CYSIZE, /* 02: SIZE_CAPTION_Y */ SM_CXICON, /* 03: SIZE_ICON_X */ SM_CYICON, /* 04: SIZE_ICON_Y */ SM_CXICONSPACING, /* 05: SIZE_ICON_SPC_X */ @@ -72,7 +72,7 @@ SM_CYMENU, /* 08: SIZE_MENU_Y */ SM_CXVSCROLL, /* 09: SIZE_SCROLL_X */ SM_CYHSCROLL, /* 10: SIZE_SCROLL_Y */ - SM_CYSMCAPTION, /* 11: SIZE_SMCAPTION_Y */ + SM_CYSMSIZE, /* 11: SIZE_SMCAPTION_Y */ SM_CXEDGE, /* 12: SIZE_EDGE_X */ SM_CYEDGE, /* 13: SIZE_EDGE_Y */ SM_CYSIZEFRAME, /* 14: SIZE_FRAME_Y */ @@ -190,13 +190,16 @@ for (i = 0; i < NUM_SIZES; i++) { wsprintf(strValueName, TEXT("Size #%d"), i); + UINT64 iSize; dwLength = sizeof(UINT64); - if (RegQueryValueEx(hkSize, strValueName, NULL, &dwType, (LPBYTE)&theme->Size[i], &dwLength) != ERROR_SUCCESS || + if (RegQueryValueEx(hkSize, strValueName, NULL, &dwType, (LPBYTE)&iSize, &dwLength) != ERROR_SUCCESS || dwType != REG_QWORD || dwLength != sizeof(UINT64)) { /* Failed to read registry value, initialize with current setting for now */ - theme->Size[i] = GetSystemMetrics(g_SizeMetric[i]); + theme->Size[i] = GetSystemMetrics(g_SizeMetric[i]); if(i == SIZE_CAPTION_Y) OutputDebugStringA("GetSystemMetrics!\n"); } + else + theme->Size[i] = (INT)iSize; } RegCloseKey(hkScheme); }

13 years, 5 months

[jgardou] 52891: [NTDLL] - remove duplicate declaration of RtlAdjustPrivilege

by jgardou＠svn.reactos.org

Author: jgardou Date: Tue Jul 26 08:29:53 2011 New Revision: 52891 URL: http://svn.reactos.org/svn/reactos?rev=52891&view=rev Log: [NTDLL] - remove duplicate declaration of RtlAdjustPrivilege Modified: trunk/reactos/dll/ntdll/def/ntdll.spec Modified: trunk/reactos/dll/ntdll/def/ntdll.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/def/ntdll.spec?r… ============================================================================== --- trunk/reactos/dll/ntdll/def/ntdll.spec [iso-8859-1] (original) +++ trunk/reactos/dll/ntdll/def/ntdll.spec [iso-8859-1] Tue Jul 26 08:29:53 2011 @@ -411,7 +411,6 @@ ;@ stdcall RtlAbortRXact @ stdcall RtlAbsoluteToSelfRelativeSD(ptr ptr ptr) @ stdcall RtlAcquirePebLock() -@ stdcall RtlAdjustPrivilege(long long long ptr) @ stdcall RtlAcquireResourceExclusive(ptr long) @ stdcall RtlAcquireResourceShared(ptr long) @ stdcall RtlAcquireSRWLockExclusive(ptr)

13 years, 5 months

[jgardou] 52890: [NDK/DDK] Fix definitions of ZwPowerInformation and ZwInitiatePowerAction

by jgardou＠svn.reactos.org

Author: jgardou Date: Tue Jul 26 08:27:35 2011 New Revision: 52890 URL: http://svn.reactos.org/svn/reactos?rev=52890&view=rev Log: [NDK/DDK] Fix definitions of ZwPowerInformation and ZwInitiatePowerAction Modified: trunk/reactos/include/ddk/ntddk.h trunk/reactos/include/ddk/ntifs.h trunk/reactos/include/ndk/pofuncs.h Modified: trunk/reactos/include/ddk/ntddk.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntddk.h?rev=52… ============================================================================== --- trunk/reactos/include/ddk/ntddk.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/ntddk.h [iso-8859-1] Tue Jul 26 08:27:35 2011 @@ -5600,8 +5600,8 @@ NTAPI ZwDisplayString( IN PUNICODE_STRING String); - -NTSYSAPI + +NTSYSCALLAPI NTSTATUS NTAPI ZwPowerInformation( Modified: trunk/reactos/include/ddk/ntifs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntifs.h?rev=52… ============================================================================== --- trunk/reactos/include/ddk/ntifs.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/ntifs.h [iso-8859-1] Tue Jul 26 08:27:35 2011 @@ -9615,7 +9615,7 @@ #if (VER_PRODUCTBUILD >= 2195) -NTSYSAPI +NTSYSCALLAPI NTSTATUS NTAPI ZwInitiatePowerAction ( Modified: trunk/reactos/include/ndk/pofuncs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/pofuncs.h?rev=… ============================================================================== --- trunk/reactos/include/ndk/pofuncs.h [iso-8859-1] (original) +++ trunk/reactos/include/ndk/pofuncs.h [iso-8859-1] Tue Jul 26 08:27:35 2011 @@ -114,21 +114,21 @@ NTSTATUS NTAPI ZwInitiatePowerAction( - POWER_ACTION SystemAction, - SYSTEM_POWER_STATE MinSystemState, - ULONG Flags, - BOOLEAN Asynchronous + IN POWER_ACTION SystemAction, + IN SYSTEM_POWER_STATE MinSystemState, + IN ULONG Flags, + IN BOOLEAN Asynchronous ); NTSYSCALLAPI NTSTATUS NTAPI ZwPowerInformation( - POWER_INFORMATION_LEVEL PowerInformationLevel, - PVOID InputBuffer, - ULONG InputBufferLength, - PVOID OutputBuffer, - ULONG OutputBufferLength + IN POWER_INFORMATION_LEVEL PowerInformationLevel, + IN PVOID InputBuffer OPTIONAL, + IN ULONG InputBufferLength, + OUT PVOID OutputBuffer OPTIONAL, + IN ULONG OutputBufferLength ); NTSYSCALLAPI

13 years, 5 months

[tfaber] 52889: [KMTESTS/RTL] - add a concept test for Rtl functions, which can run unmodified in user/kernel mode

by tfaber＠svn.reactos.org

Author: tfaber Date: Tue Jul 26 07:40:19 2011 New Revision: 52889 URL: http://svn.reactos.org/svn/reactos?rev=52889&view=rev Log: [KMTESTS/RTL] - add a concept test for Rtl functions, which can run unmodified in user/kernel mode Added: branches/GSoC_2011/KMTestSuite/kmtests/rtl/ (with props) branches/GSoC_2011/KMTestSuite/kmtests/rtl/RtlMemory.c (with props) Modified: branches/GSoC_2011/KMTestSuite/kmtests/CMakeLists.txt branches/GSoC_2011/KMTestSuite/kmtests/kmtest.rbuild branches/GSoC_2011/KMTestSuite/kmtests/kmtest/testlist.c branches/GSoC_2011/KMTestSuite/kmtests/kmtest_drv.rbuild branches/GSoC_2011/KMTestSuite/kmtests/kmtest_drv/testlist.c Modified: branches/GSoC_2011/KMTestSuite/kmtests/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2011/KMTestSuite/kmtests/C… ============================================================================== --- branches/GSoC_2011/KMTestSuite/kmtests/CMakeLists.txt [iso-8859-1] (original) +++ branches/GSoC_2011/KMTestSuite/kmtests/CMakeLists.txt [iso-8859-1] Tue Jul 26 07:40:19 2011 @@ -32,6 +32,7 @@ ntos_ke/KeProcessor.c ntos_ke/KeSpinLock.c ntos_ob/ObCreate.c + rtl/RtlMemory.c kmtest_drv/kmtest_drv.rc) @@ -62,6 +63,7 @@ kmtest/testlist.c example/Example_user.c + rtl/RtlMemory.c kmtest/kmtest.rc) Modified: branches/GSoC_2011/KMTestSuite/kmtests/kmtest.rbuild URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2011/KMTestSuite/kmtests/k… ============================================================================== --- branches/GSoC_2011/KMTestSuite/kmtests/kmtest.rbuild [iso-8859-1] (original) +++ branches/GSoC_2011/KMTestSuite/kmtests/kmtest.rbuild [iso-8859-1] Tue Jul 26 07:40:19 2011 @@ -11,4 +11,7 @@ <directory name="example"> <file>Example_user.c</file> </directory> + <directory name="rtl"> + <file>RtlMemory.c</file> + </directory> </module> Modified: branches/GSoC_2011/KMTestSuite/kmtests/kmtest/testlist.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2011/KMTestSuite/kmtests/k… ============================================================================== --- branches/GSoC_2011/KMTestSuite/kmtests/kmtest/testlist.c [iso-8859-1] (original) +++ branches/GSoC_2011/KMTestSuite/kmtests/kmtest/testlist.c [iso-8859-1] Tue Jul 26 07:40:19 2011 @@ -10,11 +10,13 @@ #include <windows.h> #include <kmt_test.h> -VOID Test_Example(VOID); +KMT_TESTFUNC Test_Example; +KMT_TESTFUNC Test_RtlMemory; /* tests with a leading '-' will not be listed */ const KMT_TEST TestList[] = { { "Example", Test_Example }, + { "RtlMemory", Test_RtlMemory }, { NULL, NULL }, }; Modified: branches/GSoC_2011/KMTestSuite/kmtests/kmtest_drv.rbuild URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2011/KMTestSuite/kmtests/k… ============================================================================== --- branches/GSoC_2011/KMTestSuite/kmtests/kmtest_drv.rbuild [iso-8859-1] (original) +++ branches/GSoC_2011/KMTestSuite/kmtests/kmtest_drv.rbuild [iso-8859-1] Tue Jul 26 07:40:19 2011 @@ -41,6 +41,9 @@ <directory name="ntos_ob"> <file>ObCreate.c</file> </directory> + <directory name="rtl"> + <file>RtlMemory.c</file> + </directory> </module> <module name="kmtest_printf" type="staticlibrary"> <include base="crt">include</include> Modified: branches/GSoC_2011/KMTestSuite/kmtests/kmtest_drv/testlist.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2011/KMTestSuite/kmtests/k… ============================================================================== --- branches/GSoC_2011/KMTestSuite/kmtests/kmtest_drv/testlist.c [iso-8859-1] (original) +++ branches/GSoC_2011/KMTestSuite/kmtests/kmtest_drv/testlist.c [iso-8859-1] Tue Jul 26 07:40:19 2011 @@ -27,6 +27,7 @@ KMT_TESTFUNC Test_KeProcessor; KMT_TESTFUNC Test_KernelType; KMT_TESTFUNC Test_ObCreate; +KMT_TESTFUNC Test_RtlMemory; const KMT_TEST TestList[] = { @@ -49,5 +50,6 @@ { "KeProcessor", Test_KeProcessor }, { "-KernelType", Test_KernelType }, { "ObCreate", Test_ObCreate }, + { "RtlMemoryKM", Test_RtlMemory }, { NULL, NULL } }; Propchange: branches/GSoC_2011/KMTestSuite/kmtests/rtl/ ------------------------------------------------------------------------------ --- bugtraq:logregex (added) +++ bugtraq:logregex Tue Jul 26 07:40:19 2011 @@ -1,0 +1,2 @@ +([Ii]ssue|[Bb]ug)s? #?(\d+)(,? ?#?(\d+))*(,? ?(and |or )?#?(\d+))? +(\d+) Propchange: branches/GSoC_2011/KMTestSuite/kmtests/rtl/ ------------------------------------------------------------------------------ bugtraq:message = See issue #%BUGID% for more details. Propchange: branches/GSoC_2011/KMTestSuite/kmtests/rtl/ ------------------------------------------------------------------------------ bugtraq:number = true Propchange: branches/GSoC_2011/KMTestSuite/kmtests/rtl/ ------------------------------------------------------------------------------ bugtraq:url = http://www.reactos.org/bugzilla/show_bug.cgi?id=%BUGID% Propchange: branches/GSoC_2011/KMTestSuite/kmtests/rtl/ ------------------------------------------------------------------------------ tsvn:logminsize = 10 Added: branches/GSoC_2011/KMTestSuite/kmtests/rtl/RtlMemory.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2011/KMTestSuite/kmtests/r… ============================================================================== --- branches/GSoC_2011/KMTestSuite/kmtests/rtl/RtlMemory.c (added) +++ branches/GSoC_2011/KMTestSuite/kmtests/rtl/RtlMemory.c [iso-8859-1] Tue Jul 26 07:40:19 2011 @@ -1,0 +1,36 @@ +/* + * PROJECT: ReactOS kernel-mode tests + * LICENSE: GPLv2+ - See COPYING in the top level directory + * PURPOSE: Kernel-Mode Test Suite Runtime library memory functions test + * PROGRAMMER: Thomas Faber <thfabba(a)gmx.de> + */ + +/* TODO: move this to some header */ +#ifdef KMT_USER_MODE +# include <windows.h> +# define ok_irql(i) +# define KIRQL int +# define KeRaiseIrql(new, old) +# define KeLowerIrql(i) +#elif KMT_KERNEL_MODE +# include <ntddk.h> +#endif +#include <kmt_test.h> + +START_TEST(RtlMemory) +{ + UCHAR Buffer[512]; + KIRQL Irql; + int i; + + KeRaiseIrql(HIGH_LEVEL, &Irql); + + RtlFillMemory(Buffer, sizeof Buffer / 2, 0x55); + RtlFillMemory(Buffer + sizeof Buffer / 2, sizeof Buffer / 2, 0xAA); + for (i = 0; i < sizeof Buffer / 2; ++i) + ok_eq_uint(Buffer[i], 0x55); + for (i = sizeof Buffer / 2; i < sizeof Buffer; ++i) + ok_eq_uint(Buffer[i], 0xAA); + + KeLowerIrql(Irql); +} Propchange: branches/GSoC_2011/KMTestSuite/kmtests/rtl/RtlMemory.c ------------------------------------------------------------------------------ svn:eol-style = native

13 years, 5 months

[tfaber] 52888: [KMTESTS] - add missing function KmtAreInterruptsEnabled - fix an MSVC warning

by tfaber＠svn.reactos.org

Author: tfaber Date: Tue Jul 26 07:38:43 2011 New Revision: 52888 URL: http://svn.reactos.org/svn/reactos?rev=52888&view=rev Log: [KMTESTS] - add missing function KmtAreInterruptsEnabled - fix an MSVC warning Modified: branches/GSoC_2011/KMTestSuite/kmtests/include/kmt_test.h branches/GSoC_2011/KMTestSuite/kmtests/kmtest_drv/printf_stubs.c Modified: branches/GSoC_2011/KMTestSuite/kmtests/include/kmt_test.h URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2011/KMTestSuite/kmtests/i… ============================================================================== --- branches/GSoC_2011/KMTestSuite/kmtests/include/kmt_test.h [iso-8859-1] (original) +++ branches/GSoC_2011/KMTestSuite/kmtests/include/kmt_test.h [iso-8859-1] Tue Jul 26 07:38:43 2011 @@ -84,6 +84,7 @@ extern BOOLEAN KmtIsMultiProcessorBuild; VOID KmtSetIrql(IN KIRQL NewIrql); +BOOLEAN KmtAreInterruptsEnabled(VOID); #elif defined KMT_USER_MODE DWORD KmtRunKernelTest(IN PCSTR TestName); @@ -165,6 +166,11 @@ KeRaiseIrql(NewIrql, &Irql); } +BOOLEAN KmtAreInterruptsEnabled(VOID) +{ + return (__readeflags() & (1 << 9)) != 0; +} + INT __cdecl KmtVSNPrintF(PSTR Buffer, SIZE_T BufferMaxLength, PCSTR Format, va_list Arguments) KMT_FORMAT(ms_printf, 3, 0); #elif defined KMT_USER_MODE static PKMT_RESULTBUFFER KmtAllocateResultBuffer(SIZE_T LogBufferMaxLength) Modified: branches/GSoC_2011/KMTestSuite/kmtests/kmtest_drv/printf_stubs.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2011/KMTestSuite/kmtests/k… ============================================================================== --- branches/GSoC_2011/KMTestSuite/kmtests/kmtest_drv/printf_stubs.c [iso-8859-1] (original) +++ branches/GSoC_2011/KMTestSuite/kmtests/kmtest_drv/printf_stubs.c [iso-8859-1] Tue Jul 26 07:38:43 2011 @@ -12,7 +12,7 @@ int __cdecl KmtWcToMb(char *mbchar, wchar_t wchar) { - *mbchar = wchar; + *mbchar = (char)wchar; return 1; }

13 years, 5 months

[dgorbachev] 52887: [WIN32K] Do not go beyond the MouseHistoryOfMoves[] bounds. Fixes a crash in Win32k.

by dgorbachev＠svn.reactos.org

Author: dgorbachev Date: Tue Jul 26 03:24:48 2011 New Revision: 52887 URL: http://svn.reactos.org/svn/reactos?rev=52887&view=rev Log: [WIN32K] Do not go beyond the MouseHistoryOfMoves[] bounds. Fixes a crash in Win32k. Modified: trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c [iso-8859-1] Tue Jul 26 03:24:48 2011 @@ -616,7 +616,8 @@ MouseHistoryOfMoves[gcur_count].y = Msg->pt.y; MouseHistoryOfMoves[gcur_count].time = Msg->time; MouseHistoryOfMoves[gcur_count].dwExtraInfo = dwExtraInfo; - if (gcur_count++ == 64) gcur_count = 0; // 0 - 63 is 64, FIFO forwards. + if (++gcur_count == ARRAYSIZE(MouseHistoryOfMoves)) + gcur_count = 0; // 0 - 63 is 64, FIFO forwards. } //

13 years, 5 months

[dgorbachev] 52886: [MINGW-W64] Reduce differences with upstream. Fixes crash if ReactOS is compiled with GCC 4.6.

by dgorbachev＠svn.reactos.org

Author: dgorbachev Date: Tue Jul 26 01:16:32 2011 New Revision: 52886 URL: http://svn.reactos.org/svn/reactos?rev=52886&view=rev Log: [MINGW-W64] Reduce differences with upstream. Fixes crash if ReactOS is compiled with GCC 4.6. Modified: trunk/reactos/lib/3rdparty/mingw/tlssup.c Modified: trunk/reactos/lib/3rdparty/mingw/tlssup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/mingw/tlssup.… ============================================================================== --- trunk/reactos/lib/3rdparty/mingw/tlssup.c [iso-8859-1] (original) +++ trunk/reactos/lib/3rdparty/mingw/tlssup.c [iso-8859-1] Tue Jul 26 01:16:32 2011 @@ -99,6 +99,7 @@ __dyn_tls_init (HANDLE hDllHandle, DWORD dwReason, LPVOID lpreserved) { _PVFV *pfunc; + uintptr_t ps; #ifndef _WIN64 if (_winmajor < 4) @@ -135,8 +136,11 @@ return TRUE; } - for (pfunc = &__xd_a + 1; pfunc != &__xd_z; ++pfunc) - { + ps = (uintptr_t) &__xd_a; + ps += sizeof (uintptr_t); + for ( ; ps != (uintptr_t) &__xd_z; ps += sizeof (uintptr_t)) + { + pfunc = (_PVFV *) ps; if (*pfunc != NULL) (*pfunc)(); }

13 years, 5 months

[akhaldi] 52885: [MAGNIFY] * Designate magnifier.h as a precompiled header and use it as one.

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Tue Jul 26 00:08:58 2011 New Revision: 52885 URL: http://svn.reactos.org/svn/reactos?rev=52885&view=rev Log: [MAGNIFY] * Designate magnifier.h as a precompiled header and use it as one. Modified: trunk/reactos/base/applications/magnify/CMakeLists.txt trunk/reactos/base/applications/magnify/magnifier.c trunk/reactos/base/applications/magnify/magnifier.h trunk/reactos/base/applications/magnify/magnify.rbuild trunk/reactos/base/applications/magnify/magnify.rc trunk/reactos/base/applications/magnify/settings.c Modified: trunk/reactos/base/applications/magnify/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/magnify/… ============================================================================== --- trunk/reactos/base/applications/magnify/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/base/applications/magnify/CMakeLists.txt [iso-8859-1] Tue Jul 26 00:08:58 2011 @@ -6,6 +6,7 @@ settings.c magnify.rc) +add_pch(magnify magnifier.h) set_module_type(magnify win32gui) add_importlibs(magnify user32 gdi32 advapi32 shell32 msvcrt kernel32) add_cd_file(TARGET magnify DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/base/applications/magnify/magnifier.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/magnify/… ============================================================================== --- trunk/reactos/base/applications/magnify/magnifier.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/magnify/magnifier.c [iso-8859-1] Tue Jul 26 00:08:58 2011 @@ -7,10 +7,7 @@ * */ -#include <windows.h> -#include <shellapi.h> #include "magnifier.h" -#include "resource.h" const TCHAR szWindowClass[] = TEXT("MAGNIFIER"); Modified: trunk/reactos/base/applications/magnify/magnifier.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/magnify/… ============================================================================== --- trunk/reactos/base/applications/magnify/magnifier.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/magnify/magnifier.h [iso-8859-1] Tue Jul 26 00:08:58 2011 @@ -20,6 +20,12 @@ ////////////////////////////////////////////////////////////////// +#include <windows.h> +#include <commctrl.h> +#include <tchar.h> +#include <shellapi.h> +#include "resource.h" + extern int iZoom; extern BOOL bShowWarning; Modified: trunk/reactos/base/applications/magnify/magnify.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/magnify/… ============================================================================== --- trunk/reactos/base/applications/magnify/magnify.rbuild [iso-8859-1] (original) +++ trunk/reactos/base/applications/magnify/magnify.rbuild [iso-8859-1] Tue Jul 26 00:08:58 2011 @@ -9,4 +9,5 @@ <file>magnifier.c</file> <file>settings.c</file> <file>magnify.rc</file> + <pch>magnifier.h</pch> </module> Modified: trunk/reactos/base/applications/magnify/magnify.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/magnify/… ============================================================================== --- trunk/reactos/base/applications/magnify/magnify.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/magnify/magnify.rc [iso-8859-1] Tue Jul 26 00:08:58 2011 @@ -1,6 +1,5 @@ -#include <windows.h> -#include <commctrl.h> -#include "resource.h" + +#include "magnifier.h" LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL Modified: trunk/reactos/base/applications/magnify/settings.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/magnify/… ============================================================================== --- trunk/reactos/base/applications/magnify/settings.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/magnify/settings.c [iso-8859-1] Tue Jul 26 00:08:58 2011 @@ -1,5 +1,4 @@ -#include <windows.h> -#include <tchar.h> + #include "magnifier.h" int iZoom = 3;

13 years, 5 months

[akhaldi] 52884: [SPIDER] * Designate spider.h as a precompiled header and use it as one.

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Mon Jul 25 23:50:18 2011 New Revision: 52884 URL: http://svn.reactos.org/svn/reactos?rev=52884&view=rev Log: [SPIDER] * Designate spider.h as a precompiled header and use it as one. Modified: trunk/reactos/base/applications/games/spider/CMakeLists.txt trunk/reactos/base/applications/games/spider/spider.cpp trunk/reactos/base/applications/games/spider/spider.h trunk/reactos/base/applications/games/spider/spider.rbuild trunk/reactos/base/applications/games/spider/spigame.cpp Modified: trunk/reactos/base/applications/games/spider/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/sp… ============================================================================== --- trunk/reactos/base/applications/games/spider/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/base/applications/games/spider/CMakeLists.txt [iso-8859-1] Mon Jul 25 23:50:18 2011 @@ -12,9 +12,7 @@ rsrc.rc) target_link_libraries(spider cardlib) - +add_pch(spider spider.h) set_module_type(spider win32gui) - add_importlibs(spider advapi32 comctl32 user32 gdi32 msvcrt kernel32) - add_cd_file(TARGET spider DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/base/applications/games/spider/spider.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/sp… ============================================================================== --- trunk/reactos/base/applications/games/spider/spider.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/games/spider/spider.cpp [iso-8859-1] Mon Jul 25 23:50:18 2011 @@ -6,13 +6,6 @@ * PROGRAMMER: Gregor Schneider */ -#include <windows.h> -#include <commctrl.h> -#include <tchar.h> -#include <stdlib.h> - -#include "resource.h" -#include "cardlib.h" #include "spider.h" TCHAR szHelpPath[MAX_PATH]; Modified: trunk/reactos/base/applications/games/spider/spider.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/sp… ============================================================================== --- trunk/reactos/base/applications/games/spider/spider.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/games/spider/spider.h [iso-8859-1] Mon Jul 25 23:50:18 2011 @@ -1,4 +1,12 @@ -#pragma once + +#include <windows.h> +#include <commctrl.h> +#include <tchar.h> +#include <stdio.h> +#include <stdlib.h> +#include "resource.h" +#include "cardlib.h" + #define DIFFICULTY_ONE_COLOR 1 #define DIFFICULTY_TWO_COLORS 2 Modified: trunk/reactos/base/applications/games/spider/spider.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/sp… ============================================================================== --- trunk/reactos/base/applications/games/spider/spider.rbuild [iso-8859-1] (original) +++ trunk/reactos/base/applications/games/spider/spider.rbuild [iso-8859-1] Mon Jul 25 23:50:18 2011 @@ -7,4 +7,5 @@ <file>spigame.cpp</file> <file>spider.cpp</file> <file>rsrc.rc</file> + <pch>spider.h</pch> </module> Modified: trunk/reactos/base/applications/games/spider/spigame.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/sp… ============================================================================== --- trunk/reactos/base/applications/games/spider/spigame.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/games/spider/spigame.cpp [iso-8859-1] Mon Jul 25 23:50:18 2011 @@ -6,13 +6,6 @@ * PROGRAMMER: Gregor Schneider */ -#include <windows.h> -#include <commctrl.h> -#include <tchar.h> -#include <stdio.h> - -#include "resource.h" -#include "cardlib.h" #include "spider.h" #define NUM_DECK_CARDS 5

13 years, 5 months

← Newer
1
...
10
11
12
13
14
15
16
...
52
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs July 2011