Ros-diffs September 2011

ros-diffs@reactos.org

20 participants
399 discussions

[jgardou] 53590: [ATAPI] - get rid of unused variable
by jgardou＠svn.reactos.org 04 Sep '11

04 Sep '11

Author: jgardou Date: Sun Sep 4 20:51:52 2011 New Revision: 53590 URL: http://svn.reactos.org/svn/reactos?rev=53590&view=rev Log: [ATAPI] - get rid of unused variable Modified: trunk/reactos/drivers/storage/ide/atapi/atapi.c Modified: trunk/reactos/drivers/storage/ide/atapi/atapi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/ide/atapi/… ============================================================================== --- trunk/reactos/drivers/storage/ide/atapi/atapi.c [iso-8859-1] (original) +++ trunk/reactos/drivers/storage/ide/atapi/atapi.c [iso-8859-1] Sun Sep 4 20:51:52 2011 @@ -1383,7 +1383,6 @@ } else if (!(deviceExtension->DeviceFlags[i] & DFLAGS_CHANGER_INITED)){ ULONG j; - BOOLEAN isSanyo = FALSE; UCHAR vendorId[26]; // @@ -1415,7 +1414,6 @@ deviceExtension->DeviceFlags[i] |= (DFLAGS_CHANGER_INITED | DFLAGS_SANYO_ATAPI_CHANGER); deviceExtension->DiscsPresent[i] = 3; - isSanyo = TRUE; } } }

1 0

[jgardou] 53589: [PCMCIA] - remove #pragma once from pch
by jgardou＠svn.reactos.org 04 Sep '11

04 Sep '11

Author: jgardou Date: Sun Sep 4 20:32:19 2011 New Revision: 53589 URL: http://svn.reactos.org/svn/reactos?rev=53589&view=rev Log: [PCMCIA] - remove #pragma once from pch Modified: trunk/reactos/drivers/bus/pcmcia/pcmcia.h Modified: trunk/reactos/drivers/bus/pcmcia/pcmcia.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcmcia/pcmcia.… ============================================================================== --- trunk/reactos/drivers/bus/pcmcia/pcmcia.h [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/pcmcia/pcmcia.h [iso-8859-1] Sun Sep 4 20:32:19 2011 @@ -1,4 +1,3 @@ -#pragma once #include <ntifs.h> #include <wdmguid.h>

1 0

[jgardou] 53588: [CMAKE/CRT] - disable pch for now
by jgardou＠svn.reactos.org 04 Sep '11

04 Sep '11

Author: jgardou Date: Sun Sep 4 20:27:48 2011 New Revision: 53588 URL: http://svn.reactos.org/svn/reactos?rev=53588&view=rev Log: [CMAKE/CRT] - disable pch for now Modified: trunk/reactos/lib/sdk/crt/crt.cmake Modified: trunk/reactos/lib/sdk/crt/crt.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/crt.cmake?rev=… ============================================================================== --- trunk/reactos/lib/sdk/crt/crt.cmake [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/crt.cmake [iso-8859-1] Sun Sep 4 20:27:48 2011 @@ -442,5 +442,5 @@ add_library(crt ${CRT_SOURCE}) target_link_libraries(crt chkstk) set_property(TARGET crt PROPERTY COMPILE_DEFINITIONS __MINGW_IMPORT=extern USE_MSVCRT_PREFIX _MSVCRT_LIB_ _MSVCRT_ _MT) -add_pch(crt precomp.h) +#add_pch(crt precomp.h) add_dependencies(crt psdk asm)

1 0

[jgardou] 53587: [CMAKE] - revert unwanted change from 53567
by jgardou＠svn.reactos.org 04 Sep '11

04 Sep '11

Author: jgardou Date: Sun Sep 4 18:41:04 2011 New Revision: 53587 URL: http://svn.reactos.org/svn/reactos?rev=53587&view=rev Log: [CMAKE] - revert unwanted change from 53567 Modified: trunk/reactos/cmake/gcc.cmake Modified: trunk/reactos/cmake/gcc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/gcc.cmake?rev=53587&… ============================================================================== --- trunk/reactos/cmake/gcc.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/gcc.cmake [iso-8859-1] Sun Sep 4 18:41:04 2011 @@ -302,6 +302,12 @@ DEPENDS ${_header_filename} ${ARGN}) get_target_property(_src_files ${_target_name} SOURCES) add_target_compile_flags(${_target_name} "-fpch-preprocess -Winvalid-pch -Wno-error=invalid-pch") + foreach(_item in ${_src_files}) + get_source_file_property(__src_lang ${_item} LANGUAGE) + if(__src_lang STREQUAL __lang) + set_source_files_properties(${_item} PROPERTIES OBJECT_DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${_gch_filename}) + endif() + endforeach() #set dependency checking : depends on precompiled header only which already depends on deeper header set_target_properties(${_target_name} PROPERTIES IMPLICIT_DEPENDS_INCLUDE_TRANSFORM "\"${_basename}\"=;<${_basename}>=") endmacro()

1 0

[jgardou] 53586: [CMAKE] - rostests side of r53585
by jgardou＠svn.reactos.org 04 Sep '11

04 Sep '11

Author: jgardou Date: Sun Sep 4 17:33:34 2011 New Revision: 53586 URL: http://svn.reactos.org/svn/reactos?rev=53586&view=rev Log: [CMAKE] - rostests side of r53585 Modified: trunk/rostests/tests/pseh2/CMakeLists.txt trunk/rostests/winetests/comctl32/CMakeLists.txt trunk/rostests/winetests/fusion/CMakeLists.txt trunk/rostests/winetests/kernel32/CMakeLists.txt trunk/rostests/winetests/msvcrt/CMakeLists.txt trunk/rostests/winetests/ntdll/CMakeLists.txt trunk/rostests/winetests/powrprof/CMakeLists.txt trunk/rostests/winetests/rpcrt4/CMakeLists.txt trunk/rostests/winetests/setupapi/CMakeLists.txt trunk/rostests/winetests/shdocvw/CMakeLists.txt trunk/rostests/winetests/user32/CMakeLists.txt trunk/rostests/winetests/winmm/CMakeLists.txt trunk/rostests/winetests/ws2_32/CMakeLists.txt Modified: trunk/rostests/tests/pseh2/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/tests/pseh2/CMakeLists.tx… ============================================================================== --- trunk/rostests/tests/pseh2/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/tests/pseh2/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:33:34 2011 @@ -6,3 +6,7 @@ set_module_type(pseh2_test win32cui) add_importlibs(pseh2_test msvcrt kernel32 ntdll) add_cd_file(TARGET pseh2_test DESTINATION reactos/bin FOR all) + +if(NOT MSVC) + allow_warnings(pseh2_test) +endif() Modified: trunk/rostests/winetests/comctl32/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/comctl32/CMakeL… ============================================================================== --- trunk/rostests/winetests/comctl32/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/winetests/comctl32/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:33:34 2011 @@ -39,6 +39,8 @@ if(MSVC) target_link_libraries(comctl32_winetest uuid) +else() + allow_warnings(comctl32_winetest) endif() set_module_type(comctl32_winetest win32cui) Modified: trunk/rostests/winetests/fusion/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/fusion/CMakeLis… ============================================================================== --- trunk/rostests/winetests/fusion/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/winetests/fusion/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:33:34 2011 @@ -15,3 +15,7 @@ set_module_type(fusion_winetest win32cui) add_importlibs(fusion_winetest user32 msvcrt kernel32 ntdll) add_cd_file(TARGET fusion_winetest DESTINATION reactos/bin FOR all) + +if(NOT MSVC) + allow_warnings(fusion_winetest) +endif() Modified: trunk/rostests/winetests/kernel32/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/kernel32/CMakeL… ============================================================================== --- trunk/rostests/winetests/kernel32/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/winetests/kernel32/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:33:34 2011 @@ -2,6 +2,8 @@ add_definitions( -D__ROS_LONG64__ -D_DLL -D__USE_CRTIMP) + +remove_definitions(-DWINVER=0x502 -D_WIN32_IE=0x600 -D_WIN32_WINNT=0x502) set_rc_compiler() @@ -49,4 +51,6 @@ set_module_type(kernel32_winetest win32cui) add_importlibs(kernel32_winetest user32 advapi32 msvcrt kernel32 ntdll) +allow_warnings(kernel32_winetest) + add_cd_file(TARGET kernel32_winetest DESTINATION reactos/bin FOR all) Modified: trunk/rostests/winetests/msvcrt/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/msvcrt/CMakeLis… ============================================================================== --- trunk/rostests/winetests/msvcrt/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/winetests/msvcrt/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:33:34 2011 @@ -24,6 +24,8 @@ if(MSVC) target_link_libraries(msvcrt_winetest oldnames) +else() + allow_warnings(msvcrt_winetest) endif() set_module_type(msvcrt_winetest win32cui) Modified: trunk/rostests/winetests/ntdll/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/ntdll/CMakeList… ============================================================================== --- trunk/rostests/winetests/ntdll/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/winetests/ntdll/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:33:34 2011 @@ -29,3 +29,6 @@ set_module_type(ntdll_winetest win32cui) add_importlibs(ntdll_winetest user32 msvcrt kernel32 ntdll) add_cd_file(TARGET ntdll_winetest DESTINATION reactos/bin FOR all) +if(NOT MSVC) + allow_warnings(ntdll_winetest) +endif() Modified: trunk/rostests/winetests/powrprof/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/powrprof/CMakeL… ============================================================================== --- trunk/rostests/winetests/powrprof/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/winetests/powrprof/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:33:34 2011 @@ -8,3 +8,7 @@ set_module_type(powrprof_winetest win32cui) add_importlibs(powrprof_winetest advapi32 powrprof msvcrt kernel32 ntdll) add_cd_file(TARGET powrprof_winetest DESTINATION reactos/bin FOR all) + +if(NOT MSVC) + allow_warnings(powrprof_winetest) +endif() Modified: trunk/rostests/winetests/rpcrt4/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/rpcrt4/CMakeLis… ============================================================================== --- trunk/rostests/winetests/rpcrt4/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/winetests/rpcrt4/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:33:34 2011 @@ -1,5 +1,6 @@ -remove_definitions(-D_WIN32_WINNT=0x502) +remove_definitions(-DWINVER=0x502 -D_WIN32_IE=0x600 -D_WIN32_WINNT=0x502) + add_definitions(-D_WIN32_WINNT=0x500) add_definitions( @@ -44,3 +45,7 @@ set_module_type(rpcrt4_winetest win32cui) add_importlibs(rpcrt4_winetest ole32 rpcrt4 msvcrt kernel32 ntdll) add_cd_file(TARGET rpcrt4_winetest DESTINATION reactos/bin FOR all) + +if(NOT MSVC) + allow_warnings(rpcrt4_winetest) +endif() Modified: trunk/rostests/winetests/setupapi/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/setupapi/CMakeL… ============================================================================== --- trunk/rostests/winetests/setupapi/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/winetests/setupapi/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:33:34 2011 @@ -19,3 +19,7 @@ set_module_type(setupapi_winetest win32cui) add_importlibs(setupapi_winetest advapi32 setupapi user32 msvcrt kernel32 ntdll) add_cd_file(TARGET setupapi_winetest DESTINATION reactos/bin FOR all) + +if(NOT MSVC) + allow_warnings(setupapi_winetest) +endif() Modified: trunk/rostests/winetests/shdocvw/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/shdocvw/CMakeLi… ============================================================================== --- trunk/rostests/winetests/shdocvw/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/winetests/shdocvw/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:33:34 2011 @@ -15,3 +15,7 @@ set_module_type(shdocvw_winetest win32cui) add_importlibs(shdocvw_winetest gdi32 shell32 ole32 oleaut32 user32 advapi32 msvcrt kernel32 ntdll) add_cd_file(TARGET shdocvw_winetest DESTINATION reactos/bin FOR all) + +if(NOT MSVC) + allow_warnings(shdocvw_winetest) +endif() Modified: trunk/rostests/winetests/user32/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/user32/CMakeLis… ============================================================================== --- trunk/rostests/winetests/user32/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/winetests/user32/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:33:34 2011 @@ -38,3 +38,7 @@ set_module_type(user32_winetest win32cui) add_importlibs(user32_winetest user32 gdi32 advapi32 msvcrt kernel32 ntdll) add_cd_file(TARGET user32_winetest DESTINATION reactos/bin FOR all) + +if(NOT MSVC) + allow_warnings(user32_winetest) +endif() Modified: trunk/rostests/winetests/winmm/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/winmm/CMakeList… ============================================================================== --- trunk/rostests/winetests/winmm/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/winetests/winmm/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:33:34 2011 @@ -17,3 +17,7 @@ set_module_type(winmm_winetest win32cui) add_importlibs(winmm_winetest winmm user32 msvcrt kernel32 ntdll) add_cd_file(TARGET winmm_winetest DESTINATION reactos/bin FOR all) + +if(NOT MSVC) + allow_warnings(winmm_winetest) +endif() Modified: trunk/rostests/winetests/ws2_32/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/ws2_32/CMakeLis… ============================================================================== --- trunk/rostests/winetests/ws2_32/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/winetests/ws2_32/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:33:34 2011 @@ -8,3 +8,7 @@ set_module_type(ws2_32_winetest win32cui) add_importlibs(ws2_32_winetest ws2_32 user32 msvcrt kernel32 ntdll) add_cd_file(TARGET ws2_32_winetest DESTINATION reactos/bin FOR all) + +if(NOT MSVC) + allow_warnings(ws2_32_winetest) +endif()

1 0

[jgardou] 53585: [CMAKE] - enable -Werror by default on gcc build
by jgardou＠svn.reactos.org 04 Sep '11

04 Sep '11

Author: jgardou Date: Sun Sep 4 17:32:30 2011 New Revision: 53585 URL: http://svn.reactos.org/svn/reactos?rev=53585&view=rev Log: [CMAKE] - enable -Werror by default on gcc build Modified: trunk/reactos/base/applications/winhlp32/CMakeLists.txt trunk/reactos/base/applications/wordpad/CMakeLists.txt trunk/reactos/base/applications/write/CMakeLists.txt trunk/reactos/cmake/gcc.cmake trunk/reactos/dll/3rdparty/libtiff/CMakeLists.txt trunk/reactos/dll/3rdparty/libxslt/CMakeLists.txt trunk/reactos/dll/3rdparty/mesa32/CMakeLists.txt trunk/reactos/dll/directx/quartz/CMakeLists.txt trunk/reactos/dll/directx/wine/wined3d/CMakeLists.txt trunk/reactos/dll/win32/cabinet/CMakeLists.txt trunk/reactos/dll/win32/itss/CMakeLists.txt trunk/reactos/dll/win32/jscript/CMakeLists.txt trunk/reactos/dll/win32/localspl/CMakeLists.txt trunk/reactos/dll/win32/mciseq/CMakeLists.txt trunk/reactos/dll/win32/mciwave/CMakeLists.txt trunk/reactos/dll/win32/rpcrt4/CMakeLists.txt trunk/reactos/dll/win32/shdocvw/CMakeLists.txt trunk/reactos/dll/win32/winhttp/CMakeLists.txt trunk/reactos/dll/win32/wininet/CMakeLists.txt trunk/reactos/lib/3rdparty/libxml2/CMakeLists.txt trunk/reactos/lib/drivers/lwip/CMakeLists.txt trunk/reactos/lib/rossym_new/CMakeLists.txt trunk/reactos/lib/sdk/crt/msvcrtex.cmake Modified: trunk/reactos/base/applications/winhlp32/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/winhlp32… ============================================================================== --- trunk/reactos/base/applications/winhlp32/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/base/applications/winhlp32/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -22,3 +22,7 @@ target_link_libraries(winhlp32 wine) add_importlibs(winhlp32 user32 gdi32 shell32 comctl32 comdlg32 msvcrt kernel32 ntdll) add_cd_file(TARGET winhlp32 DESTINATION reactos FOR all) + +if(NOT MSVC) + allow_warnings(winhlp32) +endif() Modified: trunk/reactos/base/applications/wordpad/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/wordpad/… ============================================================================== --- trunk/reactos/base/applications/wordpad/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/base/applications/wordpad/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -18,3 +18,7 @@ target_link_libraries(wordpad wine uuid) add_importlibs(wordpad comdlg32 ole32 shell32 user32 gdi32 advapi32 comctl32 msvcrt kernel32 ntdll) add_cd_file(TARGET wordpad DESTINATION reactos/system32 FOR all) + +if(NOT MSVC) + allow_warnings(wordpad) +endif() Modified: trunk/reactos/base/applications/write/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/write/CM… ============================================================================== --- trunk/reactos/base/applications/write/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/base/applications/write/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -5,3 +5,7 @@ set_module_type(write win32gui UNICODE) add_importlibs(write user32 gdi32 msvcrt kernel32) add_cd_file(TARGET write DESTINATION reactos/system32 FOR all) + +if(NOT MSVC) + allow_warnings(write) +endif() Modified: trunk/reactos/cmake/gcc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/gcc.cmake?rev=53585&… ============================================================================== --- trunk/reactos/cmake/gcc.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/gcc.cmake [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -4,6 +4,9 @@ # Debugging (Note: DWARF-4 on 4.5.1 when we ship) add_compile_flags("-gdwarf-2 -g2 -femit-struct-debug-detailed=none -feliminate-unused-debug-types") + +# Do not allow warnings +add_compile_flags("-Werror") # For some reason, cmake sets -fPIC, and we don't want it string(REPLACE "-fPIC" "" CMAKE_SHARED_LIBRARY_ASM_FLAGS ${CMAKE_SHARED_LIBRARY_ASM_FLAGS}) @@ -349,3 +352,7 @@ add_custom_target(${_target_name} ALL DEPENDS ${_binary_file}) endfunction() + +function(allow_warnings __module) + add_target_compile_flags(${__module} -Wno-error) +endfunction() Modified: trunk/reactos/dll/3rdparty/libtiff/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libtiff/CMake… ============================================================================== --- trunk/reactos/dll/3rdparty/libtiff/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/3rdparty/libtiff/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -50,8 +50,12 @@ tif_write.c tif_zip.c) -set_entrypoint(libtiff 0) +set_module_type(libtiff win32dll ENTRYPOINT 0) target_link_libraries(libtiff zlib getopt) add_importlibs(libtiff user32 msvcrt kernel32) add_dependencies(libtiff psdk) add_cd_file(TARGET libtiff DESTINATION reactos/system32 FOR all) + +if(NOT MSVC) + allow_warnings(libtiff) +endif() Modified: trunk/reactos/dll/3rdparty/libxslt/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libxslt/CMake… ============================================================================== --- trunk/reactos/dll/3rdparty/libxslt/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/3rdparty/libxslt/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -44,3 +44,7 @@ add_dependencies(libxslt psdk) add_pch(libxslt libxslt.h) add_cd_file(TARGET libxslt DESTINATION reactos/system32 FOR all) + +if(NOT MSVC) + allow_warnings(libxslt) +endif() Modified: trunk/reactos/dll/3rdparty/mesa32/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/mesa32/CMakeL… ============================================================================== --- trunk/reactos/dll/3rdparty/mesa32/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/3rdparty/mesa32/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -260,7 +260,11 @@ add_library(mesa32 SHARED ${SOURCE}) add_pch(mesa32 src/main/glheader.h) -set_entrypoint(mesa32 0) +set_module_type(mesa32 win32dll ENTRYPOINT 0) add_importlibs(mesa32 gdi32 user32 msvcrt kernel32 ntdll) add_dependencies(mesa32 psdk) add_cd_file(TARGET mesa32 DESTINATION reactos/system32 FOR all) + +if(NOT MSVC) + allow_warnings(mesa32) +endif() Modified: trunk/reactos/dll/directx/quartz/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/quartz/CMakeLi… ============================================================================== --- trunk/reactos/dll/directx/quartz/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/directx/quartz/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -72,3 +72,7 @@ add_pch(quartz quartz_private.h) add_cd_file(TARGET quartz DESTINATION reactos/system32 FOR all) + +if(NOT MSVC) + allow_warnings(quartz) +endif() Modified: trunk/reactos/dll/directx/wine/wined3d/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/wined3d/C… ============================================================================== --- trunk/reactos/dll/directx/wine/wined3d/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/directx/wine/wined3d/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -70,3 +70,7 @@ add_pch(wined3d wined3d_private.h) add_cd_file(TARGET wined3d DESTINATION reactos/system32 FOR all) add_importlib_target(wined3d.spec) + +if(NOT MSVC) + allow_warnings(wined3d) +endif() Modified: trunk/reactos/dll/win32/cabinet/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/cabinet/CMakeLis… ============================================================================== --- trunk/reactos/dll/win32/cabinet/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/cabinet/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -15,7 +15,7 @@ add_library(cabinet SHARED ${SOURCE}) -set_entrypoint(cabinet 0) +set_module_type(cabinet win32dll ENTRYPOINT 0) target_link_libraries(cabinet wine) add_importlibs(cabinet kernel32 ntdll) add_importlib_target(cabinet.spec) Modified: trunk/reactos/dll/win32/itss/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/itss/CMakeLists.… ============================================================================== --- trunk/reactos/dll/win32/itss/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/itss/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -24,6 +24,8 @@ target_link_libraries(itss uuid wine) if(MSVC) target_link_libraries(itss itss_guid) +else() + allow_warnings(itss) endif() add_importlibs(itss Modified: trunk/reactos/dll/win32/jscript/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/jscript/CMakeLis… ============================================================================== --- trunk/reactos/dll/win32/jscript/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/jscript/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -62,3 +62,7 @@ add_pch(jscript jscript.h) add_dependencies(jscript jsglobal) add_cd_file(TARGET jscript DESTINATION reactos/system32 FOR all) + +if(NOT MSVC) + allow_warnings(jscript) +endif() Modified: trunk/reactos/dll/win32/localspl/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/localspl/CMakeLi… ============================================================================== --- trunk/reactos/dll/win32/localspl/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/localspl/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -33,3 +33,7 @@ ntdll) add_cd_file(TARGET localspl DESTINATION reactos/system32 FOR all) + +if(NOT MSVC) + allow_warnings(localspl) +endif() Modified: trunk/reactos/dll/win32/mciseq/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/mciseq/CMakeList… ============================================================================== --- trunk/reactos/dll/win32/mciseq/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/mciseq/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -10,8 +10,13 @@ add_library(mciseq SHARED ${SOURCE}) -set_entrypoint(mciseq 0) +set_module_type(mciseq win32dll ENTRYPOINT 0) + target_link_libraries(mciseq wine) add_importlibs(mciseq winmm user32 kernel32 ntdll msvcrt) add_dependencies(mciseq psdk) add_cd_file(TARGET mciseq DESTINATION reactos/system32 FOR all) + +if(NOT MSVC) + allow_warnings(mciseq) +endif() Modified: trunk/reactos/dll/win32/mciwave/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/mciwave/CMakeLis… ============================================================================== --- trunk/reactos/dll/win32/mciwave/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/mciwave/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -13,8 +13,13 @@ add_library(mciwave SHARED ${SOURCE}) -set_entrypoint(mciwave 0) +set_module_type(mciwave win32dll ENTRYPOINT 0) + target_link_libraries(mciwave wine) add_importlibs(mciwave user32 winmm msvcrt kernel32 ntdll) add_dependencies(mciwave psdk) add_cd_file(TARGET mciwave DESTINATION reactos/system32 FOR all) + +if(NOT MSVC) + allow_warnings(mciwave) +endif() Modified: trunk/reactos/dll/win32/rpcrt4/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/CMakeList… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/rpcrt4/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -50,3 +50,7 @@ add_importlibs(rpcrt4 msvcrt advapi32 ws2_32 kernel32 ntdll) add_cd_file(TARGET rpcrt4 DESTINATION reactos/system32 FOR all) add_importlib_target(rpcrt4.spec) + +if(NOT MSVC) + allow_warnings(rpcrt4) +endif() Modified: trunk/reactos/dll/win32/shdocvw/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shdocvw/CMakeLis… ============================================================================== --- trunk/reactos/dll/win32/shdocvw/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shdocvw/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -53,3 +53,7 @@ add_pch(shdocvw shdocvw.h) add_cd_file(TARGET shdocvw DESTINATION reactos/system32 FOR all) add_importlib_target(shdocvw.spec) + +if(NOT MSVC) + allow_warnings(shdocvw) +endif() Modified: trunk/reactos/dll/win32/winhttp/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/winhttp/CMakeLis… ============================================================================== --- trunk/reactos/dll/win32/winhttp/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/winhttp/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -22,3 +22,7 @@ add_importlibs(winhttp shlwapi wininet ws2_32 msvcrt advapi32 kernel32 ntdll) add_importlib_target(winhttp.spec) add_cd_file(TARGET winhttp DESTINATION reactos/system32 FOR all) + +if(NOT MSVC) + allow_warnings(winhttp) +endif() Modified: trunk/reactos/dll/win32/wininet/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wininet/CMakeLis… ============================================================================== --- trunk/reactos/dll/win32/wininet/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/wininet/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -34,3 +34,7 @@ add_importlibs(wininet mpr shlwapi shell32 user32 advapi32 ws2_32 msvcrt kernel32 ntdll) add_cd_file(TARGET wininet DESTINATION reactos/system32 FOR all) add_importlib_target(wininet.spec) + +if(NOT MSVC) + allow_warnings(wininet) +endif() Modified: trunk/reactos/lib/3rdparty/libxml2/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/libxml2/CMake… ============================================================================== --- trunk/reactos/lib/3rdparty/libxml2/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/lib/3rdparty/libxml2/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -59,3 +59,7 @@ add_library(libxml2 ${SOURCE}) target_link_libraries(libxml2 oldnames) add_dependencies(libxml2 psdk) + +if(NOT MSVC) + allow_warnings(libxml2) +endif() Modified: trunk/reactos/lib/drivers/lwip/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/drivers/lwip/CMakeList… ============================================================================== --- trunk/reactos/lib/drivers/lwip/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/lib/drivers/lwip/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -58,3 +58,6 @@ add_library(lwip ${SOURCE}) add_dependencies(lwip bugcodes) +if(NOT MSVC) + allow_warnings(lwip) +endif() Modified: trunk/reactos/lib/rossym_new/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rossym_new/CMakeLists.… ============================================================================== --- trunk/reactos/lib/rossym_new/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/lib/rossym_new/CMakeLists.txt [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -22,4 +22,5 @@ add_library(rossym ${SOURCE}) add_pch(rossym precomp.h) add_dependencies(rossym psdk bugcodes) + allow_warnings(rossym) endif() Modified: trunk/reactos/lib/sdk/crt/msvcrtex.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/msvcrtex.cmake… ============================================================================== --- trunk/reactos/lib/sdk/crt/msvcrtex.cmake [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/msvcrtex.cmake [iso-8859-1] Sun Sep 4 17:32:30 2011 @@ -68,6 +68,7 @@ if(NOT MSVC) target_link_libraries(msvcrtex oldnames) + allow_warnings(msvcrtex) endif() add_dependencies(msvcrtex psdk asm)

1 0

[jgardou] 53584: [CMAKE/KDBG] - fix warning
by jgardou＠svn.reactos.org 04 Sep '11

04 Sep '11

Author: jgardou Date: Sun Sep 4 17:31:12 2011 New Revision: 53584 URL: http://svn.reactos.org/svn/reactos?rev=53584&view=rev Log: [CMAKE/KDBG] - fix warning Modified: trunk/reactos/ntoskrnl/kdbg/kdb_symbols.cmake.c Modified: trunk/reactos/ntoskrnl/kdbg/kdb_symbols.cmake.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kdbg/kdb_symbols.… ============================================================================== --- trunk/reactos/ntoskrnl/kdbg/kdb_symbols.cmake.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kdbg/kdb_symbols.cmake.c [iso-8859-1] Sun Sep 4 17:31:12 2011 @@ -653,7 +653,7 @@ return ExFreePool(Area); } -static BOOLEAN KdbpSymReadMem(PVOID FileContext, PVOID TargetDebug, PVOID SourceMem, ULONG Size) +static BOOLEAN KdbpSymReadMem(PVOID FileContext, ULONG_PTR* TargetDebug, PVOID SourceMem, ULONG Size) { return NT_SUCCESS(KdbpSafeReadMemory(TargetDebug, SourceMem, Size)); }

1 0

[jgardou] 53583: [WIN32K] - Avoid invalid memory write. See issue #5969 for more details.
by jgardou＠svn.reactos.org 04 Sep '11

04 Sep '11

Author: jgardou Date: Sun Sep 4 15:58:48 2011 New Revision: 53583 URL: http://svn.reactos.org/svn/reactos?rev=53583&view=rev Log: [WIN32K] - Avoid invalid memory write. See issue #5969 for more details. Modified: trunk/reactos/subsystems/win32/win32k/ntuser/misc.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/misc.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/misc.c [iso-8859-1] Sun Sep 4 15:58:48 2011 @@ -497,11 +497,14 @@ pti->pClientInfo = pci; _SEH2_TRY { - ProbeForWrite( Teb, - sizeof(TEB), - sizeof(ULONG)); - - Teb->Win32ThreadInfo = (PW32THREAD) pti; + if(Teb) + { + ProbeForWrite( Teb, + sizeof(TEB), + sizeof(ULONG)); + + Teb->Win32ThreadInfo = (PW32THREAD) pti; + } pci->ppi = ppi; pci->fsHooks = pti->fsHooks;

1 0

[jgardou] 53582: [RPCRT4] - remove ros hack, obsoleted by r53580 and r53581
by jgardou＠svn.reactos.org 04 Sep '11

04 Sep '11

Author: jgardou Date: Sun Sep 4 15:37:42 2011 New Revision: 53582 URL: http://svn.reactos.org/svn/reactos?rev=53582&view=rev Log: [RPCRT4] - remove ros hack, obsoleted by r53580 and r53581 Modified: trunk/reactos/dll/win32/rpcrt4/cpsf.c Modified: trunk/reactos/dll/win32/rpcrt4/cpsf.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/cpsf.c?re… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/cpsf.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/rpcrt4/cpsf.c [iso-8859-1] Sun Sep 4 15:37:42 2011 @@ -241,7 +241,7 @@ TRACE("(%p,%p,%s)\n", hDll, pProxyFileList, debugstr_guid(pclsid)); - //if (!hDll) return E_HANDLE; + if (!hDll) return E_HANDLE; if (!*pProxyFileList) return E_NOINTERFACE; if (pclsid)

1 0

[jgardou] 53581: [STI] - we have an entry point.
by jgardou＠svn.reactos.org 04 Sep '11

04 Sep '11

Author: jgardou Date: Sun Sep 4 15:29:15 2011 New Revision: 53581 URL: http://svn.reactos.org/svn/reactos?rev=53581&view=rev Log: [STI] - we have an entry point. Modified: trunk/reactos/dll/win32/sti/CMakeLists.txt trunk/reactos/dll/win32/sti/sti.rbuild Modified: trunk/reactos/dll/win32/sti/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/sti/CMakeLists.t… ============================================================================== --- trunk/reactos/dll/win32/sti/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/sti/CMakeLists.txt [iso-8859-1] Sun Sep 4 15:29:15 2011 @@ -24,7 +24,7 @@ add_library(sti SHARED ${SOURCE}) -set_entrypoint(sti 0) +set_module_type(sti win32dll) target_link_libraries(sti wine Modified: trunk/reactos/dll/win32/sti/sti.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/sti/sti.rbuild?r… ============================================================================== --- trunk/reactos/dll/win32/sti/sti.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/sti/sti.rbuild [iso-8859-1] Sun Sep 4 15:29:15 2011 @@ -1,7 +1,7 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <group> -<module name="sti" type="win32dll" baseaddress="${BASEADDRESS_STI}" installbase="system32" installname="sti.dll" allowwarnings="true" entrypoint="0"> +<module name="sti" type="win32dll" baseaddress="${BASEADDRESS_STI}" installbase="system32" installname="sti.dll" allowwarnings="true"> <autoregister infsection="OleControlDlls" type="DllRegisterServer" /> <importlibrary definition="sti.spec" /> <include base="sti">.</include>

1 0

← Newer
1
...
30
31
32
33
34
35
36
...
40
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs September 2011