Ros-diffs September 2011

ros-diffs@reactos.org

20 participants
399 discussions

[dgorbachev] 53841: [FREELDR] Add FREELDR_MEMORY_DESCRIPTOR structure using TYPE_OF_MEMORY instead of MEMORY_TYPE. Use it in place of MEMORY_DESCRIPTOR. Undo r53837 changes.
by dgorbachev＠svn.reactos.org 24 Sep '11

24 Sep '11

Author: dgorbachev Date: Sat Sep 24 17:25:29 2011 New Revision: 53841 URL: http://svn.reactos.org/svn/reactos?rev=53841&view=rev Log: [FREELDR] Add FREELDR_MEMORY_DESCRIPTOR structure using TYPE_OF_MEMORY instead of MEMORY_TYPE. Use it in place of MEMORY_DESCRIPTOR. Undo r53837 changes. Modified: trunk/reactos/boot/freeldr/freeldr/arch/arm/macharm.c trunk/reactos/boot/freeldr/freeldr/arch/i386/pcdisk.c trunk/reactos/boot/freeldr/freeldr/arch/i386/pcmem.c trunk/reactos/boot/freeldr/freeldr/arch/i386/xboxmem.c trunk/reactos/boot/freeldr/freeldr/include/arcemul.h trunk/reactos/boot/freeldr/freeldr/include/arch/i386/machxbox.h trunk/reactos/boot/freeldr/freeldr/include/arch/pc/machpc.h trunk/reactos/boot/freeldr/freeldr/include/machine.h trunk/reactos/boot/freeldr/freeldr/include/mm.h trunk/reactos/boot/freeldr/freeldr/mm/meminit.c Modified: trunk/reactos/boot/freeldr/freeldr/arch/arm/macharm.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/arch/arm/macharm.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/arch/arm/macharm.c [iso-8859-1] Sat Sep 24 17:25:29 2011 @@ -143,9 +143,9 @@ return RootNode; } -MEMORY_DESCRIPTOR ArmMemoryMap[32]; - -PMEMORY_DESCRIPTOR +FREELDR_MEMORY_DESCRIPTOR ArmMemoryMap[32]; + +PFREELDR_MEMORY_DESCRIPTOR ArmMemGetMemoryMap(OUT ULONG *MemoryMapSize) { ASSERT(ArmBoardBlock->MemoryMapEntryCount <= 32); Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/pcdisk.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/arch/i386/pcdisk.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/arch/i386/pcdisk.c [iso-8859-1] Sat Sep 24 17:25:29 2011 @@ -271,6 +271,7 @@ BOOLEAN PcDiskReadLogicalSectors(UCHAR DriveNumber, ULONGLONG SectorNumber, ULONG SectorCount, PVOID Buffer) { + BOOLEAN ExtensionsSupported; TRACE("PcDiskReadLogicalSectors() DriveNumber: 0x%x SectorNumber: %I64d SectorCount: %d Buffer: 0x%x\n", DriveNumber, SectorNumber, SectorCount, Buffer); @@ -279,9 +280,11 @@ // If so then check to see if Int13 extensions work // If they do then use them, otherwise default back to BIOS calls // - if ((DriveNumber >= 0x80) && DiskInt13ExtensionsSupported(DriveNumber)) - { - TRACE("Using Int 13 Extensions for read. DiskInt13ExtensionsSupported(%d) = %s\n", DriveNumber, DiskInt13ExtensionsSupported(DriveNumber) ? "TRUE" : "FALSE"); + ExtensionsSupported = DiskInt13ExtensionsSupported(DriveNumber); + + if ((DriveNumber >= 0x80) && ExtensionsSupported) + { + TRACE("Using Int 13 Extensions for read. DiskInt13ExtensionsSupported(%d) = %s\n", DriveNumber, ExtensionsSupported ? "TRUE" : "FALSE"); // // LBA is easy, nothing to calculate Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/pcmem.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/arch/i386/pcmem.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/arch/i386/pcmem.c [iso-8859-1] Sat Sep 24 17:25:29 2011 @@ -44,7 +44,7 @@ BIOS_MEMORY_MAP PcBiosMemoryMap[MAX_BIOS_DESCRIPTORS]; ULONG PcBiosMapCount; -MEMORY_DESCRIPTOR PcMemoryMap[MAX_BIOS_DESCRIPTORS + 1] = +FREELDR_MEMORY_DESCRIPTOR PcMemoryMap[MAX_BIOS_DESCRIPTORS + 1] = { { LoaderFirmwarePermanent, 0x00, 1 }, // realmode int vectors { LoaderFirmwareTemporary, 0x01, FREELDR_BASE_PAGE - 1 }, // freeldr stack + cmdline @@ -60,7 +60,7 @@ ULONG AddMemoryDescriptor( - IN OUT PMEMORY_DESCRIPTOR List, + IN OUT PFREELDR_MEMORY_DESCRIPTOR List, IN ULONG MaxCount, IN PFN_NUMBER BasePage, IN PFN_NUMBER PageCount, @@ -189,7 +189,7 @@ static ULONG -PcMemGetBiosMemoryMap(PMEMORY_DESCRIPTOR MemoryMap, ULONG MaxMemoryMapSize) +PcMemGetBiosMemoryMap(PFREELDR_MEMORY_DESCRIPTOR MemoryMap, ULONG MaxMemoryMapSize) { REGS Regs; ULONG MapCount = 0; @@ -292,7 +292,7 @@ } -PMEMORY_DESCRIPTOR +PFREELDR_MEMORY_DESCRIPTOR PcMemGetMemoryMap(ULONG *MemoryMapSize) { ULONG i, EntryCount; Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/xboxmem.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/arch/i386/xboxmem.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/arch/i386/xboxmem.c [iso-8859-1] Sat Sep 24 17:25:29 2011 @@ -75,9 +75,9 @@ AvailableMemoryMb = InstalledMemoryMb; } -MEMORY_DESCRIPTOR BiosMemoryMap[2]; +FREELDR_MEMORY_DESCRIPTOR BiosMemoryMap[2]; -PMEMORY_DESCRIPTOR +PFREELDR_MEMORY_DESCRIPTOR XboxMemGetMemoryMap(ULONG *MemoryMapSize) { /* Synthesize memory map */ Modified: trunk/reactos/boot/freeldr/freeldr/include/arcemul.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/inclu… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/include/arcemul.h [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/include/arcemul.h [iso-8859-1] Sat Sep 24 17:25:29 2011 @@ -34,10 +34,6 @@ VOID* ConfigurationData, CONFIGURATION_COMPONENT* Component); -/* mm.c */ -const MEMORY_DESCRIPTOR* -ArcGetMemoryDescriptor(const MEMORY_DESCRIPTOR* Current); - /* time.c */ TIMEINFO* ArcGetTime(VOID); ULONG ArcGetRelativeTime(VOID); Modified: trunk/reactos/boot/freeldr/freeldr/include/arch/i386/machxbox.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/inclu… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/include/arch/i386/machxbox.h [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/include/arch/i386/machxbox.h [iso-8859-1] Sat Sep 24 17:25:29 2011 @@ -49,7 +49,7 @@ VOID XboxMemInit(VOID); PVOID XboxMemReserveMemory(ULONG MbToReserve); -PMEMORY_DESCRIPTOR XboxMemGetMemoryMap(ULONG *MemoryMapSize); +PFREELDR_MEMORY_DESCRIPTOR XboxMemGetMemoryMap(ULONG *MemoryMapSize); BOOLEAN XboxDiskReadLogicalSectors(UCHAR DriveNumber, ULONGLONG SectorNumber, ULONG SectorCount, PVOID Buffer); BOOLEAN XboxDiskGetPartitionEntry(UCHAR DriveNumber, ULONG PartitionNumber, PPARTITION_TABLE_ENTRY PartitionTableEntry); Modified: trunk/reactos/boot/freeldr/freeldr/include/arch/pc/machpc.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/inclu… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/include/arch/pc/machpc.h [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/include/arch/pc/machpc.h [iso-8859-1] Sat Sep 24 17:25:29 2011 @@ -46,7 +46,7 @@ VOID PcVideoPrepareForReactOS(IN BOOLEAN Setup); VOID PcPrepareForReactOS(IN BOOLEAN Setup); -PMEMORY_DESCRIPTOR PcMemGetMemoryMap(ULONG *MemoryMapSize); +PFREELDR_MEMORY_DESCRIPTOR PcMemGetMemoryMap(ULONG *MemoryMapSize); BOOLEAN PcDiskGetBootPath(char *BootPath, unsigned Size); BOOLEAN PcDiskReadLogicalSectors(UCHAR DriveNumber, ULONGLONG SectorNumber, ULONG SectorCount, PVOID Buffer); Modified: trunk/reactos/boot/freeldr/freeldr/include/machine.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/inclu… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/include/machine.h [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/include/machine.h [iso-8859-1] Sat Sep 24 17:25:29 2011 @@ -57,8 +57,8 @@ VOID (*Beep)(VOID); VOID (*PrepareForReactOS)(IN BOOLEAN Setup); - MEMORY_DESCRIPTOR* (*GetMemoryDescriptor)(MEMORY_DESCRIPTOR* Current); - PMEMORY_DESCRIPTOR (*GetMemoryMap)(PULONG MaxMemoryMapSize); + FREELDR_MEMORY_DESCRIPTOR* (*GetMemoryDescriptor)(FREELDR_MEMORY_DESCRIPTOR* Current); + PFREELDR_MEMORY_DESCRIPTOR (*GetMemoryMap)(PULONG MaxMemoryMapSize); BOOLEAN (*DiskGetBootPath)(char *BootPath, unsigned Size); BOOLEAN (*DiskReadLogicalSectors)(UCHAR DriveNumber, ULONGLONG SectorNumber, ULONG SectorCount, PVOID Buffer); Modified: trunk/reactos/boot/freeldr/freeldr/include/mm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/inclu… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/include/mm.h [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/include/mm.h [iso-8859-1] Sat Sep 24 17:25:29 2011 @@ -26,6 +26,13 @@ BiosMemoryAcpiReclaim, BiosMemoryAcpiNvs } BIOS_MEMORY_TYPE; + +typedef struct _FREELDR_MEMORY_DESCRIPTOR +{ + TYPE_OF_MEMORY MemoryType; + PFN_NUMBER BasePage; + PFN_NUMBER PageCount; +} FREELDR_MEMORY_DESCRIPTOR, *PFREELDR_MEMORY_DESCRIPTOR; #include <pshpack1.h> typedef struct Modified: trunk/reactos/boot/freeldr/freeldr/mm/meminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/mm/me… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/mm/meminit.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/mm/meminit.c [iso-8859-1] Sat Sep 24 17:25:29 2011 @@ -59,7 +59,7 @@ ULONG MmLowestPhysicalPage = 0xFFFFFFFF; ULONG MmHighestPhysicalPage = 0; -PMEMORY_DESCRIPTOR BiosMemoryMap; +PFREELDR_MEMORY_DESCRIPTOR BiosMemoryMap; ULONG BiosMemoryMapEntryCount; extern ULONG_PTR MmHeapPointer; @@ -67,11 +67,11 @@ ULONG AddMemoryDescriptor( - IN OUT PMEMORY_DESCRIPTOR List, + IN OUT PFREELDR_MEMORY_DESCRIPTOR List, IN ULONG MaxCount, IN PFN_NUMBER BasePage, IN PFN_NUMBER PageCount, - IN MEMORY_TYPE MemoryType) + IN TYPE_OF_MEMORY MemoryType) { ULONG i, c; PFN_NUMBER NextBase; @@ -147,8 +147,8 @@ return c; } -const MEMORY_DESCRIPTOR* -ArcGetMemoryDescriptor(const MEMORY_DESCRIPTOR* Current) +const FREELDR_MEMORY_DESCRIPTOR* +ArcGetMemoryDescriptor(const FREELDR_MEMORY_DESCRIPTOR* Current) { if (Current == NULL) { @@ -166,7 +166,7 @@ BOOLEAN MmInitializeMemoryManager(VOID) { #if DBG - const MEMORY_DESCRIPTOR* MemoryDescriptor = NULL; + const FREELDR_MEMORY_DESCRIPTOR* MemoryDescriptor = NULL; #endif TRACE("Initializing Memory Manager.\n"); @@ -239,7 +239,7 @@ ULONG MmGetAddressablePageCountIncludingHoles(VOID) { - const MEMORY_DESCRIPTOR* MemoryDescriptor = NULL; + const FREELDR_MEMORY_DESCRIPTOR* MemoryDescriptor = NULL; ULONG PageCount; // @@ -255,7 +255,7 @@ // // Yes, remember it if this is real memory // - if (MemoryDescriptor->MemoryType == MemoryFree) + if (MemoryDescriptor->MemoryType == LoaderFree) MmHighestPhysicalPage = MemoryDescriptor->BasePage + MemoryDescriptor->PageCount; } @@ -279,7 +279,7 @@ PVOID MmFindLocationForPageLookupTable(ULONG TotalPageCount) { - const MEMORY_DESCRIPTOR* MemoryDescriptor = NULL; + const FREELDR_MEMORY_DESCRIPTOR* MemoryDescriptor = NULL; ULONG PageLookupTableSize; ULONG PageLookupTablePages; ULONG PageLookupTableStartPage = 0; @@ -293,7 +293,7 @@ while ((MemoryDescriptor = ArcGetMemoryDescriptor(MemoryDescriptor)) != NULL) { // Continue, if memory is not free - if (MemoryDescriptor->MemoryType != MemoryFree) continue; + if (MemoryDescriptor->MemoryType != LoaderFree) continue; // Continue, if the block is not big enough? if (MemoryDescriptor->PageCount < PageLookupTablePages) continue; @@ -318,7 +318,7 @@ VOID MmInitPageLookupTable(PVOID PageLookupTable, ULONG TotalPageCount) { - const MEMORY_DESCRIPTOR* MemoryDescriptor = NULL; + const FREELDR_MEMORY_DESCRIPTOR* MemoryDescriptor = NULL; TYPE_OF_MEMORY MemoryMapPageAllocated; ULONG PageLookupTableStartPage; ULONG PageLookupTablePageCount;

1 0

[akhaldi] 53840: [FREELDR/SETUPLDR] * Add _dbg versions of freeldr_pe and setupldr_pe per Dmitry's request. They retain debug info, and they're compiled on-demand (not included in the normal build).
by akhaldi＠svn.reactos.org 24 Sep '11

24 Sep '11

Author: akhaldi Date: Sat Sep 24 16:08:37 2011 New Revision: 53840 URL: http://svn.reactos.org/svn/reactos?rev=53840&view=rev Log: [FREELDR/SETUPLDR] * Add _dbg versions of freeldr_pe and setupldr_pe per Dmitry's request. They retain debug info, and they're compiled on-demand (not included in the normal build). Modified: trunk/reactos/boot/freeldr/freeldr/CMakeLists.txt Modified: trunk/reactos/boot/freeldr/freeldr/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/CMake… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/CMakeLists.txt [iso-8859-1] Sat Sep 24 16:08:37 2011 @@ -57,7 +57,6 @@ reactos/arcname.c reactos/archwsup.c reactos/binhive.c - ui/directui.c ui/gui.c ui/minitui.c @@ -72,8 +71,7 @@ windows/peloader.c windows/winldr.c windows/wlmemory.c - windows/wlregistry.c -) + windows/wlregistry.c) if(ARCH MATCHES i386) list(APPEND FREELDR_COMMON_SOURCE @@ -155,23 +153,30 @@ bootmgr.c # This file is compiled with custom definitions freeldr.c rtl/bget.c - rtl/libsupp.c -) + rtl/libsupp.c) add_executable(freeldr_pe ${FREELDR_BASE_SOURCE}) +add_executable(freeldr_pe_dbg EXCLUDE_FROM_ALL ${FREELDR_BASE_SOURCE}) if(NOT MSVC) set_target_properties(freeldr_pe PROPERTIES LINK_FLAGS "-Wl,--strip-all,--exclude-all-symbols,--file-alignment,0x1000,-T,${CMAKE_CURRENT_SOURCE_DIR}/freeldr_i386.lnk") + set_target_properties(freeldr_pe_dbg PROPERTIES LINK_FLAGS "-Wl,--exclude-all-symbols,--file-alignment,0x1000,-T,${CMAKE_CURRENT_SOURCE_DIR}/freeldr_i386.lnk") else() set_target_properties(freeldr_pe PROPERTIES LINK_FLAGS "/ignore:4078 /ignore:4254 /DRIVER /FIXED /ALIGN:0x400 /SECTION:.text,ERW /SECTION:.data,RW /MERGE:.text16=.text /MERGE:.data=.text /MERGE:.rdata=.text /MERGE:.bss=.text /SUBSYSTEM:BOOT_APPLICATION") + set_target_properties(freeldr_pe_dbg PROPERTIES LINK_FLAGS "/ignore:4078 /ignore:4254 /DRIVER /FIXED /ALIGN:0x400 /SECTION:.text,ERW /SECTION:.data,RW /MERGE:.text16=.text /MERGE:.data=.text /MERGE:.rdata=.text /MERGE:.bss=.text /SUBSYSTEM:BOOT_APPLICATION") endif() set_image_base(freeldr_pe 0x10000) set_subsystem(freeldr_pe native) set_entrypoint(freeldr_pe RealEntryPoint) +set_image_base(freeldr_pe_dbg 0x10000) +set_subsystem(freeldr_pe_dbg native) +set_entrypoint(freeldr_pe_dbg RealEntryPoint) + if(ARCH MATCHES i386) target_link_libraries(freeldr_pe mini_hal) + target_link_libraries(freeldr_pe_dbg mini_hal) endif() target_link_libraries(freeldr_pe @@ -182,8 +187,18 @@ rtl libcntpr) +target_link_libraries(freeldr_pe_dbg + freeldr_common + cportlib + rossym + cmlib + rtl + libcntpr) + add_pch(freeldr_pe include/freeldr.h) + add_dependencies(freeldr_pe asm) +add_dependencies(freeldr_pe_dbg asm) concatenate_files( ${CMAKE_CURRENT_BINARY_DIR}/frldr16.bin @@ -204,19 +219,27 @@ endif() add_executable(setupldr_pe ${FREELDR_BASE_SOURCE} ${SETUPLDR_SOURCE}) +add_executable(setupldr_pe_dbg EXCLUDE_FROM_ALL ${FREELDR_BASE_SOURCE} ${SETUPLDR_SOURCE}) if(NOT MSVC) set_target_properties(setupldr_pe PROPERTIES LINK_FLAGS "-Wl,--strip-all,--exclude-all-symbols,--file-alignment,0x1000,-T,${CMAKE_CURRENT_SOURCE_DIR}/freeldr_i386.lnk" COMPILE_DEFINITIONS "FREELDR_REACTOS_SETUP") + set_target_properties(setupldr_pe_dbg PROPERTIES LINK_FLAGS "-Wl,--exclude-all-symbols,--file-alignment,0x1000,-T,${CMAKE_CURRENT_SOURCE_DIR}/freeldr_i386.lnk" COMPILE_DEFINITIONS "FREELDR_REACTOS_SETUP") else() set_target_properties(setupldr_pe PROPERTIES LINK_FLAGS "/ignore:4078 /ignore:4254 /DRIVER /FIXED /ALIGN:0x400 /SECTION:.text,ERW /SECTION:.data,RW /MERGE:.text16=.text /MERGE:.data=.text /MERGE:.rdata=.text /MERGE:.bss=.text /SUBSYSTEM:BOOT_APPLICATION" COMPILE_DEFINITIONS "FREELDR_REACTOS_SETUP") + set_target_properties(setupldr_pe_dbg PROPERTIES LINK_FLAGS "/ignore:4078 /ignore:4254 /DRIVER /FIXED /ALIGN:0x400 /SECTION:.text,ERW /SECTION:.data,RW /MERGE:.text16=.text /MERGE:.data=.text /MERGE:.rdata=.text /MERGE:.bss=.text /SUBSYSTEM:BOOT_APPLICATION" COMPILE_DEFINITIONS "FREELDR_REACTOS_SETUP") endif() set_image_base(setupldr_pe 0x10000) set_subsystem(setupldr_pe native) set_entrypoint(setupldr_pe RealEntryPoint) +set_image_base(setupldr_pe_dbg 0x10000) +set_subsystem(setupldr_pe_dbg native) +set_entrypoint(setupldr_pe_dbg RealEntryPoint) + if(ARCH MATCHES i386) target_link_libraries(setupldr_pe mini_hal) + target_link_libraries(setupldr_pe_dbg mini_hal) endif() target_link_libraries(setupldr_pe @@ -227,7 +250,16 @@ rtl libcntpr) +target_link_libraries(setupldr_pe_dbg + freeldr_common + cportlib + rossym + cmlib + rtl + libcntpr) + add_dependencies(setupldr_pe asm) +add_dependencies(setupldr_pe_dbg asm) concatenate_files( ${CMAKE_CURRENT_BINARY_DIR}/frldr16.bin @@ -237,4 +269,3 @@ add_custom_target(setupldr ALL DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/setupldr.sys) add_cd_file(TARGET setupldr FILE ${CMAKE_CURRENT_BINARY_DIR}/setupldr.sys DESTINATION loader NO_CAB FOR bootcd regtest) -

1 0

[tkreuzer] 53838: [NTOSKRNL] - Cleanup amd64 mm.h header - Call MiScanMemoryDescriptors earlier, since it doesn't depend on anything except the loader block. - MiComputeColorInformation() and the c...
by tkreuzer＠svn.reactos.org 24 Sep '11

24 Sep '11

Author: tkreuzer Date: Sat Sep 24 14:22:13 2011 New Revision: 53838 URL: http://svn.reactos.org/svn/reactos?rev=53838&view=rev Log: [NTOSKRNL] - Cleanup amd64 mm.h header - Call MiScanMemoryDescriptors earlier, since it doesn't depend on anything except the loader block. - MiComputeColorInformation() and the calculation of the pfn database size are portable, so move them out of MiInitMachineDependent Modified: trunk/reactos/ntoskrnl/include/internal/amd64/mm.h trunk/reactos/ntoskrnl/mm/ARM3/i386/init.c trunk/reactos/ntoskrnl/mm/ARM3/mminit.c Modified: trunk/reactos/ntoskrnl/include/internal/amd64/mm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/amd64/mm.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/amd64/mm.h [iso-8859-1] Sat Sep 24 14:22:13 2011 @@ -1,16 +1,10 @@ /* - * Lowlevel memory managment definitions + * kernel internal memory managment definitions for amd64 */ - #pragma once -#define _MI_PAGING_LEVELS 4 - -/* Helper macros */ -#define PAGE_MASK(x) ((x)&(~0xfff)) -#define PAE_PAGE_MASK(x) ((x)&(~0xfffLL)) - /* Memory layout base addresses */ +#define MI_LOWEST_VAD_ADDRESS (PVOID)0x000000007FF00000ULL #define MI_HIGHEST_USER_ADDRESS (PVOID)0x000007FFFFFEFFFFULL #define MI_USER_PROBE_ADDRESS (PVOID)0x000007FFFFFF0000ULL #define MI_DEFAULT_SYSTEM_RANGE_START (PVOID)0xFFFF080000000000ULL @@ -28,128 +22,58 @@ #define MI_HIGHEST_SYSTEM_ADDRESS (PVOID)0xFFFFFFFFFFFFFFFFULL #define MI_SYSTEM_CACHE_WS_START (PVOID)0xFFFFF78000001000ULL // CHECKME -#define MI_LOWEST_VAD_ADDRESS (PVOID)0x000000007FF00000ULL - +#define MM_HIGHEST_USER_ADDRESS_WOW64 0x7FFEFFFF +#define MM_SYSTEM_RANGE_START_WOW64 0x80000000 + + +#define MI_SYSTEM_PTE_END (PVOID)((ULONG64)MI_SYSTEM_PTE_START + MI_NUMBER_SYSTEM_PTES * PAGE_SIZE - 1) #define MI_SYSTEM_PTE_BASE (PVOID)MiAddressToPte(KSEG0_BASE) +#define MM_HIGHEST_VAD_ADDRESS (PVOID)((ULONG_PTR)MM_HIGHEST_USER_ADDRESS - (16 * PAGE_SIZE)) +#define MI_MAPPING_RANGE_START (ULONG64)HYPER_SPACE +#define MI_MAPPING_RANGE_END (MI_MAPPING_RANGE_START + MI_HYPERSPACE_PTES * PAGE_SIZE) /* Memory sizes */ #define MI_MIN_PAGES_FOR_NONPAGED_POOL_TUNING ((255*1024*1024) >> PAGE_SHIFT) -#define MI_MIN_PAGES_FOR_SYSPTE_TUNING ((19*1024*1024) >> PAGE_SHIFT) -#define MI_MIN_PAGES_FOR_SYSPTE_BOOST ((32*1024*1024) >> PAGE_SHIFT) -#define MI_MAX_INIT_NONPAGED_POOL_SIZE (128ULL * 1024 * 1024 * 1024) -#define MI_MAX_NONPAGED_POOL_SIZE (128ULL * 1024 * 1024 * 1024) -#define MI_MAX_FREE_PAGE_LISTS 4 -#define MI_MIN_INIT_PAGED_POOLSIZE (32 * 1024 * 1024) -#define MI_SESSION_VIEW_SIZE (20 * 1024 * 1024) -#define MI_SESSION_POOL_SIZE (16 * 1024 * 1024) -#define MI_SESSION_IMAGE_SIZE (8 * 1024 * 1024) -#define MI_SESSION_WORKING_SET_SIZE (4 * 1024 * 1024) -#define MI_SESSION_SIZE (MI_SESSION_VIEW_SIZE + \ - MI_SESSION_POOL_SIZE + \ - MI_SESSION_IMAGE_SIZE + \ - MI_SESSION_WORKING_SET_SIZE) -#define MI_SYSTEM_VIEW_SIZE (16 * 1024 * 1024) -#define MI_NUMBER_SYSTEM_PTES 22000 - -#define MI_MIN_SECONDARY_COLORS 8 -#define MI_SECONDARY_COLORS 64 -#define MI_MAX_SECONDARY_COLORS 1024 - -#define MI_MIN_ALLOCATION_FRAGMENT (4 * _1KB) -#define MI_ALLOCATION_FRAGMENT (64 * _1KB) -#define MI_MAX_ALLOCATION_FRAGMENT (2 * _1MB) - -#define MM_HIGHEST_VAD_ADDRESS \ - (PVOID)((ULONG_PTR)MM_HIGHEST_USER_ADDRESS - (16 * PAGE_SIZE)) - -#define MM_HIGHEST_USER_ADDRESS_WOW64 0x7FFEFFFF -#define MM_SYSTEM_RANGE_START_WOW64 0x80000000 - -PULONG64 -FORCEINLINE -MmGetPageDirectory(VOID) -{ - return (PULONG64)__readcr3(); -} - -PMMPTE -FORCEINLINE -MiAddressToPxe(PVOID Address) -{ - ULONG64 Offset = (ULONG64)Address >> (PXI_SHIFT - 3); - Offset &= PXI_MASK << 3; - return (PMMPTE)(PXE_BASE + Offset); -} - -PMMPTE -FORCEINLINE -MiAddressToPpe(PVOID Address) -{ - ULONG64 Offset = (ULONG64)Address >> (PPI_SHIFT - 3); - Offset &= 0x3FFFF << 3; - return (PMMPTE)(PPE_BASE + Offset); -} - -PMMPTE -FORCEINLINE -_MiAddressToPde(PVOID Address) -{ - ULONG64 Offset = (ULONG64)Address >> (PDI_SHIFT - 3); - Offset &= 0x7FFFFFF << 3; - return (PMMPTE)(PDE_BASE + Offset); -} -#define MiAddressToPde(x) _MiAddressToPde((PVOID)(x)) - -PMMPTE -FORCEINLINE -_MiAddressToPte(PVOID Address) -{ - ULONG64 Offset = (ULONG64)Address >> (PTI_SHIFT - 3); - Offset &= 0xFFFFFFFFFULL << 3; - return (PMMPTE)(PTE_BASE + Offset); -} -#define MiAddressToPte(x) _MiAddressToPte((PVOID)(x)) - -ULONG -FORCEINLINE -MiAddressToPti(PVOID Address) -{ - return ((((ULONG64)Address) >> PTI_SHIFT) & 0x1FF); -} -#define MiAddressToPteOffset(x) MiAddressToPti(x) // FIXME: bad name - -ULONG -FORCEINLINE -MiAddressToPxi(PVOID Address) -{ - return ((((ULONG64)Address) >> PXI_SHIFT) & 0x1FF); -} - - -/* Convert a PTE into a corresponding address */ -PVOID -FORCEINLINE -MiPteToAddress(PMMPTE Pte) -{ - /* Use signed math */ - LONG64 Temp = (LONG64)Pte; - Temp <<= 25; - Temp >>= 16; - return (PVOID)Temp; -} -#define MiPdeToAddress MiPteToAddress - -BOOLEAN -FORCEINLINE -MiIsPdeForAddressValid(PVOID Address) -{ - return ((MiAddressToPxe(Address)->u.Hard.Valid) && - (MiAddressToPpe(Address)->u.Hard.Valid) && - (MiAddressToPde(Address)->u.Hard.Valid)); -} - -#define MiPdeToPte(PDE) ((PMMPTE)MiPteToAddress(PDE)) -#define MiPteToPde(PTE) ((PMMPDE)MiAddressToPte(PTE)) +#define MI_MIN_PAGES_FOR_SYSPTE_TUNING ((19*1024*1024) >> PAGE_SHIFT) +#define MI_MIN_PAGES_FOR_SYSPTE_BOOST ((32*1024*1024) >> PAGE_SHIFT) +#define MI_MIN_INIT_PAGED_POOLSIZE (32 * 1024 * 1024) +#define MI_MAX_INIT_NONPAGED_POOL_SIZE (128ULL * 1024 * 1024 * 1024) +#define MI_MAX_NONPAGED_POOL_SIZE (128ULL * 1024 * 1024 * 1024) +#define MI_SYSTEM_VIEW_SIZE (16 * 1024 * 1024) +#define MI_MIN_SECONDARY_COLORS 8 +#define MI_SECONDARY_COLORS 64 +#define MI_MAX_SECONDARY_COLORS 1024 +#define MI_MIN_ALLOCATION_FRAGMENT (4 * _1KB) +#define MI_ALLOCATION_FRAGMENT (64 * _1KB) +#define MI_MAX_ALLOCATION_FRAGMENT (2 * _1MB) +#define MI_SESSION_WORKING_SET_SIZE (4 * 1024 * 1024) +#define MI_SESSION_VIEW_SIZE (20 * 1024 * 1024) +#define MI_SESSION_POOL_SIZE (16 * 1024 * 1024) +#define MI_SESSION_IMAGE_SIZE (8 * 1024 * 1024) +#define MI_SESSION_SIZE (MI_SESSION_VIEW_SIZE + \ + MI_SESSION_POOL_SIZE + \ + MI_SESSION_IMAGE_SIZE + \ + MI_SESSION_WORKING_SET_SIZE) + +/* Misc constants */ +#define _MI_PAGING_LEVELS 4 +#define MI_NUMBER_SYSTEM_PTES 22000 +#define MI_MAX_FREE_PAGE_LISTS 4 +#define NR_SECTION_PAGE_TABLES 1024 +#define NR_SECTION_PAGE_ENTRIES 1024 +#define MI_HYPERSPACE_PTES (256 - 1) +#define MI_ZERO_PTES (32) +#define MI_DUMMY_PTE (PMMPTE)(MI_MAPPING_RANGE_END + PAGE_SIZE) +#define MI_VAD_BITMAP (PMMPTE)(MI_DUMMY_PTE + PAGE_SIZE) +#define MI_WORKING_SET_LIST (PMMPTE)(MI_VAD_BITMAP + PAGE_SIZE) +/* FIXME - different architectures have different cache line sizes... */ +#define MM_CACHE_LINE_SIZE 32 + +/* Helper macros */ +#define PAGE_MASK(x) ((x)&(~0xfff)) +#define PAE_PAGE_MASK(x) ((x)&(~0xfffLL)) +#define IS_ALIGNED(addr, align) (((ULONG64)(addr) & (align - 1)) == 0) +#define IS_PAGE_ALIGNED(addr) IS_ALIGNED(addr, PAGE_SIZE) #define ADDR_TO_PAGE_TABLE(v) ((ULONG)(((ULONG_PTR)(v)) / (512 * PAGE_SIZE))) #define ADDR_TO_PDE_OFFSET(v) ((ULONG)((((ULONG_PTR)(v)) / (512 * PAGE_SIZE)))) @@ -161,43 +85,6 @@ #define VAtoPPI(va) ((((ULONG64)va) >> PPI_SHIFT) & 0x1FF) #define VAtoPDI(va) ((((ULONG64)va) >> PDI_SHIFT) & 0x1FF) #define VAtoPTI(va) ((((ULONG64)va) >> PTI_SHIFT) & 0x1FF) - -FORCEINLINE -VOID -MI_MAKE_PROTOTYPE_PTE(IN PMMPTE NewPte, - IN PMMPTE PointerPte) -{ - /* Store the Address */ - NewPte->u.Long = (ULONG64)PointerPte; - - /* Mark this as a prototype PTE */ - NewPte->u.Proto.Prototype = 1; - NewPte->u.Proto.Valid = 1; - NewPte->u.Proto.ReadOnly = 0; - NewPte->u.Proto.Protection = 0; -} - -/* Sign extend 48 bits */ -#define MiProtoPteToPte(x) \ - (PMMPTE)((LONG64)(x)->u.Proto.ProtoAddress) - -/* We don't use these hacks */ -VOID -FORCEINLINE -MmUpdatePageDir(PEPROCESS Process, PVOID Address, ULONG Size) -{ - /* Nothing to do */ -} - -VOID -FORCEINLINE -MmInitGlobalKernelPageDirectory(VOID) -{ - /* Nothing to do */ -} - -#define IS_ALIGNED(addr, align) (((ULONG64)(addr) & (align - 1)) == 0) -#define IS_PAGE_ALIGNED(addr) IS_ALIGNED(addr, PAGE_SIZE) /* Easy accessing PFN in PTE */ #define PFN_FROM_PTE(v) ((v)->u.Hard.PageFrameNumber) @@ -227,34 +114,123 @@ // FIXME!!! #define PAGE_TO_SECTION_PAGE_DIRECTORY_OFFSET(x) \ ((x) / (4*1024*1024)) - #define PAGE_TO_SECTION_PAGE_TABLE_OFFSET(x) \ ((((x)) % (4*1024*1024)) / (4*1024)) -#define NR_SECTION_PAGE_TABLES 1024 -#define NR_SECTION_PAGE_ENTRIES 1024 - //#define TEB_BASE 0x7FFDE000 - -#define MI_HYPERSPACE_PTES (256 - 1) -#define MI_ZERO_PTES (32) -#define MI_MAPPING_RANGE_START (ULONG)HYPER_SPACE -#define MI_MAPPING_RANGE_END (MI_MAPPING_RANGE_START + \ - MI_HYPERSPACE_PTES * PAGE_SIZE) -#define MI_DUMMY_PTE (PMMPTE)(MI_MAPPING_RANGE_END + \ - PAGE_SIZE) -#define MI_VAD_BITMAP (PMMPTE)(MI_DUMMY_PTE + \ - PAGE_SIZE) -#define MI_WORKING_SET_LIST (PMMPTE)(MI_VAD_BITMAP + \ - PAGE_SIZE) - /* On x86, these two are the same */ #define MMPDE MMPTE #define PMMPDE PMMPTE -/* -* FIXME - different architectures have different cache line sizes... -*/ -#define MM_CACHE_LINE_SIZE 32 - +PULONG64 +FORCEINLINE +MmGetPageDirectory(VOID) +{ + return (PULONG64)__readcr3(); +} + +PMMPTE +FORCEINLINE +MiAddressToPxe(PVOID Address) +{ + ULONG64 Offset = (ULONG64)Address >> (PXI_SHIFT - 3); + Offset &= PXI_MASK << 3; + return (PMMPTE)(PXE_BASE + Offset); +} + +PMMPTE +FORCEINLINE +MiAddressToPpe(PVOID Address) +{ + ULONG64 Offset = (ULONG64)Address >> (PPI_SHIFT - 3); + Offset &= 0x3FFFF << 3; + return (PMMPTE)(PPE_BASE + Offset); +} + +PMMPTE +FORCEINLINE +_MiAddressToPde(PVOID Address) +{ + ULONG64 Offset = (ULONG64)Address >> (PDI_SHIFT - 3); + Offset &= 0x7FFFFFF << 3; + return (PMMPTE)(PDE_BASE + Offset); +} +#define MiAddressToPde(x) _MiAddressToPde((PVOID)(x)) + +PMMPTE +FORCEINLINE +_MiAddressToPte(PVOID Address) +{ + ULONG64 Offset = (ULONG64)Address >> (PTI_SHIFT - 3); + Offset &= 0xFFFFFFFFFULL << 3; + return (PMMPTE)(PTE_BASE + Offset); +} +#define MiAddressToPte(x) _MiAddressToPte((PVOID)(x)) + +ULONG +FORCEINLINE +MiAddressToPti(PVOID Address) +{ + return ((((ULONG64)Address) >> PTI_SHIFT) & 0x1FF); +} +#define MiAddressToPteOffset(x) MiAddressToPti(x) // FIXME: bad name + +ULONG +FORCEINLINE +MiAddressToPxi(PVOID Address) +{ + return ((((ULONG64)Address) >> PXI_SHIFT) & 0x1FF); +} + + +/* Convert a PTE into a corresponding address */ +PVOID +FORCEINLINE +MiPteToAddress(PMMPTE Pte) +{ + /* Use signed math */ + LONG64 Temp = (LONG64)Pte; + Temp <<= 25; + Temp >>= 16; + return (PVOID)Temp; +} +#define MiPdeToAddress MiPteToAddress + +BOOLEAN +FORCEINLINE +MiIsPdeForAddressValid(PVOID Address) +{ + return ((MiAddressToPxe(Address)->u.Hard.Valid) && + (MiAddressToPpe(Address)->u.Hard.Valid) && + (MiAddressToPde(Address)->u.Hard.Valid)); +} + +#define MiPdeToPte(PDE) ((PMMPTE)MiPteToAddress(PDE)) +#define MiPteToPde(PTE) ((PMMPDE)MiAddressToPte(PTE)) + +FORCEINLINE +VOID +MI_MAKE_PROTOTYPE_PTE(IN PMMPTE NewPte, + IN PMMPTE PointerPte) +{ + /* Store the Address */ + NewPte->u.Long = (ULONG64)PointerPte; + + /* Mark this as a prototype PTE */ + NewPte->u.Proto.Prototype = 1; + NewPte->u.Proto.Valid = 1; + NewPte->u.Proto.ReadOnly = 0; + NewPte->u.Proto.Protection = 0; +} + +/* Sign extend 48 bits */ +#define MiProtoPteToPte(x) (PMMPTE)((LONG64)(x)->u.Proto.ProtoAddress) + +VOID +FORCEINLINE +MmInitGlobalKernelPageDirectory(VOID) +{ + /* Nothing to do */ +} + Modified: trunk/reactos/ntoskrnl/mm/ARM3/i386/init.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/i386/init… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/i386/init.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/i386/init.c [iso-8859-1] Sat Sep 24 14:22:13 2011 @@ -265,27 +265,6 @@ /* Compute non paged pool limits and size */ MiComputeNonPagedPoolVa(MiNumberOfFreePages); - /* Compute color information (L2 cache-separated paging lists) */ - MiComputeColorInformation(); - - // - // Calculate the number of bytes for the PFN database - // then add the color tables and convert to pages - // - MxPfnAllocation = (MmHighestPhysicalPage + 1) * sizeof(MMPFN); - MxPfnAllocation += (MmSecondaryColors * sizeof(MMCOLOR_TABLES) * 2); - MxPfnAllocation >>= PAGE_SHIFT; - - // - // We have to add one to the count here, because in the process of - // shifting down to the page size, we actually ended up getting the - // lower aligned size (so say, 0x5FFFF bytes is now 0x5F pages). - // Later on, we'll shift this number back into bytes, which would cause - // us to end up with only 0x5F000 bytes -- when we actually want to have - // 0x60000 bytes. - // - MxPfnAllocation++; - // // Now calculate the nonpaged pool expansion VA region // Modified: trunk/reactos/ntoskrnl/mm/ARM3/mminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/mminit.c?… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/mminit.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/mminit.c [iso-8859-1] Sat Sep 24 14:22:13 2011 @@ -1884,6 +1884,9 @@ IncludeType[LoaderBBTMemory] = FALSE; if (Phase == 0) { + /* Count physical pages on the system */ + MiScanMemoryDescriptors(LoaderBlock); + /* Initialize the phase 0 temporary event */ KeInitializeEvent(&MiTempEvent, NotificationEvent, FALSE); @@ -1939,14 +1942,9 @@ MmZeroingPageThreadActive = FALSE; // - // Count physical pages on the system - // - MiScanMemoryDescriptors(LoaderBlock); + // Check if this is a machine with less than 19MB of RAM + // PageCount = MmNumberOfPhysicalPages; - - // - // Check if this is a machine with less than 19MB of RAM - // if (PageCount < MI_MIN_PAGES_FOR_SYSPTE_TUNING) { // @@ -2031,6 +2029,23 @@ /* Make sure it's not too low */ if (MmLargeStackSize < KERNEL_STACK_SIZE) MmLargeStackSize = KERNEL_STACK_SIZE; } + + /* Compute color information (L2 cache-separated paging lists) */ + MiComputeColorInformation(); + + // Calculate the number of bytes for the PFN database + // then add the color tables and convert to pages + MxPfnAllocation = (MmHighestPhysicalPage + 1) * sizeof(MMPFN); + MxPfnAllocation += (MmSecondaryColors * sizeof(MMCOLOR_TABLES) * 2); + MxPfnAllocation >>= PAGE_SHIFT; + + // We have to add one to the count here, because in the process of + // shifting down to the page size, we actually ended up getting the + // lower aligned size (so say, 0x5FFFF bytes is now 0x5F pages). + // Later on, we'll shift this number back into bytes, which would cause + // us to end up with only 0x5F000 bytes -- when we actually want to have + // 0x60000 bytes. + MxPfnAllocation++; /* Initialize the platform-specific parts */ MiInitMachineDependent(LoaderBlock);

1 0

[dgorbachev] 53837: [FREELDR] Compare with constants of right type.
by dgorbachev＠svn.reactos.org 24 Sep '11

24 Sep '11

Author: dgorbachev Date: Sat Sep 24 13:39:14 2011 New Revision: 53837 URL: http://svn.reactos.org/svn/reactos?rev=53837&view=rev Log: [FREELDR] Compare with constants of right type. Modified: trunk/reactos/boot/freeldr/freeldr/mm/meminit.c Modified: trunk/reactos/boot/freeldr/freeldr/mm/meminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/mm/me… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/mm/meminit.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/mm/meminit.c [iso-8859-1] Sat Sep 24 13:39:14 2011 @@ -255,7 +255,8 @@ // // Yes, remember it if this is real memory // - if (MemoryDescriptor->MemoryType == LoaderFree) MmHighestPhysicalPage = MemoryDescriptor->BasePage + MemoryDescriptor->PageCount; + if (MemoryDescriptor->MemoryType == MemoryFree) + MmHighestPhysicalPage = MemoryDescriptor->BasePage + MemoryDescriptor->PageCount; } // @@ -292,7 +293,7 @@ while ((MemoryDescriptor = ArcGetMemoryDescriptor(MemoryDescriptor)) != NULL) { // Continue, if memory is not free - if (MemoryDescriptor->MemoryType != LoaderFree) continue; + if (MemoryDescriptor->MemoryType != MemoryFree) continue; // Continue, if the block is not big enough? if (MemoryDescriptor->PageCount < PageLookupTablePages) continue;

1 0

[dgorbachev] 53836: [User32] Check return value of DIB_GetBitmapInfo.
by dgorbachev＠svn.reactos.org 24 Sep '11

24 Sep '11

Author: dgorbachev Date: Sat Sep 24 13:37:24 2011 New Revision: 53836 URL: http://svn.reactos.org/svn/reactos?rev=53836&view=rev Log: [User32] Check return value of DIB_GetBitmapInfo. Modified: trunk/reactos/dll/win32/user32/windows/cursoricon.c Modified: trunk/reactos/dll/win32/user32/windows/cursoricon.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/c… ============================================================================== --- trunk/reactos/dll/win32/user32/windows/cursoricon.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/user32/windows/cursoricon.c [iso-8859-1] Sat Sep 24 13:37:24 2011 @@ -1703,13 +1703,13 @@ else new_height = height; - if(bm_type == 0) + if (bm_type == 0) { BITMAPCOREHEADER *core = (BITMAPCOREHEADER *)&scaled_info->bmiHeader; core->bcWidth = new_width; core->bcHeight = new_height; } - else + else if (bm_type == 1) { /* Some sanity checks for BITMAPINFO (not applicable to BITMAPCOREINFO) */ if (info->bmiHeader.biHeight > 65535 || info->bmiHeader.biWidth > 65535) { @@ -1720,6 +1720,8 @@ scaled_info->bmiHeader.biWidth = new_width; scaled_info->bmiHeader.biHeight = new_height; } + else + goto end; if (new_height < 0) new_height = -new_height;

1 0

[gadamopoulos] 53835: [user32_apitest] - Add one more small test for WM_SYSTIMER
by gadamopoulos＠svn.reactos.org 24 Sep '11

24 Sep '11

Author: gadamopoulos Date: Sat Sep 24 12:22:21 2011 New Revision: 53835 URL: http://svn.reactos.org/svn/reactos?rev=53835&view=rev Log: [user32_apitest] - Add one more small test for WM_SYSTIMER Modified: trunk/rostests/apitests/user32/TrackMouseEvent.c Modified: trunk/rostests/apitests/user32/TrackMouseEvent.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/user32/TrackMous… ============================================================================== --- trunk/rostests/apitests/user32/TrackMouseEvent.c [iso-8859-1] (original) +++ trunk/rostests/apitests/user32/TrackMouseEvent.c [iso-8859-1] Sat Sep 24 12:22:21 2011 @@ -43,6 +43,9 @@ case WM_IME_NOTIFY : case WM_GETICON : case WM_GETTEXT: + break; + case WM_SYSTIMER: + ok(0, "Got unexpected WM_SYSTIMER in the winproc. wParam=%d\n", wParam); break; default: record_message(iwnd, message, SENT, 0,0);

1 0

[khornicek] 53834: another try to fix cmake build
by khornicek＠svn.reactos.org 24 Sep '11

24 Sep '11

Author: khornicek Date: Sat Sep 24 12:16:04 2011 New Revision: 53834 URL: http://svn.reactos.org/svn/reactos?rev=53834&view=rev Log: another try to fix cmake build Modified: trunk/reactos/base/system/diskpart/CMakeLists.txt Modified: trunk/reactos/base/system/diskpart/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/diskpart/CMake… ============================================================================== --- trunk/reactos/base/system/diskpart/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/base/system/diskpart/CMakeLists.txt [iso-8859-1] Sat Sep 24 12:16:04 2011 @@ -41,7 +41,7 @@ uniqueid.c diskpart.rc) -set_module_type(diskpart win32cui) +set_module_type(diskpart win32cui UNICODE) add_importlibs(diskpart user32 msvcrt kernel32) if(MSVC) add_importlibs(diskpart ntdll)

1 0

[cgutman] 53833: [ACPI] - Reduce debug spam - Report critical initialization failure
by cgutman＠svn.reactos.org 24 Sep '11

24 Sep '11

Author: cgutman Date: Sat Sep 24 12:05:43 2011 New Revision: 53833 URL: http://svn.reactos.org/svn/reactos?rev=53833&view=rev Log: [ACPI] - Reduce debug spam - Report critical initialization failure Modified: trunk/reactos/drivers/bus/acpi/pnp.c Modified: trunk/reactos/drivers/bus/acpi/pnp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/acpi/pnp.c?rev… ============================================================================== --- trunk/reactos/drivers/bus/acpi/pnp.c [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/acpi/pnp.c [iso-8859-1] Sat Sep 24 12:05:43 2011 @@ -47,7 +47,7 @@ if (commonData->IsFDO) { - DPRINT1("FDO %s IRP:0x%p\n", + DPRINT("FDO %s IRP:0x%p\n", PnPMinorFunctionString(irpStack->MinorFunction), Irp); // @@ -59,7 +59,7 @@ irpStack, (PFDO_DEVICE_DATA) commonData); } else { - DPRINT1("PDO %s IRP: 0x%p\n", + DPRINT("PDO %s IRP: 0x%p\n", PnPMinorFunctionString(irpStack->MinorFunction), Irp); // @@ -312,7 +312,7 @@ /* Initialize ACPI bus manager */ AcpiStatus = acpi_init(); if (!ACPI_SUCCESS(AcpiStatus)) { - DPRINT("acpi_init() failed with status 0x%X\n", AcpiStatus); + DPRINT1("acpi_init() failed with status 0x%X\n", AcpiStatus); AcpiTerminate(); return STATUS_UNSUCCESSFUL; }

1 0

[gadamopoulos] 53832: [user32_apitest.exe] - Fix gcc build
by gadamopoulos＠svn.reactos.org 24 Sep '11

24 Sep '11

Author: gadamopoulos Date: Sat Sep 24 12:05:14 2011 New Revision: 53832 URL: http://svn.reactos.org/svn/reactos?rev=53832&view=rev Log: [user32_apitest.exe] - Fix gcc build Modified: trunk/rostests/apitests/user32/helper.c trunk/rostests/apitests/user32/helper.h Modified: trunk/rostests/apitests/user32/helper.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/user32/helper.c?… ============================================================================== --- trunk/rostests/apitests/user32/helper.c [iso-8859-1] (original) +++ trunk/rostests/apitests/user32/helper.c [iso-8859-1] Sat Sep 24 12:05:14 2011 @@ -93,6 +93,8 @@ msgName = NULL; msgType = "event"; break; + default: + return; } if(msgName) Modified: trunk/rostests/apitests/user32/helper.h URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/user32/helper.h?… ============================================================================== --- trunk/rostests/apitests/user32/helper.h [iso-8859-1] (original) +++ trunk/rostests/apitests/user32/helper.h [iso-8859-1] Sat Sep 24 12:05:14 2011 @@ -23,7 +23,7 @@ ATOM RegisterSimpleClass(WNDPROC lpfnWndProc, LPCWSTR lpszClassName); /* filter messages that are affected by dwm */ -static _inline BOOL IsDWmMsg(UINT msg) +static inline BOOL IsDWmMsg(UINT msg) { switch(msg) { @@ -36,7 +36,7 @@ return FALSE; } -static _inline BOOL IseKeyMsg(UINT msg) +static inline BOOL IseKeyMsg(UINT msg) { return (msg == WM_KEYUP || msg == WM_KEYDOWN); }

1 0

[cgutman] 53831: [HAL] - Report table lookup failures - Report supported ACPI version
by cgutman＠svn.reactos.org 24 Sep '11

24 Sep '11

Author: cgutman Date: Sat Sep 24 12:01:48 2011 New Revision: 53831 URL: http://svn.reactos.org/svn/reactos?rev=53831&view=rev Log: [HAL] - Report table lookup failures - Report supported ACPI version Modified: trunk/reactos/hal/halx86/acpi/halacpi.c Modified: trunk/reactos/hal/halx86/acpi/halacpi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/acpi/halacpi.c?… ============================================================================== --- trunk/reactos/hal/halx86/acpi/halacpi.c [iso-8859-1] (original) +++ trunk/reactos/hal/halx86/acpi/halacpi.c [iso-8859-1] Sat Sep 24 12:01:48 2011 @@ -332,6 +332,12 @@ /* Using Mm */ MmUnmapIoSpace(Header, 2 * PAGE_SIZE); } + + DPRINT1("Failed to find ACPI table %c%c%c%c\n", + (Signature & 0xFF), + (Signature & 0xFF00) >> 8, + (Signature & 0xFF0000) >> 16, + (Signature & 0xFF000000) >> 24); /* Didn't find anything */ return NULL; @@ -386,7 +392,15 @@ } /* The correct checksum is always 0, anything else is illegal */ - if (CheckSum) HalpInvalidAcpiTable = Header->Signature; + if (CheckSum) + { + HalpInvalidAcpiTable = Header->Signature; + DPRINT1("Checksum failed on ACPI table %c%c%c%c\n", + (Signature & 0xFF), + (Signature & 0xFF00) >> 8, + (Signature & 0xFF0000) >> 16, + (Signature & 0xFF000000) >> 24); + } } /* Return the table */ @@ -755,6 +769,8 @@ } } + DPRINT1("ACPI %d.0 detected\n", (Rsdt->Header.Revision + 1)); + /* Done */ return Status; }

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
40
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs September 2011