Ros-diffs April 2013

ros-diffs@reactos.org

14 participants
265 discussions

[hbelusca] 58716: [BASESRV-CSRSRV] A little bit of code reorganization (more a "matter of taste"; delete allocated pointers in the reverse way we allocated them). [NTDLL] - Free a used SID (i.e. fi...
by hbelusca＠svn.reactos.org 07 Apr '13

07 Apr '13

Author: hbelusca Date: Sun Apr 7 18:28:38 2013 New Revision: 58716 URL: http://svn.reactos.org/svn/reactos?rev=58716&view=rev Log: [BASESRV-CSRSRV] A little bit of code reorganization (more a "matter of taste"; delete allocated pointers in the reverse way we allocated them). [NTDLL] - Free a used SID (i.e. fix a memory leak). - Only just "reserve" memory pages for the section for the CSR port. Memory will be actually committed later on (checked on Windows Server 2003 and on http://j00ru.vexillium.org/?p=527 ). Modified: branches/ros-csrss/dll/ntdll/csr/connect.c branches/ros-csrss/subsystems/win/basesrv/dosdev.c branches/ros-csrss/subsystems/win/basesrv/init.c branches/ros-csrss/subsystems/win32/csrsrv/init.c Modified: branches/ros-csrss/dll/ntdll/csr/connect.c URL: http://svn.reactos.org/svn/reactos/branches/ros-csrss/dll/ntdll/csr/connect… ============================================================================== --- branches/ros-csrss/dll/ntdll/csr/connect.c [iso-8859-1] (original) +++ branches/ros-csrss/dll/ntdll/csr/connect.c [iso-8859-1] Sun Apr 7 18:28:38 2013 @@ -221,7 +221,7 @@ NULL, &CsrSectionViewSize, PAGE_READWRITE, - SEC_COMMIT, + SEC_RESERVE, NULL); if (!NT_SUCCESS(Status)) { @@ -250,16 +250,16 @@ /* Create a SID for us */ Status = RtlAllocateAndInitializeSid(&NtSidAuthority, - 1, - SECURITY_LOCAL_SYSTEM_RID, - 0, - 0, - 0, - 0, - 0, - 0, - 0, - &SystemSid); + 1, + SECURITY_LOCAL_SYSTEM_RID, + 0, + 0, + 0, + 0, + 0, + 0, + 0, + &SystemSid); if (!NT_SUCCESS(Status)) { /* Failure */ @@ -278,6 +278,7 @@ NULL, &ConnectionInfo, &ConnectionInfoLength); + RtlFreeSid(SystemSid); NtClose(CsrSectionHandle); if (!NT_SUCCESS(Status)) { Modified: branches/ros-csrss/subsystems/win/basesrv/dosdev.c URL: http://svn.reactos.org/svn/reactos/branches/ros-csrss/subsystems/win/basesr… ============================================================================== --- branches/ros-csrss/subsystems/win/basesrv/dosdev.c [iso-8859-1] (original) +++ branches/ros-csrss/subsystems/win/basesrv/dosdev.c [iso-8859-1] Sun Apr 7 18:28:38 2013 @@ -420,8 +420,8 @@ &AdminSid); SidLength = RtlLengthSid(SystemSid) + - RtlLengthSid(AdminSid) + - RtlLengthSid(WorldSid); + RtlLengthSid(AdminSid) + + RtlLengthSid(WorldSid); Length = sizeof(ACL) + SidLength + 3 * sizeof(ACCESS_ALLOWED_ACE); SecurityDescriptor = RtlAllocateHeap(BaseSrvHeap, Modified: branches/ros-csrss/subsystems/win/basesrv/init.c URL: http://svn.reactos.org/svn/reactos/branches/ros-csrss/subsystems/win/basesr… ============================================================================== --- branches/ros-csrss/subsystems/win/basesrv/init.c [iso-8859-1] (original) +++ branches/ros-csrss/subsystems/win/basesrv/init.c [iso-8859-1] Sun Apr 7 18:28:38 2013 @@ -202,9 +202,9 @@ /* Allocate one ACL with 3 ACEs each for one SID */ AclLength = sizeof(ACL) + 3 * sizeof(ACCESS_ALLOWED_ACE) + - RtlLengthSid(SystemSid) + - RtlLengthSid(RestrictedSid) + - RtlLengthSid(WorldSid); + RtlLengthSid(SystemSid) + + RtlLengthSid(WorldSid) + + RtlLengthSid(RestrictedSid); *Dacl = RtlAllocateHeap(BaseSrvHeap, 0, AclLength); ASSERT(*Dacl != NULL); @@ -239,9 +239,9 @@ ASSERT(NT_SUCCESS(Status)); /* The SIDs are captured, can free them now */ - RtlFreeHeap(BaseSrvHeap, 0, SystemSid); - RtlFreeHeap(BaseSrvHeap, 0, WorldSid); - RtlFreeHeap(BaseSrvHeap, 0, RestrictedSid); + RtlFreeSid(RestrictedSid); + RtlFreeSid(WorldSid); + RtlFreeSid(SystemSid); return Status; } Modified: branches/ros-csrss/subsystems/win32/csrsrv/init.c URL: http://svn.reactos.org/svn/reactos/branches/ros-csrss/subsystems/win32/csrs… ============================================================================== --- branches/ros-csrss/subsystems/win32/csrsrv/init.c [iso-8859-1] (original) +++ branches/ros-csrss/subsystems/win32/csrsrv/init.c [iso-8859-1] Sun Apr 7 18:28:38 2013 @@ -350,10 +350,10 @@ /* FIXME: semi-failure cases! Quickie: */ Quickie: /* Free the SIDs */ + RtlFreeSid(CreatorSid); + RtlFreeSid(AdminSid); + RtlFreeSid(WorldSid); RtlFreeSid(SystemSid); - RtlFreeSid(WorldSid); - RtlFreeSid(AdminSid); - RtlFreeSid(CreatorSid); /* Return */ return Status; @@ -820,32 +820,24 @@ /* Now create the SD itself */ Status = RtlCreateSecurityDescriptor(SystemSd, SECURITY_DESCRIPTOR_REVISION); - if (!NT_SUCCESS(Status)) - { - /* Fail */ - RtlFreeHeap(CsrHeap, 0, SystemSd); - return Status; - } + if (!NT_SUCCESS(Status)) goto Quit; /* Create the DACL for it */ RtlCreateAcl(Dacl, Length, ACL_REVISION2); /* Create the ACE */ Status = RtlAddAccessAllowedAce(Dacl, ACL_REVISION, PORT_ALL_ACCESS, SystemSid); - if (!NT_SUCCESS(Status)) - { - /* Fail */ - RtlFreeHeap(CsrHeap, 0, SystemSd); - return Status; - } + if (!NT_SUCCESS(Status)) goto Quit; /* Clear the DACL in the SD */ Status = RtlSetDaclSecurityDescriptor(SystemSd, TRUE, Dacl, FALSE); - if (!NT_SUCCESS(Status)) - { - /* Fail */ + if (!NT_SUCCESS(Status)) goto Quit; + +Quit: + if (!NT_SUCCESS(Status)) + { RtlFreeHeap(CsrHeap, 0, SystemSd); - return Status; + SystemSd = NULL; } /* Free the SID and return*/

1 0

[ekohl] 58715: [SAMSRV] Implement the set LogonHours attribute code for all user set functions.
by ekohl＠svn.reactos.org 07 Apr '13

07 Apr '13

Author: ekohl Date: Sun Apr 7 17:58:11 2013 New Revision: 58715 URL: http://svn.reactos.org/svn/reactos?rev=58715&view=rev Log: [SAMSRV] Implement the set LogonHours attribute code for all user set functions. Modified: trunk/reactos/dll/win32/samsrv/samrpc.c trunk/reactos/dll/win32/samsrv/samsrv.h trunk/reactos/dll/win32/samsrv/user.c Modified: trunk/reactos/dll/win32/samsrv/samrpc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/samsrv/samrpc.c?… ============================================================================== --- trunk/reactos/dll/win32/samsrv/samrpc.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/samsrv/samrpc.c [iso-8859-1] Sun Apr 7 17:58:11 2013 @@ -2349,7 +2349,18 @@ return Status; } - /* FIXME: Set LogonHours attribute*/ + /* Set LogonHours attribute*/ + Status = SampSetObjectAttribute(UserObject, + L"LogonHours", + REG_BINARY, + NULL, + 0); + if (!NT_SUCCESS(Status)) + { + TRACE("failed with status 0x%08lx\n", Status); + return Status; + } + /* FIXME: Set Groups attribute*/ /* Set LMPwd attribute*/ @@ -7098,6 +7109,16 @@ REG_SZ, Buffer->All.Parameters.Buffer, Buffer->All.Parameters.MaximumLength); + if (!NT_SUCCESS(Status)) + goto done; + } + + if (WhichFields & USER_ALL_LOGONHOURS) + { + Status = SampSetLogonHoursAttrbute(UserObject, + &Buffer->All.LogonHours); + if (!NT_SUCCESS(Status)) + goto done; } if (WhichFields & (USER_ALL_PRIMARYGROUPID | @@ -7144,7 +7165,6 @@ /* FIXME: - USER_ALL_LOGONHOURS USER_ALL_NTPASSWORDPRESENT USER_ALL_LMPASSWORDPRESENT USER_ALL_PASSWORDEXPIRED @@ -7232,12 +7252,12 @@ Status = SampSetUserPreferences(UserObject, Buffer); break; -/* + case UserLogonHoursInformation: - Status = SampSetUserLogonHours(UserObject, - Buffer); - break; -*/ + Status = SampSetLogonHoursAttrbute(UserObject, + &Buffer->LogonHours.LogonHours); + break; + case UserNameInformation: Status = SampSetObjectAttribute(UserObject, L"Name", Modified: trunk/reactos/dll/win32/samsrv/samsrv.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/samsrv/samsrv.h?… ============================================================================== --- trunk/reactos/dll/win32/samsrv/samsrv.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/samsrv/samsrv.h [iso-8859-1] Sun Apr 7 17:58:11 2013 @@ -328,6 +328,10 @@ NTSTATUS SampGetLogonHoursAttrbute(IN PSAM_DB_OBJECT UserObject, + IN OUT PSAMPR_LOGON_HOURS LogonHours); + +NTSTATUS +SampSetLogonHoursAttrbute(IN PSAM_DB_OBJECT UserObject, IN PSAMPR_LOGON_HOURS LogonHours); /* EOF */ Modified: trunk/reactos/dll/win32/samsrv/user.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/samsrv/user.c?re… ============================================================================== --- trunk/reactos/dll/win32/samsrv/user.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/samsrv/user.c [iso-8859-1] Sun Apr 7 17:58:11 2013 @@ -584,7 +584,7 @@ NTSTATUS SampGetLogonHoursAttrbute(IN PSAM_DB_OBJECT UserObject, - IN PSAMPR_LOGON_HOURS LogonHours) + IN OUT PSAMPR_LOGON_HOURS LogonHours) { PUCHAR RawBuffer = NULL; ULONG Length = 0; @@ -651,4 +651,47 @@ return Status; } + +NTSTATUS +SampSetLogonHoursAttrbute(IN PSAM_DB_OBJECT UserObject, + IN PSAMPR_LOGON_HOURS LogonHours) +{ + PUCHAR RawBuffer = NULL; + ULONG BufferLength; + ULONG Length = 0; + NTSTATUS Status; + + if (LogonHours->UnitsPerWeek > 0) + { + BufferLength = (((ULONG)LogonHours->UnitsPerWeek) + 7) / 8; + + Length = BufferLength + sizeof(USHORT); + + RawBuffer = midl_user_allocate(Length); + if (RawBuffer == NULL) + { + Status = STATUS_INSUFFICIENT_RESOURCES; + goto done; + } + + *((PUSHORT)RawBuffer) = LogonHours->UnitsPerWeek; + + memcpy(&(RawBuffer[2]), + LogonHours->LogonHours, + BufferLength); + } + + Status = SampSetObjectAttribute(UserObject, + L"LogonHours", + REG_BINARY, + RawBuffer, + Length); + +done: + if (RawBuffer != NULL) + midl_user_free(RawBuffer); + + return Status; +} + /* EOF */

1 0

[gadamopoulos] 58714: [win32k] - Fix IntGetScrollBarRect when WS_EX_LEFTSCROLLBAR style is used - Spotted by vicmarcal
by gadamopoulos＠svn.reactos.org 07 Apr '13

07 Apr '13

Author: gadamopoulos Date: Sun Apr 7 15:22:20 2013 New Revision: 58714 URL: http://svn.reactos.org/svn/reactos?rev=58714&view=rev Log: [win32k] - Fix IntGetScrollBarRect when WS_EX_LEFTSCROLLBAR style is used - Spotted by vicmarcal Modified: trunk/reactos/win32ss/user/ntuser/scrollbar.c Modified: trunk/reactos/win32ss/user/ntuser/scrollbar.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/scroll… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/scrollbar.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/scrollbar.c [iso-8859-1] Sun Apr 7 15:22:20 2013 @@ -103,7 +103,7 @@ case SB_VERT: if(Wnd->ExStyle & WS_EX_LEFTSCROLLBAR) { - lprect->right = lprect->right;; + lprect->right = lprect->left; lprect->left -= UserGetSystemMetrics(SM_CXVSCROLL); } else

1 0

[jgardou] 58713: [PORTCLS] * include initguid.h as suggested here : http://msdn.microsoft.com/en-us/library/windows/hardware/ff547786%28v=vs.85%29.aspx * Remove the guids.c file
by jgardou＠svn.reactos.org 07 Apr '13

07 Apr '13

Author: jgardou Date: Sun Apr 7 14:11:21 2013 New Revision: 58713 URL: http://svn.reactos.org/svn/reactos?rev=58713&view=rev Log: [PORTCLS] * include initguid.h as suggested here : http://msdn.microsoft.com/en-us/library/windows/hardware/ff547786%28v=vs.85… * Remove the guids.c file Removed: trunk/reactos/drivers/wdm/audio/backpln/portcls/guids.cpp Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/CMakeLists.txt trunk/reactos/drivers/wdm/audio/backpln/portcls/port.cpp Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… ============================================================================== --- trunk/reactos/drivers/wdm/audio/backpln/portcls/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/backpln/portcls/CMakeLists.txt [iso-8859-1] Sun Apr 7 14:11:21 2013 @@ -20,7 +20,6 @@ filter_wavecyclic.cpp filter_wavepci.cpp filter_wavert.cpp - guids.cpp interrupt.cpp irp.cpp irpstream.cpp Removed: trunk/reactos/drivers/wdm/audio/backpln/portcls/guids.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… ============================================================================== --- trunk/reactos/drivers/wdm/audio/backpln/portcls/guids.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/backpln/portcls/guids.cpp (removed) @@ -1,91 +1,0 @@ -/* - * COPYRIGHT: See COPYING in the top level directory - * PROJECT: ReactOS Kernel Streaming - * FILE: drivers/wdm/audio/backpln/portcls/guids.cpp - * PURPOSE: portcls guid mess - * PROGRAMMER: Johannes Anderwald - */ - -#ifdef _MSC_VER -#define PUT_GUIDS_HERE -#endif -#include "private.hpp" - -#ifndef _MSC_VER -const GUID CLSID_PortTopology = {0xb4c90a32L, 0x5791, 0x11d0, {0x86, 0xf9, 0x00, 0xa0, 0xc9, 0x11, 0xb5, 0x44}}; -const GUID CLSID_PortMidi = {0xb4c90a43L, 0x5791, 0x11d0, {0x86, 0xf9, 0x00, 0xa0, 0xc9, 0x11, 0xb5, 0x44}}; -const GUID CLSID_PortWaveCyclic = {0xb4c90a2aL, 0x5791, 0x11d0, {0x86, 0xf9, 0x00, 0xa0, 0xc9, 0x11, 0xb5, 0x44}}; -const GUID CLSID_PortWavePci = {0xb4c90a54L, 0x5791, 0x11d0, {0x86, 0xf9, 0x00, 0xa0, 0xc9, 0x11, 0xb5, 0x44}}; -const GUID CLSID_PortDMus = {0xb7902fe9L, 0xfb0a, 0x11d1, {0x81, 0xb0, 0x00, 0x60, 0x08, 0x33, 0x16, 0xc1}}; -const GUID CLSID_PortWaveRT = {0xcc9be57a, 0xeb9e, 0x42b4, {0x94, 0xfc, 0xc, 0xad, 0x3d, 0xbc, 0xe7, 0xfa}}; - -const GUID IID_IMiniportDMus = {0xc096df9dL, 0xfb09, 0x11d1, {0x81, 0xb0, 0x00, 0x60, 0x08, 0x33, 0x16, 0xc1}}; -const GUID IID_IMiniportTopology = {0xb4c90a31L, 0x5791, 0x11d0, {0x86, 0xf9, 0x00, 0xa0, 0xc9, 0x11, 0xb5, 0x44}}; -const GUID IID_IMiniportMidi = {0xb4c90a41L, 0x5791, 0x11d0, {0x86, 0xf9, 0x00, 0xa0, 0xc9, 0x11, 0xb5, 0x44}}; -const GUID IID_IMiniportWavePci = {0xb4c90a52L, 0x5791, 0x11d0, {0x86, 0xf9, 0x00, 0xa0, 0xc9, 0x11, 0xb5, 0x44}}; - -const GUID IID_IPortTopology = {0xb4c90a30L, 0x5791, 0x11d0, {0x86, 0xf9, 0x00, 0xa0, 0xc9, 0x11, 0xb5, 0x44}}; - -const GUID CLSID_MiniportDriverDMusUART = {0xd3f0ce1c, 0xfffc, 0x11d1, {0x81, 0xb0, 0x00, 0x60, 0x08, 0x33, 0x16, 0xc1}}; -const GUID CLSID_MiniportDriverDMusUARTCapture = {0xd3f0ce1d, 0xfffc, 0x11d1, {0x81, 0xb0, 0x00, 0x60, 0x08, 0x33, 0x16, 0xc1}}; -const GUID CLSID_MiniportDriverUart = {0xb4c90ae1L, 0x5791, 0x11d0, {0x86, 0xf9, 0x00, 0xa0, 0xc9, 0x11, 0xb5, 0x44}}; - -const GUID CLSID_MiniportDriverFmSynth = {0xb4c90ae0L, 0x5791, 0x11d0, {0x86, 0xf9, 0x00, 0xa0, 0xc9, 0x11, 0xb5, 0x44}}; -const GUID CLSID_MiniportDriverFmSynthWithVol = {0xe5a3c139L, 0xf0f2, 0x11d1, {0x81, 0xaf, 0x00, 0x60, 0x08, 0x33, 0x16, 0xc1}}; - -const GUID IID_IPort = {0xb4c90a25L, 0x5791, 0x11d0, {0x86, 0xf9, 0x00, 0xa0, 0xc9, 0x11, 0xb5, 0x44}}; -const GUID IID_IDrmPort = {0x286D3DF8L, 0xCA22, 0x4E2E, {0xB9, 0xBC, 0x20, 0xB4, 0xF0, 0xE2, 0x01, 0xCE}}; -const GUID IID_IDrmPort2 = {0x1ACCE59CL, 0x7311, 0x4B6B, {0x9F, 0xBA, 0xCC, 0x3B, 0xA5, 0x9A, 0xCD, 0xCE}}; -const GUID IID_IInterruptSync = {0x22C6AC63L, 0x851B, 0x11D0, {0x9A, 0x7F, 0x00, 0xAA, 0x00, 0x38, 0xAC, 0xFE}}; -const GUID IID_IPortWavePci = {0xb4c90a50L, 0x5791, 0x11d0, {0x86, 0xf9, 0x00, 0xa0, 0xc9, 0x11, 0xb5, 0x44}}; -const GUID IID_IPortWavePciStream = {0xb4c90a51L, 0x5791, 0x11d0, {0x86, 0xf9, 0x00, 0xa0, 0xc9, 0x11, 0xb5, 0x44}}; -const GUID IID_IPortMidi = {0xb4c90a40L, 0x5791, 0x11d0, {0x86, 0xf9, 0x00, 0xa0, 0xc9, 0x11, 0xb5, 0x44}}; -const GUID IID_IPortDMus = {0xc096df9cL, 0xfb09, 0x11d1, {0x81, 0xb0, 0x00, 0x60, 0x08, 0x33, 0x16, 0xc1}}; -const GUID IID_IAdapterPowerManagement = {0x793417D0L, 0x35FE, 0x11D1, {0xAD, 0x08, 0x00, 0xA0, 0xC9, 0x0A, 0xB1, 0xB0}}; - -const GUID IID_IMiniport = {0xb4c90a24, 0x5791, 0x11d0, {0x86, 0xf9, 0x00, 0xa0, 0xc9, 0x11, 0xb5, 0x44}}; -const GUID IID_IMiniportWaveCyclic = {0xb4c90a27L, 0x5791, 0x11d0, {0x86, 0xf9, 0x00, 0xa0, 0xc9, 0x11, 0xb5, 0x44}}; -const GUID IID_IPortWaveCyclic = {0xb4c90a26L, 0x5791, 0x11d0, {0x86, 0xf9, 0x00, 0xa0, 0xc9, 0x11, 0xb5, 0x44}}; -const GUID IID_IResourceList = {0x22C6AC60L, 0x851B, 0x11D0, {0x9A, 0x7F, 0x00, 0xAA, 0x00, 0x38, 0xAC, 0xFE}}; -const GUID IID_IServiceGroup = {0x22C6AC65L, 0x851B, 0x11D0, {0x9A, 0x7F, 0x00, 0xAA, 0x00, 0x38, 0xAC, 0xFE}}; -const GUID IID_IPinCount = {0x5dadb7dcL, 0xa2cb, 0x4540, {0xa4, 0xa8, 0x42, 0x5e, 0xe4, 0xae, 0x90, 0x51}}; -const GUID IID_IPowerNotify = {0x3DD648B8L, 0x969F, 0x11D1, {0x95, 0xA9, 0x00, 0xC0, 0x4F, 0xB9, 0x25, 0xD3}}; -const GUID IID_IDmaChannelSlave = {0x22C6AC62L, 0x851B, 0x11D0, {0x9A, 0x7F, 0x00, 0xAA, 0x00, 0x38, 0xAC, 0xFE}}; -const GUID IID_IDmaChannel = {0x22C6AC61L, 0x851B, 0x11D0, {0x9A, 0x7F, 0x00, 0xAA, 0x00, 0x38, 0xAC, 0xFE}}; -const GUID IID_IRegistryKey = {0xE8DA4302l, 0xF304, 0x11D0, {0x95, 0x8B, 0x00, 0xC0, 0x4F, 0xB9, 0x25, 0xD3}}; -const GUID IID_IServiceSink = {0x22C6AC64L, 0x851B, 0x11D0, {0x9A, 0x7F, 0x00, 0xAA, 0x00, 0x38, 0xAC, 0xFE}}; -const GUID IID_IPortClsVersion = {0x7D89A7BBL, 0x869B, 0x4567, {0x8D, 0xBE, 0x1E, 0x16, 0x8C, 0xC8, 0x53, 0xDE}}; -const GUID IID_IUnknown = {0x00000000, 0x0000, 0x0000, {0x00, 0x00, 0xC0, 0x00, 0x00, 0x00, 0x00, 0x46}}; -const GUID IID_IPortEvents = {0xA80F29C4L, 0x5498, 0x11D2, {0x95, 0xD9, 0x00, 0xC0, 0x4F, 0xB9, 0x25, 0xD3}}; -const GUID IID_IMusicTechnology = {0x80396C3C, 0xCBCB, 0x409B, {0x9F, 0x65, 0x4F, 0x1E, 0x74, 0x67, 0xCD, 0xAF}}; - -const GUID KSNAME_PIN = {0x146F1A80, 0x4791, 0x11D0, {0xA5, 0xD6, 0x28, 0xDB, 0x04, 0xC1, 0x00, 0x00}}; -const GUID IID_IDrmAudioStream = {0x1915c967, 0x3299, 0x48cb, {0xa3, 0xe4, 0x69, 0xfd, 0x1d, 0x1b, 0x30, 0x6e}}; - -//FIXME -// -const GUID KS_CATEGORY_AUDIO = {0x6994AD04, 0x93EF, 0x11D0, {0xA3, 0xCC, 0x00, 0xA0, 0xC9, 0x22, 0x31, 0x96}}; -const GUID KS_CATEGORY_RENDER = {0x65E8773E, 0x8F56, 0x11D0, {0xA3, 0xB9, 0x00, 0xA0, 0xC9, 0x22, 0x31, 0x96}}; -const GUID KS_CATEGORY_CAPTURE = {0x65E8773D, 0x8F56, 0x11D0, {0xA3, 0xB9, 0x00, 0xA0, 0xC9, 0x22, 0x31, 0x96}}; -const GUID KS_CATEGORY_TOPOLOGY = {0xDDA54A40, 0x1E4C, 0x11D1, {0xA0, 0x50, 0x40, 0x57, 0x05, 0xC1, 0x00, 0x00}}; - -/// -/// undocumented guids - -const GUID IID_ISubdevice = {0xB4C90A61, 0x5791, 0x11D0, {0x86, 0xF9, 0x00, 0xA0, 0xC9, 0x11, 0xB5, 0x44}}; -const GUID IID_IIrpTarget = {0xB4C90A60, 0x5791, 0x11D0, {0xF9, 0x86, 0x00, 0xA0, 0xC9, 0x11, 0xB5, 0x44}}; -const GUID IID_IIrpTargetFactory = {0xB4C90A62, 0x5791, 0x11D0, {0xF9, 0x86, 0x00, 0xA0, 0xC9, 0x11, 0xB5, 0x44}}; - - -/// -/// >= Vista GUIDs -/// -const GUID IID_IPortWaveRT = {0x339ff909, 0x68a9, 0x4310, {0xb0, 0x9b, 0x27, 0x4e, 0x96, 0xee, 0x4c, 0xbd}}; -const GUID IID_IPortWaveRTStream = {0x1809ce5a, 0x64bc, 0x4e62, {0xbd, 0x7d, 0x95, 0xbc, 0xe4, 0x3d, 0xe3, 0x93}}; -const GUID IID_IMiniportWaveRT = {0x0f9fc4d6, 0x6061, 0x4f3c, {0xb1, 0xfc, 0x7, 0x5e, 0x35, 0xf7, 0x96, 0xa}}; -const GUID IID_IMiniportWaveRTStream = {0x000ac9ab, 0xfaab, 0x4f3d, {0x94, 0x55, 0x6f, 0xf8, 0x30, 0x6a, 0x74, 0xa0}}; -const GUID IID_IMiniportWaveRTStreamNotification = {0x23759128, 0x96f1, 0x423b, {0xab, 0x4d, 0x81, 0x63, 0x5b, 0xcf, 0x8c, 0xa1}}; -const GUID IID_IUnregisterSubdevice = {0x16738177, 0xe199, 0x41f9, {0x9a, 0x87, 0xab, 0xb2, 0xa5, 0x43, 0x2f, 0x21}}; -const GUID IID_IUnregisterPhysicalConnection = {0x6c38e231, 0x2a0d, 0x428d, {0x81, 0xf8, 0x07, 0xcc, 0x42, 0x8b, 0xb9, 0xa4}}; - -#endif Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/port.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… ============================================================================== --- trunk/reactos/drivers/wdm/audio/backpln/portcls/port.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/backpln/portcls/port.cpp [iso-8859-1] Sun Apr 7 14:11:21 2013 @@ -7,6 +7,7 @@ * Andrew Greenwood */ +#include <initguid.h> #include "private.hpp"

1 0

[pschweitzer] 58712: [KS] Fix copy/paste error
by pschweitzer＠svn.reactos.org 07 Apr '13

07 Apr '13

Author: pschweitzer Date: Sun Apr 7 11:36:33 2013 New Revision: 58712 URL: http://svn.reactos.org/svn/reactos?rev=58712&view=rev Log: [KS] Fix copy/paste error Modified: trunk/reactos/drivers/ksfilter/ks/irp.c Modified: trunk/reactos/drivers/ksfilter/ks/irp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/ksfilter/ks/irp.c?… ============================================================================== --- trunk/reactos/drivers/ksfilter/ks/irp.c [iso-8859-1] (original) +++ trunk/reactos/drivers/ksfilter/ks/irp.c [iso-8859-1] Sun Apr 7 11:36:33 2013 @@ -1177,7 +1177,8 @@ if (IoStack->Parameters.DeviceIoControl.IoControlCode != IOCTL_KS_PROPERTY && IoStack->Parameters.DeviceIoControl.IoControlCode != IOCTL_KS_METHOD && - IoStack->Parameters.DeviceIoControl.IoControlCode != IOCTL_KS_PROPERTY) + IoStack->Parameters.DeviceIoControl.IoControlCode != IOCTL_KS_ENABLE_EVENT && + IoStack->Parameters.DeviceIoControl.IoControlCode != IOCTL_KS_DISABLE_EVENT) { if (IoStack->Parameters.DeviceIoControl.IoControlCode == IOCTL_KS_RESET_STATE) {

1 0

[pschweitzer] 58711: [KS] Check parameters before using them and not after
by pschweitzer＠svn.reactos.org 07 Apr '13

07 Apr '13

Author: pschweitzer Date: Sun Apr 7 11:35:50 2013 New Revision: 58711 URL: http://svn.reactos.org/svn/reactos?rev=58711&view=rev Log: [KS] Check parameters before using them and not after Modified: trunk/reactos/drivers/ksfilter/ks/event.c Modified: trunk/reactos/drivers/ksfilter/ks/event.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/ksfilter/ks/event.… ============================================================================== --- trunk/reactos/drivers/ksfilter/ks/event.c [iso-8859-1] (original) +++ trunk/reactos/drivers/ksfilter/ks/event.c [iso-8859-1] Sun Apr 7 11:35:50 2013 @@ -421,17 +421,17 @@ PKSEVENT_ENTRY EventEntry; PLIST_ENTRY Entry; + if (!Ctx || !Ctx->List || !Ctx->FileObject || !Ctx->Irp) + { + /* invalid parameter */ + return FALSE; + } + /* get current irp stack location */ IoStack = IoGetCurrentIrpStackLocation(Ctx->Irp); /* get event data */ EventData = (PKSEVENTDATA)IoStack->Parameters.DeviceIoControl.Type3InputBuffer; - - if (!Ctx || !Ctx->List || !Ctx->FileObject || !Ctx->Irp) - { - /* invalid parameter */ - return FALSE; - } /* point to first entry */ Entry = Ctx->List->Flink;

1 0

[pschweitzer] 58710: [DEVMGMT] Don't use uninitialized memory address when calling InsertIntoTreeView()
by pschweitzer＠svn.reactos.org 07 Apr '13

07 Apr '13

Author: pschweitzer Date: Sun Apr 7 11:06:00 2013 New Revision: 58710 URL: http://svn.reactos.org/svn/reactos?rev=58710&view=rev Log: [DEVMGMT] Don't use uninitialized memory address when calling InsertIntoTreeView() Modified: trunk/reactos/base/applications/mscutils/devmgmt/enumdevices.c Modified: trunk/reactos/base/applications/mscutils/devmgmt/enumdevices.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/devmgmt/enumdevices.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/devmgmt/enumdevices.c [iso-8859-1] Sun Apr 7 11:06:00 2013 @@ -472,7 +472,7 @@ TCHAR ClassGuidString[MAX_GUID_STRING_LEN]; GUID ClassGuid; ULONG ulLength; - LPTSTR DeviceID; + LPTSTR DeviceID = NULL; INT ClassImage = 24; CONFIGRET cr;

1 0

[tfaber] 58709: [PORTCLS] - Remove a duplicate assignment. Patch by Víctor Martínez Calvo. CORE-7057 #resolve
by tfaber＠svn.reactos.org 07 Apr '13

07 Apr '13

Author: tfaber Date: Sun Apr 7 11:02:28 2013 New Revision: 58709 URL: http://svn.reactos.org/svn/reactos?rev=58709&view=rev Log: [PORTCLS] - Remove a duplicate assignment. Patch by Víctor Martínez Calvo. CORE-7057 #resolve Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.cpp Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… ============================================================================== --- trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.cpp [iso-8859-1] Sun Apr 7 11:02:28 2013 @@ -501,8 +501,6 @@ //UNICODE_STRING GuidString; PIO_STACK_LOCATION IoStack; - IoStack = IoGetCurrentIrpStackLocation(Irp); - //DPRINT("IPortPinWave_HandleKsProperty entered\n"); IoStack = IoGetCurrentIrpStackLocation(Irp);

1 0

[tfaber] 58708: [NTDLL_APITEST] CORE-7065 #comment Temporarily disable the crashing test to get meaningful testbot results again.
by tfaber＠svn.reactos.org 07 Apr '13

07 Apr '13

Author: tfaber Date: Sun Apr 7 10:47:10 2013 New Revision: 58708 URL: http://svn.reactos.org/svn/reactos?rev=58708&view=rev Log: [NTDLL_APITEST] CORE-7065 #comment Temporarily disable the crashing test to get meaningful testbot results again. Modified: trunk/rostests/apitests/ntdll/NtMapViewOfSection.c Modified: trunk/rostests/apitests/ntdll/NtMapViewOfSection.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/NtMapViewO… ============================================================================== --- trunk/rostests/apitests/ntdll/NtMapViewOfSection.c [iso-8859-1] (original) +++ trunk/rostests/apitests/ntdll/NtMapViewOfSection.c [iso-8859-1] Sun Apr 7 10:47:10 2013 @@ -103,7 +103,9 @@ MEM_COMMIT, PAGE_READWRITE); ok(NT_SUCCESS(Status), "NtAllocateVirtualMemory failed with Status %lx\n", Status); - +#ifndef CORE_7065_FIXED + ok(0, "Committing a range larger than the section crashes. See CORE-7065\n"); +#else /* Try to commit a range larger than the section */ BaseAddress = (PVOID)0x30000000; ViewSize = 0x3000; @@ -115,7 +117,7 @@ PAGE_READWRITE); ok(Status == STATUS_CONFLICTING_ADDRESSES, "NtAllocateVirtualMemory failed with wrong Status %lx\n", Status); - +#endif /* Try to commit a page after the section */ BaseAddress = (PVOID)0x30002000; ViewSize = 0x1000;

1 0

[jgardou] 58707: [MESA32] * Use SSE optimizations again
by jgardou＠svn.reactos.org 07 Apr '13

07 Apr '13

Author: jgardou Date: Sun Apr 7 10:18:28 2013 New Revision: 58707 URL: http://svn.reactos.org/svn/reactos?rev=58707&view=rev Log: [MESA32] * Use SSE optimizations again Modified: trunk/reactos/dll/opengl/mesa/src/mesa/CMakeLists.txt Modified: trunk/reactos/dll/opengl/mesa/src/mesa/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/opengl/mesa/src/mesa/C… ============================================================================== --- trunk/reactos/dll/opengl/mesa/src/mesa/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/opengl/mesa/src/mesa/CMakeLists.txt [iso-8859-1] Sun Apr 7 10:18:28 2013 @@ -21,7 +21,7 @@ x86/common_x86.c # x86/x86_xform.c # x86/3dnow.c - # x86/sse.c + x86/sse.c x86/common_x86_asm.S x86/x86_xform2.S x86/x86_xform3.S @@ -33,17 +33,17 @@ x86/3dnow_xform3.S x86/3dnow_xform4.S x86/3dnow_normal.S - # x86/sse_xform1.S - # x86/sse_xform2.S - # x86/sse_xform3.S - # x86/sse_xform4.S - # x86/sse_normal.S + x86/sse_xform1.S + x86/sse_xform2.S + x86/sse_xform3.S + x86/sse_xform4.S + x86/sse_normal.S x86/read_rgba_span_x86.S) add_definitions( -DUSE_X86_ASM -DUSE_MMX_ASM -DUSE_3DNOW_ASM - # -DUSE_SSE_ASM + -DUSE_SSE_ASM ) endif()

1 0

← Newer
1
...
16
17
18
19
20
21
22
...
27
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs April 2013