Ros-diffs April 2013

ros-diffs@reactos.org

14 participants
265 discussions

[jgardou] 58706: [NTOS/KE] * Reset the state of the right thread when switching NPX threads

by jgardou＠svn.reactos.org

Author: jgardou Date: Sun Apr 7 10:17:44 2013 New Revision: 58706 URL: http://svn.reactos.org/svn/reactos?rev=58706&view=rev Log: [NTOS/KE] * Reset the state of the right thread when switching NPX threads Modified: trunk/reactos/ntoskrnl/ke/i386/traphdlr.c Modified: trunk/reactos/ntoskrnl/ke/i386/traphdlr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/traphdlr.… ============================================================================== --- trunk/reactos/ntoskrnl/ke/i386/traphdlr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ke/i386/traphdlr.c [iso-8859-1] Sun Apr 7 10:17:44 2013 @@ -756,7 +756,7 @@ //Ke386SaveFpuState(NpxSaveArea); /* Update NPX state */ - Thread->NpxState = NPX_STATE_NOT_LOADED; + NpxThread->NpxState = NPX_STATE_NOT_LOADED; } /* Load FPU state */

11 years, 8 months

[pschweitzer] 58705: [CMD] Fix yet another memory leak

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Sun Apr 7 10:02:06 2013 New Revision: 58705 URL: http://svn.reactos.org/svn/reactos?rev=58705&view=rev Log: [CMD] Fix yet another memory leak Modified: trunk/reactos/base/shell/cmd/start.c Modified: trunk/reactos/base/shell/cmd/start.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/start.c?rev… ============================================================================== --- trunk/reactos/base/shell/cmd/start.c [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/start.c [iso-8859-1] Sun Apr 7 10:02:06 2013 @@ -193,9 +193,11 @@ { if (size > MAX_PATH) { + LPTSTR Oldcomspec = comspec; comspec = cmd_realloc(comspec,size * sizeof(TCHAR) ); if (comspec==NULL) { + cmd_free(Oldcomspec); return 1; } size = GetEnvironmentVariable (_T("COMSPEC"), comspec, size);

11 years, 8 months

[jgardou] 58704: [PORTCLS] * Fix copy-pasta CORE-7053 #comment Fixed in r58704, thanks for deciphering PVS studio report ; -) #resolve

by jgardou＠svn.reactos.org

Author: jgardou Date: Sun Apr 7 09:58:05 2013 New Revision: 58704 URL: http://svn.reactos.org/svn/reactos?rev=58704&view=rev Log: [PORTCLS] * Fix copy-pasta CORE-7053 #comment Fixed in r58704, thanks for deciphering PVS studio report ;-) #resolve Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.cpp Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… ============================================================================== --- trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.cpp [iso-8859-1] Sun Apr 7 09:58:05 2013 @@ -559,7 +559,7 @@ if (m_Capture) m_Position.WriteOffset += Data; else - m_Position.WriteOffset += Data; + m_Position.PlayOffset += Data; if (bFailed) {

11 years, 8 months

[pschweitzer] 58703: [CMD] Fix a bug in path command where PATH variable could never be read if it was bigger than ENV_BUFFER_SIZE

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Sun Apr 7 08:53:37 2013 New Revision: 58703 URL: http://svn.reactos.org/svn/reactos?rev=58703&view=rev Log: [CMD] Fix a bug in path command where PATH variable could never be read if it was bigger than ENV_BUFFER_SIZE Modified: trunk/reactos/base/shell/cmd/path.c Modified: trunk/reactos/base/shell/cmd/path.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/path.c?rev=… ============================================================================== --- trunk/reactos/base/shell/cmd/path.c [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/path.c [iso-8859-1] Sun Apr 7 08:53:37 2013 @@ -61,7 +61,7 @@ else if (dwBuffer > ENV_BUFFER_SIZE) { pszBuffer = (LPTSTR)cmd_realloc (pszBuffer, dwBuffer * sizeof (TCHAR)); - GetEnvironmentVariable (_T("PATH"), pszBuffer, ENV_BUFFER_SIZE); + GetEnvironmentVariable (_T("PATH"), pszBuffer, dwBuffer); } ConOutPrintf (_T("PATH=%s\n"), pszBuffer);

11 years, 8 months

[pschweitzer] 58702: [CMD] Fix two memory leaks

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Sun Apr 7 08:51:20 2013 New Revision: 58702 URL: http://svn.reactos.org/svn/reactos?rev=58702&view=rev Log: [CMD] Fix two memory leaks Modified: trunk/reactos/base/shell/cmd/for.c trunk/reactos/base/shell/cmd/path.c Modified: trunk/reactos/base/shell/cmd/for.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/for.c?rev=5… ============================================================================== --- trunk/reactos/base/shell/cmd/for.c [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/for.c [iso-8859-1] Sun Apr 7 08:51:20 2013 @@ -105,9 +105,13 @@ ULONG_PTR CharsRead = _tcslen(Buffer); while (Len + CharsRead >= AllocLen) { + LPTSTR OldContents = Contents; Contents = cmd_realloc(Contents, (AllocLen *= 2) * sizeof(TCHAR)); if (!Contents) + { + cmd_free(OldContents); return NULL; + } } _tcscpy(&Contents[Len], Buffer); Len += CharsRead; Modified: trunk/reactos/base/shell/cmd/path.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/path.c?rev=… ============================================================================== --- trunk/reactos/base/shell/cmd/path.c [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/path.c [iso-8859-1] Sun Apr 7 08:51:20 2013 @@ -54,7 +54,8 @@ dwBuffer = GetEnvironmentVariable (_T("PATH"), pszBuffer, ENV_BUFFER_SIZE); if (dwBuffer == 0) { - ConOutResPrintf(STRING_VOL_HELP2, _T("PATH")); + cmd_free(pszBuffer); + ConOutResPrintf(STRING_VOL_HELP2, _T("PATH")); return 0; } else if (dwBuffer > ENV_BUFFER_SIZE)

11 years, 8 months

[pschweitzer] 58701: [TELNET] Don't attempt to close undefined handles. Also properly set them on failure as "the contents of the output parameters are indeterminate" on failure.

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Sat Apr 6 23:27:56 2013 New Revision: 58701 URL: http://svn.reactos.org/svn/reactos?rev=58701&view=rev Log: [TELNET] Don't attempt to close undefined handles. Also properly set them on failure as "the contents of the output parameters are indeterminate" on failure. Modified: trunk/reactos/base/applications/network/telnet/src/tnmisc.cpp Modified: trunk/reactos/base/applications/network/telnet/src/tnmisc.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/… ============================================================================== --- trunk/reactos/base/applications/network/telnet/src/tnmisc.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/network/telnet/src/tnmisc.cpp [iso-8859-1] Sat Apr 6 23:27:56 2013 @@ -8,9 +8,9 @@ BOOL fCreated; STARTUPINFO si; SECURITY_ATTRIBUTES sa; - HANDLE hInRead; - HANDLE hOutWrite; - HANDLE hErrWrite; + HANDLE hInRead = INVALID_HANDLE_VALUE; + HANDLE hOutWrite = INVALID_HANDLE_VALUE; + HANDLE hErrWrite = INVALID_HANDLE_VALUE; // Create pipes // initialize security attributes for handle inheritance (for WinNT) @@ -19,16 +19,22 @@ sa.lpSecurityDescriptor = NULL; // create STDIN pipe - if( !CreatePipe( &hInRead, phInWrite, &sa, 0 )) + if( !CreatePipe( &hInRead, phInWrite, &sa, 0 )) { + hInRead = INVALID_HANDLE_VALUE; goto error; + } // create STDOUT pipe - if( !CreatePipe( phOutRead, &hOutWrite, &sa, 0 )) + if( !CreatePipe( phOutRead, &hOutWrite, &sa, 0 )) { + hOutWrite = INVALID_HANDLE_VALUE; goto error; + } // create STDERR pipe - if( !CreatePipe( phErrRead, &hErrWrite, &sa, 0 )) + if( !CreatePipe( phErrRead, &hErrWrite, &sa, 0 )) { + hErrWrite = INVALID_HANDLE_VALUE; goto error; + } // process startup information memset( &si, 0, sizeof( si )); @@ -63,9 +69,9 @@ return TRUE; error: - CloseHandle( hInRead ); - CloseHandle( hOutWrite ); - CloseHandle( hErrWrite ); + if (hInRead != INVALID_HANDLE_VALUE) CloseHandle( hInRead ); + if (hOutWrite != INVALID_HANDLE_VALUE) CloseHandle( hOutWrite ); + if (hErrWrite != INVALID_HANDLE_VALUE) CloseHandle( hErrWrite ); CloseHandle( ppi->hProcess ); CloseHandle( ppi->hThread );

11 years, 8 months

[pschweitzer] 58700: [CRT] Apply r58698 here as well

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Sat Apr 6 23:14:29 2013 New Revision: 58700 URL: http://svn.reactos.org/svn/reactos?rev=58700&view=rev Log: [CRT] Apply r58698 here as well Modified: trunk/reactos/lib/sdk/crt/locale/locale.c Modified: trunk/reactos/lib/sdk/crt/locale/locale.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/locale/locale.… ============================================================================== --- trunk/reactos/lib/sdk/crt/locale/locale.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/locale/locale.c [iso-8859-1] Sat Apr 6 23:14:29 2013 @@ -322,7 +322,7 @@ len += GetLocaleInfoA(lcid, LOCALE_SENGCOUNTRY |LOCALE_NOUSEROVERRIDE, &buf[len], 256-len); buf[len-1] = '.'; - sprintf(buf+len, "%d", cp); + sprintf(buf+len, "%u", cp); len += strlen(buf+len)+1; loc->locinfo->lc_category[category].locale = MSVCRT_malloc(len);

11 years, 8 months

[pschweitzer] 58699: [CRT] Apply r58698 here as well

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Sat Apr 6 23:12:45 2013 New Revision: 58699 URL: http://svn.reactos.org/svn/reactos?rev=58699&view=rev Log: [CRT] Apply r58698 here as well Modified: trunk/reactos/lib/sdk/crt/startup/crtexe.c Modified: trunk/reactos/lib/sdk/crt/startup/crtexe.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/startup/crtexe… ============================================================================== --- trunk/reactos/lib/sdk/crt/startup/crtexe.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/startup/crtexe.c [iso-8859-1] Sat Apr 6 23:12:45 2013 @@ -418,7 +418,7 @@ uintptr_t __UNUSED_PARAM(pReserved)) { #ifdef __MINGW_SHOW_INVALID_PARAMETER_EXCEPTION - wprintf(L"Invalid parameter detected in function %s. File: %s Line: %d\n", function, file, line); + wprintf(L"Invalid parameter detected in function %s. File: %s Line: %u\n", function, file, line); wprintf(L"Expression: %s\n", expression); #endif }

11 years, 8 months

[pschweitzer] 58698: [CRT] Fix format according to var

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Sat Apr 6 23:10:55 2013 New Revision: 58698 URL: http://svn.reactos.org/svn/reactos?rev=58698&view=rev Log: [CRT] Fix format according to var Modified: trunk/reactos/lib/sdk/crt/misc/assert.c Modified: trunk/reactos/lib/sdk/crt/misc/assert.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/misc/assert.c?… ============================================================================== --- trunk/reactos/lib/sdk/crt/misc/assert.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/misc/assert.c [iso-8859-1] Sat Apr 6 23:10:55 2013 @@ -35,7 +35,7 @@ (msvcrt_error_mode == _OUT_TO_STDERR)) { /* Print 'Assertion failed: x<y, file foo.c, line 45' to stderr */ - fprintf(stderr, "Assertion failed: %s, file %s, line %d\n", exp, file, line); + fprintf(stderr, "Assertion failed: %s, file %s, line %u\n", exp, file, line); abort(); }

11 years, 8 months

[jgardou] 58697: [PSDK] * Don't be so complicated for defining the DEFINE_GUIDSTRUCT and DEFINE_GUIDNAMED macros on GCC CORE-7052 #comment fixed in 58697, thanks. #resolve

by jgardou＠svn.reactos.org

Author: jgardou Date: Sat Apr 6 22:38:00 2013 New Revision: 58697 URL: http://svn.reactos.org/svn/reactos?rev=58697&view=rev Log: [PSDK] * Don't be so complicated for defining the DEFINE_GUIDSTRUCT and DEFINE_GUIDNAMED macros on GCC CORE-7052 #comment fixed in 58697, thanks. #resolve Modified: trunk/reactos/include/psdk/ks.h Modified: trunk/reactos/include/psdk/ks.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/ks.h?rev=5869… ============================================================================== --- trunk/reactos/include/psdk/ks.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/ks.h [iso-8859-1] Sat Apr 6 22:38:00 2013 @@ -85,21 +85,9 @@ #define DEFINE_GUIDSTRUCT(guid, name) struct __declspec(uuid(guid)) name #define DEFINE_GUIDNAMED(name) __uuidof(struct name) #else - extern "C++" { - template<typename T> const GUID &__mingw_uuidof(); - } - #define DEFINE_GUIDSTRUCT(guid, name) \ - struct __guid ## name; \ - extern "C++" { \ - template<> inline const GUID &__mingw_uuidof<__guid ## name>() { \ - static const IID iid = {STATICGUIDOF(name)}; \ - return iid; \ - } \ - template<> inline const GUID &__mingw_uuidof<__guid ## name *>() { \ - return __mingw_uuidof<__guid ## name>(); \ - } \ - } - #define DEFINE_GUIDNAMED(name) __mingw_uuidof<__guid ## name>() + #define DEFINE_GUIDSTRUCT(guid, name) \ + extern const DECLSPEC_SELECTANY GUID __uuid__##name={STATIC_##name}; + #define DEFINE_GUIDNAMED(name) __uuid__##name #endif #else #define DEFINE_GUIDSTRUCT(guid, name) DEFINE_GUIDEX(name)

11 years, 8 months

← Newer
1
...
17
18
19
20
21
22
23
...
27
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs April 2013