Ros-diffs July 2013

ros-diffs@reactos.org

13 participants
199 discussions

[hbelusca] 59514: Add the SYNCHRONIZE flag to the DesiredAccess parameter when using the flags FILE_SYNCHRONOUS_IO_(NON)ALERT in NtCreateFile or NtOpenFile, even if one uses DesiredAccess == GENERI...
by hbelusca＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: hbelusca Date: Fri Jul 19 15:05:28 2013 New Revision: 59514 URL: http://svn.reactos.org/svn/reactos?rev=59514&view=rev Log: Add the SYNCHRONIZE flag to the DesiredAccess parameter when using the flags FILE_SYNCHRONOUS_IO_(NON)ALERT in NtCreateFile or NtOpenFile, even if one uses DesiredAccess == GENERIC_xxx (which should map to some FILE_GENERIC_xxx already containing the SYNCHRONIZE flag). Indeed, it appears after extended testing that, when calling from user-mode, Windows checks the real presence of the SYNCHRONIZE flag when using FILE_SYNCHRONOUS_IO_(NON)ALERT even if we pass any of the GENERIC_xxx access flags... Otherwise, when using FILE_GENERIC_(READ/WRITE) flags directly, there is no need to add the SYNCHRONIZE flag since it is already incorporated in it. See CORE-7361 for more details. Modified: trunk/reactos/dll/win32/kernel32/client/file/create.c trunk/reactos/dll/win32/kernel32/client/file/npipe.c trunk/reactos/dll/win32/kernel32/client/file/volume.c trunk/reactos/dll/win32/ntmarta/ntmarta.c trunk/reactos/lib/rtl/actctx.c trunk/reactos/ntoskrnl/io/iomgr/bootlog.c trunk/reactos/ntoskrnl/io/iomgr/ramdisk.c trunk/reactos/ntoskrnl/kdbg/kdb_cli.c trunk/reactos/ntoskrnl/kdbg/kdb_symbols.c Modified: trunk/reactos/dll/win32/kernel32/client/file/create.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/file/create.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/file/create.c [iso-8859-1] Fri Jul 19 15:05:28 2013 @@ -535,11 +535,11 @@ ObjectAttributes.SecurityQualityOfService = NULL; errCode = NtOpenFile (&FileHandle, - GENERIC_READ|SYNCHRONIZE, + GENERIC_READ | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, FILE_SHARE_READ, - FILE_NON_DIRECTORY_FILE|FILE_SYNCHRONOUS_IO_NONALERT); + FILE_NON_DIRECTORY_FILE | FILE_SYNCHRONOUS_IO_NONALERT); RtlFreeHeap(RtlGetProcessHeap(), 0, FileNameString.Buffer); Modified: trunk/reactos/dll/win32/kernel32/client/file/npipe.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/file/npipe.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/file/npipe.c [iso-8859-1] Fri Jul 19 15:05:28 2013 @@ -105,7 +105,7 @@ /* Now try opening it for write access */ Status = NtOpenFile(&WritePipeHandle, - FILE_GENERIC_WRITE | SYNCHRONIZE, + FILE_GENERIC_WRITE, &ObjectAttributes, &StatusBlock, FILE_SHARE_READ, Modified: trunk/reactos/dll/win32/kernel32/client/file/volume.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/file/volume.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/file/volume.c [iso-8859-1] Fri Jul 19 15:05:28 2013 @@ -967,7 +967,7 @@ RtlInitUnicodeString(&NtFileName, L"\\??\\MountPointManager"); InitializeObjectAttributes(&ObjectAttributes, &NtFileName, 0, NULL, NULL); - Status = NtOpenFile(&FileHandle, FILE_GENERIC_READ | SYNCHRONIZE, &ObjectAttributes, + Status = NtOpenFile(&FileHandle, FILE_GENERIC_READ, &ObjectAttributes, &Iosb, FILE_SHARE_READ | FILE_SHARE_WRITE, FILE_SYNCHRONOUS_IO_NONALERT); if (!NT_SUCCESS(Status)) Modified: trunk/reactos/dll/win32/ntmarta/ntmarta.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ntmarta/ntmarta.… ============================================================================== --- trunk/reactos/dll/win32/ntmarta/ntmarta.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/ntmarta/ntmarta.c [iso-8859-1] Fri Jul 19 15:05:28 2013 @@ -887,7 +887,7 @@ NULL); Status = NtOpenFile(Handle, - DesiredAccess, + DesiredAccess /* | SYNCHRONIZE */, &ObjectAttributes, &IoStatusBlock, FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE, Modified: trunk/reactos/lib/rtl/actctx.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/actctx.c?rev=59514… ============================================================================== --- trunk/reactos/lib/rtl/actctx.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/actctx.c [iso-8859-1] Fri Jul 19 15:05:28 2013 @@ -1618,7 +1618,11 @@ attr.ObjectName = name; attr.SecurityDescriptor = NULL; attr.SecurityQualityOfService = NULL; - return NtOpenFile( handle, GENERIC_READ, &attr, &io, FILE_SHARE_READ, FILE_SYNCHRONOUS_IO_ALERT ); + return NtOpenFile(handle, + GENERIC_READ | SYNCHRONIZE, + &attr, &io, + FILE_SHARE_READ, + FILE_SYNCHRONOUS_IO_ALERT); } static NTSTATUS get_module_filename( HMODULE module, UNICODE_STRING *str, USHORT extra_len ) @@ -1952,8 +1956,11 @@ attr.SecurityDescriptor = NULL; attr.SecurityQualityOfService = NULL; - if (!NtOpenFile( &handle, GENERIC_READ, &attr, &io, FILE_SHARE_READ | FILE_SHARE_WRITE, - FILE_DIRECTORY_FILE | FILE_SYNCHRONOUS_IO_NONALERT )) + if (!NtOpenFile(&handle, + GENERIC_READ | SYNCHRONIZE, + &attr, &io, + FILE_SHARE_READ | FILE_SHARE_WRITE, + FILE_DIRECTORY_FILE | FILE_SYNCHRONOUS_IO_NONALERT)) { sxs_ai = *ai; file = lookup_manifest_file( handle, &sxs_ai ); Modified: trunk/reactos/ntoskrnl/io/iomgr/bootlog.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/bootlog.… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/bootlog.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/bootlog.c [iso-8859-1] Fri Jul 19 15:05:28 2013 @@ -168,7 +168,7 @@ NULL); Status = ZwCreateFile(&FileHandle, - FILE_APPEND_DATA, + FILE_APPEND_DATA | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, NULL, Modified: trunk/reactos/ntoskrnl/io/iomgr/ramdisk.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/ramdisk.… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/ramdisk.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/ramdisk.c [iso-8859-1] Fri Jul 19 15:05:28 2013 @@ -161,7 +161,7 @@ // Open a handle to the driver // Status = ZwOpenFile(&DriverHandle, - GENERIC_ALL, + GENERIC_ALL | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, FILE_SHARE_READ | FILE_SHARE_WRITE, Modified: trunk/reactos/ntoskrnl/kdbg/kdb_cli.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kdbg/kdb_cli.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/kdbg/kdb_cli.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kdbg/kdb_cli.c [iso-8859-1] Fri Jul 19 15:05:28 2013 @@ -3578,7 +3578,8 @@ InitializeObjectAttributes(&ObjectAttributes, &FileName, 0, NULL, NULL); /* Open the file */ - Status = ZwOpenFile(&hFile, FILE_READ_DATA, &ObjectAttributes, &Iosb, 0, + Status = ZwOpenFile(&hFile, FILE_READ_DATA | SYNCHRONIZE, + &ObjectAttributes, &Iosb, 0, FILE_NON_DIRECTORY_FILE | FILE_SYNCHRONOUS_IO_NONALERT | FILE_NO_INTERMEDIATE_BUFFERING); if (!NT_SUCCESS(Status)) Modified: trunk/reactos/ntoskrnl/kdbg/kdb_symbols.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kdbg/kdb_symbols.… ============================================================================== --- trunk/reactos/ntoskrnl/kdbg/kdb_symbols.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kdbg/kdb_symbols.c [iso-8859-1] Fri Jul 19 15:05:28 2013 @@ -391,10 +391,10 @@ DPRINT("Attempting to open image: %wZ\n", FileName); Status = ZwOpenFile(&FileHandle, - FILE_READ_ACCESS, + FILE_READ_ACCESS | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, - FILE_SHARE_READ|FILE_SHARE_WRITE, + FILE_SHARE_READ | FILE_SHARE_WRITE, FILE_SYNCHRONOUS_IO_NONALERT); if (!NT_SUCCESS(Status)) {

1 0

[tfaber] 59513: [WIDL] - Apply Wine commit "widl: Avoid short printf formats with int variables." (7ca08fee) by Alexandre Julliard. Fixes clang warnings
by tfaber＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: tfaber Date: Fri Jul 19 14:24:22 2013 New Revision: 59513 URL: http://svn.reactos.org/svn/reactos?rev=59513&view=rev Log: [WIDL] - Apply Wine commit "widl: Avoid short printf formats with int variables." (7ca08fee) by Alexandre Julliard. Fixes clang warnings Modified: trunk/reactos/tools/widl/typegen.c Modified: trunk/reactos/tools/widl/typegen.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/typegen.c?rev=5… ============================================================================== --- trunk/reactos/tools/widl/typegen.c [iso-8859-1] (original) +++ trunk/reactos/tools/widl/typegen.c [iso-8859-1] Fri Jul 19 14:24:22 2013 @@ -1158,7 +1158,7 @@ if (flags >> 13) sprintf( buffer + strlen(buffer), " srv size=%u,", (flags >> 13) * 8 ); strcpy( buffer + strlen( buffer ) - 1, " */" ); print_file( file, indent, "NdrFcShort(0x%hx),\t%s\n", flags, buffer ); - print_file( file, indent, "NdrFcShort(0x%hx), /* stack offset = %hu */\n", + print_file( file, indent, "NdrFcShort(0x%x), /* stack offset = %u */\n", *stack_offset, *stack_offset ); if (flags & IsBasetype) { @@ -1332,7 +1332,7 @@ print_file( file, indent, "0x%02x,\n", oi_flags ); print_file( file, indent, "NdrFcLong(0x%x),\n", rpc_flags ); print_file( file, indent, "NdrFcShort(0x%hx),\t/* method %hu */\n", num_proc, num_proc ); - print_file( file, indent, "NdrFcShort(0x%hx),\t/* stack size = %hu */\n", stack_size, stack_size ); + print_file( file, indent, "NdrFcShort(0x%x),\t/* stack size = %u */\n", stack_size, stack_size ); *offset += 10; if (!implicit_fc) @@ -1380,9 +1380,9 @@ if (is_attr( func->attrs, ATTR_NOTIFYFLAG )) ext_flags |= 0x10; /* HasNotify2 */ size = get_function_buffer_size( func, PASS_IN ); - print_file( file, indent, "NdrFcShort(0x%x),\t/* client buffer = %hu */\n", size, size ); + print_file( file, indent, "NdrFcShort(0x%x),\t/* client buffer = %u */\n", size, size ); size = get_function_buffer_size( func, PASS_OUT ); - print_file( file, indent, "NdrFcShort(0x%x),\t/* server buffer = %hu */\n", size, size ); + print_file( file, indent, "NdrFcShort(0x%x),\t/* server buffer = %u */\n", size, size ); print_file( file, indent, "0x%02x,\n", oi2_flags ); print_file( file, indent, "0x%02x,\t/* %u params */\n", nb_args, nb_args ); print_file( file, indent, "0x%02x,\n", pointer_size == 8 ? 10 : 8 );

1 0

[hbelusca] 59512: Add the SYNCHRONIZE flag to the DesiredAccess parameter when using the flags FILE_SYNCHRONOUS_IO_(NON)ALERT in NtCreateFile or NtOpenFile, even if one uses DesiredAccess == GENERI...
by hbelusca＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: hbelusca Date: Fri Jul 19 14:03:46 2013 New Revision: 59512 URL: http://svn.reactos.org/svn/reactos?rev=59512&view=rev Log: Add the SYNCHRONIZE flag to the DesiredAccess parameter when using the flags FILE_SYNCHRONOUS_IO_(NON)ALERT in NtCreateFile or NtOpenFile, even if one uses DesiredAccess == GENERIC_xxx (which should map to some FILE_GENERIC_xxx already containing the SYNCHRONIZE flag). Indeed, it appears after extended testing that, when calling from user-mode, Windows checks the real presence of the SYNCHRONIZE flag when using FILE_SYNCHRONOUS_IO_(NON)ALERT even if we pass any of the GENERIC_xxx access flags... Part 1/X Modified: trunk/reactos/base/setup/usetup/bootsup.c trunk/reactos/base/setup/usetup/filesup.c trunk/reactos/base/setup/usetup/inicache.c Modified: trunk/reactos/base/setup/usetup/bootsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/bootsup.… ============================================================================== --- trunk/reactos/base/setup/usetup/bootsup.c [iso-8859-1] (original) +++ trunk/reactos/base/setup/usetup/bootsup.c [iso-8859-1] Fri Jul 19 14:03:46 2013 @@ -683,7 +683,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_READ, + GENERIC_READ | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -720,7 +720,7 @@ NULL); Status = NtCreateFile(&FileHandle, - GENERIC_WRITE, + GENERIC_WRITE | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, NULL, @@ -783,7 +783,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_READ, + GENERIC_READ | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -828,7 +828,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_READ, + GENERIC_READ | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -876,7 +876,7 @@ NULL); Status = NtCreateFile(&FileHandle, - GENERIC_WRITE, + GENERIC_WRITE | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, NULL, @@ -943,7 +943,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_READ, + GENERIC_READ | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -988,7 +988,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_READ, + GENERIC_READ | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -1039,7 +1039,7 @@ NULL); Status = NtCreateFile(&FileHandle, - GENERIC_WRITE, + GENERIC_WRITE | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, NULL, @@ -1081,7 +1081,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_WRITE, + GENERIC_WRITE | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -1145,7 +1145,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_READ, + GENERIC_READ | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -1193,7 +1193,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_READ, + GENERIC_READ | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -1240,7 +1240,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_WRITE, + GENERIC_WRITE | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -1296,7 +1296,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_READ, + GENERIC_READ | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -1344,7 +1344,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_READ, + GENERIC_READ | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -1392,7 +1392,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_WRITE, + GENERIC_WRITE | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -1454,7 +1454,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_READ, + GENERIC_READ | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -1502,7 +1502,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_READ, + GENERIC_READ | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -1553,7 +1553,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_WRITE, + GENERIC_WRITE | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -1617,7 +1617,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_READ, + GENERIC_READ | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -1663,7 +1663,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_READ, + GENERIC_READ | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -1717,7 +1717,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_WRITE, + GENERIC_WRITE | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -1816,7 +1816,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_READ|GENERIC_WRITE, + GENERIC_READ | GENERIC_WRITE | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, @@ -1890,7 +1890,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_READ|GENERIC_WRITE, + GENERIC_READ | GENERIC_WRITE | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, Modified: trunk/reactos/base/setup/usetup/filesup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/filesup.… ============================================================================== --- trunk/reactos/base/setup/usetup/filesup.c [iso-8859-1] (original) +++ trunk/reactos/base/setup/usetup/filesup.c [iso-8859-1] Fri Jul 19 14:03:46 2013 @@ -198,7 +198,7 @@ NULL); Status = NtCreateFile(&FileHandleDest, - GENERIC_WRITE, + GENERIC_WRITE | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, NULL, @@ -377,7 +377,7 @@ NULL); Status = NtOpenFile(&FileHandle, - GENERIC_READ, + GENERIC_READ | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, 0, Modified: trunk/reactos/base/setup/usetup/inicache.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/inicache… ============================================================================== --- trunk/reactos/base/setup/usetup/inicache.c [iso-8859-1] (original) +++ trunk/reactos/base/setup/usetup/inicache.c [iso-8859-1] Fri Jul 19 14:03:46 2013 @@ -1080,7 +1080,7 @@ NULL); Status = NtCreateFile(&FileHandle, - GENERIC_WRITE, + GENERIC_WRITE | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, NULL,

1 0

[hbelusca] 59511: Fix ASSERTMSG definition and usage (which is: ASSERTMSG(Message, expression) and not the other way around, see http://msdn.microsoft.com/en-us/library/windows/hardware/ff542113(v=...
by hbelusca＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: hbelusca Date: Fri Jul 19 13:16:47 2013 New Revision: 59511 URL: http://svn.reactos.org/svn/reactos?rev=59511&view=rev Log: Fix ASSERTMSG definition and usage (which is: ASSERTMSG(Message, expression) and not the other way around, see http://msdn.microsoft.com/en-us/library/windows/hardware/ff542113(v=vs.85).… , http://www.osronline.com/DDKx/ddtools/debugfns_41yr.htm and google...) (Part 4/4) Everything fixed now \o/ Modified: trunk/reactos/lib/cmlib/hivecell.c Modified: trunk/reactos/lib/cmlib/hivecell.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/hivecell.c?rev=5… ============================================================================== --- trunk/reactos/lib/cmlib/hivecell.c [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/hivecell.c [iso-8859-1] Fri Jul 19 13:16:47 2013 @@ -548,7 +548,7 @@ } /* FIXME: TODO */ - ASSERTMSG(FALSE, "ERROR: Too many references\n"); + ASSERTMSG("ERROR: Too many references\n", FALSE); return FALSE; }

1 0

[hbelusca] 59510: Fix ASSERTMSG definition and usage (which is: ASSERTMSG(Message, expression) and not the other way around, see http://msdn.microsoft.com/en-us/library/windows/hardware/ff542113(v=...
by hbelusca＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: hbelusca Date: Fri Jul 19 13:11:25 2013 New Revision: 59510 URL: http://svn.reactos.org/svn/reactos?rev=59510&view=rev Log: Fix ASSERTMSG definition and usage (which is: ASSERTMSG(Message, expression) and not the other way around, see http://msdn.microsoft.com/en-us/library/windows/hardware/ff542113(v=vs.85).… , http://www.osronline.com/DDKx/ddtools/debugfns_41yr.htm and google...) (Part 3/4) NOTE: Fixing builds ;) Modified: trunk/reactos/base/system/smss/smss.c trunk/reactos/drivers/bus/pcix/arb/tr_irq.c trunk/reactos/drivers/bus/pcix/enum.c trunk/reactos/drivers/bus/pcix/intrface/agpintrf.c trunk/reactos/drivers/bus/pcix/intrface/busintrf.c trunk/reactos/drivers/bus/pcix/intrface/cardbus.c trunk/reactos/drivers/bus/pcix/intrface/devhere.c trunk/reactos/drivers/bus/pcix/intrface/lddintrf.c trunk/reactos/drivers/bus/pcix/intrface/locintrf.c trunk/reactos/drivers/bus/pcix/intrface/pmeintf.c trunk/reactos/drivers/bus/pcix/intrface/routintf.c trunk/reactos/drivers/bus/pcix/utils.c Modified: trunk/reactos/base/system/smss/smss.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/smss/smss.c?re… ============================================================================== --- trunk/reactos/base/system/smss/smss.c [iso-8859-1] (original) +++ trunk/reactos/base/system/smss/smss.c [iso-8859-1] Fri Jul 19 13:11:25 2013 @@ -67,7 +67,7 @@ if (!NT_SUCCESS(Status)) { /* This is a pretty bad failure. ASSERT on checked builds and exit */ - ASSERTMSG(NT_SUCCESS(Status), "RtlCreateProcessParameters"); + ASSERTMSG("RtlCreateProcessParameters", NT_SUCCESS(Status)); DPRINT1("SMSS: RtlCreateProcessParameters failed for %wZ - Status == %lx\n", FileName, Status); return Status; Modified: trunk/reactos/drivers/bus/pcix/arb/tr_irq.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/arb/tr_ir… ============================================================================== --- trunk/reactos/drivers/bus/pcix/arb/tr_irq.c [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/pcix/arb/tr_irq.c [iso-8859-1] Fri Jul 19 13:11:25 2013 @@ -35,7 +35,7 @@ { UNREFERENCED_PARAMETER(Instance); /* PnP Interfaces don't get Initialized */ - ASSERTMSG(FALSE, "PCI tranirq_Initializer, unexpected call."); + ASSERTMSG("PCI tranirq_Initializer, unexpected call.", FALSE); return STATUS_UNSUCCESSFUL; } Modified: trunk/reactos/drivers/bus/pcix/enum.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/enum.c?re… ============================================================================== --- trunk/reactos/drivers/bus/pcix/enum.c [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/pcix/enum.c [iso-8859-1] Fri Jul 19 13:11:25 2013 @@ -1127,7 +1127,7 @@ else { /* Logic error in the driver */ - ASSERTMSG(FALSE, "PCI Skip Function - Operation type unknown."); + ASSERTMSG("PCI Skip Function - Operation type unknown.", FALSE); } /* Check for legacy bridges during resource enumeration */ @@ -2171,7 +2171,7 @@ if (!PcipIsSameDevice(PdoExtension, &PciData)) { /* Fail */ - ASSERTMSG(FALSE, "PCI Set resources - not same device"); + ASSERTMSG("PCI Set resources - not same device", FALSE); return STATUS_DEVICE_DOES_NOT_EXIST; } Modified: trunk/reactos/drivers/bus/pcix/intrface/agpintrf.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/intrface/… ============================================================================== --- trunk/reactos/drivers/bus/pcix/intrface/agpintrf.c [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/pcix/intrface/agpintrf.c [iso-8859-1] Fri Jul 19 13:11:25 2013 @@ -35,7 +35,7 @@ { UNREFERENCED_PARAMETER(Instance); /* PnP Interfaces don't get Initialized */ - ASSERTMSG(FALSE, "PCI agpintrf_Initializer, unexpected call."); + ASSERTMSG("PCI agpintrf_Initializer, unexpected call.", FALSE); return STATUS_UNSUCCESSFUL; } Modified: trunk/reactos/drivers/bus/pcix/intrface/busintrf.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/intrface/… ============================================================================== --- trunk/reactos/drivers/bus/pcix/intrface/busintrf.c [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/pcix/intrface/busintrf.c [iso-8859-1] Fri Jul 19 13:11:25 2013 @@ -35,7 +35,7 @@ { UNREFERENCED_PARAMETER(Instance); /* PnP Interfaces don't get Initialized */ - ASSERTMSG(FALSE, "PCI busintrf_Initializer, unexpected call."); + ASSERTMSG("PCI busintrf_Initializer, unexpected call.", FALSE); return STATUS_UNSUCCESSFUL; } Modified: trunk/reactos/drivers/bus/pcix/intrface/cardbus.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/intrface/… ============================================================================== --- trunk/reactos/drivers/bus/pcix/intrface/cardbus.c [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/pcix/intrface/cardbus.c [iso-8859-1] Fri Jul 19 13:11:25 2013 @@ -99,7 +99,7 @@ { UNREFERENCED_PARAMETER(Instance); /* PnP Interfaces don't get Initialized */ - ASSERTMSG(FALSE, "PCI pcicbintrf_Initializer, unexpected call."); + ASSERTMSG("PCI pcicbintrf_Initializer, unexpected call.", FALSE); return STATUS_UNSUCCESSFUL; } Modified: trunk/reactos/drivers/bus/pcix/intrface/devhere.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/intrface/… ============================================================================== --- trunk/reactos/drivers/bus/pcix/intrface/devhere.c [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/pcix/intrface/devhere.c [iso-8859-1] Fri Jul 19 13:11:25 2013 @@ -35,7 +35,7 @@ { UNREFERENCED_PARAMETER(Instance); /* PnP Interfaces don't get Initialized */ - ASSERTMSG(FALSE, "PCI devpresent_Initializer, unexpected call."); + ASSERTMSG("PCI devpresent_Initializer, unexpected call.", FALSE); return STATUS_UNSUCCESSFUL; } Modified: trunk/reactos/drivers/bus/pcix/intrface/lddintrf.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/intrface/… ============================================================================== --- trunk/reactos/drivers/bus/pcix/intrface/lddintrf.c [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/pcix/intrface/lddintrf.c [iso-8859-1] Fri Jul 19 13:11:25 2013 @@ -35,7 +35,7 @@ { UNREFERENCED_PARAMETER(Instance); /* PnP Interfaces don't get Initialized */ - ASSERTMSG(FALSE, "PCI lddintrf_Initializer, unexpected call."); + ASSERTMSG("PCI lddintrf_Initializer, unexpected call.", FALSE); return STATUS_UNSUCCESSFUL; } Modified: trunk/reactos/drivers/bus/pcix/intrface/locintrf.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/intrface/… ============================================================================== --- trunk/reactos/drivers/bus/pcix/intrface/locintrf.c [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/pcix/intrface/locintrf.c [iso-8859-1] Fri Jul 19 13:11:25 2013 @@ -35,7 +35,7 @@ { UNREFERENCED_PARAMETER(Instance); /* PnP Interfaces don't get Initialized */ - ASSERTMSG(FALSE, "PCI locintrf_Initializer, unexpected call."); + ASSERTMSG("PCI locintrf_Initializer, unexpected call.", FALSE); return STATUS_UNSUCCESSFUL; } Modified: trunk/reactos/drivers/bus/pcix/intrface/pmeintf.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/intrface/… ============================================================================== --- trunk/reactos/drivers/bus/pcix/intrface/pmeintf.c [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/pcix/intrface/pmeintf.c [iso-8859-1] Fri Jul 19 13:11:25 2013 @@ -35,7 +35,7 @@ { UNREFERENCED_PARAMETER(Instance); /* PnP Interfaces don't get Initialized */ - ASSERTMSG(FALSE, "PCI PciPmeInterfaceInitializer, unexpected call."); + ASSERTMSG("PCI PciPmeInterfaceInitializer, unexpected call.", FALSE); return STATUS_UNSUCCESSFUL; } Modified: trunk/reactos/drivers/bus/pcix/intrface/routintf.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/intrface/… ============================================================================== --- trunk/reactos/drivers/bus/pcix/intrface/routintf.c [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/pcix/intrface/routintf.c [iso-8859-1] Fri Jul 19 13:11:25 2013 @@ -37,7 +37,7 @@ { UNREFERENCED_PARAMETER(Instance); /* PnP Interfaces don't get Initialized */ - ASSERTMSG(FALSE, "PCI routeintrf_Initializer, unexpected call."); + ASSERTMSG("PCI routeintrf_Initializer, unexpected call.", FALSE); return STATUS_UNSUCCESSFUL; } Modified: trunk/reactos/drivers/bus/pcix/utils.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/utils.c?r… ============================================================================== --- trunk/reactos/drivers/bus/pcix/utils.c [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/pcix/utils.c [iso-8859-1] Fri Jul 19 13:11:25 2013 @@ -493,7 +493,7 @@ Status, STATUS_BUFFER_TOO_SMALL); *OutputBuffer = NULL; - ASSERTMSG(FALSE, "PCI Successfully did the impossible!"); + ASSERTMSG("PCI Successfully did the impossible!", FALSE); break; }

1 0

[hbelusca] 59509: Fix ASSERTMSG definition and usage (which is: ASSERTMSG(Message, expression) and not the other way around, see http://msdn.microsoft.com/en-us/library/windows/hardware/ff542113(v=...
by hbelusca＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: hbelusca Date: Fri Jul 19 13:03:42 2013 New Revision: 59509 URL: http://svn.reactos.org/svn/reactos?rev=59509&view=rev Log: Fix ASSERTMSG definition and usage (which is: ASSERTMSG(Message, expression) and not the other way around, see http://msdn.microsoft.com/en-us/library/windows/hardware/ff542113(v=vs.85).… , http://www.osronline.com/DDKx/ddtools/debugfns_41yr.htm and google...) (Part 2/X) WARNING: Might break builds now. Modified: trunk/reactos/include/host/typedefs.h trunk/reactos/include/reactos/debug.h Modified: trunk/reactos/include/host/typedefs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/host/typedefs.h?re… ============================================================================== --- trunk/reactos/include/host/typedefs.h [iso-8859-1] (original) +++ trunk/reactos/include/host/typedefs.h [iso-8859-1] Fri Jul 19 13:03:42 2013 @@ -29,7 +29,7 @@ /* Basic definitions */ #define UNIMPLEMENTED { printf("%s unimplemented\n", __FUNCTION__); exit(1); } #define ASSERT(x) assert(x) -#define ASSERTMSG(x, m) assert(x) +#define ASSERTMSG(m, x) assert(x) #define DPRINT if (0) printf #define DPRINT1 printf Modified: trunk/reactos/include/reactos/debug.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/debug.h?re… ============================================================================== --- trunk/reactos/include/reactos/debug.h [iso-8859-1] (original) +++ trunk/reactos/include/reactos/debug.h [iso-8859-1] Fri Jul 19 13:03:42 2013 @@ -79,9 +79,9 @@ #ifndef ASSERTMSG #ifndef NASSERT -#define ASSERTMSG(x,m) if (!(x)) { RtlAssert((PVOID)#x, __FILE__, __LINE__, m); } +#define ASSERTMSG(m, x) if (!(x)) { RtlAssert((PVOID)#x, __FILE__, __LINE__, m); } #else -#define ASSERTMSG(x) +#define ASSERTMSG(m, x) #endif #endif

1 0

[hbelusca] 59508: Fix ASSERTMSG definition and usage (which is: ASSERTMSG(Message, expression) and not the other way around, see http://msdn.microsoft.com/en-us/library/windows/hardware/ff542113(v=...
by hbelusca＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: hbelusca Date: Fri Jul 19 12:54:34 2013 New Revision: 59508 URL: http://svn.reactos.org/svn/reactos?rev=59508&view=rev Log: Fix ASSERTMSG definition and usage (which is: ASSERTMSG(Message, expression) and not the other way around, see http://msdn.microsoft.com/en-us/library/windows/hardware/ff542113(v=vs.85).… , http://www.osronline.com/DDKx/ddtools/debugfns_41yr.htm and google...) (Part 1/X) Modified: trunk/rosapps/templates/dialog/trace.h Modified: trunk/rosapps/templates/dialog/trace.h URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/templates/dialog/trace.h?r… ============================================================================== --- trunk/rosapps/templates/dialog/trace.h [iso-8859-1] (original) +++ trunk/rosapps/templates/dialog/trace.h [iso-8859-1] Fri Jul 19 12:54:34 2013 @@ -21,7 +21,7 @@ } \ } \ -#define ASSERTMSG(exp, msg) \ +#define ASSERTMSG(msg, exp) \ { \ if (!(exp)) { \ Assert(#exp, __FILE__, __LINE__, msg); \ @@ -45,7 +45,7 @@ #ifndef ASSERT #define ASSERT(exp) -#define ASSERTMSG(exp, msg) +#define ASSERTMSG(msg, exp) #endif #define TRACE 0 ? (void)0 : Trace

1 0

[akhaldi] 59507: [DBGHELPHOST] * Fix some warnings. Brought to you by Thomas Faber.
by akhaldi＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: akhaldi Date: Fri Jul 19 00:11:08 2013 New Revision: 59507 URL: http://svn.reactos.org/svn/reactos?rev=59507&view=rev Log: [DBGHELPHOST] * Fix some warnings. Brought to you by Thomas Faber. Modified: trunk/reactos/dll/win32/dbghelp/compat.h trunk/reactos/dll/win32/dbghelp/symbol.c Modified: trunk/reactos/dll/win32/dbghelp/compat.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/compat.h… ============================================================================== --- trunk/reactos/dll/win32/dbghelp/compat.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/dbghelp/compat.h [iso-8859-1] Fri Jul 19 00:11:08 2013 @@ -15,7 +15,11 @@ #define min(x, y) (((x) < (y)) ? (x) : (y)) #define max(x, y) (((x) > (y)) ? (x) : (y)) +#ifdef __i386__ #define CDECL __cdecl +#else +#define CDECL +#endif typedef PVOID IUnknown, IDispatch, IRecordInfo; // windef.h @@ -719,7 +723,6 @@ BOOL WINAPI SymEnumerateModulesW64(HANDLE hProcess, PSYM_ENUMMODULES_CALLBACKW64 EnumModulesCallback, PVOID UserContext); -#ifndef _LP64 typedef struct _tagADDRESS { DWORD Offset; @@ -763,23 +766,6 @@ typedef BOOL (CALLBACK *PSYM_ENUMSYMBOLS_CALLBACK)(PCSTR, ULONG, ULONG, PVOID); typedef BOOL (CALLBACK *PSYM_ENUMSYMBOLS_CALLBACKW)(PCWSTR, ULONG, ULONG, PVOID); -#else -#define ADDRESS ADDRESS64 -#define LPADDRESS LPADDRESS64 -#define IMAGEHLP_MODULE IMAGEHLP_MODULE64 -#define PIMAGEHLP_MODULE PIMAGEHLP_MODULE64 -#define IMAGEHLP_MODULEW IMAGEHLP_MODULEW64 -#define PIMAGEHLP_MODULEW PIMAGEHLP_MODULEW64 -#define PENUMLOADED_MODULES_CALLBACK PENUMLOADED_MODULES_CALLBACK64 -#define PFUNCTION_TABLE_ACCESS_ROUTINE PFUNCTION_TABLE_ACCESS_ROUTINE64 -#define PTRANSLATE_ADDRESS_ROUTINE PTRANSLATE_ADDRESS_ROUTINE64 -#define PSYMBOL_REGISTERED_CALLBACK PSYMBOL_REGISTERED_CALLBACK64 -#define PREAD_PROCESS_MEMORY_ROUTINE PREAD_PROCESS_MEMORY_ROUTINE64 -#define PGET_MODULE_BASE_ROUTINE PGET_MODULE_BASE_ROUTINE64 -#define PSYM_ENUMMODULES_CALLBACK PSYM_ENUMMODULES_CALLBACK64 -#define PSYM_ENUMSYMBOLS_CALLBACK PSYM_ENUMSYMBOLS_CALLBACK64 -#define PSYM_ENUMSYMBOLS_CALLBACKW PSYM_ENUMSYMBOLS_CALLBACKW64 -#endif typedef struct _IMAGEHLP_MODULE64 { DWORD SizeOfStruct; Modified: trunk/reactos/dll/win32/dbghelp/symbol.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/symbol.c… ============================================================================== --- trunk/reactos/dll/win32/dbghelp/symbol.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/dbghelp/symbol.c [iso-8859-1] Fri Jul 19 00:11:08 2013 @@ -70,7 +70,7 @@ DWORD symt_ptr2index(struct module* module, const struct symt* sym) { -#ifdef _WIN64 +#ifdef __x86_64__ const struct symt** c; int len = vector_length(&module->vsymt), i; @@ -91,7 +91,7 @@ struct symt* symt_index2ptr(struct module* module, DWORD id) { -#ifdef _WIN64 +#ifdef __x86_64__ if (!id-- || id >= vector_length(&module->vsymt)) return NULL; return *(struct symt**)vector_at(&module->vsymt, id); #else

1 0

[tfaber] 59506: [WIDL] - Fix some warnings
by tfaber＠svn.reactos.org 18 Jul '13

18 Jul '13

Author: tfaber Date: Thu Jul 18 21:55:32 2013 New Revision: 59506 URL: http://svn.reactos.org/svn/reactos?rev=59506&view=rev Log: [WIDL] - Fix some warnings Modified: trunk/reactos/tools/widl/widl.c Modified: trunk/reactos/tools/widl/widl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/widl.c?rev=5950… ============================================================================== --- trunk/reactos/tools/widl/widl.c [iso-8859-1] (original) +++ trunk/reactos/tools/widl/widl.c [iso-8859-1] Thu Jul 18 21:55:32 2013 @@ -482,10 +482,10 @@ fprintf(idfile, "/*** Autogenerated by WIDL %s ", PACKAGE_VERSION); fprintf(idfile, "from %s - Do not edit ***/\n\n", input_name); - fprintf(idfile, "#ifdef __REACTOS__\n", input_name); - fprintf(idfile, "#define WIN32_NO_STATUS\n", input_name); - fprintf(idfile, "#define WIN32_LEAN_AND_MEAN\n", input_name); - fprintf(idfile, "#endif\n\n", input_name); + fprintf(idfile, "#ifdef __REACTOS__\n"); + fprintf(idfile, "#define WIN32_NO_STATUS\n"); + fprintf(idfile, "#define WIN32_LEAN_AND_MEAN\n"); + fprintf(idfile, "#endif\n\n"); fprintf(idfile, "#include <rpc.h>\n"); fprintf(idfile, "#include <rpcndr.h>\n\n");

1 0

[akhaldi] 59505: * Improve the way we create rossym debug info. The effort results in ~85% *smaller* build folder with ninja all with no code changes. [DBGHELPHOST] * Introduce a self-contained, st...
by akhaldi＠svn.reactos.org 18 Jul '13

18 Jul '13

Author: akhaldi Date: Thu Jul 18 21:03:01 2013 New Revision: 59505 URL: http://svn.reactos.org/svn/reactos?rev=59505&view=rev Log: * Improve the way we create rossym debug info. The effort results in ~85% *smaller* build folder with ninja all with no code changes. [DBGHELPHOST] * Introduce a self-contained, static library version of dbghelp, in order to leverage its PE DWARF support. Thanks to Jerome Gardou for his work on the compatibility layer, and to Thomas Faber for helping me with the review/improvements. * Unify the new host lib with the existing dll codebase using preprocessor conditions. This prevents code duplication. * Skip as much unneeded functionality as possible when compiling dbghelphost to keep it light and straight to the point. [RSYM] * Introduce the required functions that allow parsing DWARF (using dbghelphost) and using it (along with coff symbols) to create the rossym debug info. Brought to you by Awesome Arty with some bugfixes from Jerome Gardou. Many thanks to Thomas Faber for assisting me with the testing/bug hunting. [CMAKE/GCC] * Introduce a combination of dwarf and debug emission flags that ensure the smallest debug info size among all the possible options we have. * Introduce compressed debug sections that I already included the support for in RosBE 2.1. Thanks to the mingw-w64 folks (Kai Tietz) for the patch. * Don't compress debug sections of C++ modules for now due to a bug in the toolchain that leads to spamming the build at link time with a warning. * Don't run rsym on the RC shared libraries. Thanks to Thomas Faber for spotting this. [DBGHELP] * Update the ros diff to reflect the changes introduced by the dbghelphost unification. Added: trunk/reactos/dll/win32/dbghelp/compat.c (with props) trunk/reactos/dll/win32/dbghelp/compat.h (with props) trunk/reactos/include/host/wine/mscvpdb.h (with props) trunk/reactos/include/host/wine/rbtree.h (with props) Modified: trunk/reactos/CMakeLists.txt trunk/reactos/cmake/gcc.cmake trunk/reactos/dll/win32/dbghelp/CMakeLists.txt trunk/reactos/dll/win32/dbghelp/cpu_i386.c trunk/reactos/dll/win32/dbghelp/dbghelp.c trunk/reactos/dll/win32/dbghelp/dbghelp_private.h trunk/reactos/dll/win32/dbghelp/dbghelp_ros.diff trunk/reactos/dll/win32/dbghelp/dwarf.c trunk/reactos/dll/win32/dbghelp/dwarf.h trunk/reactos/dll/win32/dbghelp/image_private.h trunk/reactos/dll/win32/dbghelp/module.c trunk/reactos/dll/win32/dbghelp/pe_module.c trunk/reactos/dll/win32/dbghelp/source.c trunk/reactos/dll/win32/dbghelp/stabs.c trunk/reactos/dll/win32/dbghelp/storage.c trunk/reactos/dll/win32/dbghelp/symbol.c trunk/reactos/dll/win32/dbghelp/type.c trunk/reactos/include/host/config.h trunk/reactos/include/host/typedefs.h trunk/reactos/tools/obj2bin/obj2bin.c trunk/reactos/tools/pecoff.h trunk/reactos/tools/rsym/CMakeLists.txt trunk/reactos/tools/rsym/rsym.c trunk/reactos/tools/rsym/rsym.h [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/CMakeLists.txt?rev=59505&r… Modified: trunk/reactos/cmake/gcc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/gcc.cmake?rev=59505&… Modified: trunk/reactos/dll/win32/dbghelp/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/CMakeLis… Added: trunk/reactos/dll/win32/dbghelp/compat.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/compat.c… Added: trunk/reactos/dll/win32/dbghelp/compat.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/compat.h… Modified: trunk/reactos/dll/win32/dbghelp/cpu_i386.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/cpu_i386… Modified: trunk/reactos/dll/win32/dbghelp/dbghelp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/dbghelp.… Modified: trunk/reactos/dll/win32/dbghelp/dbghelp_private.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/dbghelp_… Modified: trunk/reactos/dll/win32/dbghelp/dbghelp_ros.diff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/dbghelp_… Modified: trunk/reactos/dll/win32/dbghelp/dwarf.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/dwarf.c?… Modified: trunk/reactos/dll/win32/dbghelp/dwarf.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/dwarf.h?… Modified: trunk/reactos/dll/win32/dbghelp/image_private.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/image_pr… Modified: trunk/reactos/dll/win32/dbghelp/module.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/module.c… Modified: trunk/reactos/dll/win32/dbghelp/pe_module.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/pe_modul… Modified: trunk/reactos/dll/win32/dbghelp/source.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/source.c… Modified: trunk/reactos/dll/win32/dbghelp/stabs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/stabs.c?… Modified: trunk/reactos/dll/win32/dbghelp/storage.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/storage.… Modified: trunk/reactos/dll/win32/dbghelp/symbol.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/symbol.c… Modified: trunk/reactos/dll/win32/dbghelp/type.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/type.c?r… Modified: trunk/reactos/include/host/config.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/host/config.h?rev=… Modified: trunk/reactos/include/host/typedefs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/host/typedefs.h?re… Added: trunk/reactos/include/host/wine/mscvpdb.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/host/wine/mscvpdb.… Added: trunk/reactos/include/host/wine/rbtree.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/host/wine/rbtree.h… Modified: trunk/reactos/tools/obj2bin/obj2bin.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/obj2bin/obj2bin.c?re… Modified: trunk/reactos/tools/pecoff.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/pecoff.h?rev=59505&r… Modified: trunk/reactos/tools/rsym/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rsym/CMakeLists.txt?… Modified: trunk/reactos/tools/rsym/rsym.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rsym/rsym.c?rev=5950… Modified: trunk/reactos/tools/rsym/rsym.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rsym/rsym.h?rev=5950…

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
20
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs July 2013