Ros-diffs July 2013

ros-diffs@reactos.org

13 participants
199 discussions

[akhaldi] 59524: [WINMM_WINETEST] * Silence some warnings.
by akhaldi＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: akhaldi Date: Fri Jul 19 23:42:18 2013 New Revision: 59524 URL: http://svn.reactos.org/svn/reactos?rev=59524&view=rev Log: [WINMM_WINETEST] * Silence some warnings. Modified: trunk/rostests/winetests/winmm/CMakeLists.txt Modified: trunk/rostests/winetests/winmm/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/winmm/CMakeList… ============================================================================== --- trunk/rostests/winetests/winmm/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/winetests/winmm/CMakeLists.txt [iso-8859-1] Fri Jul 19 23:42:18 2013 @@ -1,6 +1,5 @@ -add_definitions( - -D__ROS_LONG64__) +add_definitions(-D__ROS_LONG64__) list(APPEND SOURCE capture.c @@ -18,5 +17,5 @@ add_cd_file(TARGET winmm_winetest DESTINATION reactos/bin FOR all) if(NOT MSVC) - add_target_compile_flags(winmm_winetest "-Wno-format") + add_target_compile_flags(winmm_winetest "-Wno-format -Wno-unused-but-set-variable") endif()

1 0

[akhaldi] 59523: [GLU32] * Silence some warnings.
by akhaldi＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: akhaldi Date: Fri Jul 19 23:40:04 2013 New Revision: 59523 URL: http://svn.reactos.org/svn/reactos?rev=59523&view=rev Log: [GLU32] * Silence some warnings. Modified: trunk/reactos/dll/opengl/glu32/CMakeLists.txt Modified: trunk/reactos/dll/opengl/glu32/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/opengl/glu32/CMakeList… ============================================================================== --- trunk/reactos/dll/opengl/glu32/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/opengl/glu32/CMakeLists.txt [iso-8859-1] Fri Jul 19 23:40:04 2013 @@ -107,21 +107,14 @@ src/libnurbs/nurbtess/sampleMonoPoly.cc src/libnurbs/nurbtess/sampledLine.cc src/libnurbs/nurbtess/searchTree.cc - ${CMAKE_CURRENT_BINARY_DIR}/glu32.def -) + ${CMAKE_CURRENT_BINARY_DIR}/glu32.def) add_library(glu32 SHARED ${SOURCE}) set_module_type(glu32 win32dll) if(NOT MSVC) - add_compile_flags("-Wno-error=write-strings") + add_target_compile_flags(glu32 "-Wno-write-strings -Wno-unused-but-set-variable") endif() -add_importlibs(glu32 - opengl32 - gdi32 - msvcrt - kernel32 - ntdll) - +add_importlibs(glu32 opengl32 gdi32 msvcrt kernel32 ntdll) add_cd_file(TARGET glu32 DESTINATION reactos/system32 FOR all)

1 0

[akhaldi] 59522: [UNIATA] * Silence some warnings.
by akhaldi＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: akhaldi Date: Fri Jul 19 23:36:38 2013 New Revision: 59522 URL: http://svn.reactos.org/svn/reactos?rev=59522&view=rev Log: [UNIATA] * Silence some warnings. Modified: trunk/reactos/drivers/storage/ide/uniata/CMakeLists.txt Modified: trunk/reactos/drivers/storage/ide/uniata/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/ide/uniata… ============================================================================== --- trunk/reactos/drivers/storage/ide/uniata/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/drivers/storage/ide/uniata/CMakeLists.txt [iso-8859-1] Fri Jul 19 23:36:38 2013 @@ -23,7 +23,7 @@ if(NOT MSVC) # FIXME: http://www.cmake.org/Bug/view.php?id=12998 #allow_warnings(uniata) - set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-error") + set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-error -Wno-unused-but-set-variable -Wno-narrowing") endif() add_pch(uniata stdafx.h)

1 0

[akhaldi] 59521: [LIBXML2] * Disable warnings.
by akhaldi＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: akhaldi Date: Fri Jul 19 23:33:08 2013 New Revision: 59521 URL: http://svn.reactos.org/svn/reactos?rev=59521&view=rev Log: [LIBXML2] * Disable warnings. Modified: trunk/reactos/lib/3rdparty/libxml2/CMakeLists.txt Modified: trunk/reactos/lib/3rdparty/libxml2/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/libxml2/CMake… ============================================================================== --- trunk/reactos/lib/3rdparty/libxml2/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/lib/3rdparty/libxml2/CMakeLists.txt [iso-8859-1] Fri Jul 19 23:33:08 2013 @@ -62,6 +62,5 @@ add_dependencies(libxml2 psdk) if(NOT MSVC) - add_target_compile_flags(libxml2 "-Wno-format -Wno-pointer-sign") - allow_warnings(libxml2) + add_target_compile_flags(libxml2 "-w") endif()

1 0

[akhaldi] 59520: [CARDLIB] * Silence some warnings.
by akhaldi＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: akhaldi Date: Fri Jul 19 23:22:19 2013 New Revision: 59520 URL: http://svn.reactos.org/svn/reactos?rev=59520&view=rev Log: [CARDLIB] * Silence some warnings. Modified: trunk/reactos/lib/3rdparty/cardlib/CMakeLists.txt Modified: trunk/reactos/lib/3rdparty/cardlib/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/cardlib/CMake… ============================================================================== --- trunk/reactos/lib/3rdparty/cardlib/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/lib/3rdparty/cardlib/CMakeLists.txt [iso-8859-1] Fri Jul 19 23:22:19 2013 @@ -15,5 +15,8 @@ dropzone.cpp) add_library(cardlib ${SOURCE}) -allow_warnings(cardlib) add_dependencies(cardlib psdk) + +if(NOT MSVC) + add_target_compile_flags(cardlib "-Wno-unused-but-set-variable") +endif()

1 0

[akhaldi] 59519: [ADNS] * Silence some warnings.
by akhaldi＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: akhaldi Date: Fri Jul 19 23:20:17 2013 New Revision: 59519 URL: http://svn.reactos.org/svn/reactos?rev=59519&view=rev Log: [ADNS] * Silence some warnings. Modified: trunk/reactos/lib/3rdparty/adns/CMakeLists.txt Modified: trunk/reactos/lib/3rdparty/adns/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/adns/CMakeLis… ============================================================================== --- trunk/reactos/lib/3rdparty/adns/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/lib/3rdparty/adns/CMakeLists.txt [iso-8859-1] Fri Jul 19 23:20:17 2013 @@ -22,4 +22,7 @@ add_library(adns ${SOURCE}) add_dependencies(adns psdk) -allow_warnings(adns) + +if(NOT MSVC) + add_target_compile_flags(adns "-Wno-unused-but-set-variable") +endif()

1 0

[hbelusca] 59518: [SMSS] - In the token parsing function SmpParseToken, just return success directly if the input string has zero length, instead of running code which does nothing at the end, beca...
by hbelusca＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: hbelusca Date: Fri Jul 19 22:32:34 2013 New Revision: 59518 URL: http://svn.reactos.org/svn/reactos?rev=59518&view=rev Log: [SMSS] - In the token parsing function SmpParseToken, just return success directly if the input string has zero length, instead of running code which does nothing at the end, because the length was zero... - Give a default value for the "BootExecute" entry in the SMSS registry configuration table (this value is used when there is no BootExecute registry value inside HKLM\System\CurrentControlSet\Control\Session Manager) and precise that it is a multi-string value. - Remove a redundant "Environment" entry in this table, too. Modified: trunk/reactos/base/system/smss/sminit.c trunk/reactos/base/system/smss/smutil.c Modified: trunk/reactos/base/system/smss/sminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/smss/sminit.c?… ============================================================================== --- trunk/reactos/base/system/smss/sminit.c [iso-8859-1] (original) +++ trunk/reactos/base/system/smss/sminit.c [iso-8859-1] Fri Jul 19 22:32:34 2013 @@ -630,8 +630,8 @@ 0, L"BootExecute", &SmpBootExecuteList, - REG_NONE, - NULL, + REG_MULTI_SZ, + L"autocheck AutoChk.exe *\0", 0 }, @@ -710,16 +710,6 @@ RTL_QUERY_REGISTRY_SUBKEY, L"KnownDlls", &SmpKnownDllsList, - REG_NONE, - NULL, - 0 - }, - - { - SmpConfigureEnvironment, - RTL_QUERY_REGISTRY_SUBKEY, - L"Environment", - NULL, REG_NONE, NULL, 0 Modified: trunk/reactos/base/system/smss/smutil.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/smss/smutil.c?… ============================================================================== --- trunk/reactos/base/system/smss/smutil.c [iso-8859-1] (original) +++ trunk/reactos/base/system/smss/smutil.c [iso-8859-1] Fri Jul 19 22:32:34 2013 @@ -161,6 +161,9 @@ /* Save the input length */ InputLength = Input->Length; + + /* If the input string is empty, just return */ + if (InputLength == 0) return STATUS_SUCCESS; /* Parse the buffer until the first character */ p = Input->Buffer;

1 0

[hbelusca] 59517: [RTL] - Fix a potential overflow bug. - Don't hardcode the "/ 2" in indices computation (2 == sizeof(WCHAR)) - Fix a string enumeration bug when enumerating strings inside REG_MUL...
by hbelusca＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: hbelusca Date: Fri Jul 19 22:22:49 2013 New Revision: 59517 URL: http://svn.reactos.org/svn/reactos?rev=59517&view=rev Log: [RTL] - Fix a potential overflow bug. - Don't hardcode the "/ 2" in indices computation (2 == sizeof(WCHAR)) - Fix a string enumeration bug when enumerating strings inside REG_MULTI_SZ values, in RtlQueryRegistryValues. Modified: trunk/reactos/lib/rtl/registry.c Modified: trunk/reactos/lib/rtl/registry.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/registry.c?rev=595… ============================================================================== --- trunk/reactos/lib/rtl/registry.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/registry.c [iso-8859-1] Fri Jul 19 22:22:49 2013 @@ -38,7 +38,7 @@ IN ULONG ValueLength, IN PVOID Buffer) { - USHORT ActualLength = (USHORT)ValueLength; + USHORT ActualLength; PUNICODE_STRING ReturnString = Buffer; PULONG Length = Buffer; ULONG RealLength; @@ -49,7 +49,10 @@ (ValueType == REG_MULTI_SZ)) { /* Normalize the length */ - if (ValueLength > MAXUSHORT) ValueLength = MAXUSHORT; + if (ValueLength > MAXUSHORT) + ActualLength = MAXUSHORT; + else + ActualLength = (USHORT)ValueLength; /* Check if the return string has been allocated */ if (!ReturnString->Buffer) @@ -242,7 +245,8 @@ { /* Prepare defaults */ Status = STATUS_SUCCESS; - ValueEnd = (PWSTR)((ULONG_PTR)Data + Length - sizeof(UNICODE_NULL)); + /* Skip the last two UNICODE_NULL chars (the terminating null string) */ + ValueEnd = (PWSTR)((ULONG_PTR)Data + Length - 2 * sizeof(UNICODE_NULL)); p = Data; /* Loop all strings */ @@ -260,9 +264,9 @@ Data, (ULONG)Length, QueryTable->EntryContext); - QueryTable->EntryContext = (PVOID)((ULONG_PTR)QueryTable-> - EntryContext + - sizeof(UNICODE_STRING)); + QueryTable->EntryContext = + (PVOID)((ULONG_PTR)QueryTable->EntryContext + + sizeof(UNICODE_STRING)); } else { @@ -328,13 +332,13 @@ { /* This is the good case, where we fit into a string */ Destination.MaximumLength = (USHORT)SpareLength; - Destination.Buffer[SpareLength / 2 - 1] = UNICODE_NULL; + Destination.Buffer[SpareLength / sizeof(WCHAR) - 1] = UNICODE_NULL; } else { /* We can't fit into a string, so truncate */ Destination.MaximumLength = MAXUSHORT; - Destination.Buffer[MAXUSHORT / 2 - 1] = UNICODE_NULL; + Destination.Buffer[MAXUSHORT / sizeof(WCHAR) - 1] = UNICODE_NULL; } /* Expand the strings and set our type as one string */ @@ -1149,7 +1153,7 @@ if (KeyValueInfo->Type == REG_MULTI_SZ) { /* Add a null-char */ - ((PWCHAR)KeyValueInfo)[ResultLength / 2] = UNICODE_NULL; + ((PWCHAR)KeyValueInfo)[ResultLength / sizeof(WCHAR)] = UNICODE_NULL; KeyValueInfo->DataLength += sizeof(UNICODE_NULL); }

1 0

[ion] 59516: [WIN32K]: Get rid of unused variables, fix all warnings on GCC 4.7
by ion＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: ion Date: Fri Jul 19 17:06:14 2013 New Revision: 59516 URL: http://svn.reactos.org/svn/reactos?rev=59516&view=rev Log: [WIN32K]: Get rid of unused variables, fix all warnings on GCC 4.7 Modified: trunk/reactos/win32ss/gdi/ntgdi/device.c trunk/reactos/win32ss/gdi/ntgdi/gdiobj.c trunk/reactos/win32ss/gdi/ntgdi/xformobj.c trunk/reactos/win32ss/user/ntuser/monitor.c trunk/reactos/win32ss/user/ntuser/msgqueue.c trunk/reactos/win32ss/user/ntuser/winpos.c Modified: trunk/reactos/win32ss/gdi/ntgdi/device.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/device.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/device.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/device.c [iso-8859-1] Fri Jul 19 17:06:14 2013 @@ -28,12 +28,8 @@ BOOL FASTCALL IntCreatePrimarySurface(VOID) { - SIZEL SurfSize; - SURFOBJ *pso; - /* Create surface */ - pso = &PDEVOBJ_pSurface(gppdevPrimary)->SurfObj; - SurfSize = pso->sizlBitmap; + PDEVOBJ_pSurface(gppdevPrimary); DPRINT("IntCreatePrimarySurface, gppdevPrimary=%p, gppdevPrimary->pSurface = %p\n", gppdevPrimary, gppdevPrimary->pSurface); Modified: trunk/reactos/win32ss/gdi/ntgdi/gdiobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/gdiobj.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/gdiobj.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/gdiobj.c [iso-8859-1] Fri Jul 19 17:06:14 2013 @@ -570,20 +570,18 @@ NTAPI GDIOBJ_vReferenceObjectByPointer(POBJ pobj) { - ULONG cRefs; - /* Check if the object has a handle */ if (GDI_HANDLE_GET_INDEX(pobj->hHmgr)) { /* Increase the handle's reference count */ ULONG ulIndex = GDI_HANDLE_GET_INDEX(pobj->hHmgr); ASSERT((gpaulRefCount[ulIndex] & REF_MASK_COUNT) > 0); - cRefs = InterlockedIncrement((LONG*)&gpaulRefCount[ulIndex]); + InterlockedIncrement((LONG*)&gpaulRefCount[ulIndex]); } else { /* Increase the object's reference count */ - cRefs = InterlockedIncrement((LONG*)&pobj->ulShareCount); + InterlockedIncrement((LONG*)&pobj->ulShareCount); } DBG_LOGEVENT(&pobj->slhLog, EVENT_REFERENCE, cRefs); Modified: trunk/reactos/win32ss/gdi/ntgdi/xformobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/xformobj… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/xformobj.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/xformobj.c [iso-8859-1] Fri Jul 19 17:06:14 2013 @@ -254,11 +254,6 @@ PMATRIX pmxDst, pmxSrc; FLOATOBJ foDet; XFORM xformSrc; - union - { - FLOAT Float; - LONG Long; - } eDet; pmxDst = XFORMOBJ_pmx(pxoDst); pmxSrc = XFORMOBJ_pmx(pxoSrc); @@ -273,8 +268,6 @@ /* Determinant is 0! */ return DDI_ERROR; } - - eDet.Long = FLOATOBJ_GetFloat(&foDet); /* Calculate adj(A) / det(A) */ pmxDst->efM11 = pmxSrc->efM22; Modified: trunk/reactos/win32ss/user/ntuser/monitor.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/monito… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/monitor.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/monitor.c [iso-8859-1] Fri Jul 19 17:06:14 2013 @@ -786,7 +786,6 @@ IN POINT pt, IN DWORD dwFlags) { - INT cMonitors; RECTL rc; HMONITOR hMonitor = NULL; @@ -808,7 +807,7 @@ UserEnterShared(); /* Find intersecting monitor */ - cMonitors = IntGetMonitorsFromRect(&rc, &hMonitor, NULL, 1, dwFlags); + IntGetMonitorsFromRect(&rc, &hMonitor, NULL, 1, dwFlags); UserLeave(); return hMonitor; Modified: trunk/reactos/win32ss/user/ntuser/msgqueue.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/msgque… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/msgqueue.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/msgqueue.c [iso-8859-1] Fri Jul 19 17:06:14 2013 @@ -506,7 +506,6 @@ { LARGE_INTEGER LargeTickCount; MSLLHOOKSTRUCT MouseHookData; - PDESKTOP pDesk; PWND pwnd, pwndDesktop; HDC hdcScreen; PTHREADINFO pti; @@ -550,7 +549,6 @@ /* Get the desktop window */ pwndDesktop = UserGetDesktopWindow(); if (!pwndDesktop) return; - pDesk = pwndDesktop->head.rpdesk; /* Check if the mouse is captured */ Msg->hwnd = IntGetCaptureWindow(); Modified: trunk/reactos/win32ss/user/ntuser/winpos.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/winpos… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/winpos.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/winpos.c [iso-8859-1] Fri Jul 19 17:06:14 2013 @@ -2056,7 +2056,7 @@ LONG style; PWND Parent; PTHREADINFO pti; - BOOL ShowOwned = FALSE; + // BOOL ShowOwned = FALSE; // HRGN VisibleRgn; ASSERT_REFS_CO(Wnd); @@ -2125,7 +2125,7 @@ Swp |= SWP_SHOWWINDOW; if (!(style & WS_MAXIMIZE)) { - ShowOwned = TRUE; + //ShowOwned = TRUE; Swp |= co_WinPosMinMaximize(Wnd, SW_MAXIMIZE, &NewPos) | SWP_FRAMECHANGED;

1 0

[hbelusca] 59515: Final fixes for the SYNCHRONIZE flag CORE-7361 #resolve #comment Fixed in revisions 59512, 59514 and 59515.
by hbelusca＠svn.reactos.org 19 Jul '13

19 Jul '13

Author: hbelusca Date: Fri Jul 19 15:19:03 2013 New Revision: 59515 URL: http://svn.reactos.org/svn/reactos?rev=59515&view=rev Log: Final fixes for the SYNCHRONIZE flag CORE-7361 #resolve #comment Fixed in revisions 59512, 59514 and 59515. Modified: trunk/reactos/drivers/storage/port/buslogic/Log.c trunk/reactos/drivers/wdm/audio/sysaudio/deviface.c trunk/reactos/ntoskrnl/kdbg/kdb_symbols.cmake.c Modified: trunk/reactos/drivers/storage/port/buslogic/Log.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/port/buslo… ============================================================================== --- trunk/reactos/drivers/storage/port/buslogic/Log.c [iso-8859-1] (original) +++ trunk/reactos/drivers/storage/port/buslogic/Log.c [iso-8859-1] Fri Jul 19 15:19:03 2013 @@ -44,7 +44,7 @@ DbgPrint("\n BusLogic - Creating the file"); status = ZwCreateFile(&FileHandle, - FILE_APPEND_DATA, + FILE_APPEND_DATA | SYNCHRONIZE, &objectAttributes, &IoStatus, 0, Modified: trunk/reactos/drivers/wdm/audio/sysaudio/deviface.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/sysaudio… ============================================================================== --- trunk/reactos/drivers/wdm/audio/sysaudio/deviface.c [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/sysaudio/deviface.c [iso-8859-1] Fri Jul 19 15:19:03 2013 @@ -29,7 +29,7 @@ InitializeObjectAttributes(&ObjectAttributes, DeviceName, OBJ_KERNEL_HANDLE | OBJ_CASE_INSENSITIVE, NULL, NULL); Status = ZwCreateFile(&NodeHandle, - GENERIC_READ | GENERIC_WRITE, + GENERIC_READ | GENERIC_WRITE | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, NULL, Modified: trunk/reactos/ntoskrnl/kdbg/kdb_symbols.cmake.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kdbg/kdb_symbols.… ============================================================================== --- trunk/reactos/ntoskrnl/kdbg/kdb_symbols.cmake.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kdbg/kdb_symbols.cmake.c [iso-8859-1] Fri Jul 19 15:19:03 2013 @@ -517,18 +517,18 @@ /* Open the file */ InitializeObjectAttributes(&ObjectAttributes, FileName, - OBJ_CASE_INSENSITIVE|OBJ_KERNEL_HANDLE, + OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE, NULL, NULL); DPRINT("Attempting to open image: %wZ\n", FileName); Status = ZwOpenFile(&FileHandle, - FILE_READ_ACCESS, + FILE_READ_ACCESS | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, - FILE_SHARE_READ|FILE_SHARE_WRITE, - FILE_NON_DIRECTORY_FILE|FILE_SYNCHRONOUS_IO_NONALERT); + FILE_SHARE_READ | FILE_SHARE_WRITE, + FILE_NON_DIRECTORY_FILE | FILE_SYNCHRONOUS_IO_NONALERT); if (!NT_SUCCESS(Status)) { DPRINT("Could not open image file(%x): %wZ\n", Status, FileName); @@ -539,7 +539,7 @@ Status = ObReferenceObjectByHandle (FileHandle, - FILE_READ_DATA|SYNCHRONIZE, + FILE_READ_DATA | SYNCHRONIZE, NULL, KernelMode, (PVOID*)&FileObject,

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
20
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs July 2013