Ros-diffs August 2013

ros-diffs@reactos.org

10 participants
327 discussions

[hbelusca] 59792: [KERNEL32] - Move VDM-related definitions into a dedicated header. - Clean some code.
by hbelusca＠svn.reactos.org 22 Aug '13

22 Aug '13

Author: hbelusca Date: Thu Aug 22 16:10:34 2013 New Revision: 59792 URL: http://svn.reactos.org/svn/reactos?rev=59792&view=rev Log: [KERNEL32] - Move VDM-related definitions into a dedicated header. - Clean some code. Added: trunk/reactos/dll/win32/kernel32/include/vdm.h (with props) Modified: trunk/reactos/dll/win32/kernel32/client/vdm.c trunk/reactos/dll/win32/kernel32/include/kernel32.h trunk/reactos/dll/win32/kernel32/k32.h Modified: trunk/reactos/dll/win32/kernel32/client/vdm.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/vdm.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/vdm.c [iso-8859-1] Thu Aug 22 16:10:34 2013 @@ -101,7 +101,7 @@ case VdmEntryUndo: { /* Tell the server how far we had gotten along */ - UpdateVdmEntry->iTask = (ULONG)*WaitHandle; + UpdateVdmEntry->iTask = HandleToUlong(*WaitHandle); UpdateVdmEntry->VDMCreationState = IndexInfo; break; } @@ -186,7 +186,7 @@ /* Call CSRSS */ Status = CsrClientCallServer((PCSR_API_MESSAGE)&ApiMessage, NULL, - CSR_CREATE_API_NUMBER(BASESRV_SERVERDLL_INDEX, BasepGetVDMExitCode /* BasepCheckVDM */), + CSR_CREATE_API_NUMBER(BASESRV_SERVERDLL_INDEX, BasepGetVDMExitCode), sizeof(BASE_GET_VDM_EXIT_CODE)); if (!NT_SUCCESS(Status)) return FALSE; Modified: trunk/reactos/dll/win32/kernel32/include/kernel32.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/include… ============================================================================== --- trunk/reactos/dll/win32/kernel32/include/kernel32.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/include/kernel32.h [iso-8859-1] Thu Aug 22 16:10:34 2013 @@ -61,41 +61,6 @@ #define FIELD_OFFSET(type,fld) ((LONG)&(((type *)0)->fld)) #endif -// -// This stuff maybe should go in a vdm.h? -// -typedef enum _VDM_ENTRY_CODE -{ - VdmEntryUndo, - VdmEntryUpdateProcess, - VdmEntryUpdateControlCHandler -} VDM_ENTRY_CODE; - -// -// Undo States -// -#define VDM_UNDO_PARTIAL 0x01 -#define VDM_UNDO_FULL 0x02 -#define VDM_UNDO_REUSE 0x04 -#define VDM_UNDO_COMPLETED 0x08 - -// -// Binary Types to share with VDM -// -#define BINARY_TYPE_EXE 0x01 -#define BINARY_TYPE_COM 0x02 -#define BINARY_TYPE_PIF 0x03 -#define BINARY_TYPE_DOS 0x10 -#define BINARY_TYPE_SEPARATE_WOW 0x20 -#define BINARY_TYPE_WOW 0x40 -#define BINARY_TYPE_WOW_EX 0x80 - -// -// VDM States -// -#define VDM_NOT_LOADED 0x01 -#define VDM_NOT_READY 0x02 -#define VDM_READY 0x04 /* Undocumented CreateProcess flag */ #define STARTF_SHELLPRIVATE 0x400 @@ -366,31 +331,6 @@ VOID ); -BOOL -NTAPI -BaseDestroyVDMEnvironment( - IN PANSI_STRING AnsiEnv, - IN PUNICODE_STRING UnicodeEnv -); - -BOOL -WINAPI -BaseGetVdmConfigInfo( - IN LPCWSTR CommandLineReserved, - IN ULONG DosSeqId, - IN ULONG BinaryType, - IN PUNICODE_STRING CmdLineString, - OUT PULONG VdmSize -); - -BOOL -NTAPI -BaseCreateVDMEnvironment( - IN PWCHAR lpEnvironment, - IN PANSI_STRING AnsiEnv, - IN PUNICODE_STRING UnicodeEnv -); - VOID WINAPI InitCommandLines(VOID); @@ -468,42 +408,11 @@ extern LIST_ENTRY BasepAppCertDllsList; extern RTL_CRITICAL_SECTION gcsAppCert; -BOOL -WINAPI -BaseUpdateVDMEntry( - IN ULONG UpdateIndex, - IN OUT PHANDLE WaitHandle, - IN ULONG IndexInfo, - IN ULONG BinaryType -); - VOID WINAPI BaseMarkFileForDelete( IN HANDLE FileHandle, IN ULONG FileAttributes -); - -BOOL -WINAPI -BaseCheckForVDM( - IN HANDLE ProcessHandle, - OUT LPDWORD ExitCode -); - -BOOL -WINAPI -BaseCheckVDM( - IN ULONG BinaryType, - IN PCWCH ApplicationName, - IN PCWCH CommandLine, - IN PCWCH CurrentDirectory, - IN PANSI_STRING AnsiEnvironment, - IN PCSR_API_MESSAGE ApiMessage, - IN OUT PULONG iTask, - IN DWORD CreationFlags, - IN LPSTARTUPINFOW StartupInfo, - IN HANDLE hUserToken OPTIONAL ); Added: trunk/reactos/dll/win32/kernel32/include/vdm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/include… ============================================================================== --- trunk/reactos/dll/win32/kernel32/include/vdm.h (added) +++ trunk/reactos/dll/win32/kernel32/include/vdm.h [iso-8859-1] Thu Aug 22 16:10:34 2013 @@ -0,0 +1,105 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS System Libraries + * FILE: dll/win32/kernel32/include/vdm.h + * PURPOSE: Virtual DOS Machines (VDM) Support Definitions + * PROGRAMMERS: Alex Ionescu (alex.ionescu(a)reactos.org) + */ + +#pragma once + +/* CONSTANTS ******************************************************************/ + +typedef enum _VDM_ENTRY_CODE +{ + VdmEntryUndo, + VdmEntryUpdateProcess, + VdmEntryUpdateControlCHandler +} VDM_ENTRY_CODE; + +// +// Undo States +// +#define VDM_UNDO_PARTIAL 0x01 +#define VDM_UNDO_FULL 0x02 +#define VDM_UNDO_REUSE 0x04 +#define VDM_UNDO_COMPLETED 0x08 + +// +// Binary Types to share with VDM +// +#define BINARY_TYPE_EXE 0x01 +#define BINARY_TYPE_COM 0x02 +#define BINARY_TYPE_PIF 0x03 +#define BINARY_TYPE_DOS 0x10 +#define BINARY_TYPE_SEPARATE_WOW 0x20 +#define BINARY_TYPE_WOW 0x40 +#define BINARY_TYPE_WOW_EX 0x80 + +// +// VDM States +// +#define VDM_NOT_LOADED 0x01 +#define VDM_NOT_READY 0x02 +#define VDM_READY 0x04 + + +/* FUNCTION PROTOTYPES ********************************************************/ + +BOOL +NTAPI +BaseDestroyVDMEnvironment( + IN PANSI_STRING AnsiEnv, + IN PUNICODE_STRING UnicodeEnv +); + +BOOL +WINAPI +BaseGetVdmConfigInfo( + IN LPCWSTR CommandLineReserved, + IN ULONG DosSeqId, + IN ULONG BinaryType, + IN PUNICODE_STRING CmdLineString, + OUT PULONG VdmSize +); + +BOOL +NTAPI +BaseCreateVDMEnvironment( + IN PWCHAR lpEnvironment, + IN PANSI_STRING AnsiEnv, + IN PUNICODE_STRING UnicodeEnv +); + +BOOL +WINAPI +BaseUpdateVDMEntry( + IN ULONG UpdateIndex, + IN OUT PHANDLE WaitHandle, + IN ULONG IndexInfo, + IN ULONG BinaryType +); + +BOOL +WINAPI +BaseCheckForVDM( + IN HANDLE ProcessHandle, + OUT LPDWORD ExitCode +); + +BOOL +WINAPI +BaseCheckVDM( + IN ULONG BinaryType, + IN PCWCH ApplicationName, + IN PCWCH CommandLine, + IN PCWCH CurrentDirectory, + IN PANSI_STRING AnsiEnvironment, + IN PCSR_API_MESSAGE ApiMessage, + IN OUT PULONG iTask, + IN DWORD CreationFlags, + IN LPSTARTUPINFOW StartupInfo, + IN HANDLE hUserToken OPTIONAL +); + +/* EOF */ Propchange: trunk/reactos/dll/win32/kernel32/include/vdm.h ------------------------------------------------------------------------------ svn:eol-style = native Modified: trunk/reactos/dll/win32/kernel32/k32.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/k32.h?r… ============================================================================== --- trunk/reactos/dll/win32/kernel32/k32.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/k32.h [iso-8859-1] Thu Aug 22 16:10:34 2013 @@ -72,4 +72,7 @@ /* Console API Client Definitions */ #include "include/console.h" +/* Virtual DOS Machines (VDM) Support Definitions */ +#include "include/vdm.h" + #endif

1 0

[hbelusca] 59791: [KERNEL32] *Just* clarify some parts of the code and argument names of functions, and do not hardcode constant values; use #defines instead.
by hbelusca＠svn.reactos.org 22 Aug '13

22 Aug '13

Author: hbelusca Date: Thu Aug 22 12:47:14 2013 New Revision: 59791 URL: http://svn.reactos.org/svn/reactos?rev=59791&view=rev Log: [KERNEL32] *Just* clarify some parts of the code and argument names of functions, and do not hardcode constant values; use #defines instead. Modified: trunk/reactos/dll/win32/kernel32/client/vdm.c trunk/reactos/dll/win32/kernel32/include/kernel32.h Modified: trunk/reactos/dll/win32/kernel32/client/vdm.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/vdm.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/vdm.c [iso-8859-1] Thu Aug 22 12:47:14 2013 @@ -26,11 +26,11 @@ ENV_INFO BasepEnvNameType[] = { - {3, sizeof(L"PATH"), L"PATH"}, - {2, sizeof(L"WINDIR"), L"WINDIR"}, + {3, sizeof(L"PATH") , L"PATH" }, + {2, sizeof(L"WINDIR") , L"WINDIR" }, {2, sizeof(L"SYSTEMROOT"), L"SYSTEMROOT"}, - {3, sizeof(L"TEMP"), L"TEMP"}, - {3, sizeof(L"TMP"), L"TMP"}, + {3, sizeof(L"TEMP") , L"TEMP" }, + {3, sizeof(L"TMP") , L"TMP" }, }; UNICODE_STRING BaseDotComSuffixName = RTL_CONSTANT_STRING(L".com"); @@ -99,19 +99,21 @@ { /* VDM is being undone */ case VdmEntryUndo: - + { /* Tell the server how far we had gotten along */ UpdateVdmEntry->iTask = (ULONG)*WaitHandle; UpdateVdmEntry->VDMCreationState = IndexInfo; break; + } /* VDM is ready with a new process handle */ case VdmEntryUpdateProcess: - + { /* Send it the process handle */ UpdateVdmEntry->VDMProcessHandle = *WaitHandle; UpdateVdmEntry->iTask = IndexInfo; break; + } } /* Also check what kind of binary this is for the console handle */ @@ -123,11 +125,11 @@ else if (UpdateVdmEntry->iTask) { /* No handle for true VDM */ - UpdateVdmEntry->ConsoleHandle = 0; + UpdateVdmEntry->ConsoleHandle = NULL; } else { - /* Otherwise, send the regular consoel handle */ + /* Otherwise, use the regular console handle */ UpdateVdmEntry->ConsoleHandle = NtCurrentPeb()->ProcessParameters->ConsoleHandle; } @@ -196,7 +198,7 @@ BOOL WINAPI -BaseGetVdmConfigInfo(IN LPCWSTR Reserved, +BaseGetVdmConfigInfo(IN LPCWSTR CommandLineReserved, IN ULONG DosSeqId, IN ULONG BinaryType, IN PUNICODE_STRING CmdLineString, @@ -209,7 +211,7 @@ /* Clear the buffer in case we fail */ CmdLineString->Buffer = 0; - /* Always return the same size */ + /* Always return the same size: 16 Mb */ *VdmSize = 0x1000000; /* Get the system directory */ @@ -224,24 +226,31 @@ /* Check if this is VDM with a DOS Sequence ID */ if (DosSeqId) { - /* Build the VDM string for it */ + /* + * Build the VDM string for it: + * -i%lx : Gives the DOS Sequence ID; + * %s%c : Nothing if DOS VDM, -w if WoW VDM, -ws if separate WoW VDM. + */ _snwprintf(CommandLine, sizeof(CommandLine), L"\"%s\\ntvdm.exe\" -i%lx %s%c", Buffer, DosSeqId, - (BinaryType == 0x10) ? L" " : L"-w", - (BinaryType == 0x40) ? 's' : ' '); + (BinaryType == BINARY_TYPE_DOS) ? L" " : L"-w", + (BinaryType == BINARY_TYPE_SEPARATE_WOW) ? L's' : L' '); } else { - /* Non-DOS, build the string for it without the task ID */ + /* + * Build the string for it without the DOS Sequence ID: + * %s%c : Nothing if DOS VDM, -w if WoW VDM, -ws if separate WoW VDM. + */ _snwprintf(CommandLine, sizeof(CommandLine), - L"\"%s\\ntvdm.exe\" %s%c", + L"\"%s\\ntvdm.exe\" %s%c", Buffer, - (BinaryType == 0x10) ? L" " : L"-w", - (BinaryType == 0x40) ? 's' : ' '); + (BinaryType == BINARY_TYPE_DOS) ? L" " : L"-w", + (BinaryType == BINARY_TYPE_SEPARATE_WOW) ? L's' : L' '); } /* Create the actual string */ Modified: trunk/reactos/dll/win32/kernel32/include/kernel32.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/include… ============================================================================== --- trunk/reactos/dll/win32/kernel32/include/kernel32.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/include/kernel32.h [iso-8859-1] Thu Aug 22 12:47:14 2013 @@ -376,7 +376,7 @@ BOOL WINAPI BaseGetVdmConfigInfo( - IN LPCWSTR Reserved, + IN LPCWSTR CommandLineReserved, IN ULONG DosSeqId, IN ULONG BinaryType, IN PUNICODE_STRING CmdLineString,

1 0

[hbelusca] 59790: [NTOSKRNL] - Move NtQueryTimerResolution and NtSetTimerResolution from ke/clock.c to their proper place in ex/time.c - Simplify NtQueryTimerResolution and implement NtSetTimerReso...
by hbelusca＠svn.reactos.org 21 Aug '13

21 Aug '13

Author: hbelusca Date: Wed Aug 21 16:54:19 2013 New Revision: 59790 URL: http://svn.reactos.org/svn/reactos?rev=59790&view=rev Log: [NTOSKRNL] - Move NtQueryTimerResolution and NtSetTimerResolution from ke/clock.c to their proper place in ex/time.c - Simplify NtQueryTimerResolution and implement NtSetTimerResolution based on the patch of Aleksandar Andrejevic. CORE-7387 #resolve #comment NtSetTimerResolution function committed in revision 59790, thanks :D Modified: trunk/reactos/ntoskrnl/ex/time.c trunk/reactos/ntoskrnl/ke/clock.c Modified: trunk/reactos/ntoskrnl/ex/time.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/time.c?rev=597… ============================================================================== --- trunk/reactos/ntoskrnl/ex/time.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/time.c [iso-8859-1] Wed Aug 21 16:54:19 2013 @@ -48,9 +48,7 @@ *--*/ BOOLEAN NTAPI -ExAcquireTimeRefreshLock( - IN BOOLEAN Wait - ) +ExAcquireTimeRefreshLock(IN BOOLEAN Wait) { /* Block APCs */ KeEnterCriticalRegion(); @@ -82,9 +80,7 @@ *--*/ VOID NTAPI -ExReleaseTimeRefreshLock( - VOID - ) +ExReleaseTimeRefreshLock(VOID) { /* Release the lock and re-enable APCs */ ExReleaseResourceLite(&ExpTimeRefreshLock); @@ -478,4 +474,92 @@ LocalTime->QuadPart = SystemTime->QuadPart - ExpTimeZoneBias.QuadPart; } +/* + * @implemented + */ +NTSTATUS +NTAPI +NtQueryTimerResolution(OUT PULONG MinimumResolution, + OUT PULONG MaximumResolution, + OUT PULONG ActualResolution) +{ + KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); + + /* Check if the call came from user mode */ + if (PreviousMode != KernelMode) + { + _SEH2_TRY + { + /* Probe the parameters */ + ProbeForWriteUlong(MinimumResolution); + ProbeForWriteUlong(MaximumResolution); + ProbeForWriteUlong(ActualResolution); + } + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) + { + /* Return the exception code */ + _SEH2_YIELD(return _SEH2_GetExceptionCode()); + } + _SEH2_END; + } + + /* + * Set the parameters to the actual values. + * + * NOTE: + * MinimumResolution corresponds to the biggest time increment and + * MaximumResolution corresponds to the smallest time increment. + */ + *MinimumResolution = KeMaximumIncrement; + *MaximumResolution = KeMinimumIncrement; + *ActualResolution = KeTimeIncrement; + + /* Return success */ + return STATUS_SUCCESS; +} + +/* + * @implemented + */ +NTSTATUS +NTAPI +NtSetTimerResolution(IN ULONG DesiredResolution, + IN BOOLEAN SetResolution, + OUT PULONG CurrentResolution) +{ + KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); + PEPROCESS Process = PsGetCurrentProcess(); + ULONG NewResolution; + + /* Check if the call came from user mode */ + if (PreviousMode != KernelMode) + { + _SEH2_TRY + { + /* Probe the parameter */ + ProbeForWriteUlong(CurrentResolution); + } + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) + { + /* Return the exception code */ + _SEH2_YIELD(return _SEH2_GetExceptionCode()); + } + _SEH2_END; + } + + /* Set and return the new resolution */ + NewResolution = ExSetTimerResolution(DesiredResolution, SetResolution); + *CurrentResolution = NewResolution; + + if (SetResolution) + { + /* Set the flag that the resolution has been changed */ + Process->SetTimerResolution = TRUE; + } + + /* Return success if the process changed its timer resolution */ + if (Process->SetTimerResolution) return STATUS_SUCCESS; + else return STATUS_TIMER_RESOLUTION_NOT_SET; +} + /* EOF */ Modified: trunk/reactos/ntoskrnl/ke/clock.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/clock.c?rev=59… ============================================================================== --- trunk/reactos/ntoskrnl/ke/clock.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ke/clock.c [iso-8859-1] Wed Aug 21 16:54:19 2013 @@ -236,56 +236,4 @@ KiTickOffset = MaxIncrement; } -NTSTATUS -NTAPI -NtQueryTimerResolution(OUT PULONG MinimumResolution, - OUT PULONG MaximumResolution, - OUT PULONG ActualResolution) -{ - KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); - - /* Check if the call came from user mode */ - if (PreviousMode != KernelMode) - { - _SEH2_TRY - { - /* Probe the parameters */ - ProbeForWriteUlong(MinimumResolution); - ProbeForWriteUlong(MaximumResolution); - ProbeForWriteUlong(ActualResolution); - - /* Try to set the parameters to the actual values */ - *MinimumResolution = KeMinimumIncrement; - *MaximumResolution = KeMaximumIncrement; - *ActualResolution = KeTimeIncrement; - } - _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) - { - /* Return the exception code */ - _SEH2_YIELD(return _SEH2_GetExceptionCode()); - } - _SEH2_END; - } - else - { - /* The call came from kernel mode. Use the pointers directly */ - *MinimumResolution = KeMinimumIncrement; - *MaximumResolution = KeMaximumIncrement; - *ActualResolution = KeTimeIncrement; - } - - /* Return success */ - return STATUS_SUCCESS; -} - -NTSTATUS -NTAPI -NtSetTimerResolution(IN ULONG DesiredResolution, - IN BOOLEAN SetResolution, - OUT PULONG CurrentResolution) -{ - UNIMPLEMENTED; - return STATUS_NOT_IMPLEMENTED; -} - /* EOF */

1 0

[hbelusca] 59789: [ROSTESTS] Add a newline.
by hbelusca＠svn.reactos.org 21 Aug '13

21 Aug '13

Author: hbelusca Date: Wed Aug 21 11:14:22 2013 New Revision: 59789 URL: http://svn.reactos.org/svn/reactos?rev=59789&view=rev Log: [ROSTESTS] Add a newline. Modified: trunk/rostests/apitests/ntdll/Timer.c Modified: trunk/rostests/apitests/ntdll/Timer.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/Timer.c?re… ============================================================================== --- trunk/rostests/apitests/ntdll/Timer.c [iso-8859-1] (original) +++ trunk/rostests/apitests/ntdll/Timer.c [iso-8859-1] Wed Aug 21 11:14:22 2013 @@ -43,7 +43,7 @@ ok_hex(Status, STATUS_SUCCESS); /* The MinimumResolution should be higher than the MaximumResolution */ - ok(MinimumResolution >= MaximumResolution, "MaximumResolution higher than MinimumResolution!"); + ok(MinimumResolution >= MaximumResolution, "MaximumResolution higher than MinimumResolution!\n"); /* These two values should be the same */ ok_hex(CurrentResolution, CurrentResolution2);

1 0

[hbelusca] 59788: [ROSTESTS] Fix timer tests, by Aleksander Andrejevic. See CORE-7387 for more details, and: http://mirrors.arcadecontrols.com/www.sysinternals.com/Information/HighResolutionTimers....
by hbelusca＠svn.reactos.org 20 Aug '13

20 Aug '13

Author: hbelusca Date: Tue Aug 20 18:55:42 2013 New Revision: 59788 URL: http://svn.reactos.org/svn/reactos?rev=59788&view=rev Log: [ROSTESTS] Fix timer tests, by Aleksander Andrejevic. See CORE-7387 for more details, and: http://mirrors.arcadecontrols.com/www.sysinternals.com/Information/HighReso… too. Modified: trunk/rostests/apitests/ntdll/Timer.c trunk/rostests/apitests/ntdll/testlist.c Modified: trunk/rostests/apitests/ntdll/Timer.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/Timer.c?re… ============================================================================== --- trunk/rostests/apitests/ntdll/Timer.c [iso-8859-1] (original) +++ trunk/rostests/apitests/ntdll/Timer.c [iso-8859-1] Tue Aug 20 18:55:42 2013 @@ -26,8 +26,8 @@ &CurrentResolution); /* - * When not setting the resolution, it always - * returns STATUS_TIMER_RESOLUTION_NOT_SET + * If the timer resolution hasn't been changed for this process, + * it returns STATUS_TIMER_RESOLUTION_NOT_SET */ ok_hex(Status, STATUS_TIMER_RESOLUTION_NOT_SET); @@ -42,6 +42,9 @@ /* This function should always return STATUS_SUCCESS */ ok_hex(Status, STATUS_SUCCESS); + /* The MinimumResolution should be higher than the MaximumResolution */ + ok(MinimumResolution >= MaximumResolution, "MaximumResolution higher than MinimumResolution!"); + /* These two values should be the same */ ok_hex(CurrentResolution, CurrentResolution2); @@ -50,17 +53,25 @@ * NtSetTimerResolution will return STATUS_SUCCESS, * but it will not change the resolution. */ - Status = NtSetTimerResolution(MinimumResolution - 1, + Status = NtSetTimerResolution(MinimumResolution + 1, TRUE, &CurrentResolution); ok_hex(Status, STATUS_SUCCESS); printf("Current resolution: %d ; minimum resolution: %d\n", CurrentResolution, MinimumResolution); - ok(CurrentResolution >= MinimumResolution, "Current resolution: %d became too low! (minimum resolution: %d)\n", CurrentResolution, MinimumResolution); + ok(CurrentResolution <= MinimumResolution, "Current resolution: %d became too high! (minimum resolution: %d)\n", CurrentResolution, MinimumResolution); - Status = NtSetTimerResolution(MaximumResolution + 1, + Status = NtSetTimerResolution(MaximumResolution - 1, TRUE, &CurrentResolution); ok_hex(Status, STATUS_SUCCESS); printf("Current resolution: %d ; maximum resolution: %d\n", CurrentResolution, MaximumResolution); - ok(CurrentResolution <= MaximumResolution, "Current resolution: %d became too high! (maximum resolution: %d)\n", CurrentResolution, MaximumResolution); + ok(CurrentResolution >= MaximumResolution, "Current resolution: %d became too low! (maximum resolution: %d)\n", CurrentResolution, MaximumResolution); + + /* Get the current timer resolution */ + Status = NtSetTimerResolution(0, /* Ignored */ + FALSE, /* Don't change resolution */ + &CurrentResolution); + + /* Since we have changed the resolution earlier, it returns STATUS_SUCCESS. */ + ok_hex(Status, STATUS_SUCCESS); } Modified: trunk/rostests/apitests/ntdll/testlist.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/testlist.c… ============================================================================== --- trunk/rostests/apitests/ntdll/testlist.c [iso-8859-1] (original) +++ trunk/rostests/apitests/ntdll/testlist.c [iso-8859-1] Tue Aug 20 18:55:42 2013 @@ -21,8 +21,8 @@ extern void func_RtlGetFullPathName_UstrEx(void); extern void func_RtlGetLongestNtPathLength(void); extern void func_RtlInitializeBitMap(void); +extern void func_TimerResolution(void); extern void func_ZwContinue(void); -extern void func_TimerResolution(void); const struct test winetest_testlist[] = { @@ -44,8 +44,8 @@ { "RtlGetFullPathName_UstrEx", func_RtlGetFullPathName_UstrEx }, { "RtlGetLongestNtPathLength", func_RtlGetLongestNtPathLength }, { "RtlInitializeBitMap", func_RtlInitializeBitMap }, + { "TimerResolution", func_TimerResolution }, { "ZwContinue", func_ZwContinue }, - { "TimerResolution", func_TimerResolution }, { 0, 0 } };

1 0

[fireball] 59787: [CTM] - Change my email address to a working one. - Remove version info from the title.
by fireball＠svn.reactos.org 20 Aug '13

20 Aug '13

Author: fireball Date: Tue Aug 20 11:51:05 2013 New Revision: 59787 URL: http://svn.reactos.org/svn/reactos?rev=59787&view=rev Log: [CTM] - Change my email address to a working one. - Remove version info from the title. Modified: trunk/rosapps/applications/sysutils/ctm/ctm.c trunk/rosapps/applications/sysutils/ctm/ctm.h trunk/rosapps/applications/sysutils/ctm/lang/de-DE.rc trunk/rosapps/applications/sysutils/ctm/lang/el-GR.rc trunk/rosapps/applications/sysutils/ctm/lang/en-US.rc trunk/rosapps/applications/sysutils/ctm/lang/fr-FR.rc trunk/rosapps/applications/sysutils/ctm/lang/no-NO.rc trunk/rosapps/applications/sysutils/ctm/lang/ru-RU.rc trunk/rosapps/applications/sysutils/ctm/lang/uk-UA.rc Modified: trunk/rosapps/applications/sysutils/ctm/ctm.c URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/sysutils/ctm/… ============================================================================== --- trunk/rosapps/applications/sysutils/ctm/ctm.c [iso-8859-1] (original) +++ trunk/rosapps/applications/sysutils/ctm/ctm.c [iso-8859-1] Tue Aug 20 11:51:05 2013 @@ -2,7 +2,7 @@ ctm.c - main program file - Written by: Aleksey Bragin (aleksey(a)studiocerebral.com) + Written by: Aleksey Bragin (aleksey(a)reactos.org) Most of the code dealing with getting system parameters is taken from ReactOS Task Manager written by Brian Palmer (brianp(a)reactos.org) Modified: trunk/rosapps/applications/sysutils/ctm/ctm.h URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/sysutils/ctm/… ============================================================================== --- trunk/rosapps/applications/sysutils/ctm/ctm.h [iso-8859-1] (original) +++ trunk/rosapps/applications/sysutils/ctm/ctm.h [iso-8859-1] Tue Aug 20 11:51:05 2013 @@ -2,7 +2,7 @@ ctm.h - header file for main program - Written by: Aleksey Bragin (aleksey(a)studiocerebral.com) + Written by: Aleksey Bragin (aleksey(a)reactos.org) Most of this file content is taken from ReactOS Task Manager written by Brian Palmer (brianp(a)reactos.org) Modified: trunk/rosapps/applications/sysutils/ctm/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/sysutils/ctm/… ============================================================================== --- trunk/rosapps/applications/sysutils/ctm/lang/de-DE.rc [iso-8859-1] (original) +++ trunk/rosapps/applications/sysutils/ctm/lang/de-DE.rc [iso-8859-1] Tue Aug 20 11:51:05 2013 @@ -4,7 +4,7 @@ STRINGTABLE DISCARDABLE BEGIN - IDS_APP_TITLE "Console TaskManager v0.1 von Aleksey Bragin <aleksey(a)studiocerebral.com>" + IDS_APP_TITLE "Console TaskManager von Aleksey Bragin <aleksey(a)reactos.org>" IDS_COLUMN_NUMBER "# " IDS_COLUMN_IMAGENAME "Dateiname " Modified: trunk/rosapps/applications/sysutils/ctm/lang/el-GR.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/sysutils/ctm/… ============================================================================== --- trunk/rosapps/applications/sysutils/ctm/lang/el-GR.rc [iso-8859-1] (original) +++ trunk/rosapps/applications/sysutils/ctm/lang/el-GR.rc [iso-8859-1] Tue Aug 20 11:51:05 2013 @@ -4,7 +4,7 @@ STRINGTABLE DISCARDABLE BEGIN - IDS_APP_TITLE "Console TaskManager v0.1 by Aleksey Bragin <aleksey(a)studiocerebral.com>" + IDS_APP_TITLE "Console TaskManager by Aleksey Bragin <aleksey(a)reactos.org>" IDS_COLUMN_NUMBER "# " IDS_COLUMN_IMAGENAME "Image name " Modified: trunk/rosapps/applications/sysutils/ctm/lang/en-US.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/sysutils/ctm/… ============================================================================== --- trunk/rosapps/applications/sysutils/ctm/lang/en-US.rc [iso-8859-1] (original) +++ trunk/rosapps/applications/sysutils/ctm/lang/en-US.rc [iso-8859-1] Tue Aug 20 11:51:05 2013 @@ -4,7 +4,7 @@ STRINGTABLE DISCARDABLE BEGIN - IDS_APP_TITLE "Console TaskManager v0.1 by Aleksey Bragin <aleksey(a)studiocerebral.com>" + IDS_APP_TITLE "Console TaskManager by Aleksey Bragin <aleksey(a)reactos.org>" IDS_COLUMN_NUMBER "# " IDS_COLUMN_IMAGENAME "Image name " Modified: trunk/rosapps/applications/sysutils/ctm/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/sysutils/ctm/… ============================================================================== --- trunk/rosapps/applications/sysutils/ctm/lang/fr-FR.rc [iso-8859-1] (original) +++ trunk/rosapps/applications/sysutils/ctm/lang/fr-FR.rc [iso-8859-1] Tue Aug 20 11:51:05 2013 @@ -4,7 +4,7 @@ STRINGTABLE DISCARDABLE BEGIN - IDS_APP_TITLE "Console TaskManager v0.1 par Aleksey Bragin <aleksey(a)studiocerebral.com>" + IDS_APP_TITLE "Console TaskManager par Aleksey Bragin <aleksey(a)reactos.org>" IDS_COLUMN_NUMBER "# " IDS_COLUMN_IMAGENAME "Image name " Modified: trunk/rosapps/applications/sysutils/ctm/lang/no-NO.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/sysutils/ctm/… ============================================================================== --- trunk/rosapps/applications/sysutils/ctm/lang/no-NO.rc [iso-8859-1] (original) +++ trunk/rosapps/applications/sysutils/ctm/lang/no-NO.rc [iso-8859-1] Tue Aug 20 11:51:05 2013 @@ -4,7 +4,7 @@ STRINGTABLE DISCARDABLE BEGIN - IDS_APP_TITLE "Konsoll oppgavebehandler v0.1 av Aleksey Bragin <aleksey(a)studiocerebral.com>" + IDS_APP_TITLE "Konsoll oppgavebehandler av Aleksey Bragin <aleksey(a)reactos.org>" IDS_COLUMN_NUMBER "# " IDS_COLUMN_IMAGENAME "Bilde navn " Modified: trunk/rosapps/applications/sysutils/ctm/lang/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/sysutils/ctm/… ============================================================================== --- trunk/rosapps/applications/sysutils/ctm/lang/ru-RU.rc [iso-8859-1] (original) +++ trunk/rosapps/applications/sysutils/ctm/lang/ru-RU.rc [iso-8859-1] Tue Aug 20 11:51:05 2013 @@ -4,7 +4,7 @@ STRINGTABLE DISCARDABLE BEGIN - IDS_APP_TITLE "Êîíñîëüíûé Äèñïåò÷åð çàäà÷ v0.1 îò Aleksey Bragin <aleksey(a)studiocerebral.com>" + IDS_APP_TITLE "Êîíñîëüíûé Äèñïåò÷åð çàäà÷ îò Àëåêñåÿ Áðàãèíà <aleksey(a)reactos.org>" IDS_COLUMN_NUMBER "# " IDS_COLUMN_IMAGENAME "Èìÿ îáðàçà " Modified: trunk/rosapps/applications/sysutils/ctm/lang/uk-UA.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/sysutils/ctm/… ============================================================================== --- trunk/rosapps/applications/sysutils/ctm/lang/uk-UA.rc [iso-8859-1] (original) +++ trunk/rosapps/applications/sysutils/ctm/lang/uk-UA.rc [iso-8859-1] Tue Aug 20 11:51:05 2013 @@ -10,7 +10,7 @@ STRINGTABLE DISCARDABLE BEGIN - IDS_APP_TITLE "Êîíñîëüíèé Äèñïåò÷åð çàâäàíü v0.1 â³ä Aleksey Bragin <aleksey(a)studiocerebral.com>" + IDS_APP_TITLE "Êîíñîëüíèé Äèñïåò÷åð çàâäàíü â³ä Aleksey Bragin <aleksey(a)reactos.org>" IDS_COLUMN_NUMBER "# " IDS_COLUMN_IMAGENAME "²ì'ÿ îáðàçó "

1 0

[hbelusca] 59786: [ROSTESTS] Add a test for NtQueryTimerResolution and NtSetTimerResolution, by Aleksander Andrejevic. See CORE-7387 for more information.
by hbelusca＠svn.reactos.org 19 Aug '13

19 Aug '13

Author: hbelusca Date: Mon Aug 19 21:44:26 2013 New Revision: 59786 URL: http://svn.reactos.org/svn/reactos?rev=59786&view=rev Log: [ROSTESTS] Add a test for NtQueryTimerResolution and NtSetTimerResolution, by Aleksander Andrejevic. See CORE-7387 for more information. Added: trunk/rostests/apitests/ntdll/Timer.c (with props) Modified: trunk/rostests/apitests/ntdll/CMakeLists.txt trunk/rostests/apitests/ntdll/testlist.c Modified: trunk/rostests/apitests/ntdll/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/CMakeLists… ============================================================================== --- trunk/rostests/apitests/ntdll/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/apitests/ntdll/CMakeLists.txt [iso-8859-1] Mon Aug 19 21:44:26 2013 @@ -18,6 +18,7 @@ RtlGetLongestNtPathLength.c RtlInitializeBitMap.c SystemInfo.c + Timer.c ZwContinue.c testlist.c) Added: trunk/rostests/apitests/ntdll/Timer.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/Timer.c?re… ============================================================================== --- trunk/rostests/apitests/ntdll/Timer.c (added) +++ trunk/rostests/apitests/ntdll/Timer.c [iso-8859-1] Mon Aug 19 21:44:26 2013 @@ -0,0 +1,66 @@ +/* + * PROJECT: ReactOS API tests + * LICENSE: GPL - See COPYING in the top level directory + * PURPOSE: Test for NtQueryTimerResolution and NtSetTimerResolution. + * PROGRAMMER: Aleksandar Andrejevic <theflash AT sdf DOT lonestar DOT org> + */ + +#define WIN32_NO_STATUS +#include <wine/test.h> +#include <ndk/ketypes.h> +#include <ndk/kefuncs.h> + +#include <stdio.h> + +START_TEST(TimerResolution) +{ + NTSTATUS Status; + ULONG CurrentResolution; + ULONG MinimumResolution; + ULONG MaximumResolution; + ULONG CurrentResolution2; + + /* Get the current timer resolution */ + Status = NtSetTimerResolution(0, /* Ignored */ + FALSE, /* Don't change resolution */ + &CurrentResolution); + + /* + * When not setting the resolution, it always + * returns STATUS_TIMER_RESOLUTION_NOT_SET + */ + ok_hex(Status, STATUS_TIMER_RESOLUTION_NOT_SET); + + /* + * Get the timer resolution limits and current timer resolution + * using a different method + */ + Status = NtQueryTimerResolution(&MinimumResolution, + &MaximumResolution, + &CurrentResolution2); + + /* This function should always return STATUS_SUCCESS */ + ok_hex(Status, STATUS_SUCCESS); + + /* These two values should be the same */ + ok_hex(CurrentResolution, CurrentResolution2); + + /* + * Even if you give it invalid values, + * NtSetTimerResolution will return STATUS_SUCCESS, + * but it will not change the resolution. + */ + Status = NtSetTimerResolution(MinimumResolution - 1, + TRUE, + &CurrentResolution); + ok_hex(Status, STATUS_SUCCESS); + printf("Current resolution: %d ; minimum resolution: %d\n", CurrentResolution, MinimumResolution); + ok(CurrentResolution >= MinimumResolution, "Current resolution: %d became too low! (minimum resolution: %d)\n", CurrentResolution, MinimumResolution); + + Status = NtSetTimerResolution(MaximumResolution + 1, + TRUE, + &CurrentResolution); + ok_hex(Status, STATUS_SUCCESS); + printf("Current resolution: %d ; maximum resolution: %d\n", CurrentResolution, MaximumResolution); + ok(CurrentResolution <= MaximumResolution, "Current resolution: %d became too high! (maximum resolution: %d)\n", CurrentResolution, MaximumResolution); +} Propchange: trunk/rostests/apitests/ntdll/Timer.c ------------------------------------------------------------------------------ svn:eol-style = native Modified: trunk/rostests/apitests/ntdll/testlist.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/testlist.c… ============================================================================== --- trunk/rostests/apitests/ntdll/testlist.c [iso-8859-1] (original) +++ trunk/rostests/apitests/ntdll/testlist.c [iso-8859-1] Mon Aug 19 21:44:26 2013 @@ -22,6 +22,7 @@ extern void func_RtlGetLongestNtPathLength(void); extern void func_RtlInitializeBitMap(void); extern void func_ZwContinue(void); +extern void func_TimerResolution(void); const struct test winetest_testlist[] = { @@ -44,6 +45,7 @@ { "RtlGetLongestNtPathLength", func_RtlGetLongestNtPathLength }, { "RtlInitializeBitMap", func_RtlInitializeBitMap }, { "ZwContinue", func_ZwContinue }, + { "TimerResolution", func_TimerResolution }, { 0, 0 } };

1 0

[fireball] 59785: [NTOS] - Aleksandar Andrejevic: Implement NtQueryTimerResolution(). CORE-7387
by fireball＠svn.reactos.org 19 Aug '13

19 Aug '13

Author: fireball Date: Mon Aug 19 19:40:25 2013 New Revision: 59785 URL: http://svn.reactos.org/svn/reactos?rev=59785&view=rev Log: [NTOS] - Aleksandar Andrejevic: Implement NtQueryTimerResolution(). CORE-7387 Modified: trunk/reactos/ntoskrnl/ke/clock.c Modified: trunk/reactos/ntoskrnl/ke/clock.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/clock.c?rev=59… ============================================================================== --- trunk/reactos/ntoskrnl/ke/clock.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ke/clock.c [iso-8859-1] Mon Aug 19 19:40:25 2013 @@ -242,8 +242,40 @@ OUT PULONG MaximumResolution, OUT PULONG ActualResolution) { - UNIMPLEMENTED; - return STATUS_NOT_IMPLEMENTED; + KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); + + /* Check if the call came from user mode */ + if (PreviousMode != KernelMode) + { + _SEH2_TRY + { + /* Probe the parameters */ + ProbeForWriteUlong(MinimumResolution); + ProbeForWriteUlong(MaximumResolution); + ProbeForWriteUlong(ActualResolution); + + /* Try to set the parameters to the actual values */ + *MinimumResolution = KeMinimumIncrement; + *MaximumResolution = KeMaximumIncrement; + *ActualResolution = KeTimeIncrement; + } + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) + { + /* Return the exception code */ + _SEH2_YIELD(return _SEH2_GetExceptionCode()); + } + _SEH2_END; + } + else + { + /* The call came from kernel mode. Use the pointers directly */ + *MinimumResolution = KeMinimumIncrement; + *MaximumResolution = KeMaximumIncrement; + *ActualResolution = KeTimeIncrement; + } + + /* Return success */ + return STATUS_SUCCESS; } NTSTATUS

1 0

[hbelusca] 59784: Synchronize with trunk revision 59781.
by hbelusca＠svn.reactos.org 19 Aug '13

19 Aug '13

Author: hbelusca Date: Mon Aug 19 18:55:28 2013 New Revision: 59784 URL: http://svn.reactos.org/svn/reactos?rev=59784&view=rev Log: Synchronize with trunk revision 59781. Added: branches/ntvdm/dll/opengl/glu32/glu32.rc - copied unchanged from r59782, trunk/reactos/dll/opengl/glu32/glu32.rc branches/ntvdm/subsystems/win/basesrv/vdm.c - copied unchanged from r59782, trunk/reactos/subsystems/win/basesrv/vdm.c Modified: branches/ntvdm/ (props changed) branches/ntvdm/base/setup/usetup/bootsup.c branches/ntvdm/base/system/services/database.c branches/ntvdm/boot/bootdata/hivesys.inf branches/ntvdm/boot/freeldr/freeldr/comm/rs232.c branches/ntvdm/boot/freeldr/freeldr/windows/headless.c branches/ntvdm/boot/freeldr/freeldr/windows/winldr.c branches/ntvdm/cmake/gcc.cmake branches/ntvdm/dll/ntdll/csr/connect.c branches/ntvdm/dll/opengl/glu32/CMakeLists.txt branches/ntvdm/dll/win32/kernel32/client/console/init.c branches/ntvdm/dll/win32/kernel32/client/dosdev.c branches/ntvdm/dll/win32/kernel32/client/file/filename.c branches/ntvdm/dll/win32/kernel32/client/job.c branches/ntvdm/dll/win32/kernel32/client/proc.c branches/ntvdm/dll/win32/kernel32/client/vdm.c branches/ntvdm/dll/win32/kernel32/k32.h branches/ntvdm/dll/win32/netapi32/user.c branches/ntvdm/dll/win32/samlib/samlib.c branches/ntvdm/dll/win32/samsrv/samrpc.c branches/ntvdm/dll/win32/samsrv/user.c branches/ntvdm/drivers/base/kdcom/kdcom.c branches/ntvdm/drivers/sac/driver/chanmgr.c branches/ntvdm/drivers/sac/driver/channel.c branches/ntvdm/drivers/sac/driver/concmd.c branches/ntvdm/drivers/sac/driver/conmgr.c branches/ntvdm/drivers/sac/driver/data.c branches/ntvdm/drivers/sac/driver/dispatch.c branches/ntvdm/drivers/sac/driver/memory.c branches/ntvdm/drivers/sac/driver/rawchan.c branches/ntvdm/drivers/sac/driver/sacdrv.h branches/ntvdm/drivers/sac/driver/util.c branches/ntvdm/drivers/sac/driver/vtutf8chan.c branches/ntvdm/include/crt/mbstring.h branches/ntvdm/include/crt/sec_api/conio_s.h branches/ntvdm/include/crt/sec_api/mbstring_s.h branches/ntvdm/include/crt/sec_api/string_s.h branches/ntvdm/include/psdk/cfgmgr32.h branches/ntvdm/include/psdk/commctrl.h branches/ntvdm/include/psdk/dbghelp.h branches/ntvdm/include/psdk/ks.h branches/ntvdm/include/psdk/msi.h branches/ntvdm/include/psdk/objbase.h branches/ntvdm/include/psdk/oleauto.h branches/ntvdm/include/psdk/oledlg.h branches/ntvdm/include/psdk/sal.h branches/ntvdm/include/psdk/shellapi.h branches/ntvdm/include/psdk/shlobj.h branches/ntvdm/include/psdk/shlwapi.h branches/ntvdm/include/psdk/shlwapi_undoc.h branches/ntvdm/include/psdk/wincon.h branches/ntvdm/include/psdk/winsock.h branches/ntvdm/include/psdk/ws2spi.h branches/ntvdm/include/psdk/ws2tcpip.h branches/ntvdm/include/reactos/libs/cportlib/cportlib.h branches/ntvdm/include/reactos/mc/CMakeLists.txt branches/ntvdm/include/reactos/mc/sacmsg.mc branches/ntvdm/include/reactos/subsys/csr/csrmsg.h branches/ntvdm/include/reactos/subsys/win/basemsg.h branches/ntvdm/include/reactos/subsys/win/conmsg.h branches/ntvdm/lib/cportlib/cport.c branches/ntvdm/lib/rtl/process.c branches/ntvdm/ntoskrnl/ex/hdlsterm.c branches/ntvdm/ntoskrnl/inbv/inbvport.c branches/ntvdm/ntoskrnl/include/internal/hdl.h branches/ntvdm/ntoskrnl/include/internal/inbv.h branches/ntvdm/ntoskrnl/kd/i386/kdbg.c branches/ntvdm/ntoskrnl/rtl/misc.c branches/ntvdm/subsystems/win/basesrv/dosdev.c branches/ntvdm/subsystems/win/basesrv/proc.c branches/ntvdm/subsystems/win32/csrsrv/api.c branches/ntvdm/subsystems/win32/csrsrv/api.h branches/ntvdm/subsystems/win32/csrsrv/server.c branches/ntvdm/tools/rsym/rsym.c branches/ntvdm/win32ss/gdi/ntgdi/freetype.c branches/ntvdm/win32ss/user/ntuser/desktop.h branches/ntvdm/win32ss/user/ntuser/main.c branches/ntvdm/win32ss/user/ntuser/ntuser.h branches/ntvdm/win32ss/user/ntuser/usrheap.c branches/ntvdm/win32ss/user/winsrv/consrv/init.c [This mail would be too long, it was shortened to contain the URLs only.] Modified: branches/ntvdm/base/setup/usetup/bootsup.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/base/setup/usetup/bootsup… Modified: branches/ntvdm/base/system/services/database.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/base/system/services/data… Modified: branches/ntvdm/boot/bootdata/hivesys.inf URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/boot/bootdata/hivesys.inf… Modified: branches/ntvdm/boot/freeldr/freeldr/comm/rs232.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/boot/freeldr/freeldr/comm… Modified: branches/ntvdm/boot/freeldr/freeldr/windows/headless.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/boot/freeldr/freeldr/wind… Modified: branches/ntvdm/boot/freeldr/freeldr/windows/winldr.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/boot/freeldr/freeldr/wind… Modified: branches/ntvdm/cmake/gcc.cmake URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/cmake/gcc.cmake?rev=59784… Modified: branches/ntvdm/dll/ntdll/csr/connect.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/dll/ntdll/csr/connect.c?r… Modified: branches/ntvdm/dll/opengl/glu32/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/dll/opengl/glu32/CMakeLis… Modified: branches/ntvdm/dll/win32/kernel32/client/console/init.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/dll/win32/kernel32/client… Modified: branches/ntvdm/dll/win32/kernel32/client/dosdev.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/dll/win32/kernel32/client… Modified: branches/ntvdm/dll/win32/kernel32/client/file/filename.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/dll/win32/kernel32/client… Modified: branches/ntvdm/dll/win32/kernel32/client/job.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/dll/win32/kernel32/client… Modified: branches/ntvdm/dll/win32/kernel32/client/proc.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/dll/win32/kernel32/client… Modified: branches/ntvdm/dll/win32/kernel32/client/vdm.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/dll/win32/kernel32/client… Modified: branches/ntvdm/dll/win32/kernel32/k32.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/dll/win32/kernel32/k32.h?… Modified: branches/ntvdm/dll/win32/netapi32/user.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/dll/win32/netapi32/user.c… Modified: branches/ntvdm/dll/win32/samlib/samlib.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/dll/win32/samlib/samlib.c… Modified: branches/ntvdm/dll/win32/samsrv/samrpc.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/dll/win32/samsrv/samrpc.c… Modified: branches/ntvdm/dll/win32/samsrv/user.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/dll/win32/samsrv/user.c?r… Modified: branches/ntvdm/drivers/base/kdcom/kdcom.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/drivers/base/kdcom/kdcom.… Modified: branches/ntvdm/drivers/sac/driver/chanmgr.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/drivers/sac/driver/chanmg… Modified: branches/ntvdm/drivers/sac/driver/channel.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/drivers/sac/driver/channe… Modified: branches/ntvdm/drivers/sac/driver/concmd.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/drivers/sac/driver/concmd… Modified: branches/ntvdm/drivers/sac/driver/conmgr.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/drivers/sac/driver/conmgr… Modified: branches/ntvdm/drivers/sac/driver/data.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/drivers/sac/driver/data.c… Modified: branches/ntvdm/drivers/sac/driver/dispatch.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/drivers/sac/driver/dispat… Modified: branches/ntvdm/drivers/sac/driver/memory.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/drivers/sac/driver/memory… Modified: branches/ntvdm/drivers/sac/driver/rawchan.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/drivers/sac/driver/rawcha… Modified: branches/ntvdm/drivers/sac/driver/sacdrv.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/drivers/sac/driver/sacdrv… Modified: branches/ntvdm/drivers/sac/driver/util.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/drivers/sac/driver/util.c… Modified: branches/ntvdm/drivers/sac/driver/vtutf8chan.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/drivers/sac/driver/vtutf8… Modified: branches/ntvdm/include/crt/mbstring.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/crt/mbstring.h?re… Modified: branches/ntvdm/include/crt/sec_api/conio_s.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/crt/sec_api/conio… Modified: branches/ntvdm/include/crt/sec_api/mbstring_s.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/crt/sec_api/mbstr… Modified: branches/ntvdm/include/crt/sec_api/string_s.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/crt/sec_api/strin… Modified: branches/ntvdm/include/psdk/cfgmgr32.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/psdk/cfgmgr32.h?r… Modified: branches/ntvdm/include/psdk/commctrl.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/psdk/commctrl.h?r… Modified: branches/ntvdm/include/psdk/dbghelp.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/psdk/dbghelp.h?re… Modified: branches/ntvdm/include/psdk/ks.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/psdk/ks.h?rev=597… Modified: branches/ntvdm/include/psdk/msi.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/psdk/msi.h?rev=59… Modified: branches/ntvdm/include/psdk/objbase.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/psdk/objbase.h?re… Modified: branches/ntvdm/include/psdk/oleauto.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/psdk/oleauto.h?re… Modified: branches/ntvdm/include/psdk/oledlg.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/psdk/oledlg.h?rev… Modified: branches/ntvdm/include/psdk/sal.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/psdk/sal.h?rev=59… Modified: branches/ntvdm/include/psdk/shellapi.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/psdk/shellapi.h?r… Modified: branches/ntvdm/include/psdk/shlobj.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/psdk/shlobj.h?rev… Modified: branches/ntvdm/include/psdk/shlwapi.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/psdk/shlwapi.h?re… Modified: branches/ntvdm/include/psdk/shlwapi_undoc.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/psdk/shlwapi_undo… Modified: branches/ntvdm/include/psdk/wincon.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/psdk/wincon.h?rev… Modified: branches/ntvdm/include/psdk/winsock.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/psdk/winsock.h?re… Modified: branches/ntvdm/include/psdk/ws2spi.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/psdk/ws2spi.h?rev… Modified: branches/ntvdm/include/psdk/ws2tcpip.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/psdk/ws2tcpip.h?r… Modified: branches/ntvdm/include/reactos/libs/cportlib/cportlib.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/reactos/libs/cpor… Modified: branches/ntvdm/include/reactos/mc/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/reactos/mc/CMakeL… Modified: branches/ntvdm/include/reactos/mc/sacmsg.mc URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/reactos/mc/sacmsg… Modified: branches/ntvdm/include/reactos/subsys/csr/csrmsg.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/reactos/subsys/cs… Modified: branches/ntvdm/include/reactos/subsys/win/basemsg.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/reactos/subsys/wi… Modified: branches/ntvdm/include/reactos/subsys/win/conmsg.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/reactos/subsys/wi… Modified: branches/ntvdm/lib/cportlib/cport.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/lib/cportlib/cport.c?rev=… Modified: branches/ntvdm/lib/rtl/process.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/lib/rtl/process.c?rev=597… Modified: branches/ntvdm/ntoskrnl/ex/hdlsterm.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/ntoskrnl/ex/hdlsterm.c?re… Modified: branches/ntvdm/ntoskrnl/inbv/inbvport.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/ntoskrnl/inbv/inbvport.c?… Modified: branches/ntvdm/ntoskrnl/include/internal/hdl.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/ntoskrnl/include/internal… Modified: branches/ntvdm/ntoskrnl/include/internal/inbv.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/ntoskrnl/include/internal… Modified: branches/ntvdm/ntoskrnl/kd/i386/kdbg.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/ntoskrnl/kd/i386/kdbg.c?r… Modified: branches/ntvdm/ntoskrnl/rtl/misc.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/ntoskrnl/rtl/misc.c?rev=5… Modified: branches/ntvdm/subsystems/win/basesrv/dosdev.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/subsystems/win/basesrv/do… Modified: branches/ntvdm/subsystems/win/basesrv/proc.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/subsystems/win/basesrv/pr… Modified: branches/ntvdm/subsystems/win32/csrsrv/api.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/subsystems/win32/csrsrv/a… Modified: branches/ntvdm/subsystems/win32/csrsrv/api.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/subsystems/win32/csrsrv/a… Modified: branches/ntvdm/subsystems/win32/csrsrv/server.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/subsystems/win32/csrsrv/s… Modified: branches/ntvdm/tools/rsym/rsym.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/tools/rsym/rsym.c?rev=597… Modified: branches/ntvdm/win32ss/gdi/ntgdi/freetype.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/win32ss/gdi/ntgdi/freetyp… Modified: branches/ntvdm/win32ss/user/ntuser/desktop.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/win32ss/user/ntuser/deskt… Modified: branches/ntvdm/win32ss/user/ntuser/main.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/win32ss/user/ntuser/main.… Modified: branches/ntvdm/win32ss/user/ntuser/ntuser.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/win32ss/user/ntuser/ntuse… Modified: branches/ntvdm/win32ss/user/ntuser/usrheap.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/win32ss/user/ntuser/usrhe… Modified: branches/ntvdm/win32ss/user/winsrv/consrv/init.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/win32ss/user/winsrv/consr…

1 0

[aandrejevic] 59783: [SOFT386] Fix minor bug.
by aandrejevic＠svn.reactos.org 19 Aug '13

19 Aug '13

Author: aandrejevic Date: Mon Aug 19 18:52:53 2013 New Revision: 59783 URL: http://svn.reactos.org/svn/reactos?rev=59783&view=rev Log: [SOFT386] Fix minor bug. Modified: branches/ntvdm/lib/soft386/common.c Modified: branches/ntvdm/lib/soft386/common.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/lib/soft386/common.c?rev=… ============================================================================== --- branches/ntvdm/lib/soft386/common.c [iso-8859-1] (original) +++ branches/ntvdm/lib/soft386/common.c [iso-8859-1] Mon Aug 19 18:52:53 2013 @@ -597,7 +597,7 @@ if (!Soft386StackPush(State, OldSs)) return FALSE; /* Push stack pointer */ - if (Soft386StackPush(State, OldEsp)) return FALSE; + if (!Soft386StackPush(State, OldEsp)) return FALSE; } }

1 0

← Newer
1
...
12
13
14
15
16
17
18
...
33
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs August 2013