Author: pschweitzer
Date: Thu Oct 30 08:39:03 2014
New Revision: 65120
URL: http://svn.reactos.org/svn/reactos?rev=65120&view=rev
Log:
[NTOSKRNL]
Actually enable again the hack...
For whatever reason, it works with my WC but not with clean trunk...
Where are the you, magic and silent patch that fixes it? :-(
Modified:
trunk/reactos/ntoskrnl/io/iomgr/file.c
Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?r…
==============================================================================
--- trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] Thu Oct 30 08:39:03 2014
@@ -419,7 +419,7 @@
DirectOpen = TRUE;
}
-#if 0
+#if 1
/* FIXME: Small hack still exists, have to check why...
* This is triggered multiple times by usetup and then once per boot.
*/
Author: pschweitzer
Date: Thu Oct 30 07:49:37 2014
New Revision: 65119
URL: http://svn.reactos.org/svn/reactos?rev=65119&view=rev
Log:
[NTOSKRNL]
Finally, disable again the IopParseDevice hack.
Just for the record, opening a volume with FILE_READ_EA or FILE_READ_DATA is legal and works in Windows (NTFS Info for instance opens it with GENERIC_READ).
Let's hope we can rid of this hack forever now... It's been with us since 2006!
Modified:
trunk/reactos/ntoskrnl/io/iomgr/file.c
Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?r…
==============================================================================
--- trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] Thu Oct 30 07:49:37 2014
@@ -419,7 +419,7 @@
DirectOpen = TRUE;
}
-#if 1
+#if 0
/* FIXME: Small hack still exists, have to check why...
* This is triggered multiple times by usetup and then once per boot.
*/
Author: pschweitzer
Date: Wed Oct 29 23:28:15 2014
New Revision: 65117
URL: http://svn.reactos.org/svn/reactos?rev=65117&view=rev
Log:
[NTOSKRNL]
Reenable IopParseDevice hack for now.
Out of fixes for tonight.
Modified:
trunk/reactos/ntoskrnl/io/iomgr/file.c
Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?r…
==============================================================================
--- trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] Wed Oct 29 23:28:15 2014
@@ -419,7 +419,7 @@
DirectOpen = TRUE;
}
-#if 0
+#if 1
/* FIXME: Small hack still exists, have to check why...
* This is triggered multiple times by usetup and then once per boot.
*/
Author: dquintana
Date: Wed Oct 29 22:50:27 2014
New Revision: 65114
URL: http://svn.reactos.org/svn/reactos?rev=65114&view=rev
Log:
[RSHELL]
* Hopefully fix the start menu closing randomly. May have side-effects, but I think it's best to be conservative here and prefer the possibility of the menu staying open unexpectedly, rather than closing unexpectedly.
Modified:
branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp
Modified: branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp
URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs…
==============================================================================
--- branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp [iso-8859-1] (original)
+++ branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp [iso-8859-1] Wed Oct 29 22:50:27 2014
@@ -501,6 +501,7 @@
CComPtr<IMenuPopup> oldParent = m_SubMenuParent;
+ TRACE("OnSelect dwSelectType=%d\n", this, dwSelectType);
switch (dwSelectType)
{
case MPOS_EXECUTE:
@@ -705,9 +706,11 @@
LRESULT CMenuDeskBar::_OnAppActivate(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled)
{
+#if 0
if (wParam == 0 && m_Shown)
{
OnSelect(MPOS_FULLCANCEL);
}
+#endif
return 0;
}