Ros-diffs October 2014

ros-diffs@reactos.org

19 participants
730 discussions

[dquintana] 65092: [RSHELL] * Remove a few GCC unused-but-set-variable warnings.
by dquintana＠svn.reactos.org 28 Oct '14

28 Oct '14

Author: dquintana Date: Tue Oct 28 22:13:18 2014 New Revision: 65092 URL: http://svn.reactos.org/svn/reactos?rev=65092&view=rev Log: [RSHELL] * Remove a few GCC unused-but-set-variable warnings. Modified: branches/shell-experiments/base/shell/rshell/CDesktopBrowser.cpp branches/shell-experiments/base/shell/rshell/CMenuFocusManager.cpp Modified: branches/shell-experiments/base/shell/rshell/CDesktopBrowser.cpp URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/CDesktopBrowser.cpp [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/CDesktopBrowser.cpp [iso-8859-1] Tue Oct 28 22:13:18 2014 @@ -417,14 +417,16 @@ } else { + + /* FIXME: Update work area */ +#if 0 RECT rcDesktop; rcDesktop.left = GetSystemMetrics(SM_XVIRTUALSCREEN); rcDesktop.top = GetSystemMetrics(SM_YVIRTUALSCREEN); rcDesktop.right = GetSystemMetrics(SM_CXVIRTUALSCREEN); rcDesktop.bottom = GetSystemMetrics(SM_CYVIRTUALSCREEN); - - /* FIXME: Update work area */ +#endif } break; Modified: branches/shell-experiments/base/shell/rshell/CMenuFocusManager.cpp URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/CMenuFocusManager.cpp [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/CMenuFocusManager.cpp [iso-8859-1] Tue Oct 28 22:13:18 2014 @@ -396,12 +396,10 @@ TRACE("MouseDown %d\n", m_isLButtonDown); - BOOL isTracking = FALSE; if (entry) { ScreenToClient(child, &pt); iHitTestResult = SendMessageW(child, TB_HITTEST, 0, (LPARAM) &pt); - isTracking = entry->mb->_IsTracking(); if (iHitTestResult >= 0) { @@ -448,12 +446,10 @@ TRACE("MouseUp %d\n", m_isLButtonDown); - BOOL isTracking = FALSE; if (entry) { ScreenToClient(child, &pt); iHitTestResult = SendMessageW(child, TB_HITTEST, 0, (LPARAM) &pt); - isTracking = entry->mb->_IsTracking(); if (iHitTestResult >= 0) {

1 0

[zguo] 65091: [WIN32SS] Fix icon selection regression caused by cascading fix. In this case, this should probably go into trunk. CORE-8574
by zguo＠svn.reactos.org 28 Oct '14

28 Oct '14

Author: zguo Date: Tue Oct 28 22:01:57 2014 New Revision: 65091 URL: http://svn.reactos.org/svn/reactos?rev=65091&view=rev Log: [WIN32SS] Fix icon selection regression caused by cascading fix. In this case, this should probably go into trunk. CORE-8574 Modified: branches/0.3.17/reactos/win32ss/user/ntuser/msgqueue.c Modified: branches/0.3.17/reactos/win32ss/user/ntuser/msgqueue.c URL: http://svn.reactos.org/svn/reactos/branches/0.3.17/reactos/win32ss/user/ntu… ============================================================================== --- branches/0.3.17/reactos/win32ss/user/ntuser/msgqueue.c [iso-8859-1] (original) +++ branches/0.3.17/reactos/win32ss/user/ntuser/msgqueue.c [iso-8859-1] Tue Oct 28 22:01:57 2014 @@ -1676,8 +1676,21 @@ MSG msg; PUSER_MESSAGE_QUEUE MessageQueue = pti->MessageQueue; + // First look for any buttons downs or ups before testing for the move. + if (pti->nCntsQBits[QSRosMouseButton]) + { + if (co_MsqPeekHardwareMessage( pti, + Remove, + Window, + MsgFilterLow, + MsgFilterHigh, + QS_MOUSEBUTTON, + pMsg)) + return TRUE; // Have one and return. + } + if(!(MessageQueue->MouseMoved)) - return FALSE; + return FALSE; if (!MessageQueue->ptiSysLock) {

1 0

[pschweitzer] 65090: [DISK] Get ready to enter into the 10th dimension... So: - Implement support for IRP_MJ_FILE_SYSTEM_CONTROL. Yes... You read well! So, implemented a ScsiDiskFileSystemControl()...
by pschweitzer＠svn.reactos.org 28 Oct '14

28 Oct '14

Author: pschweitzer Date: Tue Oct 28 21:59:57 2014 New Revision: 65090 URL: http://svn.reactos.org/svn/reactos?rev=65090&view=rev Log: [DISK] Get ready to enter into the 10th dimension... So: - Implement support for IRP_MJ_FILE_SYSTEM_CONTROL. Yes... You read well! So, implemented a ScsiDiskFileSystemControl() function. The way it is added to the DriverObject is a big hack, class2 is not supposed to have such requests, so, we do it in its back. Fear! - Stubplement the NtfsRussinovichism() function. This is the only function we're supposed to call with IRP MJ FSCTRL and with IRP MN USRFSRQST. Its purpose (when its implemented) is to reply back to the M. Russinovich tools (NFI & NTFSInfo) so that they can directly dump NTFS information without going into NTFS driver. They kind of bypass it. We do all agree this is a ugly hack. But it exists in Windows, as these tools work in Windows. And it would be useful they actually work in ReactOS. Soon, we'll be able to publish a book "ReactOS Internals" where we speak about undocumented FS controls to dump NTFS information to show how well our NTFS works ;-). Modified: trunk/reactos/drivers/storage/class/disk/disk.c Modified: trunk/reactos/drivers/storage/class/disk/disk.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/disk… ============================================================================== --- trunk/reactos/drivers/storage/class/disk/disk.c [iso-8859-1] (original) +++ trunk/reactos/drivers/storage/class/disk/disk.c [iso-8859-1] Tue Oct 28 21:59:57 2014 @@ -310,6 +310,11 @@ IN PDEVICE_OBJECT DeviceObject ); +NTSTATUS +NTAPI +ScsiDiskFileSystemControl(PDEVICE_OBJECT DeviceObject, + PIRP Irp); + #ifdef ALLOC_PRAGMA #pragma alloc_text(PAGE, DriverEntry) #pragma alloc_text(PAGE, FindScsiDisks) @@ -379,6 +384,11 @@ InitializationData.ClassDeviceControl = ScsiDiskDeviceControl; InitializationData.ClassShutdownFlush = ScsiDiskShutdownFlush; InitializationData.ClassCreateClose = NULL; + + // + // HACK! Please check below to the implementation of the function + // + DriverObject->MajorFunction[IRP_MJ_FILE_SYSTEM_CONTROL] = ScsiDiskFileSystemControl; // // Call the class init routine @@ -5202,3 +5212,56 @@ } } // end UpdateDeviceObjects() + +// +// This function is supposed only to support NTFS tools +// from M. Russinovich. This is kind of huge hack and is +// totally undocumented :-). +// +NTSTATUS +NtfsRussinovichism(PDEVICE_OBJECT DeviceObject, + PIRP Irp) +{ + UNIMPLEMENTED; + return STATUS_NOT_IMPLEMENTED; +} + +// +// Hack: this function is not supposed to be implemented +// Even though it's required to enable some M. Russinovich +// to directly request disks so that they can dump NTFS data +// without going through the driver. +// We don't expect doing more from here, hence the limited +// implementation and support. +// +NTSTATUS +NTAPI +ScsiDiskFileSystemControl(PDEVICE_OBJECT DeviceObject, + PIRP Irp) +{ + PIO_STACK_LOCATION Stack; + NTSTATUS Status; + + DPRINT1("ScsiDiskFileSystemControl(%p, %p)\n", DeviceObject, Irp); + + Stack = IoGetCurrentIrpStackLocation(Irp); + + switch (Stack->MinorFunction) + { + case IRP_MN_USER_FS_REQUEST: + Status = NtfsRussinovichism(DeviceObject, Irp); + break; + + default: + DPRINT("MinorFunction %d\n", Stack->MinorFunction); + Status = STATUS_INVALID_DEVICE_REQUEST; + break; + } + + Irp->IoStatus.Status = Status; + Irp->IoStatus.Information = 0; + + IoCompleteRequest(Irp, IO_NO_INCREMENT); + + return Status; +}

1 0

[ekohl] 65089: [NET] Display more password information in the NET USER command.
by ekohl＠svn.reactos.org 28 Oct '14

28 Oct '14

Author: ekohl Date: Tue Oct 28 21:57:41 2014 New Revision: 65089 URL: http://svn.reactos.org/svn/reactos?rev=65089&view=rev Log: [NET] Display more password information in the NET USER command. Modified: trunk/reactos/base/applications/network/net/cmdUser.c Modified: trunk/reactos/base/applications/network/net/cmdUser.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/… ============================================================================== --- trunk/reactos/base/applications/network/net/cmdUser.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/network/net/cmdUser.c [iso-8859-1] Tue Oct 28 21:57:41 2014 @@ -86,6 +86,7 @@ RtlSecondsSince1970ToTime(dwSeconds, &Time); FileTime.dwLowDateTime = Time.u.LowPart; FileTime.dwHighDateTime = Time.u.HighPart; + FileTimeToLocalFileTime(&FileTime, &FileTime); FileTimeToSystemTime(&FileTime, &SystemTime); GetDateFormatW(LOCALE_USER_DEFAULT, @@ -107,11 +108,29 @@ static +DWORD +GetTimeInSeconds(VOID) +{ + LARGE_INTEGER Time; + FILETIME FileTime; + DWORD dwSeconds; + + GetSystemTimeAsFileTime(&FileTime); + Time.u.LowPart = FileTime.dwLowDateTime; + Time.u.HighPart = FileTime.dwHighDateTime; + RtlTimeToSecondsSince1970(&Time, &dwSeconds); + + return dwSeconds; +} + + +static NET_API_STATUS DisplayUser(LPWSTR lpUserName) { PUSER_MODALS_INFO_0 pUserModals = NULL; PUSER_INFO_4 pUserInfo = NULL; + DWORD dwLastSet; NET_API_STATUS Status; /* Modify the user */ @@ -141,17 +160,22 @@ PrintDateTime(pUserInfo->usri4_acct_expires); PrintToConsole(L"\n"); - PrintToConsole(L"Password last set \n"); PrintToConsole(L"Password expires "); - if (pUserModals->usrmod0_max_passwd_age == TIMEQ_FOREVER) + dwLastSet = GetTimeInSeconds() - pUserInfo->usri4_password_age; + PrintDateTime(dwLastSet); + + PrintToConsole(L"Password expires "); + if ((pUserInfo->usri4_flags & UF_DONT_EXPIRE_PASSWD) || pUserModals->usrmod0_max_passwd_age == TIMEQ_FOREVER) PrintToConsole(L"Never\n"); else - PrintDateTime(pUserInfo->usri4_acct_expires); - - PrintToConsole(L"Password changeable \n"); - PrintToConsole(L"Password required \n"); - PrintToConsole(L"User may change password \n"); + PrintDateTime(dwLastSet + pUserModals->usrmod0_max_passwd_age); + + PrintToConsole(L"Password changeable "); + PrintDateTime(dwLastSet + pUserModals->usrmod0_min_passwd_age); + + PrintToConsole(L"Password required %s\n", (pUserInfo->usri4_flags & UF_PASSWD_NOTREQD) ? L"No" : L"Yes"); + PrintToConsole(L"User may change password %s\n", (pUserInfo->usri4_flags & UF_PASSWD_CANT_CHANGE) ? L"No" : L"Yes"); PrintToConsole(L"\n"); PrintToConsole(L"Workstation allowed %s\n", pUserInfo->usri4_workstations); @@ -196,6 +220,7 @@ LPWSTR lpPassword = NULL; PUSER_INFO_4 pUserInfo = NULL; USER_INFO_4 UserInfo; + LPWSTR p; NET_API_STATUS Status; if (argc == 2) @@ -281,6 +306,21 @@ { if (_wcsnicmp(argv[j], L"/active:", 8) == 0) { + p = &argv[i][8]; + if (_wcsicmp(p, L"yes") == 0) + { + + } + else if (_wcsicmp(p, L"no") == 0) + { + + } + else + { + PrintToConsole(L"You entered an invalid value for the /ACTIVE option.\n"); + result = 1; + goto done; + } } else if (_wcsnicmp(argv[j], L"/comment:", 9) == 0) {

1 0

[dquintana] 65088: [RSHELL] * CMenuBand: Refcount before assigning a return pointer. * CMenuDeskBar: Revert change and protect the refcounting in case I was wrong to assume there will be exactly on...
by dquintana＠svn.reactos.org 28 Oct '14

28 Oct '14

Author: dquintana Date: Tue Oct 28 21:40:50 2014 New Revision: 65088 URL: http://svn.reactos.org/svn/reactos?rev=65088&view=rev Log: [RSHELL] * CMenuBand: Refcount before assigning a return pointer. * CMenuDeskBar: Revert change and protect the refcounting in case I was wrong to assume there will be exactly one OnFinalMessage for each OnCreate. * CMenuToolbars: Add a debug message. * CStartMenu: Refcount correctly. Modified: branches/shell-experiments/base/shell/rshell/CMenuBand.cpp branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp branches/shell-experiments/base/shell/rshell/CMenuDeskBar.h branches/shell-experiments/base/shell/rshell/CMenuToolbars.cpp branches/shell-experiments/base/shell/rshell/CStartMenu.cpp branches/shell-experiments/base/shell/rshell/precomp.h branches/shell-experiments/include/reactos/undocshell.h Modified: branches/shell-experiments/base/shell/rshell/CMenuBand.cpp URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/CMenuBand.cpp [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/CMenuBand.cpp [iso-8859-1] Tue Oct 28 21:40:50 2014 @@ -628,21 +628,22 @@ return S_OK; } - HRESULT hr = punkClient->QueryInterface(IID_PPV_ARG(IMenuPopup, &m_subMenuChild)); - - return hr; + return punkClient->QueryInterface(IID_PPV_ARG(IMenuPopup, &m_subMenuChild)); } HRESULT STDMETHODCALLTYPE CMenuBand::GetClient(IUnknown **ppunkClient) { // HACK, so I can test for a submenu in the DeskBar - if (ppunkClient) - { - if (m_subMenuChild) - *ppunkClient = m_subMenuChild; - else - *ppunkClient = NULL; - } + if (!ppunkClient) + return E_POINTER; + *ppunkClient = NULL; + + if (m_subMenuChild) + { + m_subMenuChild->AddRef(); + *ppunkClient = m_subMenuChild; + } + return S_OK; } Modified: branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp [iso-8859-1] Tue Oct 28 21:40:50 2014 @@ -39,7 +39,8 @@ m_IconSize(0), m_Banner(NULL), m_Shown(FALSE), - m_ShowFlags(0) + m_ShowFlags(0), + m_didAddRef(FALSE) { } @@ -49,7 +50,11 @@ LRESULT CMenuDeskBar::_OnCreate(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) { - this->AddRef(); + if (!m_didAddRef) + { + this->AddRef(); + m_didAddRef = TRUE; + } bHandled = FALSE; return 0; @@ -57,6 +62,11 @@ void CMenuDeskBar::OnFinalMessage(HWND /* hWnd */) { + if (m_didAddRef) + { + this->Release(); + m_didAddRef = FALSE; + } } HRESULT STDMETHODCALLTYPE CMenuDeskBar::Initialize(THIS) Modified: branches/shell-experiments/base/shell/rshell/CMenuDeskBar.h URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/CMenuDeskBar.h [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/CMenuDeskBar.h [iso-8859-1] Tue Oct 28 21:40:50 2014 @@ -49,6 +49,8 @@ BOOL m_Shown; DWORD m_ShowFlags; + + BOOL m_didAddRef; virtual void OnFinalMessage(HWND hWnd); public: Modified: branches/shell-experiments/base/shell/rshell/CMenuToolbars.cpp URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/CMenuToolbars.cpp [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/CMenuToolbars.cpp [iso-8859-1] Tue Oct 28 21:40:50 2014 @@ -1374,6 +1374,7 @@ pidl = ILClone(m_idList); if (!pidl) { + ERR("ILClone failed!\n"); (*reinterpret_cast<IUnknown**>(ppv))->Release(); return E_FAIL; } Modified: branches/shell-experiments/base/shell/rshell/CStartMenu.cpp URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/CStartMenu.cpp [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/CStartMenu.cpp [iso-8859-1] Tue Oct 28 21:40:50 2014 @@ -262,16 +262,13 @@ IBandSite* pBandSite, IDeskBar* pDeskBar) { - m_pShellMenu.Attach(pShellMenu); - m_pBandSite.Attach(pBandSite); - m_pDeskBar.Attach(pDeskBar); + m_pShellMenu = pShellMenu; + m_pBandSite = pBandSite; + m_pDeskBar = pDeskBar; } ~CShellMenuCallback() { - m_pShellMenu.Release(); - m_pBandSite.Release(); - m_pDeskBar.Release(); } HRESULT _SetProgramsFolder(IShellFolder * psf, LPITEMIDLIST pidl) Modified: branches/shell-experiments/base/shell/rshell/precomp.h URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/precomp.h [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/precomp.h [iso-8859-1] Tue Oct 28 21:40:50 2014 @@ -38,9 +38,9 @@ #define COBJMACROS //#define DEBUG_CCOMOBJECT -//#define DEBUG_CCOMOBJECT_CREATION 1 -//#define DEBUG_CCOMOBJECT_DESTRUCTION 1 -//#define DEBUG_CCOMOBJECT_REFCOUNTING 0 +#define DEBUG_CCOMOBJECT_CREATION 1 +#define DEBUG_CCOMOBJECT_DESTRUCTION 1 +#define DEBUG_CCOMOBJECT_REFCOUNTING 1 #include <windef.h> #include <winbase.h> Modified: branches/shell-experiments/include/reactos/undocshell.h URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/include/react… ============================================================================== --- branches/shell-experiments/include/reactos/undocshell.h [iso-8859-1] (original) +++ branches/shell-experiments/include/reactos/undocshell.h [iso-8859-1] Tue Oct 28 21:40:50 2014 @@ -731,6 +731,24 @@ } template<class T, class R> +HRESULT inline ShellDebugObjectCreator(REFIID riid, R ** ppv) +{ + CComPtr<T> obj; + HRESULT hResult; + + if (ppv == NULL) + return E_POINTER; + *ppv = NULL; + ATLTRY(obj = new CComDebugObject<T>); + if (obj.p == NULL) + return E_OUTOFMEMORY; + hResult = obj->QueryInterface(riid, reinterpret_cast<void **>(ppv)); + if (FAILED(hResult)) + return hResult; + return S_OK; +} + +template<class T, class R> HRESULT inline ShellObjectCreator(REFIID riid, R ** ppv) { CComPtr<T> obj;

1 0

[khornicek] 65087: [WIN32K] - addendum to revision 64877 which slightly changed UserDrawCaption's logic - fixes window title being drawn over the icon
by khornicek＠svn.reactos.org 28 Oct '14

28 Oct '14

Author: khornicek Date: Tue Oct 28 21:38:26 2014 New Revision: 65087 URL: http://svn.reactos.org/svn/reactos?rev=65087&view=rev Log: [WIN32K] - addendum to revision 64877 which slightly changed UserDrawCaption's logic - fixes window title being drawn over the icon Modified: trunk/reactos/win32ss/user/ntuser/painting.c Modified: trunk/reactos/win32ss/user/ntuser/painting.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/painti… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/painting.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/painting.c [iso-8859-1] Tue Oct 28 21:38:26 2014 @@ -2143,9 +2143,13 @@ UserDrawIconEx(hDc, x, y, pIcon, cx, cy, 0, NULL, DI_NORMAL); UserDereferenceObject(pIcon); } - } - - if (hIcon) + else + { + HasIcon = FALSE; + } + } + + if (HasIcon) Rect.left += Rect.bottom - Rect.top; if((uFlags & DC_TEXT))

1 0

[tkreuzer] 65086: [GDI32] - Move functions to the appropriate source files, zap hacks.c, stubs.c, stubsa.c and stubsw.c (sorry for the noise, but this mess had to be cleaned up)
by tkreuzer＠svn.reactos.org 28 Oct '14

28 Oct '14

Author: tkreuzer Date: Tue Oct 28 21:09:01 2014 New Revision: 65086 URL: http://svn.reactos.org/svn/reactos?rev=65086&view=rev Log: [GDI32] - Move functions to the appropriate source files, zap hacks.c, stubs.c, stubsa.c and stubsw.c (sorry for the noise, but this mess had to be cleaned up) Added: trunk/reactos/win32ss/gdi/gdi32/objects/colorspace.c (with props) trunk/reactos/win32ss/gdi/gdi32/objects/gdiobj.c (with props) Removed: trunk/reactos/win32ss/gdi/gdi32/misc/hacks.c trunk/reactos/win32ss/gdi/gdi32/misc/stubs.c trunk/reactos/win32ss/gdi/gdi32/misc/stubsa.c trunk/reactos/win32ss/gdi/gdi32/misc/stubsw.c Modified: trunk/reactos/win32ss/gdi/gdi32/CMakeLists.txt trunk/reactos/win32ss/gdi/gdi32/include/gdi32p.h trunk/reactos/win32ss/gdi/gdi32/misc/misc.c trunk/reactos/win32ss/gdi/gdi32/misc/wingl.c trunk/reactos/win32ss/gdi/gdi32/objects/bitmap.c trunk/reactos/win32ss/gdi/gdi32/objects/brush.c trunk/reactos/win32ss/gdi/gdi32/objects/coord.c trunk/reactos/win32ss/gdi/gdi32/objects/dc.c trunk/reactos/win32ss/gdi/gdi32/objects/eng.c trunk/reactos/win32ss/gdi/gdi32/objects/enhmfile.c trunk/reactos/win32ss/gdi/gdi32/objects/font.c trunk/reactos/win32ss/gdi/gdi32/objects/icm.c trunk/reactos/win32ss/gdi/gdi32/objects/metafile.c trunk/reactos/win32ss/gdi/gdi32/objects/painting.c trunk/reactos/win32ss/gdi/gdi32/objects/palette.c trunk/reactos/win32ss/gdi/gdi32/objects/printdrv.c trunk/reactos/win32ss/gdi/gdi32/objects/text.c [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/win32ss/gdi/gdi32/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/CMakeLis… Modified: trunk/reactos/win32ss/gdi/gdi32/include/gdi32p.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/include/… Removed: trunk/reactos/win32ss/gdi/gdi32/misc/hacks.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/misc/hac… Modified: trunk/reactos/win32ss/gdi/gdi32/misc/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/misc/mis… Removed: trunk/reactos/win32ss/gdi/gdi32/misc/stubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/misc/stu… Removed: trunk/reactos/win32ss/gdi/gdi32/misc/stubsa.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/misc/stu… Removed: trunk/reactos/win32ss/gdi/gdi32/misc/stubsw.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/misc/stu… Modified: trunk/reactos/win32ss/gdi/gdi32/misc/wingl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/misc/win… Modified: trunk/reactos/win32ss/gdi/gdi32/objects/bitmap.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/objects/… Modified: trunk/reactos/win32ss/gdi/gdi32/objects/brush.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/objects/… Added: trunk/reactos/win32ss/gdi/gdi32/objects/colorspace.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/objects/… Modified: trunk/reactos/win32ss/gdi/gdi32/objects/coord.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/objects/… Modified: trunk/reactos/win32ss/gdi/gdi32/objects/dc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/objects/… Modified: trunk/reactos/win32ss/gdi/gdi32/objects/eng.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/objects/… Modified: trunk/reactos/win32ss/gdi/gdi32/objects/enhmfile.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/objects/… Modified: trunk/reactos/win32ss/gdi/gdi32/objects/font.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/objects/… Added: trunk/reactos/win32ss/gdi/gdi32/objects/gdiobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/objects/… Modified: trunk/reactos/win32ss/gdi/gdi32/objects/icm.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/objects/… Modified: trunk/reactos/win32ss/gdi/gdi32/objects/metafile.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/objects/… Modified: trunk/reactos/win32ss/gdi/gdi32/objects/painting.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/objects/… Modified: trunk/reactos/win32ss/gdi/gdi32/objects/palette.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/objects/… Modified: trunk/reactos/win32ss/gdi/gdi32/objects/printdrv.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/objects/… Modified: trunk/reactos/win32ss/gdi/gdi32/objects/text.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/objects/…

1 0

[pschweitzer] 65085: [FASTFAT] For now, disable the VfatSetRenameInformation() asserts in trunk. They can be reenabled for testing by commenting "#define NASSERTS_RENAME" out. CORE-8721 #resolve #c...
by pschweitzer＠svn.reactos.org 28 Oct '14

28 Oct '14

Author: pschweitzer Date: Tue Oct 28 20:39:42 2014 New Revision: 65085 URL: http://svn.reactos.org/svn/reactos?rev=65085&view=rev Log: [FASTFAT] For now, disable the VfatSetRenameInformation() asserts in trunk. They can be reenabled for testing by commenting "#define NASSERTS_RENAME" out. CORE-8721 #resolve #comment Fixed with r65085 Modified: trunk/reactos/drivers/filesystems/fastfat/finfo.c Modified: trunk/reactos/drivers/filesystems/fastfat/finfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/finfo.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/finfo.c [iso-8859-1] Tue Oct 28 20:39:42 2014 @@ -15,6 +15,8 @@ #define NDEBUG #include <debug.h> + +#define NASSERTS_RENAME /* GLOBALS ******************************************************************/ @@ -459,6 +461,11 @@ PFILE_RENAME_INFORMATION RenameInfo, PFILE_OBJECT TargetFileObject) { +#ifdef NASSERTS_RENAME +#pragma push_macro("ASSERT") +#undef ASSERT +#define ASSERT(x) ((VOID) 0) +#endif NTSTATUS Status; UNICODE_STRING NewName; UNICODE_STRING SourcePath; @@ -485,6 +492,9 @@ } OldReferences = FCB->parentFcb->RefCount; +#ifdef NASSERTS_RENAME + UNREFERENCED_PARAMETER(OldReferences); +#endif /* If we are performing relative opening for rename, get FO for getting FCB and path name */ if (RenameInfo->RootDirectory != NULL) @@ -790,6 +800,9 @@ /* Try to find target */ ParentFCB = NULL; OldParent = FCB->parentFcb; +#ifdef NASSERTS_RENAME + UNREFERENCED_PARAMETER(OldParent); +#endif Status = vfatPrepareTargetForRename(DeviceExt, &ParentFCB, &NewName, @@ -803,6 +816,9 @@ } NewReferences = ParentFCB->RefCount; +#ifdef NASSERTS_RENAME + UNREFERENCED_PARAMETER(NewReferences); +#endif FsRtlNotifyFullReportChange(DeviceExt->NotifySync, &(DeviceExt->NotifyList), @@ -854,6 +870,9 @@ if (RenameInfo->RootDirectory != NULL) ObDereferenceObject(RootFileObject); return Status; +#ifdef NASSERTS_RENAME +#pragma pop_macro("ASSERT") +#endif } /*

1 0

[gadamopoulos] 65084: Revert unwanted change
by gadamopoulos＠svn.reactos.org 28 Oct '14

28 Oct '14

Author: gadamopoulos Date: Tue Oct 28 19:52:04 2014 New Revision: 65084 URL: http://svn.reactos.org/svn/reactos?rev=65084&view=rev Log: Revert unwanted change Modified: branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp Modified: branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp [iso-8859-1] Tue Oct 28 19:52:04 2014 @@ -45,7 +45,6 @@ CMenuDeskBar::~CMenuDeskBar() { - m_ShowFlags = 0; } LRESULT CMenuDeskBar::_OnCreate(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled)

1 0

[gadamopoulos] 65083: [RSHELL] - Do not release CMenuDeskBar more times than necessary - Should fix the start menu
by gadamopoulos＠svn.reactos.org 28 Oct '14

28 Oct '14

Author: gadamopoulos Date: Tue Oct 28 19:50:49 2014 New Revision: 65083 URL: http://svn.reactos.org/svn/reactos?rev=65083&view=rev Log: [RSHELL] - Do not release CMenuDeskBar more times than necessary - Should fix the start menu Modified: branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp Modified: branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp [iso-8859-1] Tue Oct 28 19:50:49 2014 @@ -45,6 +45,7 @@ CMenuDeskBar::~CMenuDeskBar() { + m_ShowFlags = 0; } LRESULT CMenuDeskBar::_OnCreate(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) @@ -57,7 +58,6 @@ void CMenuDeskBar::OnFinalMessage(HWND /* hWnd */) { - this->Release(); } HRESULT STDMETHODCALLTYPE CMenuDeskBar::Initialize(THIS)

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
73
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs October 2014