ReactOS.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
List overview
Download
Ros-diffs
October 2014
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
ros-diffs@reactos.org
19 participants
730 discussions
Start a n
N
ew thread
[pschweitzer] 65082: [NTFS] Finally, implement NtfsGetFreeClusters() which will just read the $Data stream from $BITMAP file record to get the amount of free clusters to allow estimating the free s...
by pschweitzer@svn.reactos.org
Author: pschweitzer Date: Tue Oct 28 19:17:59 2014 New Revision: 65082 URL:
http://svn.reactos.org/svn/reactos?rev=65082&view=rev
Log: [NTFS] Finally, implement NtfsGetFreeClusters() which will just read the $Data stream from $BITMAP file record to get the amount of free clusters to allow estimating the free space on a volume. The implementation is likely under-optimized... But wwell, the rest of the FSD is not better. Who talked about caching?! ;-) Because pictures are more relevant than words in such case:
http://www.heisspiter.net/~Pierre/rostests/NTFS_disksize.png
Modified: trunk/reactos/drivers/filesystems/ntfs/volinfo.c Modified: trunk/reactos/drivers/filesystems/ntfs/volinfo.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ntfs/v…
============================================================================== --- trunk/reactos/drivers/filesystems/ntfs/volinfo.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/ntfs/volinfo.c [iso-8859-1] Tue Oct 28 19:17:59 2014 @@ -36,8 +36,67 @@ ULONGLONG NtfsGetFreeClusters(PDEVICE_EXTENSION DeviceExt) { - UNIMPLEMENTED; - return 0; + NTSTATUS Status; + PFILE_RECORD_HEADER BitmapRecord; + PNTFS_ATTR_CONTEXT DataContext; + ULONGLONG BitmapDataSize; + PCHAR BitmapData; + ULONGLONG FreeClusters = 0; + ULONG Read = 0; + RTL_BITMAP Bitmap; + + DPRINT1("NtfsGetFreeClusters(%p)\n", DeviceExt); + + BitmapRecord = ExAllocatePoolWithTag(NonPagedPool, + DeviceExt->NtfsInfo.BytesPerFileRecord, + TAG_NTFS); + if (BitmapRecord == NULL) + { + return 0; + } + + Status = ReadFileRecord(DeviceExt, NTFS_FILE_BITMAP, BitmapRecord); + if (!NT_SUCCESS(Status)) + { + ExFreePoolWithTag(BitmapRecord, TAG_NTFS); + return 0; + } + + Status = FindAttribute(DeviceExt, BitmapRecord, AttributeData, L"", 0, &DataContext); + if (!NT_SUCCESS(Status)) + { + ExFreePoolWithTag(BitmapRecord, TAG_NTFS); + return 0; + } + + BitmapDataSize = AttributeDataLength(&DataContext->Record); + ASSERT((BitmapDataSize * 8) >= (DeviceExt->NtfsInfo.SectorCount / DeviceExt->NtfsInfo.SectorsPerCluster)); + BitmapData = ExAllocatePoolWithTag(NonPagedPool, BitmapDataSize, TAG_NTFS); + if (BitmapData == NULL) + { + ReleaseAttributeContext(DataContext); + ExFreePoolWithTag(BitmapRecord, TAG_NTFS); + return 0; + } + + /* FIXME: Totally underoptimized! */ + for (; Read < BitmapDataSize; Read += DeviceExt->NtfsInfo.BytesPerSector) + { + ReadAttribute(DeviceExt, DataContext, Read, (PCHAR)((ULONG_PTR)BitmapData + Read), DeviceExt->NtfsInfo.BytesPerSector); + } + ReleaseAttributeContext(DataContext); + + DPRINT1("Total clusters: %I64x\n", DeviceExt->NtfsInfo.SectorCount / DeviceExt->NtfsInfo.SectorsPerCluster); + DPRINT1("Total clusters in bitmap: %I64x\n", BitmapDataSize * 8); + DPRINT1("Diff in size: %I64d B\n", ((BitmapDataSize * 8) - (DeviceExt->NtfsInfo.SectorCount / DeviceExt->NtfsInfo.SectorsPerCluster)) * DeviceExt->NtfsInfo.SectorsPerCluster * DeviceExt->NtfsInfo.BytesPerSector); + + RtlInitializeBitMap(&Bitmap, (PULONG)BitmapData, DeviceExt->NtfsInfo.SectorCount / DeviceExt->NtfsInfo.SectorsPerCluster); + FreeClusters = RtlNumberOfClearBits(&Bitmap); + + ExFreePoolWithTag(BitmapData, TAG_NTFS); + ExFreePoolWithTag(BitmapRecord, TAG_NTFS); + + return FreeClusters; } static
10 years, 1 month
1
0
0
0
[dquintana] 65081: [BROWSEUI] * Disable the Tools menu items until they are implemented.
by dquintana@svn.reactos.org
Author: dquintana Date: Tue Oct 28 18:37:44 2014 New Revision: 65081 URL:
http://svn.reactos.org/svn/reactos?rev=65081&view=rev
Log: [BROWSEUI] * Disable the Tools menu items until they are implemented. Modified: branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp Modified: branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/bro…
============================================================================== --- branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp [iso-8859-1] (original) +++ branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp [iso-8859-1] Tue Oct 28 18:37:44 2014 @@ -3152,6 +3152,11 @@ } else if (theMenu == SHGetMenuFromID(fCurrentMenuBar, FCIDM_MENU_TOOLS)) { + // FIXME: Remove once implemented + SHEnableMenuItem(theMenu, IDM_TOOLS_MAPNETWORKDRIVE, FALSE); + SHEnableMenuItem(theMenu, IDM_TOOLS_DISCONNECTNETWORKDRIVE, FALSE); + SHEnableMenuItem(theMenu, IDM_TOOLS_SYNCHRONIZE, FALSE); + SHEnableMenuItem(theMenu, IDM_TOOLS_FOLDEROPTIONS, FALSE); menuIndex = 4; } else if (theMenu == SHGetMenuFromID(fCurrentMenuBar, FCIDM_MENU_HELP))
10 years, 1 month
1
0
0
0
[dquintana] 65080: [BROWSEUI] * Properly return the toolbar status on QueryStatus. * Properly make use of the returned into from QueryStatus.
by dquintana@svn.reactos.org
Author: dquintana Date: Tue Oct 28 18:32:21 2014 New Revision: 65080 URL:
http://svn.reactos.org/svn/reactos?rev=65080&view=rev
Log: [BROWSEUI] * Properly return the toolbar status on QueryStatus. * Properly make use of the returned into from QueryStatus. Modified: branches/shell-experiments/dll/win32/browseui/internettoolbar.cpp branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp Modified: branches/shell-experiments/dll/win32/browseui/internettoolbar.cpp URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/bro…
============================================================================== --- branches/shell-experiments/dll/win32/browseui/internettoolbar.cpp [iso-8859-1] (original) +++ branches/shell-experiments/dll/win32/browseui/internettoolbar.cpp [iso-8859-1] Tue Oct 28 18:32:21 2014 @@ -1155,22 +1155,28 @@ prgCmds->cmdf = OLECMDF_SUPPORTED; break; case ITID_TOOLBARBANDSHOWN: // toolbar visibility - prgCmds->cmdf = OLECMDF_SUPPORTED | OLECMDF_ENABLED; + prgCmds->cmdf = OLECMDF_SUPPORTED; + if (fControlsBar) + prgCmds->cmdf |= OLECMDF_LATCHED; break; case ITID_ADDRESSBANDSHOWN: // address bar visibility - prgCmds->cmdf = OLECMDF_SUPPORTED | OLECMDF_ENABLED; + prgCmds->cmdf = OLECMDF_SUPPORTED; + if (fNavigationBar) + prgCmds->cmdf |= OLECMDF_LATCHED; break; case ITID_LINKSBANDSHOWN: // links bar visibility prgCmds->cmdf = 0; break; case ITID_MENUBANDSHOWN: // Menubar band visibility - prgCmds->cmdf = 0; + prgCmds->cmdf = OLECMDF_SUPPORTED; + if (fMenuBar) + prgCmds->cmdf |= OLECMDF_LATCHED; break; case ITID_AUTOHIDEENABLED: // Auto hide enabled/disabled prgCmds->cmdf = 0; break; case ITID_CUSTOMIZEENABLED: // customize enabled - prgCmds->cmdf = OLECMDF_SUPPORTED | OLECMDF_ENABLED; + prgCmds->cmdf = OLECMDF_SUPPORTED; break; case ITID_TOOLBARLOCKED: // lock toolbars prgCmds->cmdf = OLECMDF_SUPPORTED | OLECMDF_ENABLED; @@ -1796,12 +1802,18 @@ default: break; } - - MENUITEMINFO mii; - mii.cbSize = sizeof(mii); - mii.fMask = MIIM_STATE; - mii.fState = fLocked ? MFS_CHECKED : MFS_UNCHECKED; - SetMenuItemInfo(contextMenu, IDM_TOOLBARS_LOCKTOOLBARS, FALSE, &mii); + + // TODO: Implement show/hide toolbars + SHEnableMenuItem(contextMenu, IDM_TOOLBARS_STANDARDBUTTONS, FALSE); + SHEnableMenuItem(contextMenu, IDM_TOOLBARS_ADDRESSBAR, FALSE); + SHEnableMenuItem(contextMenu, IDM_TOOLBARS_LINKSBAR, FALSE); + SHEnableMenuItem(contextMenu, IDM_TOOLBARS_CUSTOMIZE, FALSE); + + SHCheckMenuItem(contextMenu, IDM_TOOLBARS_STANDARDBUTTONS, fControlsBar != NULL); + SHCheckMenuItem(contextMenu, IDM_TOOLBARS_ADDRESSBAR, fNavigationBar != NULL); + SHCheckMenuItem(contextMenu, IDM_TOOLBARS_LINKSBAR, FALSE); + SHCheckMenuItem(contextMenu, IDM_TOOLBARS_CUSTOMIZE, FALSE); + SHCheckMenuItem(contextMenu, IDM_TOOLBARS_LOCKTOOLBARS, fLocked); // TODO: use GetSystemMetrics(SM_MENUDROPALIGNMENT) to determine menu alignment command = TrackPopupMenu(contextMenu, TPM_LEFTALIGN | TPM_TOPALIGN | TPM_RIGHTBUTTON | TPM_RETURNCMD, Modified: branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/bro…
============================================================================== --- branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp [iso-8859-1] (original) +++ branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp [iso-8859-1] Tue Oct 28 18:32:21 2014 @@ -1570,10 +1570,16 @@ RemoveMenu(toolbarMenuBar, 0, MF_BYPOSITION); DestroyMenu(toolbarMenuBar); - SHCheckMenuItem(toolbarMenu, IDM_TOOLBARS_STANDARDBUTTONS, commandList[0].cmdf); - SHCheckMenuItem(toolbarMenu, IDM_TOOLBARS_ADDRESSBAR, commandList[1].cmdf & OLECMDF_ENABLED); - SHCheckMenuItem(toolbarMenu, IDM_TOOLBARS_LINKSBAR, commandList[2].cmdf & OLECMDF_ENABLED); - SHCheckMenuItem(toolbarMenu, IDM_TOOLBARS_LOCKTOOLBARS, commandList[3].cmdf & OLECMDF_ENABLED); + // TODO: Implement + SHEnableMenuItem(toolbarMenu, IDM_TOOLBARS_STANDARDBUTTONS, commandList[0].cmdf & OLECMDF_ENABLED); + SHEnableMenuItem(toolbarMenu, IDM_TOOLBARS_ADDRESSBAR, commandList[1].cmdf & OLECMDF_ENABLED); + SHEnableMenuItem(toolbarMenu, IDM_TOOLBARS_LINKSBAR, commandList[2].cmdf & OLECMDF_ENABLED); + SHEnableMenuItem(toolbarMenu, IDM_TOOLBARS_CUSTOMIZE, commandList[4].cmdf & OLECMDF_ENABLED); + + SHCheckMenuItem(toolbarMenu, IDM_TOOLBARS_STANDARDBUTTONS, commandList[0].cmdf & OLECMDF_LATCHED); + SHCheckMenuItem(toolbarMenu, IDM_TOOLBARS_ADDRESSBAR, commandList[1].cmdf & OLECMDF_LATCHED); + SHCheckMenuItem(toolbarMenu, IDM_TOOLBARS_LINKSBAR, commandList[2].cmdf & OLECMDF_LATCHED); + SHCheckMenuItem(toolbarMenu, IDM_TOOLBARS_LOCKTOOLBARS, commandList[3].cmdf & OLECMDF_LATCHED); if ((commandList[4].cmdf & OLECMDF_ENABLED) == 0) DeleteMenu(toolbarMenu, IDM_TOOLBARS_CUSTOMIZE, MF_BYCOMMAND); DeleteMenu(toolbarMenu, IDM_TOOLBARS_TEXTLABELS, MF_BYCOMMAND); @@ -1585,6 +1591,9 @@ SetMenuItemInfo(theMenu, IDM_VIEW_TOOLBARS, FALSE, &menuItemInfo); } SHCheckMenuItem(theMenu, IDM_VIEW_STATUSBAR, fStatusBarVisible ? TRUE : FALSE); + + // TODO: Implement + SHEnableMenuItem(theMenu, IDM_VIEW_EXPLORERBAR, FALSE); } bool IUnknownIsEqual(IUnknown *int1, IUnknown *int2)
10 years, 1 month
1
0
0
0
[gadamopoulos] 65079: Addendum to r65077 (svn merge info).
by gadamopoulos@svn.reactos.org
Author: gadamopoulos Date: Tue Oct 28 17:40:49 2014 New Revision: 65079 URL:
http://svn.reactos.org/svn/reactos?rev=65079&view=rev
Log: Addendum to r65077 (svn merge info). Modified: trunk/reactos/ (props changed) Propchange: trunk/reactos/ ------------------------------------------------------------------------------ --- svn:mergeinfo (original) +++ svn:mergeinfo Tue Oct 28 17:40:49 2014 @@ -13,7 +13,7 @@ /branches/ros-amd64-bringup/reactos:34711-34712,34741,34743,34770,34780-34782,34803,34812,34839,34842,34864,34870,34874,34877,34908-34909,34917,34965,35323-35324,35347-35348,35361,35436,35509,35515,35588,35655,35683,35739,35746,35762,35771,35777,35781,35789,35805,35823,35827,35902,35904-35906,35942,35947-35949,35952-35953,35966,36011-36013,36172,36360,36380,36388-36389,36393,36397,36443,36445,36475,36502-36503,36505,36570,36614,36852,36898-36899,36930,36936,36949,36951,36958,36961,36964,36969,36972,36987-36988,36990,36992,37019,37322-37323,37333-37334,37434,37472,37475,37536,37820-37821,37868-37869,37873,37990-37991,38013-38014,38092,38100,38148-38151,38264-38265,38268,38355,39151,39333,39335,39345,39639,40120,40122-40123,40125,40127-40128,40155,40247,40324,40608,40753,40926-40928,40986-40987,40989,40991,40993,40995-40996,41000-41001,41027-41030,41044-41045,41047-41050,41052,41070,41082-41086,41097-41098,41101,41449,41479-41480,41483-41485,41499-41500,41502,41531,41536,41540,41546-41547,41549,43080,43426,43451,43454,43506,43566,43574,43598,43600-43602,43604-43605,43677,43682,43757,43775,43836,43838-43840,43852,43857-43858,43860,43905-43907,43952,43954,43965,43969,43979,43981,43992,44002,44036-44037,44039-44040,44044-44045,44053,44065,44095,44123,44143-44144,44205,44238,44257,44259,44294,44338-44339,44385,44389,44391,44426,44460,44467-44468,44470-44471,44499,44501,44503-44504,44506,44510-44512,44521,44523-44526,44530,44540,44601,44634,44639,44772,44818,45124,45126-45127,45430,46394,46404,46478,46511,46523-46524,46526,46534-46535,46537-46539,46589,46805,46868,47472,47846-47847,47878,47882 /branches/ros-branch-0_3_15-lt2013:59059 /branches/ros-csrss:57561-58762 -/branches/shell-experiments:64866 +/branches/shell-experiments:64866,65001 /branches/shell32_new-bringup:51893-53652,53661,53700 /branches/tcp-rewrite-branch:48720,48840-48841,49424-49426,49454 /branches/usb-bringup:51335,51337,51341-51343,51348,51350,51353,51355,51365-51369,51372,51384-54388,54396-54398,54736-54737,54752-54754,54756-54760,54762,54764-54765,54767-54768,54772,54774-54777,54781,54787,54790-54792,54797-54798,54806,54808,54834-54838,54843,54850,54852,54856,54858-54859
10 years, 1 month
1
0
0
0
[dquintana] 65078: Fix GCC build.
by dquintana@svn.reactos.org
Author: dquintana Date: Tue Oct 28 17:33:22 2014 New Revision: 65078 URL:
http://svn.reactos.org/svn/reactos?rev=65078&view=rev
Log: Fix GCC build. Modified: branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp Modified: branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/bro…
============================================================================== --- branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp [iso-8859-1] (original) +++ branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp [iso-8859-1] Tue Oct 28 17:33:22 2014 @@ -3170,6 +3170,8 @@ LRESULT CShellBrowser::OnFolderOptions(WORD wNotifyCode, WORD wID, HWND hWndCtl, BOOL &bHandled) { HRESULT hResult = DoFolderOptions(); + if (FAILED(hResult)) + TRACE("DoFolderOptions failed with hResult=%08lx\n", hResult); return 0; } @@ -3198,24 +3200,32 @@ LRESULT CShellBrowser::OnGoBack(WORD wNotifyCode, WORD wID, HWND hWndCtl, BOOL &bHandled) { HRESULT hResult = GoBack(); + if (FAILED(hResult)) + TRACE("GoBack failed with hResult=%08lx\n", hResult); return 0; } LRESULT CShellBrowser::OnGoForward(WORD wNotifyCode, WORD wID, HWND hWndCtl, BOOL &bHandled) { HRESULT hResult = GoForward(); + if (FAILED(hResult)) + TRACE("GoForward failed with hResult=%08lx\n", hResult); return 0; } LRESULT CShellBrowser::OnGoUpLevel(WORD wNotifyCode, WORD wID, HWND hWndCtl, BOOL &bHandled) { HRESULT hResult = NavigateToParent(); + if (FAILED(hResult)) + TRACE("NavigateToParent failed with hResult=%08lx\n", hResult); return 0; } LRESULT CShellBrowser::OnGoHome(WORD wNotifyCode, WORD wID, HWND hWndCtl, BOOL &bHandled) { HRESULT hResult = GoHome(); + if (FAILED(hResult)) + TRACE("GoHome failed with hResult=%08lx\n", hResult); return 0; } @@ -3223,6 +3233,8 @@ { // FIXME: This does not appear to be what windows does. HRESULT hResult = NavigateToParent(); + if (FAILED(hResult)) + TRACE("NavigateToParent failed with hResult=%08lx\n", hResult); return 0; }
10 years, 1 month
1
0
0
0
[gadamopoulos] 65077: Merge r65001 from shell-experiments branch: [user32] - Properly notify the theme engine that the caption needs to be repainted on WM_SETICON - Fixes a classic frame appearing ...
by gadamopoulos@svn.reactos.org
Author: gadamopoulos Date: Tue Oct 28 17:32:01 2014 New Revision: 65077 URL:
http://svn.reactos.org/svn/reactos?rev=65077&view=rev
Log: Merge r65001 from shell-experiments branch: [user32] - Properly notify the theme engine that the caption needs to be repainted on WM_SETICON - Fixes a classic frame appearing when themes are enabled and we navigate to a different folder Modified: trunk/reactos/win32ss/user/user32/windows/defwnd.c Modified: trunk/reactos/win32ss/user/user32/windows/defwnd.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/window…
============================================================================== --- trunk/reactos/win32ss/user/user32/windows/defwnd.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/user32/windows/defwnd.c [iso-8859-1] Tue Oct 28 17:32:01 2014 @@ -447,6 +447,27 @@ return TRUE; } +static void +UserPaintCaption(HWND hwnd) +{ + /* FIXME: this is not 100% correct */ + + /* + * When themes are not enabled we can go on and paint the non client area. + * However if we do that with themes enabled we will draw a classic frame. + * This is sovled by sending a themes specific message to notify the themes + * engine that the caption needs to be redrawn + */ + if(gpsi->dwSRVIFlags & SRVINFO_APIHOOK) + { + SendMessage(hwnd, WM_NCUAHDRAWCAPTION,0,0); + } + else + { + DefWndNCPaint(hwnd, HRGN_WINDOW, -1); + } +} + // WM_SETICON LRESULT FASTCALL DefWndSetIcon(PWND pWnd, WPARAM wParam, LPARAM lParam) @@ -481,7 +502,7 @@ NtUserSetProp(UserHMGetHandle(pWnd), gpsi->atomIconSmProp, hIconSmall); if ((pWnd->style & WS_CAPTION ) == WS_CAPTION) - DefWndNCPaint(UserHMGetHandle(pWnd), HRGN_WINDOW, -1); /* Repaint caption */ + UserPaintCaption(UserHMGetHandle(pWnd)); /* Repaint caption */ return (LRESULT)hIconOld; } @@ -1454,17 +1475,7 @@ DefSetText(hWnd, (PCWSTR)lParam, TRUE); if ((GetWindowLongPtrW(hWnd, GWL_STYLE) & WS_CAPTION) == WS_CAPTION) - { - /* FIXME: this is not 100% correct */ - if(gpsi->dwSRVIFlags & SRVINFO_APIHOOK) - { - SendMessage(hWnd, WM_NCUAHDRAWCAPTION,0,0); - } - else - { - DefWndNCPaint(hWnd, HRGN_WINDOW, -1); - } - } + UserPaintCaption(hWnd); Result = 1; break; } @@ -1626,17 +1637,7 @@ DefSetText(hWnd, (PCWSTR)lParam, FALSE); if ((GetWindowLongPtrW(hWnd, GWL_STYLE) & WS_CAPTION) == WS_CAPTION) - { - /* FIXME: this is not 100% correct */ - if(gpsi->dwSRVIFlags & SRVINFO_APIHOOK) - { - SendMessage(hWnd, WM_NCUAHDRAWCAPTION,0,0); - } - else - { - DefWndNCPaint(hWnd, HRGN_WINDOW, -1); - } - } + UserPaintCaption(hWnd); Result = 1; break; }
10 years, 1 month
1
0
0
0
[gedmurphy] 65076: [WINLOGON] - Stop the log from being spammed when the session is idle and no screensaver is set - Also checking if my login still works :)
by gedmurphy@svn.reactos.org
Author: gedmurphy Date: Tue Oct 28 17:07:47 2014 New Revision: 65076 URL:
http://svn.reactos.org/svn/reactos?rev=65076&view=rev
Log: [WINLOGON] - Stop the log from being spammed when the session is idle and no screensaver is set - Also checking if my login still works :) Modified: trunk/reactos/base/system/winlogon/screensaver.c Modified: trunk/reactos/base/system/winlogon/screensaver.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/winlogon/scree…
============================================================================== --- trunk/reactos/base/system/winlogon/screensaver.c [iso-8859-1] (original) +++ trunk/reactos/base/system/winlogon/screensaver.c [iso-8859-1] Tue Oct 28 17:07:47 2014 @@ -277,7 +277,7 @@ &hCurrentUser); if (rc != ERROR_SUCCESS) { - ERR("WL: RegOpenCurrentUser Error!\n"); + ERR("WL: RegOpenCurrentUser error %lu\n", rc); goto cleanup; } @@ -288,7 +288,7 @@ &hKey); if (rc != ERROR_SUCCESS) { - ERR("WL: RegOpenKeyEx Error!\n"); + ERR("WL: RegOpenKeyEx error %lu\n", rc); goto cleanup; } @@ -300,7 +300,8 @@ &bufferSize); if (rc != ERROR_SUCCESS || dwType != REG_SZ) { - ERR("WL: RegQueryValueEx Error!\n"); + if (rc != ERROR_FILE_NOT_FOUND) + ERR("WL: RegQueryValueEx error %lu\n", rc); goto cleanup; }
10 years, 1 month
1
0
0
0
[akhaldi] 65075: * Sync up to trunk head (r65074).
by akhaldi@svn.reactos.org
Author: akhaldi Date: Tue Oct 28 16:58:25 2014 New Revision: 65075 URL:
http://svn.reactos.org/svn/reactos?rev=65075&view=rev
Log: * Sync up to trunk head (r65074). Added: branches/shell-experiments/win32ss/gdi/gdi32/objects/clientobj.c - copied unchanged from r65074, trunk/reactos/win32ss/gdi/gdi32/objects/clientobj.c Modified: branches/shell-experiments/ (props changed) branches/shell-experiments/base/applications/network/net/cmdAccounts.c branches/shell-experiments/base/applications/network/net/cmdHelpMsg.c branches/shell-experiments/base/applications/network/net/cmdLocalGroup.c branches/shell-experiments/base/applications/network/net/cmdStart.c branches/shell-experiments/base/applications/network/net/cmdUser.c branches/shell-experiments/base/applications/network/net/main.c branches/shell-experiments/base/applications/network/net/net.h branches/shell-experiments/dll/win32/advapi32/wine/security.c branches/shell-experiments/dll/win32/kernel32/client/file/mntpoint.c branches/shell-experiments/dll/win32/kernel32/client/resntfy.c branches/shell-experiments/dll/win32/rasdlg/lang/tr-TR.rc branches/shell-experiments/drivers/bus/acpi/main.c branches/shell-experiments/drivers/bus/pcix/fdo.c branches/shell-experiments/drivers/filesystems/fastfat/create.c branches/shell-experiments/drivers/filesystems/fastfat/dir.c branches/shell-experiments/drivers/filesystems/fastfat/direntry.c branches/shell-experiments/drivers/filesystems/fastfat/dirwr.c branches/shell-experiments/drivers/filesystems/fastfat/fcb.c branches/shell-experiments/drivers/filesystems/fastfat/finfo.c branches/shell-experiments/drivers/filesystems/ntfs/attrib.c branches/shell-experiments/drivers/filesystems/ntfs/dirctl.c branches/shell-experiments/drivers/filesystems/ntfs/fcb.c branches/shell-experiments/drivers/filesystems/ntfs/mft.c branches/shell-experiments/drivers/filesystems/ntfs/ntfs.h branches/shell-experiments/include/ddk/nt_vdd.h branches/shell-experiments/include/reactos/libs/fast486/fast486.h branches/shell-experiments/lib/fast486/common.c branches/shell-experiments/lib/fast486/common.h branches/shell-experiments/lib/fast486/common.inl branches/shell-experiments/lib/fast486/extraops.c branches/shell-experiments/lib/fast486/fast486.c branches/shell-experiments/lib/fast486/fpu.c branches/shell-experiments/lib/fast486/opcodes.c branches/shell-experiments/lib/fast486/opgroups.c branches/shell-experiments/lib/sdk/crt/mem/i386/memchr_asm.s branches/shell-experiments/lib/sdk/crt/mem/i386/memmove_asm.s branches/shell-experiments/lib/sdk/crt/mem/i386/memset_asm.s branches/shell-experiments/lib/sdk/crt/string/i386/tcsnlen.inc branches/shell-experiments/ntoskrnl/se/accesschk.c branches/shell-experiments/subsystems/ntvdm/bios/vidbios.c branches/shell-experiments/subsystems/ntvdm/clock.c branches/shell-experiments/subsystems/ntvdm/cpu/registers.c branches/shell-experiments/subsystems/ntvdm/dos/dos32krnl/dos.c branches/shell-experiments/subsystems/ntvdm/emulator.c branches/shell-experiments/subsystems/ntvdm/emulator.h branches/shell-experiments/subsystems/ntvdm/hardware/keyboard.c branches/shell-experiments/subsystems/ntvdm/hardware/pic.c branches/shell-experiments/subsystems/ntvdm/hardware/ps2.c branches/shell-experiments/subsystems/ntvdm/hardware/vga.c branches/shell-experiments/subsystems/ntvdm/io.c branches/shell-experiments/subsystems/ntvdm/ntvdm.c branches/shell-experiments/win32ss/gdi/gdi32/CMakeLists.txt branches/shell-experiments/win32ss/gdi/gdi32/include/gdi32p.h branches/shell-experiments/win32ss/gdi/gdi32/main/dllmain.c branches/shell-experiments/win32ss/gdi/gdi32/misc/misc.c branches/shell-experiments/win32ss/gdi/gdi32/objects/dc.c branches/shell-experiments/win32ss/gdi/ntgdi/bitmaps.c branches/shell-experiments/win32ss/gdi/ntgdi/gdiobj.c branches/shell-experiments/win32ss/user/ntuser/desktop.c branches/shell-experiments/win32ss/user/ntuser/msgqueue.c [This mail would be too long, it was shortened to contain the URLs only.] Modified: branches/shell-experiments/base/applications/network/net/cmdAccounts.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/applicat…
Modified: branches/shell-experiments/base/applications/network/net/cmdHelpMsg.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/applicat…
Modified: branches/shell-experiments/base/applications/network/net/cmdLocalGroup.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/applicat…
Modified: branches/shell-experiments/base/applications/network/net/cmdStart.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/applicat…
Modified: branches/shell-experiments/base/applications/network/net/cmdUser.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/applicat…
Modified: branches/shell-experiments/base/applications/network/net/main.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/applicat…
Modified: branches/shell-experiments/base/applications/network/net/net.h URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/applicat…
Modified: branches/shell-experiments/dll/win32/advapi32/wine/security.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/adv…
Modified: branches/shell-experiments/dll/win32/kernel32/client/file/mntpoint.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/ker…
Modified: branches/shell-experiments/dll/win32/kernel32/client/resntfy.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/ker…
Modified: branches/shell-experiments/dll/win32/rasdlg/lang/tr-TR.rc URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/ras…
Modified: branches/shell-experiments/drivers/bus/acpi/main.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/drivers/bus/a…
Modified: branches/shell-experiments/drivers/bus/pcix/fdo.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/drivers/bus/p…
Modified: branches/shell-experiments/drivers/filesystems/fastfat/create.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/drivers/files…
Modified: branches/shell-experiments/drivers/filesystems/fastfat/dir.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/drivers/files…
Modified: branches/shell-experiments/drivers/filesystems/fastfat/direntry.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/drivers/files…
Modified: branches/shell-experiments/drivers/filesystems/fastfat/dirwr.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/drivers/files…
Modified: branches/shell-experiments/drivers/filesystems/fastfat/fcb.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/drivers/files…
Modified: branches/shell-experiments/drivers/filesystems/fastfat/finfo.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/drivers/files…
Modified: branches/shell-experiments/drivers/filesystems/ntfs/attrib.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/drivers/files…
Modified: branches/shell-experiments/drivers/filesystems/ntfs/dirctl.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/drivers/files…
Modified: branches/shell-experiments/drivers/filesystems/ntfs/fcb.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/drivers/files…
Modified: branches/shell-experiments/drivers/filesystems/ntfs/mft.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/drivers/files…
Modified: branches/shell-experiments/drivers/filesystems/ntfs/ntfs.h URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/drivers/files…
Modified: branches/shell-experiments/include/ddk/nt_vdd.h URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/include/ddk/n…
Modified: branches/shell-experiments/include/reactos/libs/fast486/fast486.h URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/include/react…
Modified: branches/shell-experiments/lib/fast486/common.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/lib/fast486/c…
Modified: branches/shell-experiments/lib/fast486/common.h URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/lib/fast486/c…
Modified: branches/shell-experiments/lib/fast486/common.inl URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/lib/fast486/c…
Modified: branches/shell-experiments/lib/fast486/extraops.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/lib/fast486/e…
Modified: branches/shell-experiments/lib/fast486/fast486.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/lib/fast486/f…
Modified: branches/shell-experiments/lib/fast486/fpu.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/lib/fast486/f…
Modified: branches/shell-experiments/lib/fast486/opcodes.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/lib/fast486/o…
Modified: branches/shell-experiments/lib/fast486/opgroups.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/lib/fast486/o…
Modified: branches/shell-experiments/lib/sdk/crt/mem/i386/memchr_asm.s URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/lib/sdk/crt/m…
Modified: branches/shell-experiments/lib/sdk/crt/mem/i386/memmove_asm.s URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/lib/sdk/crt/m…
Modified: branches/shell-experiments/lib/sdk/crt/mem/i386/memset_asm.s URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/lib/sdk/crt/m…
Modified: branches/shell-experiments/lib/sdk/crt/string/i386/tcsnlen.inc URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/lib/sdk/crt/s…
Modified: branches/shell-experiments/ntoskrnl/se/accesschk.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/ntoskrnl/se/a…
Modified: branches/shell-experiments/subsystems/ntvdm/bios/vidbios.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/subsystems/nt…
Modified: branches/shell-experiments/subsystems/ntvdm/clock.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/subsystems/nt…
Modified: branches/shell-experiments/subsystems/ntvdm/cpu/registers.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/subsystems/nt…
Modified: branches/shell-experiments/subsystems/ntvdm/dos/dos32krnl/dos.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/subsystems/nt…
Modified: branches/shell-experiments/subsystems/ntvdm/emulator.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/subsystems/nt…
Modified: branches/shell-experiments/subsystems/ntvdm/emulator.h URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/subsystems/nt…
Modified: branches/shell-experiments/subsystems/ntvdm/hardware/keyboard.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/subsystems/nt…
Modified: branches/shell-experiments/subsystems/ntvdm/hardware/pic.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/subsystems/nt…
Modified: branches/shell-experiments/subsystems/ntvdm/hardware/ps2.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/subsystems/nt…
Modified: branches/shell-experiments/subsystems/ntvdm/hardware/vga.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/subsystems/nt…
Modified: branches/shell-experiments/subsystems/ntvdm/io.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/subsystems/nt…
Modified: branches/shell-experiments/subsystems/ntvdm/ntvdm.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/subsystems/nt…
Modified: branches/shell-experiments/win32ss/gdi/gdi32/CMakeLists.txt URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/win32ss/gdi/g…
Modified: branches/shell-experiments/win32ss/gdi/gdi32/include/gdi32p.h URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/win32ss/gdi/g…
Modified: branches/shell-experiments/win32ss/gdi/gdi32/main/dllmain.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/win32ss/gdi/g…
Modified: branches/shell-experiments/win32ss/gdi/gdi32/misc/misc.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/win32ss/gdi/g…
Modified: branches/shell-experiments/win32ss/gdi/gdi32/objects/dc.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/win32ss/gdi/g…
Modified: branches/shell-experiments/win32ss/gdi/ntgdi/bitmaps.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/win32ss/gdi/n…
Modified: branches/shell-experiments/win32ss/gdi/ntgdi/gdiobj.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/win32ss/gdi/n…
Modified: branches/shell-experiments/win32ss/user/ntuser/desktop.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/win32ss/user/…
Modified: branches/shell-experiments/win32ss/user/ntuser/msgqueue.c URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/win32ss/user/…
10 years, 1 month
1
0
0
0
[dquintana] 65074: [RSHELL] * Fix executing items after the menu has closed.
by dquintana@svn.reactos.org
Author: dquintana Date: Tue Oct 28 15:39:47 2014 New Revision: 65074 URL:
http://svn.reactos.org/svn/reactos?rev=65074&view=rev
Log: [RSHELL] * Fix executing items after the menu has closed. Modified: branches/shell-experiments/base/shell/rshell/CMenuBand.cpp branches/shell-experiments/base/shell/rshell/CMenuToolbars.cpp branches/shell-experiments/base/shell/rshell/CMenuToolbars.h Modified: branches/shell-experiments/base/shell/rshell/CMenuBand.cpp URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs…
============================================================================== --- branches/shell-experiments/base/shell/rshell/CMenuBand.cpp [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/CMenuBand.cpp [iso-8859-1] Tue Oct 28 15:39:47 2014 @@ -948,14 +948,18 @@ switch (changeType) { case MPOS_EXECUTE: + { + CMenuToolbarBase * tb = m_hotBar; + int item = m_hotItem; + tb->PrepareExecuteItem(item); if (m_subMenuParent) { m_subMenuParent->OnSelect(changeType); } TRACE("Menu closed, executing item...\n"); - m_hotBar->ExecuteItem(m_hotItem); + tb->ExecuteItem(); break; - + } case MPOS_SELECTLEFT: if (m_parentBand && m_parentBand->_IsPopup()==S_FALSE) return m_parentBand->_MenuItemHotTrack(VK_LEFT); Modified: branches/shell-experiments/base/shell/rshell/CMenuToolbars.cpp URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs…
============================================================================== --- branches/shell-experiments/base/shell/rshell/CMenuToolbars.cpp [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/CMenuToolbars.cpp [iso-8859-1] Tue Oct 28 15:39:47 2014 @@ -846,16 +846,17 @@ return ProcessClick(btn.idCommand); } -HRESULT CMenuToolbarBase::ExecuteItem(INT iItem) +HRESULT CMenuToolbarBase::PrepareExecuteItem(INT iItem) { this->m_menuBand->_KillPopupTimers(); - INT index; - DWORD_PTR data; - - GetDataFromId(iItem, &index, &data); - - return InternalExecuteItem(iItem, index, data); + m_executeItem = iItem; + return GetDataFromId(iItem, &m_executeIndex, &m_executeData); +} + +HRESULT CMenuToolbarBase::ExecuteItem() +{ + return InternalExecuteItem(m_executeItem, m_executeItem, m_executeData); } HRESULT CMenuToolbarBase::OnContextMenu(NMMOUSE * rclick) Modified: branches/shell-experiments/base/shell/rshell/CMenuToolbars.h URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs…
============================================================================== --- branches/shell-experiments/base/shell/rshell/CMenuToolbars.h [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/CMenuToolbars.h [iso-8859-1] Tue Oct 28 15:39:47 2014 @@ -51,6 +51,10 @@ DWORD m_initFlags; BOOL m_isTrackingPopup; + INT m_executeIndex; + INT m_executeItem; + DWORD_PTR m_executeData; + private: static LRESULT CALLBACK s_SubclassProc(HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam); @@ -77,7 +81,8 @@ HRESULT KeyboardItemChange(DWORD changeType); - HRESULT ExecuteItem(INT iItem); + HRESULT PrepareExecuteItem(INT iItem); + HRESULT ExecuteItem(); HRESULT IsTrackedItem(INT index); HRESULT ChangeTrackedItem(INT index, BOOL wasTracking, BOOL mouse);
10 years, 1 month
1
0
0
0
[gadamopoulos] 65073: [STOBJECT] - Disable querying if audio is muted or not for now. - Hides an assert that happened in wdmaud.drv
by gadamopoulos@svn.reactos.org
Author: gadamopoulos Date: Tue Oct 28 15:27:00 2014 New Revision: 65073 URL:
http://svn.reactos.org/svn/reactos?rev=65073&view=rev
Log: [STOBJECT] - Disable querying if audio is muted or not for now. - Hides an assert that happened in wdmaud.drv Modified: branches/shell-experiments/dll/shellext/stobject/volume.cpp Modified: branches/shell-experiments/dll/shellext/stobject/volume.cpp URL:
http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/shellext/…
============================================================================== --- branches/shell-experiments/dll/shellext/stobject/volume.cpp [iso-8859-1] (original) +++ branches/shell-experiments/dll/shellext/stobject/volume.cpp [iso-8859-1] Tue Oct 28 15:27:00 2014 @@ -114,6 +114,7 @@ HRESULT Volume_IsMute() { +#if 0 MIXERCONTROLDETAILS mixerControlDetails; if (g_mixerId != (UINT)-1 && g_muteControlID != (DWORD)-1) @@ -132,7 +133,7 @@ g_IsMute = detailsResult != 0; } - +#endif return S_OK; }
10 years, 1 month
1
0
0
0
← Newer
1
...
6
7
8
9
10
11
12
...
73
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
Results per page:
10
25
50
100
200